Commit Graph

1766 Commits

Author SHA1 Message Date
Russell Johnson
341da1092d Path: Move more common methods to PathSurfaceSupport module 2020-04-16 00:20:46 -05:00
Russell Johnson
0bd0d52baf Path: Simplify if ... is True: statements. 2020-04-16 00:17:47 -05:00
Russell Johnson
ccfd52477f Path: New class - PathGeometryGenerator; new CutPattern - Offset
Converted _planarMakePathGeom() into independent class, PathGeometryGenerator, as preparation to share common code with Waterline.
Implementation of new class within existing code.
Added new cut pattern: Offset.  It is ported from Waterline.
2020-04-16 00:17:40 -05:00
Russell Johnson
f6ad7101c6 Path: Create shared support module for 3D Surface and Waterline 2020-04-16 00:17:33 -05:00
Russell Johnson
fd34891c99 Path: Improve compatibility between file versions
Verify enumerations on document reload, maintaining the existing value for the property.
2020-04-16 00:17:33 -05:00
Russell Johnson
a6cb530d57 Path: Fix weakness in face analysis for unique OuterWire cases 2020-04-16 00:17:24 -05:00
Russell Johnson
f41ec732e1 Path: Added Spiral cut pattern; Adjusted tooltip language 2020-04-16 00:17:16 -05:00
Russell Johnson
b5048f4f02 Path: Multiple fixes; code optimizations and cleanup
Fix _processRotationalOp() arguments and erroneous call thereto.
Fix isOnLineSegment() usage.
Fix transition between profile edge and clearing.
Fix _planarSinglepassProcess() method.
Fix `ProfileEdges` feature.
Fix Y-axis rotation error in G-code and display.
Fix error handling of `import ocl` test.
Raise `import ocl` test in code sequence.
Convert ocl.Point scan results and handling to FreeCAD.Vector() type throughout `Rotational` scan code.
Change properties group from `Rotational` to `Rotation`.
Make operation property details accessible through class.
Relocate Draft import to dependent function.
Improve property visibility in Data tab.
Issue warning for Rotational scans if faces are selected.
Compact setup() function.
LGTM cleanup throughout.
Delete unnecessary comments.
2020-04-16 00:17:05 -05:00
Russell Johnson
c6b9adec25 Path: GUI improvement - swap setEnabled() for show() and hide()
Improve GUI usability by using hide() and show().
Apply hide() and show() to labels as well.
Fix visibility update issue on loading task window for editing of existing operation.
2020-04-16 00:14:11 -05:00
Eric Trombly
070099daa4 fix some typos in recent lazyloader implementation 2020-04-15 12:32:48 -05:00
sliptonic
1ff9c0899b Merge pull request #3330 from etrombly/lazyloader
[Path] Use lazyloader for deferred python imports
2020-04-15 10:22:28 -05:00
Eric Trombly
7fe094ac02 add lazyloader support
lazy_loader is copied to Ext now, modified external imports to lazy_load

add a few more imports to be lazy loaded, think the install path is correct now

[TD]"<" symbol embedded in html

revert changes to path modules for testing

use lazyloader in PathAreaOp.py

add back in deferred loading

temp change to print error message in tests

temp change to print error message in tests

add _init__.py to lazy_loader

make install in CMakeLists.txt one line
2020-04-13 21:14:34 -05:00
sliptonic
1f1043bf3c Merge pull request #3333 from fra589/master
[Path] Add size parameter for syntax highlighting of GCode editor
2020-04-13 08:48:18 -05:00
Daniel Wood
15318f4957 Deburr: signal for update when values are changed 2020-04-12 06:33:34 +01:00
Patrick F
954590dd4a Added confirm dialog for table delete 2020-04-12 00:49:09 +02:00
Patrick F
abea303a88 Improved error handling 2020-04-11 19:27:37 +02:00
Gauthier
ae05df5034 Merge remote-tracking branch 'upstream/master' 2020-04-11 17:06:31 +02:00
Gauthier
bc9569515a Add size parameter for syntax highlighting of GCode editor 2020-04-11 17:05:59 +02:00
Patrick F
c94ef27e0d Add tool table list to UI 2020-04-10 22:10:35 +02:00
Patrick F
034b48f849 Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into toolbit-gui 2020-04-09 21:55:28 +02:00
Russell Johnson
ad784bc7d5 Path: PEP8 cleanup
line endings fix
2020-04-07 22:17:37 -05:00
Russell Johnson
20d85edd62 Path: Fix broken Gui::QuantitySpinBox class
Now, custom expressions are applied to spinbox.
Spinbox now updates, after clicking elsewhere.
Path: Shorten for loop search
2020-04-07 22:17:37 -05:00
sliptonic
ee520f1013 user attributes kinda works. Hacked. 2020-04-07 10:09:34 -05:00
sliptonic
4030e44e41 checkpoint 2020-04-07 10:09:34 -05:00
sliptonic
baba091596 linuxcnc tool table exporter 2020-04-07 10:09:34 -05:00
sliptonic
663d5f3086 revise library editor 2020-04-07 10:09:34 -05:00
sliptonic
c200734dc6 Merge branch 'master' into 3d_surface_perf 2020-04-06 14:33:26 -05:00
Patrick F
65aee430af Removed offset check 2020-04-06 21:11:40 +02:00
Eric Trombly
5ecbc89f30 change isOnLine to isOnLineSegment 2020-04-06 06:34:53 -05:00
Eric Trombly
b631c5600a move getFacets from Path to Part 2020-04-06 06:34:53 -05:00
Eric Trombly
2b8cd1be42 add changes to Waterline 2020-04-06 06:34:53 -05:00
Eric Trombly
0cbf56886a clean up commented old code 2020-04-06 06:34:53 -05:00
Eric Trombly
54022ea630 remove debug profiling from surface 2020-04-06 06:34:53 -05:00
Eric Trombly
fbc266c158 remove parallel processing, replace mesh generation with getting facets 2020-04-06 06:34:53 -05:00
Eric Trombly
651c383925 changed some for loops to list comprehensions, added openmp for area to make two loops parallel, changed a fuse to a compound 2020-04-06 06:34:53 -05:00
Eric Trombly
5f648aa2c1 remove sleep calls, change some for loops to list comp, move isPointOnLine to base vector 2020-04-06 06:34:53 -05:00
sliptonic
bb45a2b01f Merge pull request #3132 from Schildkroet/deburr+dressup
[Path] Deburr+DressupLeadInOut fixes
2020-04-05 18:34:52 -05:00
Patrick F
b8a32610c8 Bugfix for circular hole base 2020-04-02 19:38:21 +02:00
luz.paz
cafed2a137 [skip ci] Fix typos in Path WB
Found via 
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-01 13:28:48 +02:00
Patrick Felixberger
66fbec6005 Setup length depending on tool 2020-03-31 17:31:30 +02:00
Patrick Felixberger
d66ff3364e Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into deburr+dressup 2020-03-31 17:18:06 +02:00
sliptonic
e76c505a17 Merge pull request #3231 from Russ4262/4th_axis_fixes
[Path] 4th-axis rotational alignment improvements;  Code clean-up
2020-03-31 08:17:18 -05:00
Russell Johnson
ebb383cc6c Path: Synchronize tooltips. Apply DepthOffset. Hide properties.
Sync tooltip text between 3D Surface and Waterline.
Also, apply `DepthOffset` to Experimental Waterline algorithm.
Hide some properties in Data tab.
2020-03-30 23:24:47 -05:00
Russell Johnson
6644d08191 Path: Implement experimental Waterline algorithm
Insert experimental Waterline algorithm that is non-OCL based.  It slices by step-down value, not stepover.
2020-03-30 22:34:57 -05:00
Russell Johnson
7d4b2f2a50 Path: Fix bug that fails Multi-pass usage 2020-03-30 22:34:57 -05:00
Russell Johnson
5d03294980 Path: Fix "increase by factor of 10" issue
Forum discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=44486.
2020-03-30 22:34:57 -05:00
Russell Johnson
a907585f0d Path: Four bug fixes per forum discussion
Fix grammar mistake.
Fix Gcode comment formatting.
Fix application of `Optimize Step Over Transitions` by adjusting the offset tolerance for creating the offset cut area for the operation.
Fix math error in circular based cut patterns for small diameter cutters.
Identification of bugs begins in the forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=41997&start=210.
Path: Lower SampleInterval minimum to 0.0001mm
2020-03-30 22:34:57 -05:00
Russell Johnson
11db9553d4 Path: Add Cut Pattern selection to task panel 2020-03-30 22:34:57 -05:00
Russell Johnson
3720b57d63 Path: Add initPage() call to update GUI upon loading
Added initPage() function call updates task panel values and visibilities when user edits an existing operation.
2020-03-30 22:34:57 -05:00
Russell Johnson
3363639681 Path: Update GUI inputs for independent Waterline operation 2020-03-30 22:34:57 -05:00