Yorik van Havre
bff31175cb
Draft: better checks for no active document
2020-11-16 13:25:12 +01:00
Yorik van Havre
ec3bbb02f1
Merge branch 'master' of github.com:FreeCAD/FreeCAD
2020-11-16 13:24:33 +01:00
Yorik van Havre
e06e3d7bb6
Merge pull request #4054 from Roy-043/ArchRoof_processSubShapes_placement_fix
...
Arch: Fix for ArchRoof. When processing a roof's subshapes the placement of the roof was ignored.
2020-11-16 13:06:11 +01:00
Yorik van Havre
23dd5fa8e2
Draft: Enabled 'apply to selected' button in SetStyle dialog
2020-11-16 12:59:44 +01:00
wmayer
d819a62db2
PartDesign: [skip ci] support negative values as second length of a pocket
2020-11-16 11:35:05 +01:00
wmayer
f9d1538186
PartDesign: [skip ci] support negative values as second length of a pad
2020-11-16 11:26:51 +01:00
sliptonic
a5efc81ff8
minor change to make toolcontroller labels better
2020-11-15 18:41:08 -06:00
sliptonic
c415272905
Rework default library and toolbits
2020-11-15 18:22:45 -06:00
sliptonic
f2eaa98bf1
Add toolcontroller to open operation
2020-11-15 18:22:45 -06:00
sliptonic
2da3308bc3
Only allow editing of toolbit if shapefile is found
2020-11-15 18:22:45 -06:00
sliptonic
472cb83ae7
Handle errors is toolbit json more gracefully
2020-11-15 18:22:45 -06:00
sliptonic
aa59e98b37
Make Toolbit find Bit files relative to the current library directory
2020-11-15 18:22:45 -06:00
sliptonic
7c3300dbf2
Fix duplicate docs being created
...
fix edit changes not being retained
fix edit removing new toolbit from diretory
2020-11-15 18:22:45 -06:00
sliptonic
0a77421481
Removed diameter dependencies so lathe tools work
2020-11-15 18:22:45 -06:00
sliptonic
e64f868765
Fix default directory bug
2020-11-15 18:22:45 -06:00
sliptonic
234b88cc18
added attribute to Toolbit for spindlepower
...
setting this to false will suppress M3 commands.
User can configure a toolbit to never have the spindle turn on
this is to prevent accidental powering of the spindle with
unpowered tools like dragknife and probe
2020-11-15 18:22:45 -06:00
sliptonic
88a24475b8
Better cleanup on new toolbit creation
2020-11-15 18:22:45 -06:00
sliptonic
42f7854a5e
fix bug in create toolbit flow
2020-11-15 18:22:45 -06:00
sliptonic
7c4c25ceed
Editing Works
2020-11-15 18:22:45 -06:00
sliptonic
0a2183fe4f
Basic workflow. No editing
...
concept dock work
most functions working.
made linuxcnc export work
Fixed some defaults on new install
fixed display label in dock
2020-11-15 18:22:45 -06:00
wmayer
691f259042
Part: allow to open attachment editor via context-menu
2020-11-15 19:16:22 +01:00
wmayer
8af45a1fe1
Part: move ViewProviderPrimitive to its own source files
2020-11-15 18:44:27 +01:00
wmayer
d3d34fc9d1
Part: [skip ci] include needed headers into PCH file
2020-11-15 13:30:32 +01:00
tomate44
74d5e458cb
fixes and typos
2020-11-15 13:20:41 +01:00
tomate44
b21f5d5916
Part: add BezierCurve constrained interpolation
2020-11-15 13:20:41 +01:00
wmayer
bb7e64786a
Part: [skip ci] include generated ui files from within source file
2020-11-15 13:17:52 +01:00
donovaly
9f6c14998d
[Part] show location dialog when creating a Primitive
...
- there is no reason to hide it and even a bit tiring to open it manually since most no new primitives should be at the origin
- give the combobox to select the primitive type a reasonable name, this helps to understand the code better
2020-11-15 12:56:16 +01:00
Roy-043
b99102f2ac
Update ArchRoof.py
...
The processSubShapes function was wrongly called without providing the placement argument.
2020-11-15 12:02:02 +01:00
wmayer
55af73b07a
PartDesign: [skip ci] if numpy fails to load due a RuntimeError then handle this exception but still load the workbench
2020-11-15 11:47:19 +01:00
wmayer
ed175c9f66
Sketcher: [skip ci] revert minimum size hint from widgets in datum dialog
...
because this leads to a squashed appearance on some systems.
For more details see: https://forum.freecadweb.org/viewtopic.php?f=34&t=52139
2020-11-15 11:07:19 +01:00
donovaly
d5767cd3ba
[PD] Hole countersink angle work
...
- fix bug that custom angles were overwritten
- the norms only define screw heads, not the cut for them, so also a custom angle is possible to sink a metric screw
- use better step in UI since one changes the presets only in fractions of a millimeter (otherwise it would be a different hole size)
- handle case of no cut
- calculate change in diameter when adding depth to countersinks
2020-11-14 19:24:32 +01:00
luz paz
a3cb87b117
TechDraw: Header uniformity and whitespace fixes
2020-11-14 16:59:51 +01:00
wmayer
8f69368f65
Image: [skip ci] move the import of Draft trackers inside scaling function. This gives a more useful error message in case of a failure to load it
2020-11-14 12:08:03 +01:00
Russell Johnson
d3c3a11d90
Path: Delete irrelevant code
2020-11-13 16:34:59 -06:00
Russell Johnson
a273bef210
Path: Fix div by zero error
...
Fix MillFace div by zero error reported in forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=51415 .
Rotational-related variables were exposed to non-rotational code block. They have been moved into correct rotational code block.
2020-11-13 16:34:59 -06:00
Russell Johnson
9f13c8c23b
Path: LGTM cleanup
2020-11-13 16:34:59 -06:00
Russell Johnson
01fa1fecd8
Path: Organize rotational code in areaOpShapes() method
...
Relocate the rotational analysis code into smaller independent methods to allow for easier maintenance and support.
Commented out recently added debug object creation statement.
2020-11-13 16:34:59 -06:00
Russell Johnson
c03a0bba62
Path: Fix and cleanup removal shape creation code
...
The `isFaceUp()` method in the PathAreaOp module was returning false results in some instances.
Rotational code has been consolidated and better organized to fix certain errors reported in the forum.
Overall, this code section has been better organized as a part of the necessary fixes.
2020-11-13 16:34:59 -06:00
Russell Johnson
7fb8f1149a
Path: Improve accuracy of isFaceUp() method
...
This method is used in rotational operations and some standard operations to identify if a face's normal-direction Z value is +1.0
2020-11-13 16:07:18 -06:00
Russell Johnson
c357cb77a1
Path: Remove null comments and improve debugging
...
Added method to create a FreeCAD object when in debug mode.
2020-11-13 16:07:18 -06:00
sliptonic
9c49dc595f
Merge pull request #3989 from Russ4262/Surface_fixes
...
Path: 3D Surface fix to apply `CutMode` when `CutPattern = Offset`; and LGTM cleanup
2020-11-13 14:25:19 -06:00
wmayer
b7d763a1c4
PartDesign: [skip ci] make cut type modes of hole feature translatable
2020-11-13 17:51:41 +01:00
donovaly
4246c902a5
[PD] fix issue 3968
...
https://tracker.freecadweb.org/view.php?id=3968
Don't set the tip to features that cannot hold the tip
2020-11-13 17:03:19 +01:00
wmayer
a48dd3aa2c
Part: [skip ci] rearrange line page to save some vertical space
2020-11-13 15:35:07 +01:00
donovaly
f8ac3ea14a
[Part] remove unnecessary vertical whitespace in dialogs
...
on smaller screens it is very annoying that the Part dialogs have too much vertical whitespace.
This PR gets rid of some unnecessary whitespace.
2020-11-13 13:52:31 +01:00
donovaly
a58c4736a2
[PD] add measure tools
...
use Part's measure tools also for PartDesign
2020-11-13 12:38:42 +01:00
donovaly
922815df57
[Part] improve tube dialog
...
- remove vertical whitespace
2020-11-13 12:37:57 +01:00
wmayer
64288425a2
Part: [skip ci] show dialog directly when creating a tube feature
2020-11-13 12:33:59 +01:00
marioalexis
2b2524451e
Draft: Fixes #0004293 : Vertical dimensions can't be created in XZ and YZ working plane
2020-11-13 10:58:34 +01:00
donovaly
e7af8b5c01
[PD] hole UTS fixes
...
- propose cut values also for UTS profiles
- the UTS defines coarse and fine while for ISO it is regular and fine, thus fix the name
- for the dialog: set minimum values to zero (angles etc. cannot be negative)
2020-11-13 09:07:27 +01:00