Commit Graph

26119 Commits

Author SHA1 Message Date
Matthijs Kooijman
2a60d81c7d Arch: Do not draw draft-like groups twice in section view
When drawing a section view, first a list of objects to draw is made.
Starting with the objects selected by the section plane, any groups or
group-like objects are recursively expanded. The resulting list contains
all contained objects, but also the expanded groups themselves (due to
Draft.get_group_contents with addgroups set).

This list of objects is then further categorized and processed. In this
categorization, there was already an exception for DocumentObjectGroup
instances, which were omitted from the resulting `nonspaces` list
(presumably since there is no point in drawing the groups themselves
when their contents are already in the list).

However, any groups that only contain flat objects would be caught by
`looksLikeDraf()` and added to the `drafts` list, before this exception
could ignore them.

This causes these groups to be processed by Draft.get_svg, which does so
by calling itself recursively on the group contents. Effectively, this
means that the contents of such groups is drawn on the section view
twice. Even more, since Draft.get_svg does not do a visibility check
like Arch.getSVG does, this causes invisible objects to show up when not
intended.

This commit fixes this by moving the DocumentObjectGroup exception a bit
further up, so all these objects should be dropped.

An alternative fix might be to pass addgroups=False to
Draft.get_group_contents (in getSectionData), but that also prevents
group-like objects (Building, BuildingPart, Space, Site) from being
returned, but those likely need to be returned so they can be sectioned
if needed (though if just spaces are needed, then
Draft.get_group_contents also have a spaces argument to return just
those).
2021-05-09 17:19:05 +02:00
wmayer
aba9ef731c Make smesh compile with vtk9 2021-05-09 10:53:13 +02:00
bitacovir
d6c92946ac Update TechDraw_TreePageTemplate.svg 2021-05-08 08:26:04 -04:00
bitacovir
3aa21509b8 Update TechDraw_TreeView.svg
metadata name updated
2021-05-07 16:34:35 -04:00
bitacovir
cb54104189 Update TechDraw_TreeSymbol.svg
metadata name updated
2021-05-07 16:33:29 -04:00
bitacovir
b298cc04a0 Update TechDraw_TreeSpreadsheet.svg
metadata name updated
2021-05-07 16:31:49 -04:00
bitacovir
00612e93a0 Update TechDraw_TreeSection.svg
metadata name updated
2021-05-07 16:30:07 -04:00
bitacovir
af6d977043 Update TechDraw_TreeProjGroup.svg
metadata names updated
2021-05-07 16:28:43 -04:00
bitacovir
06b99bd26e Update TechDraw_TreePageTemplate.svg
metadata names updated
2021-05-07 16:24:58 -04:00
bitacovir
2b419b95ba Update TechDraw_TreePage.svg
metadata names updated
2021-05-07 16:00:36 -04:00
bitacovir
a5e7e0a697 Update TechDraw_TreeMulti.svg
metadata names updated
2021-05-07 15:58:53 -04:00
bitacovir
1dd00d6588 Update TechDraw_TreeHatch.svg
metadata names updated
2021-05-07 15:57:31 -04:00
bitacovir
b26069a508 [TD] Name uniformity for Tree Icons 2021-05-07 12:07:35 -04:00
Bernd Waibel
97a9571892 [Fem] fix femtest failure with yaml.load
Solves an issue with using an outdated call to yaml.load
as described in
https://forum.freecadweb.org/viewtopic.php?f=10&t=57617

Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
2021-05-06 19:52:20 +02:00
UR-0
38adcc0a24 [FEM] patch LGTM alerts 2021-05-06 19:51:27 +02:00
Yorik van Havre
6e9c157cd5 Draft: Fixed last commit (stroke endcap -> stroke-linecap) 2021-05-06 18:49:55 +02:00
Yorik van Havre
e37e8eddfb Draft: Using square endcaps for lines in SVG output 2021-05-06 18:38:32 +02:00
Yorik van Havre
5705bb8aa8 Arch: Small translation fix 2021-05-06 18:37:40 +02:00
Yorik van Havre
dd3f723465 Draft: Added load/save functionality to SetStyle dialog 2021-05-06 18:36:41 +02:00
Yorik van Havre
a0dea60f71 Added OpeningDesign to contributors list 2021-05-06 13:14:12 +02:00
Daniel Wood
f497d0da04 Use defaults for retract height
Use the StartDepth + SafeHeightOffset to calculate the retract height in relation to the hole start height.
2021-05-06 08:09:43 +01:00
Daniel Wood
1e8e81b986 use correct feedrate for rapid moves 2021-05-05 20:33:26 +01:00
Yorik van Havre
966906da96 Merge pull request #4557 from luzpaz/crowdin/whitespaces-substituted-into-code
Crowdin: represent whitespace in code instead of in string
2021-05-05 17:18:35 +02:00
Yorik van Havre
4ff9b768dd Draft: Changed shapestring FillLetters property to MakeFace 2021-05-05 15:41:28 +02:00
Yorik van Havre
fe92e39e8a Merge pull request #4769 from Roy-043/Draft_make_ellipse
Draft: Fixed make_ellipse.py: the face argument was not used
2021-05-05 15:31:13 +02:00
Yorik van Havre
308d292bb9 Merge pull request #4768 from Roy-043/Draft-Gui-addModule-issue
Draft: Fixed 3 gui_*.py files that did not execute Gui.addModule("Draft") if UsePartPrimitives is True
2021-05-05 14:11:33 +02:00
Daniel Wood
aaa5a81e45 use toolbits with tooltip calculation 2021-05-04 15:56:45 +01:00
Daniel Wood
5ff5b11e3c Rapid to safe height above the hole 2021-05-04 14:06:30 +01:00
Daniel Wood
ac13b55666 fixes for drilling operation start depth 2021-05-04 13:41:50 +01:00
Łukasz Stelmach
ba5f7f5d80 [TD] Make the root SVG group a layer for Inkscape
Layers are Inkscape way of marking top level groups. Inkscape provides
convenient UI to show and hide these groups as well as to lock them to
prevent users from accidentally editing them. Although Inkscape can open
and edit files without layers (without any top level group having the
groupmode attribute set to "layer"), it is somewhat cumbersome to move
the group created by TechDraw to a separate layer, which is what I do,
when I want to add more layers with additional information.

Signed-off-by: Łukasz Stelmach <stlman@poczta.fm>
2021-05-03 21:39:07 +02:00
Amritpal Singh
feb8746563 Arch: allow Rebar OffsetStart and OffsetEnd in negative also 2021-05-03 23:06:05 +05:30
wmayer
a6e7bdf849 allow to enable PCH for gcc and clang 2021-05-03 17:37:58 +02:00
Syres916
61b04b9969 Changes as per @Chennes advice 2021-05-02 12:04:03 +01:00
Zheng, Lei
37d6752404 Base: add new API Rotation::get/setEulerAngles()
Exposed to Python as new constructor parameters and
Rotation.toEulerAngles()

This function uses the code from OCCT
gp_Quaternion::Get/SetEulerAngles() to support all 24 possible
generalized euler rotation sequences. Call Rotation.toEulerAngles()
without argument to obtain all possible sequence types.
2021-05-02 17:20:45 +08:00
Syres916
2fd7625a9e [Gui] Preferences - Selection Fix Bug for new...
... users who save an unrelated Preference such as Stylesheet from loosing the default selection settings.
See discussion : https://forum.freecadweb.org/viewtopic.php?f=3&t=58215
2021-05-01 11:58:46 +01:00
Yorik van Havre
a5bab10ff7 Draft: Added a 'solid faces' projection mode to shape2dviews to treat individual faces 2021-04-30 16:44:20 +02:00
Matt Ueckermann
3d1176053f Part [DOC]: Adding documentation to Python API of BSplineCurve (intersect and buildFromPoles) 2021-04-29 23:06:55 -04:00
Roy-043
86f3c4021a Update make_ellipse.py
Draft: Fixed make_ellipse.py: the face argument was not used and therefore "filled mode" did not work in the GUI.
2021-04-29 21:23:26 +02:00
Roy-043
e13bf0fac7 Update gui_points.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:07:07 +02:00
Roy-043
a3778eacd4 Update gui_arcs.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:05:52 +02:00
Roy-043
7fa3869116 Update gui_ellipses.py
Gui.addModule("Draft") should be executed before committing _cmd_list irrespective of the UsePartPrimitives setting.
2021-04-29 21:03:44 +02:00
Yorik van Havre
e605b2f930 Draft: Allow to set 'arch' unit override on dimensions 2021-04-29 19:51:34 +02:00
Yorik van Havre
117ec1b918 Merge pull request #4766 from waebbl/module-test-issue
[Test] fix failing test in Test module
2021-04-29 12:47:15 +02:00
Yorik van Havre
c0c49ebffc Merge branch 'master' into draft-feature_name 2021-04-29 12:40:27 +02:00
Bernd Waibel
203d408429 [Test] fix failing test
Solves an issue with the test module when running test-suite
as described in
https://forum.freecadweb.org/viewtopic.php?f=10&t=58099

Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
2021-04-28 22:09:55 +02:00
Yorik van Havre
d5393bb1e1 Merge pull request #4764 from KeithSloan/addElement
OpenSCAD - Add element ( Load | Save | Refresh )
2021-04-28 12:37:45 +02:00
wmayer
545d055766 Gui: [skip ci] fix crash in SequencerBar::setProgress or SequencerDialog::setProgress when used in worker threads 2021-04-28 12:02:52 +02:00
wmayer
0909fa76aa Base: allow to use the classes XUTF8Str and StrXUTF8 outside FreeCADBase 2021-04-28 10:56:17 +02:00
sliptonic
b922ae5b15 fix bug adding TC from job dialog.
When adding tool controllers from the job dialog, it will now
try to match the toolbit file with the currently selected library
and add use the toolnumber from there.  If no match is found,
it will autoincrement from the existing tool controllers
in the job
2021-04-27 14:56:05 -05:00
luz paz
63cd79538e Misc: remove py2 code 2021-04-27 18:52:01 +02:00