Commit Graph

3521 Commits

Author SHA1 Message Date
Ajinkya Dahale
23ecf94ab6 [Sketcher] Make trimmed curve(s) construction based on original 2025-04-10 09:20:18 +02:00
Ajinkya Dahale
08a66afbc8 [Sketcher] Add missing check when transforming constraints for trim
Fixes https://github.com/AstoCAD/FreeCAD/issues/24.
2025-04-10 09:20:18 +02:00
Ajinkya Dahale
2779f0b29f [Sketcher] Add missing check in deriveConstraintsForPieces
Fixes #19770.
2025-04-10 09:20:18 +02:00
Ajinkya Dahale
b6a069dc63 [Sketcher] Attempt to avoid double-trimming in some cases
Possibly fixes #19425 and/or #20081.
2025-04-10 09:20:18 +02:00
Ajinkya Dahale
fbac7d737b [Sketcher] Refactor DrawSketchHandlerTrimming::mouseMove() 2025-04-10 09:20:18 +02:00
Ajinkya Dahale
358942b771 [Sketcher] Fix issue in SketchObject::transferConstraints
Small but major oversight.
2025-04-10 09:20:18 +02:00
Ajinkya Dahale
f0d30cb570 [Sketcher] Adjust constraint changes when trimming
1. No longer applying equality constraints between new (circular) pieces since
they may cause issues.
2. Only transfer equality with a different curve to one of the pieces.
3. Re-added certain constraints (that applied to both ends of the original
curve) that were incorrectly excluded from modification/deletion at a certain
step.
4. Use C++20 `std::erase_if()` in trim
2025-04-10 09:20:18 +02:00
Kacper Donat
35a9673a75 Base: Rename Base::freecad_dynamic_cast into freecad_cast
This is to make it shorter and easier to use. QT does the same thing
with their qobject_cast.
2025-04-07 10:32:28 -05:00
luzpaz
7a12d2f96f Fix various typos (#20651)
* Fix various typos
Found via `codespell -q 3 -L aci,addmin,ake,aline,alle,alledges,alocation,als,ang,anid,anormal,anull,aply,apoints,ba,beginn,behaviour,bloaded,bottome,brushin,bu,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,documentin,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,findn,fle,freez,graphin,groupe,hist,iff,incrementin,indexin,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,itsel,kilometre,leadin,localy,lod,mantatory,matc,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,renderin,re-use,re-used,re-using,rin,ro,rougly,sectionin,seperator,sergent,serie,shs,sinc,siz,som,stpo,strack,substraction,te,technic,thist,thru,tread,tru,ue,uint,unter,uupper,uptodate,vas,vertexes,vew,wallthickness,whitespaces -S "./.git,*.po,*.ts,*.pdf,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./src/Base/StackWalker.cpp,./build/doc/SourceDoc,./tools/build/WindowsInstaller/lang,./src/Mod/TechDraw/Templates/locale"`

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-04-05 22:58:20 -05:00
tritao
63ed3e8dff Sketcher: Remove XML binding files.
These are not needed anyore with the Python bindings conversion.
2025-04-05 17:52:38 +02:00
Kacper Donat
52aec7d639 Merge pull request #20594 from captain0xff/icon-res
Gui: make BitmapFactory::pixmapFromSvg dpi aware
2025-04-05 00:32:21 +02:00
tritao
770dbe5580 Sketcher: Convert XML binding files to Python API bindings model. 2025-04-04 22:59:32 +02:00
captain0xff
08381b1d18 remove some code setting pixel density ratio for pixmaps
update
2025-04-03 19:55:27 +05:30
Kacper Donat
db08735e10 Merge pull request #20559 from hyarion/refactor/add-limits
Add `#include <limits>` in all files where it is used
2025-04-01 17:11:50 +02:00
Benjamin Nauck
4b589088f6 Sketcher: Add #include <limits> where used 2025-03-31 23:52:38 +02:00
Rafael Pronto
1d4a09366c Sketcher: Prevent renaming interruption when hovering task elements. (#20458)
* Sketcher: Prevent renaming interruption when hovering task elements.

Fixes #11842.

* Sketcher: Refactored input focus check based on PR feedback (PR #20458)

* Update src/Mod/Sketcher/Gui/TaskSketcherElements.cpp

---------

Co-authored-by: Benjamin Nauck <benjamin@nauck.se>
2025-03-31 17:45:33 +00:00
Chris Hennes
e7156aa326 Merge pull request #20496 from hyarion/refactor/cppify-constants 2025-03-29 18:43:40 -05:00
ashimabu
0317206930 Sketcher: Explicitly check fullyConstrainedChanged on solve (#20236) 2025-03-29 14:25:58 -05:00
Benjamin Nauck
b4eb28e50e Sketcher: Use std::numeric_limits and std::numbers instead of defines 2025-03-29 13:32:39 +01:00
mosfet80
96e8a9e83c Remove old GCC<=8 (#20508)
GCC version is always greater than 8
2025-03-29 12:21:36 +01:00
PaddleStroke
0f00c6d2d1 Sketcher: Slot tool: Enforce correctly when angle is set (#20269) 2025-03-22 18:21:24 +01:00
PaddleStroke
1fc61423f3 Sketcher: Line tool: Enforce correctly when angle is set (#20267) 2025-03-22 18:20:26 +01:00
Chris Hennes
28b62eb52b Sketcher: Ensure copy of temp string is kept
Coverity issue 545249. A temporary string is constructed, and its address stored via c_str(). That pointer is then used after the string is destroyed. The fix is to store the std::string.
2025-03-22 07:15:15 +01:00
Chris Hennes
e12deea20e Sketcher: Ensure loop can exit
Coverity issue 513796
2025-03-22 07:15:15 +01:00
PaddleStroke
7076989ead Remove unecessary if in DrawSketchHandlerArc.h 2025-03-20 13:40:24 +01:00
Chris Hennes
e574fa1efc Merge pull request #19899 from tritao/cmake-cleanup-targets
CMake: Cleanup targets with transitive dependencies
2025-03-17 13:15:37 -05:00
Chris Hennes
061876db82 Merge pull request #14176 from mosfet80/cleanmodPart
[mod:part] clean code
2025-03-17 11:13:19 -05:00
tritao
6c2c6847eb CMake: Cleanup targets with transitive dependencies 2025-03-17 12:12:06 +00:00
Chris Hennes
5f623390fb Merge pull request #20142 from bofdahof/ranges
Apply C++20 std::ranges (mainly to std::find)
2025-03-17 03:08:27 -05:00
Chris Hennes
42cc0d93be Merge pull request #20160 from karliss/popup-parent
Add missing parent for messagbox and other popups.
2025-03-17 00:16:49 -05:00
Chris Hennes
4fcdac28fb Merge pull request #19583 from hyarion/refactor/base-type
Refactor Base::Type
2025-03-17 00:03:22 -05:00
Chris Hennes
fd4fd6ccf7 Merge pull request #19890 from Shkolik/sketcher_defining_color
Sketcher: Preference color added for External defining geometry
2025-03-17 00:00:02 -05:00
Chris Hennes
89e20d561d Merge pull request #20105 from PaddleStroke/patch-15
Sketcher: DSH: add OVP constraints before AutoConstraints.
2025-03-16 23:58:57 -05:00
Chris Hennes
75bcc7d316 Merge pull request #20165 from PaddleStroke/patch-16
Sketcher: Add parameter to combine line and polyline
2025-03-16 23:58:07 -05:00
bofdahof
34881bc82e Sketcher: apply std::ranges 2025-03-16 17:18:12 -05:00
Karliss
fa61131590 Add missing parent for messagebox and other popups
Unparented popups can easily get lost in backround, but they still block top level event loop when run with ::exec() thus preventing interactions with main window.  This mainly happens on wayland. Setting the parent ensures they are always kept on top and reasonably positioned.
2025-03-16 16:02:36 -05:00
Luz Paz
17102251e5 Fix various typos 2025-03-14 12:37:12 -04:00
PaddleStroke
0814df7488 Update src/Mod/Sketcher/Gui/SketcherSettings.ui
Co-authored-by: Furgo <148809153+furgo16@users.noreply.github.com>
2025-03-13 15:05:00 +01:00
PaddleStroke
2d5d1397a9 Update src/Mod/Sketcher/Gui/SketcherSettings.ui
Co-authored-by: Furgo <148809153+furgo16@users.noreply.github.com>
2025-03-13 15:04:52 +01:00
PaddleStroke
255949134f Add line group checkbox to SketcherSettings.cpp 2025-03-13 14:47:02 +01:00
PaddleStroke
8ae1d9bbde add line group checkbox in SketcherSettings.ui 2025-03-13 14:45:40 +01:00
pre-commit-ci[bot]
fde9be13bc [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2025-03-13 11:12:48 +00:00
PaddleStroke
b940863353 Sketcher: Add parameter to combine line and polyline 2025-03-13 12:08:56 +01:00
Chris Hennes
3359fee251 Sketcher: Clean up compiler warnings
* numpoints from double to int
* Remove redundant out-of-line definition for constexpr static data member
2025-03-11 22:33:32 -05:00
Chris Hennes
71906499c4 Merge pull request #19843 from Shkolik/sketcher_spline_intersection
fix #19831 Sketcher: Create external Intersection geometry not working with complex surfaces
2025-03-11 21:44:28 +00:00
Chris Hennes
357cddabc7 Merge pull request #20117 from hyarion/ps-move-func-to-cpp
Sketcher: Move getStandardButtons to cpp file
2025-03-11 20:55:40 +00:00
Chris Hennes
6de034bf84 Merge pull request #19926 from benj5378/toStringasd
Gui: clean up PropertyItem::toString
2025-03-11 20:38:15 +00:00
Benjamin Nauck
2db9ae7bdf Remove outdated comment 2025-03-11 10:17:12 +01:00
PaddleStroke
0bb47bc0d8 Move getStandardButtons to cpp file 2025-03-11 10:09:09 +01:00
Andrea
cd5c46ba18 Remove unnecessary check (duplicated)
before including the library, it is uselessly checked if the variable __QtAll__ and __InventorAll__ have been defined. The same check is performed again once the library is included
2025-03-10 21:53:00 +01:00