Commit Graph

2809 Commits

Author SHA1 Message Date
Paddle
d19a16ddd5 SketcherToolDefaultWidget : add 3 parameter configuration functions.
And remove the units from setParameter.
2023-10-24 19:28:13 +02:00
Paddle
5ced1c2680 SketcherToolDefaultWidget : add functions to set combobox item icons and checkboxes icons. 2023-10-23 20:24:20 +02:00
Paddle
f45fd8fe35 Sketcher: commandConstraint : remove leftover bothexternal variable. 2023-10-22 13:51:21 +02:00
wmayer
ce9c57383a Sketch: use new-style connect() in new code 2023-10-20 14:23:21 +02:00
wmayer
7f23467674 Sketch: fix several compiler and lint warnings
* Remove private unused field 'sketchView'
* Mark constructor with single argument as explicit
* Mark virtual methods of base class as override
* Fix clang code model parsing error
* Avoid too short identifiers
* Avoid redundant ternary operators
* Avoid passing Base::Unit by value but by const reference
2023-10-20 12:29:59 +02:00
wmayer
5a6cfafda8 Sketch: fix Qt6 build failure
QRegExp has been replaced with QRegularExpression and isn't part of the base of Qt6 any more
2023-10-20 11:57:21 +02:00
Abdullah Tahiri
71a9eca750 Sketcher: ToolSettings Widget - Tool Management
===============================================

Sets the full interface between the DrawSketchHandler and a tool widget available somewhere in the UI.

Signalling is as follows:
1. On activation of the tool, DrawSketchHandler notifies the tool widget.
2. The tool widget retrieves tool information necessary for representation (type of widget, visibility, ...)
3. When the tool widget has created an appropriate widget, it notifies back a widget change.
4. The tool receives the widget handler and can now configure and interact with the widget.
2023-10-15 15:20:03 +02:00
Paddle
9538aafc9a Sketcher: DrawSketchHandler - add getViewer function to drawsketchHandler to simplify code. 2023-10-15 15:20:03 +02:00
Paddle
c62f5f30fd ToolWidget-Sketcher: Tool widget basic framework
================================================

Provides a framework to show in the taskbar a taskbox with a tool settings dialog.
2023-10-15 15:20:03 +02:00
Paddle
951edf3ec4 Fix typo making Sketcher_Dimension fails for angles. 2023-10-10 13:48:07 +02:00
wmayer
56820718c5 Core: Revert superfluous changes made with PR #9521 2023-10-09 15:06:45 +02:00
Abdullah Tahiri
e9187412d9 Sketcher: Example new type checking template function usage
===========================================================

Just two small refactor examples of how to use the type checking template functions.
2023-10-07 23:12:46 +02:00
Abdullah Tahiri
96efff81c7 Sketcher: Fix segfault when activating a tool in a different view
=================================================================

When in Sketcher edit mode, a tool button is activated, while the view has been changing to view of a different type, it segfaults.

This commit checks the pointer of the view to ensure correct type before activation, and refusing to activate if not of the correct type.

fixes #10809
2023-10-07 09:00:06 +02:00
Paddle
37b68f3931 Create makeAngleBetweenTwoLines and Create Create calculateAngle to remove duplicates 2023-10-07 07:43:39 +02:00
AgCaliva
2212e68a30 merge master via cli 2023-10-04 13:28:48 -03:00
liukaiwen
18af697795 Merge remote-tracking branch 'origin/master' into remove_redundant_definition 2023-10-02 01:42:37 +08:00
Chris Hennes
5dfd4d5190 Update translations 2023-09-29 22:57:37 -05:00
liukaiwen
4f8fe8fd4a [cmake] some definitions do not matter build now 2023-09-27 18:17:14 +08:00
AgCaliva
1f9bae0de7 Merge branch 'master' into User/Document/Feature_level_units_selection_#7746 2023-09-25 22:58:23 -03:00
howie-j
acbf135b78 [Sketcher] Fix angle constraint expression regression (#10743)
* fix 10742

* moved expression string modifier to helper function

* Tests: Add example tests for SketchObject

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* made expr modifier func static, pass by value and added unit tests

---------

Co-authored-by: Chris Hennes <chennes@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2023-09-25 10:44:31 -05:00
wmayer
5a81fcd7a5 MSVC: fix warnings and build failure 2023-09-23 19:10:32 +02:00
Chris Hennes
730d471fb1 Update translations 2023-09-19 22:25:14 -05:00
wmayer
ab4abab53d Sketch: fix a few minor issues:
* fix compiler warning about unused variable
* fix const correctness
* fix access type of setExpression()
* removed duplicated method
2023-09-19 22:01:19 +02:00
Chris Hennes
0bbb10864b Merge pull request #10656 from Ondsel-Development/dim_arc_angle
Sketcher_Dimension: Adds arc angle mode.
2023-09-19 12:42:56 -05:00
Paddle
e3445388a2 Sketcher_Dimension : adds arc-angle mode for arcs. 2023-09-19 08:25:45 +02:00
Paddle
55420d96af Sketcher: Angle constraint: when moving it with mouse, it enables user to switch of supplementary angle. 2023-09-19 07:22:50 +02:00
Paddle
a8f11f12fb Implement a function in sketchObject that swap an angle constraint to its supplementary. 2023-09-19 07:22:50 +02:00
Paddle
e58b52ea12 Add setter/getter for constraint expression. 2023-09-19 07:22:50 +02:00
AgCaliva
9aabfcd1f8 continue fix DOMDocument redefinition 2023-09-18 18:58:05 -03:00
Paddle
1c8f49ee67 Adds a small convenience function to get arc of circle angle. 2023-09-18 21:33:24 +02:00
AgCaliva
dacb2c43a4 Merge branch 'master' into User/Document/Feature_level_units_selection_#7746 2023-09-18 14:01:25 -03:00
AgCaliva
c483ecebb4 using clang-format tags to avoid get headers reordered(fix DOMDocument redefinition error) 2023-09-18 13:40:13 -03:00
Jonas Bähr
efc7fd09e4 Sketcher: update SketchObject's pydocs, first batch
Style like in e.g. `Part.makeLine(...)`, which seems to loosely follow
Google's recommendations [1]. Note that the signature *is* repeated in
the docstrings, as it's not "inspectable" (see notes for non-python
implementations in `inspect.signature` [2]).

[1]: https://github.com/google/styleguide/blob/gh-pages/pyguide.md#38-comments-and-docstrings
[2]: https://docs.python.org/3/library/inspect.html#inspect.signature
2023-09-18 10:57:12 -05:00
howie-j
12913daef5 fixes #10651 2023-09-18 10:56:13 -05:00
Florian Foinant-Willig
f393a90467 Sketcher: refactor CommandConstraint.cpp (#10692)
* Sketcher: refactor CommandConstraint.cpp with TypeId helpers

* Sketcher: cosmetic empty lines

* fix pointer misusage
2023-09-18 10:37:03 -05:00
AgCaliva
5ce71463f5 fixing DOMDocument redefinition3 2023-09-16 07:27:11 -03:00
pre-commit-ci[bot]
d31c2130fb [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-16 05:14:03 +00:00
AgCaliva
4a504437d3 merge master via cli 2023-09-16 02:12:58 -03:00
AgCaliva
280e5e3987 Fixing DOMDocument redefinition 2023-09-16 00:38:41 -03:00
Paddle
594b1aec11 Sketcher_Dimension : enable user to deselect geos by clicking on them again. 2023-09-14 20:57:39 -05:00
wmayer
e9b61bdbe2 Sketcher: fix several inconsistencies in Sketcher_CompDimensionTools
* The menu text and tooltip of the Sketcher_ConstrainRadius command shouldn't be different if part of the group command or not.
  The explicit mentioning to change the weight of a B-Spline is pointless and confusing.
* The order of Sketcher_ConstrainRadius and Sketcher_ConstrainDiameter has flippend when used in Sketcher_CompDimensionTools
* The command Sketcher_ConstrainRadiam is completely missing
* The command Sketcher_ConstrainSnellsLaw was wrongly re-added
* CmdSketcherCompConstrainRadDia uses a wrong context
2023-09-14 20:56:14 -05:00
luzpaz
760fac5d82 Fix typos 2023-09-14 20:53:04 -05:00
Florian Foinant-Willig
602819478c Sketcher: add TypeId checking helpers 2023-09-14 20:52:03 -05:00
AgCaliva
41230a9427 fixing DOMDocument redefinition error 2 2023-09-14 03:50:53 -03:00
wmayer
89bb28239e MSVC: fix several compiler warnings 2023-09-12 22:57:26 +02:00
pre-commit-ci[bot]
e8ab02b26b [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-12 21:19:33 +02:00
pre-commit-ci[bot]
222a2520b1 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-12 13:02:35 -04:00
sliptonic
ea2919765e Merge pull request #10597 from howie-j/sketcher_dim_key
[Sketcher] Change Sketcher_Dimension modifier key from SHIFT to M
2023-09-11 10:38:07 -05:00
Chris Hennes
857ddacb6e Update translations (#10613)
* Update translations
* Start: Remove Start.ts
2023-09-10 13:06:26 -05:00
pre-commit-ci[bot]
86083a5b94 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-08 12:13:51 +00:00