Commit Graph

24937 Commits

Author SHA1 Message Date
Florian Foinant-Willig
27ed6d6349 Fix circles distance constraint for concentrics 2023-03-20 16:02:08 +01:00
Uwe
431fafc533 [FEM] fine-tune flow examples
- use a more sensible velocity distribution
- change inlet temperature for 2 examples

- also change step size for nonlinear iterations for more convenience for practical usage
2023-03-20 07:17:11 +01:00
Uwe
9007723331 [FEM] rewrite initial velocity constraint
- same as #8963 but for initial velocity

- add an example file that demonstrates the influence of the initial velocity
- some fine-tuning for the existing flow example
2023-03-20 04:58:24 +01:00
Uwe
06061e37dc [FEM] rewrite velocity constraint
- complete revision of the constraint.

This is a breaking change, meaning existing constraints won't work.

This is possible because since 2 days ago the whole flow equation did not work at all. Also the existing constraint implementation if buggy and cannot be used to do the Elmer tutorial. Also, the constraint is only used by Elmer and only be the flow equation.

Since nobody complained about the obvious wrong results, we can assume the flow equation was not yet in practical usage (and for FC 0.20 we known that it does not work at all, first with FC 0.20.1).

It is necessary since it must be possible to either input a velocity or an equation. With an equation, a velocity profile can be specified.

- update the flow examples accordingly:
-- simplify them since an initial and and output velocity is not necessary to specify
-- use a formula as input velocity for the non-turbulent example
2023-03-20 01:57:09 +01:00
Uwe
a2fec51923 [FEM] Elmer: support for variable strings
- Elmer offers the "Variable" calls do define variables via math equations. These are for example used to define as constraint a certain velocity profile
2023-03-20 01:14:34 +01:00
Uwe
09fbf45925 [FEM] output less messages
- the message how to use the feature is not useful since it is triggered by the GUI selection and in the GUI has already the info in form of tooltips how to use
2023-03-20 01:13:46 +01:00
Abdullah Tahiri
f7f78aa44b Missing overrides 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
6ffd22fa9b Refactor of CmdSketcherSnap and SnapSpaceAction to reduce verbose calls to retrieve preference parameters 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
a07630dfb3 Refactor parameter in a single place 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
5ae5d0db87 Prevent unnecessary update of snapAngle, block signals when auto updating 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
8d33a24092 Remove unnecessary ViewProvider retrieving and checking, as it is unused 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
65ec96d12d Rename angleSnapEnabled to angleSnapRequested for consistency with the other snap flags 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
75fd0dbc73 Remov warning -squash group by meaningful groups 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
e763fd3d80 Remove warning - SnapManager initialisation order in constructor different from class declaration 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
41408b411f Encapsulate interface data members 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
50b3662535 Rename preference parameter 2023-03-19 19:14:22 +01:00
Abdullah Tahiri
af0f4b10f6 Remove left-over code 2023-03-19 19:14:22 +01:00
Paddle
de57296576 Sketcher: Snap: Add 'Snap at angle' to Arc of Ellipse DSH. 2023-03-19 19:14:22 +01:00
Paddle
4922a48997 Sketcher: Snap: Add 'Snap at angle' to Ellipse DSH. 2023-03-19 19:14:22 +01:00
Paddle
7b7368b04b Sketcher: Snap: Add 'Snap at angle' to Line DSH. 2023-03-19 19:14:22 +01:00
Paddle
e62d6b854b Sketcher: Snap: Add 'Snap at angle' to Arc DSH. 2023-03-19 19:14:22 +01:00
Paddle
7d97a5d8da Sketcher: Snap: Add 'Snap at angle' support to DrawSketchHandler. 2023-03-19 19:14:22 +01:00
Paddle
0f274c2e07 Sketcher: Snap: initial implementation: - creation of SnapManager class. - Move grid snap to this new class. - Add snap to object. - Add snap at angle. 2023-03-19 19:14:22 +01:00
flachyjoe
21c2eb6014 Sketcher: Add circle to circle distance constraint 2023-03-19 14:05:35 +01:00
wmayer
c585a9f430 TD: move all XML query handling to a single function 2023-03-18 19:26:01 -04:00
Paddle
5090cf3436 Sketcher: Constraint Widget: Change showHideButton from QPushButton to QToolButton to avoid style problems. 2023-03-18 18:22:21 +01:00
Abdullah Tahiri
64eb85b1ea ElementWidget: remove unnecesary element pointer
================================================

This should fix this (I cannot reproduce it):
https://forum.freecad.org/viewtopic.php?p=667579#p667579

Lately I added the geometry pointer to the item. This has indeed
the potential for an already deleted pointer being accessed.

This PR removes the geometry pointer from the item and relies on the
ViewProvider to indirectly access an updated pointer.
2023-03-18 11:32:22 +01:00
Abdullah Tahiri
522679321c ElementWidget: reorganise implementation class declarations 2023-03-18 11:32:22 +01:00
Abdullah Tahiri
3f19bcbeef Sketcher: Elements Widget - Fix crash when moving external geometry to another layer
====================================================================================

As reported:
https://forum.freecad.org/viewtopic.php?p=667426#p667426

Support for moving external geometry to another layer will come in the future.
2023-03-18 07:45:04 +01:00
Abdullah Tahiri
5242f6d048 ElementsWidget: Move ElementFilterList to implementation
========================================================

Only moving code from header to implementation.
2023-03-18 07:45:04 +01:00
Abdullah Tahiri
7cc3fe480c ElementsWidget: Move Delegate to implementation
===============================================

Only moving code from header to implementation.
2023-03-18 07:45:04 +01:00
Uwe
d23b576c33 [FEM] update a file license
- like in #8933
2023-03-18 01:04:17 +01:00
Uwe
576781363d Merge pull request #8934 from jbaehr/partdesign-ingolutegear-profileshift
PD: Implement Profile Shift for InvoluteGear
2023-03-18 00:48:44 +01:00
Chris Hennes
23182666dc Fem: Fix licensing of Calculix test FCStd files (#8933)
* Fem: Fix licensing of Calculix test FCStd files
2023-03-18 00:47:02 +01:00
Jonas Bähr
9404c032f4 PD: Implement Profile Shift for InvoluteGear
This commit adds the ability to shift the involute profile inside or
outside. Profile shift is implemented as coefficient, i.e. normalized by
the module, so that it the whole profile scales with the module without
chaning shape.
To verify the profile, the tests implement an "over pins measurement"
using formulae found in literature.
Backward compatibility with FreeCAD-v0.20 is garanteed by already
existing tests, not touched by this commit.

This addresses issue #5618.
2023-03-17 22:22:34 +01:00
Uwe
5dabd5dfff [FEM] add an example for a turbulent flow 2023-03-17 17:57:09 +01:00
Uwe
b9398e3fdb [FEM] improve check for fluid material
- it is sufficient if there is a dynamic viscosity defined
2023-03-17 17:56:41 +01:00
Uwe
e5caf77009 [FEM] fix 1D thermomech example
- the heat capacity of water was wrong
- also specify just thermal expansion, this make that water is recognized as material and then all water parameters will be available

(that the analysis fail despite CalculiX reports everything went well s is another issue, I will investigate later)
2023-03-17 17:55:50 +01:00
Uwe
c38fcf8ed7 [FEM] Elmer: add new default coordinate system
- for new versions of Elmer the default coordinate system is "Cartesian". (if 2D or 3D is determined by the "Variable" setting for the equation)
2023-03-17 16:03:23 +01:00
Paddle
db65bb751d Draft: Remove unit selector in status bar as it is now implemented in core's sizeLabel. 2023-03-17 14:04:24 +00:00
Paddle
66ab1e3bf3 Sketcher: Add parameter observer for system unit, such that the view is updated when user change the unit system through the sizeLabel widget. 2023-03-17 14:04:24 +00:00
Uwe
b1c848b8db [FEM] fix flow equation
- the density must be output using the correct units. Due to this bug also the viscosity was written with wrong units-
- if there is a dynamic viscosity given for a material, use it directly
2023-03-17 03:55:23 +01:00
Uwe
c1751bde4a [FEM] improve deletion warning
- don't popup a warning if all children of an object are selected too when deleting the object
2023-03-16 21:54:09 +01:00
sliptonic
fc3e1fe70e Path Update license to CC 4.0 2023-03-16 19:49:40 +01:00
marioalexis
20984f866c Fem: Remove unused member node 2023-03-16 17:50:21 +01:00
Russell Johnson
ca1312c8ad Path: Update license
Addresses user-specific need in #8894
2023-03-16 17:46:27 +01:00
LarryWoestman
0fcfb2206e Path: Updated the licensing to Creative Commons 4.0 2023-03-16 16:33:47 +01:00
wandererfan
5247b91a63 [TD]add wait for threads to Dimension test script 2023-03-16 10:37:14 -04:00
wandererfan
e3dcb24ebe [TD]prevent bleed through on Detail mat 2023-03-16 10:37:14 -04:00
wandererfan
0c5f476ad4 [TD]skip center marks for view frame 2023-03-16 10:37:14 -04:00