kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
37,627 Commits 41 Branches 6 Tags
298deb719937f9cdfb13d107c8db33944d9d591e
Commit Graph

165 Commits

Author SHA1 Message Date
donovaly
714a716575 [TD] handle equal tolerances correctly 
the common rule is that if a dimension has equal over- and undertolerance, they are output on the same line as the dimension concatenated using the ± character.

This PR does this.

Note that this is not just cosmetics, it is even standardized in the GD&T norms.

also:
* use one format specifier for tolerances since the norms don't allow a different format for the over- and the undertolerance
* some code optimizations like a self-explaining function name, remove unnecessary/outdated comments
 2021-01-08 15:14:37 +01:00
Aapo
dadac36234 [TD] GQIViedDimension.cpp, GQCustomText.cpp - Fix Dimension label unit positioning bug and too tight bounding rectangle. 2020-12-03 21:31:01 +01:00
aapo-aapo
e71b7ac879 @aapo-aapo @chennes [TD] Suggested minor improvements for DrawViewDimension.cpp and QGIViewDimension.cpp in Pull request review. 
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2020-12-02 16:38:21 +01:00
Aapo
3f623576d5 [TD] Add tolerance format specifiers and arbitrary tolerances. 2020-12-02 16:38:21 +01:00
Aapo
768a2b1f11 [TD] Make tolerance labels use the same formatValue() conversion as dimension labels. Support MultiValueSchemas for tolerances, too. 2020-12-02 16:38:21 +01:00
Aapo
c695b4009b [TD] Refactor DrawViewDimension getFormatedValue() into two functions. 2020-12-02 16:38:21 +01:00
luz paz
2befcd9502 TD: Issue #0004473: Expose openCommand() to translation 
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the TechDraw Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
 2020-12-01 14:53:35 +01:00
Aapo
4e06414552 [TD] Add comments and more transparent tolerance position adjustment calculation. 2020-12-01 14:37:39 +01:00
Aapo
f2e91ec488 [TD] Make dimension number graphical layout more compact by making boundingRect() tighter for dimension number labels. 2020-12-01 14:37:39 +01:00
wmayer
9fd5769f07 TechDraw: [skip ci] fix several gcc/clang warnings 
-Wunused-private-field
-Wmaybe-uninitialized
-Wunused-parameter
 2020-09-11 15:10:58 +02:00
wandererfan
5d58c2c711 [TD]remove extra space in Angular Dims 2020-08-29 11:13:35 -04:00
wandererfan
cc81f791da [TD]change Angle Dim tolerance format 2020-08-22 08:56:57 -04:00
wandererfan
980ecc87a3 [TD]Dim blocks selection of geometry 2020-07-28 15:09:40 -04:00
wandererfan
9dac347fc7 [TD]fix Dim selection fails to clear prev selection 2020-07-26 19:45:49 -04:00
wmayer
b25dee58d5 Coverity: Uninitialized scalar/pointer field 2020-07-20 17:34:30 +02:00
wmayer
da6b379566 fixes #0004318: Compilation fails with Qt 5.15 beta with QPainterPath errors [skip ci] 2020-07-02 13:19:43 +02:00
wandererfan
e80c576241 [TD]Centralize preference getters 2020-04-24 11:13:49 -04:00
donovaly
6fa80d8cbf [TD] fix order of arrow heads 
see https://forum.freecadweb.org/viewtopic.php?f=35&t=44334#p378675
 2020-03-21 09:44:07 -04:00
Tobias Ellinghaus
85c9376fef Fix label of angular dimensions 
According to ISO 129-1 labels of angular dimensions may never be upside
down (that is also true for other labels but not relevant for this
commit).
 2020-03-13 09:02:37 -04:00
donovaly
a219f92711 [TD] fix arrow end None for dimensions 
This was not merged from my PR to PR #3153

- also uniform the combobox appearance in the preferences
 2020-03-13 09:01:06 -04:00
wandererfan
fb2454dde7 [TD]fix crash on Dim delete 
- adjust index/cache options to avoid "dirty" screen
  region errors.
- may be masking missing "prepareGeometryChange"
 2020-03-06 13:56:38 -05:00
wandererfan
e0eda0de58 [TD]expose dimension arrow position to Python 2020-03-02 08:37:19 -05:00
WandererFan
49e4e45ff3 [TD]fix compile error on Win re M_PI 2020-01-10 18:04:41 -05:00
wandererfan
b7190a8b50 [TD]refix Dim select area problem 2020-01-08 15:07:28 -05:00
wandererfan
7e3197abe0 [TD]fix Dimension selection issues 2019-12-31 17:28:41 -05:00
wandererfan
dcc2790834 [TD]fix potential nullptr while restoring 2019-12-30 18:20:48 -05:00
wandererfan
6a31795600 [TD]improve presentation of tolerance text 2019-12-18 07:01:46 -05:00
wandererfan
186d52ffd4 [TD]fix dim text for multi value schemas 2019-12-05 07:10:08 -05:00
wandererfan
5021f3777b [TD]Fix Dimension prefix/suffix 2019-10-20 15:36:59 -04:00
wandererfan
a1de871e93 [TD]Fix duplicate Arbitrary dim text 2019-10-18 09:13:06 -04:00
wmayer
9ba5d3505c fix -Winconsistent-missing-override -Wunused-variable 2019-10-13 14:29:52 +02:00
wandererfan
90fad8180f [TD]Improve tolerance formatting 2019-10-11 09:16:41 -04:00
wandererfan
d7dabeb885 [TD]Fix Dimension Color Regression 
- still an issue where text looses select color if
  clicked while selected
 2019-09-29 19:56:46 -04:00
Tomas Pavlicek
b75398d763 Complete remake of drawing dimensions 2019-09-25 15:20:14 +02:00
Tomas Pavlicek
46c73062ff TechDraw: Radius drawing refactored - ASME support 2019-08-21 19:27:12 -04:00
wandererfan
641d946fa4 [TD]Allow Aligned & Uniform Conventions on Radius Dims 2019-08-10 19:41:03 -04:00
Tomas Pavlicek
f704340f2b Enhance Radius dimension drawing 2019-08-10 19:41:03 -04:00
Tomas Pavlicek
28b2df05da TechDraw: SVG export refactoring - Keep correct font sizes 2019-06-11 15:46:46 -04:00
wandererfan
4494d384a6 Fix overlap of dimension selection area 2019-06-07 22:13:16 -04:00
wandererfan
5cea2f83bc Fix "trails" on dim lines when zoomed in 2019-06-04 15:41:41 -04:00
wandererfan
8e6dd25ad7 Fix overlap of line ends and arrowheads 2019-06-04 06:59:17 -04:00
Tomas Pavlicek
fad4db3300 TechDraw: Fix font size issues when exporting to SVG 2019-05-27 22:18:14 -04:00
Tomas Pavlicek
243aebf2df TechDraw: Place diameter label better 2019-05-23 07:10:16 -04:00
wandererfan
d42c79c146 Fix #3695 Frame toggle sync 2019-05-13 12:29:15 -04:00
wandererfan
ef912cfea8 Improve radius/diameter dims for ellipse,spline 2019-05-13 12:29:15 -04:00
wandererfan
ede3bd2210 Fix crash on Dimension with corrupted References 2019-04-24 19:52:39 -04:00
wandererfan
6474e49b8c Fix missing arc on 3pt angle 2019-04-21 07:23:32 -04:00
wandererfan
a7e82e8612 Fix Text position error on some Dims 2019-04-01 23:46:35 +02:00
Franck Jullien
b5613b2bd8 TechDraw: add Balloons 2019-04-01 23:24:17 +02:00
Franck Jullien
99b476595c TechDraw: datumLabelDragged now include a modifier value 2019-04-01 23:23:50 +02:00