Commit Graph

26531 Commits

Author SHA1 Message Date
Roy-043
29fda5e974 Draft: remove unused dimorientation and saveonexit prefs 2023-11-12 20:54:25 +01:00
Roy-043
c7777b8ed3 Draft: Draft_SelectPlane did not trigger the grid 2023-11-12 20:16:34 +01:00
Abdullah Tahiri
8d82835514 Sketcher: DSH Default - improve return value of ShapeGeometry functions
=======================================================================

Previous version return an reference to the smart pointer to generic Part::Geometry.

This version returns a type specific naked pointer, while ShapeGeometry keeps ownership
and memory management, so if an arc is created a Part::ArcOfCircle is returned.
2023-11-12 17:53:36 +01:00
Abdullah Tahiri
55639df573 Sketcher: Box Selection - refactor
==================================

Full refactor of this function without change of functionality (hopefully).
2023-11-11 21:19:12 +01:00
Abdullah Tahiri
811da8bb09 Sketcher: Box selection - Hyperbola/Parabola endpoint fix 2023-11-11 21:19:12 +01:00
Abdullah Tahiri
373a167d7d Sketcher: DSH - improving geo creation helpers for ShapeGeometry
================================================================

In some DSHs instead of the convenience function, the code is being duplicated because
of the need to access the geometry after pushing it to the std::vector.

This commit leverages emplace_back return reference to improve code reuse.
2023-11-11 21:18:20 +01:00
pre-commit-ci[bot]
11916af30d [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-11-11 18:21:31 +01:00
bgbsww
b52694c87b Fix 10545 by using position of array members 2023-11-11 18:21:31 +01:00
wandererfan
66ece1c068 [TD]fix 3x extension circle methods #11310 2023-11-11 07:48:03 -05:00
wandererfan
037165f1b7 [TD]add 2 utility methods
- toAppSpace converts qt point to app view coords
- angleWithX(Base::Vector3d) returns [0,2pi]
2023-11-11 07:48:03 -05:00
Abdullah Tahiri
0144b4b14d Sketcher: Adapt DSHs to new dynamic cursor 2023-11-11 11:15:54 +01:00
Abdullah Tahiri
136392830a Sketcher: DSHController - extend framework to make cursors OVP visibility dependent 2023-11-11 11:15:54 +01:00
Abdullah Tahiri
e73d8e2e96 Sketcher: DSH - new cursor drawing functions 2023-11-11 11:15:54 +01:00
pavltom
4c888b6afe [TechDraw] Issue #6527 - Implement face transparency 2023-11-10 10:48:06 -05:00
wandererfan
65c88376f8 [TD]fix Print Center Marks #11309 2023-11-10 09:30:19 -05:00
wandererfan
0bd0d2e4b5 [TD]Fix margins on PDF output #11308 2023-11-10 09:30:19 -05:00
Roy-043
453c099873 Draft: Improve grid behavior
This PR improves the behavior of the Draft grid:
* Options in the preferences: "Always show the grid" and "Show the grid during commands".
* The parameters are used for new views. In existing views the grid can be toggled either during a command or when no command is active.
* When switching to a different workbench all grids are hidden unless GridHideInOtherWorkbenches is set to `False`. This can be a Fine-tuning parameter IMO.

Notes:
* The defaultCameraHeight parameter becomes obsolete. It was only used in very specific circumstances.
* The code of PR #8818 becomes obsolete. It makes more sense to use `App.activeDraftCommand` instead of adding a `tool` argument to some functions. Will do some related cleanup later.
* Improved alignment for the related preference ui. The checkbox interaction has been fixed as well.
2023-11-10 14:02:38 +01:00
Roy-043
6359597341 Arch: make Arch_CutPlane nesting and link aware
Forum topic:
https://forum.freecad.org/viewtopic.php?t=82340
2023-11-10 11:04:27 +01:00
Roy-043
704949d843 MEASUREMENT should also be checked if INSUNITS is zero 2023-11-10 10:21:54 +01:00
Roy-043
ab3bb51e15 Avoid Python match function 2023-11-10 10:21:54 +01:00
Roy-043
6ec2ecffe9 Draft: fix import scale for Legacy DXF importer
Fixes #10253.
2023-11-10 10:21:54 +01:00
czinehuba
22a107b775 Update iso10642.json (#11302)
* Update iso10642.json

Update ISO10642 with M2 and M2.5 sizes

* Update iso10642.json

Updated dimensions
2023-11-09 12:26:56 -06:00
Chris Hennes
954c2fa03f Update translations 2023-11-09 12:23:56 -06:00
Roy-043
8a3e07b23e Merge pull request #11319 from Roy-043/Arch-start-and-stop-WP-view-observer
Arch: start and stop WP view observer
2023-11-09 12:15:46 +01:00
wmayer
640018bfa7 JtReader: allow to open JT files using TKJT 2023-11-09 01:40:54 +01:00
Abdullah Tahiri
0d221c0969 Sketcher: Fix lints 2023-11-08 17:46:34 +01:00
Abdullah Tahiri
75c3972c44 Sketcher: Encapsulate function to ensure MDI focus 2023-11-08 17:46:34 +01:00
Roy-043
b19fed42e3 Arch: start and stop WP view observer
See #11257.
2023-11-08 16:36:31 +01:00
Roy-043
9be9881ed8 Merge pull request #11295 from Roy-043/Draft-improved-props_changed_placement_only-function
Draft: improved props_changed_placement_only function
2023-11-08 15:31:43 +01:00
Roy-043
0002729cbf Merge pull request #11280 from Roy-043/Arch-Fix-issue-with-getSceneGraph
Arch: Fix issue with getSceneGraph
2023-11-08 15:30:50 +01:00
Roy-043
ec7d3e643f Merge pull request #11257 from Roy-043/Draft-PlaneGui-view-observer-to-update-the-Tray
Draft: PlaneGui: view observer to update the Tray
2023-11-08 15:29:18 +01:00
Paddle
403bc55bfa Line DSH : hide widget if OVP disabled. 2023-11-08 15:20:13 +01:00
Paddle
20fcdfbd89 Remove moveCursorToSketchPoint on init. 2023-11-08 15:20:13 +01:00
Paddle
f035331263 Fix bug where M key stop working in some cases by giving focus to MDI on reset. 2023-11-08 15:20:13 +01:00
Paddle
8f3ebe1cc6 Rectangle DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
05dde3d3cf Polygon DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
8daccecb52 Offset DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
422d5861d8 Line DSH : set OVP Functions. 2023-11-08 15:20:13 +01:00
Paddle
17f4109358 Add preference for OVP visibility. 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
5c2a55ade7 Sketcher: Update DSHs to set value via framework only when they are visible 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
0282d3844a Sketcher: DrawSketchController - Extend framework to support hiding OVPs via preference 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
5873403254 Fix Compiler warnings of previous merged PRs 2023-11-08 15:20:13 +01:00
Abdullah Tahiri
c09793e811 Sketcher Gui: DrawSketchController - lints 2023-11-08 15:20:13 +01:00
wmayer
a28b2dcf37 PD: fixes #11197: If bounding box of Body is activated it will be done for each sub-feature 2023-11-08 10:38:42 +01:00
Abdullah Tahiri
e235a1b795 Sketcher: Handling of right mouse button during handler execution
=================================================================

    Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
    delegates the action to DrawSketchHandler.

    DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

    DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
    in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Abdullah Tahiri
9cb6fa0df7 Sketcher: Handling of ESC keypress during handler execution
===========================================================

Instead of terminating the handler, as mandated before this PR by ViewProviderSketch, ViewProviderSketch
delegates the action to DrawSketchHandler.

DrawSketchHandler implements by default this terminating behaviour, but allows to override it.

DrawSketchDefaultHandler (and all tools deriving from it) implement as default behaviour to cancel if
in initial state, otherwise to reset.
2023-11-07 16:05:08 +01:00
Paddle
fc472601e4 EditableDatumLabel : Fix issue where the spinbox would get in the way of the cursor for angle. For example line angle. 2023-11-07 15:36:21 +01:00
Paddle
029fd10bf1 Offset DSH : various fixes 2023-11-07 15:36:21 +01:00
Paddle
2aa67a0b38 Rectangle DSH : fix a bug when trying to make inward thickness. 2023-11-07 15:36:21 +01:00
Paddle
57524b24ef Rectangle DSH : Fixes #11287. Issue where the spinbox for frame thickness doesn't get focus. 2023-11-07 15:36:21 +01:00