Commit Graph

46 Commits

Author SHA1 Message Date
Uwe
17e6ebf120 [PD] remove more unused includes 2022-02-22 01:19:32 +01:00
Mark Ganson TheMarkster
abe0c9222a [PartDesign Fillet/Chamfer] add UseAllEdges boolean property (#5340)
- [PartDesign Fillet/Chamfer] add UseAllEdges boolean property
- add UseAllEdges checkbox to fillet and chamfer dialogs
- put UseAllEdges property into Chamfer and Fillet groups, create Fillet group for fillets and put Radius into it, too.
2022-02-05 01:50:51 +01:00
wmayer
be020c8d9d PD: fix crash in thickness dialog when clicking 'Add Face' button 2022-01-16 18:59:26 +01:00
wmayer
1d021345f3 PD: fix bug in TaskDressUpParameters::KeyEvent and simplify code 2021-12-31 17:03:16 +01:00
wmayer
fd8f860223 [skip ci] fix some typos 2021-12-31 14:03:51 +01:00
mwganson
a324b33104 [PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode 2021-12-31 14:01:43 +01:00
wmayer
b165947625 PD: cleanup the mess with boolean arguments and replace them with a bitmask 2021-12-03 14:46:19 +01:00
donovaly
3fdce54be7 [PD] fix dressup feature display when broken
As discussed in https://forum.freecadweb.org/viewtopic.php?p=479647#p479377
the user can end up without either seeing nothing or an inexisting dressup feature.

This PR fixes this.
2021-02-19 14:51:52 +01:00
wmayer
ba683bf241 Coverity: Dereference null return value 2020-07-20 17:34:26 +02:00
wmayer
cbee07d53a PartDesign: fix issues of PR #3108
* in the undo/redo list use an object's label and not the internal name
* check by the transaction ID instead of name to open a transaction to make the workbenches independent of implementation details of the core system
* when rejecting a task do not call undo() because this is not the same as aborting a pending transaction
* this also fixes the warning: <App> Document.cpp(1182): Cannot commit transaction while transacting
2020-03-14 14:51:45 +01:00
Zheng, Lei
e9bbae0a89 PartDesign: fix task dressup/transformed creation cancel 2020-03-14 14:51:45 +01:00
luz.paz
ebe194a9e9 Fix typos
Found via  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-06 14:50:35 +01:00
wmayer
c654ce3629 PartDesign/Fem: [skip ci] when handling Del key make sure that deleteAction is instantiated 2020-02-19 11:31:40 +01:00
wmayer
7ac63efd0e PartDesign: [skip ci] add missing header 2020-02-18 23:23:49 +01:00
donovaly
1a718a6371 improve code as suggested by Werner
see https://forum.freecadweb.org/viewtopic.php?p=369921#p369921
2020-02-18 23:16:48 +01:00
donovaly
83a4a918a0 try to squash GCC compile error 2020-02-18 00:08:58 +01:00
donovaly
58bb17478c enable selection in the dialog item list
now the user can use the Ctrl and/or Shift key to select multiple items to be deleted
2020-02-17 22:36:42 +01:00
donovaly
0283cb09fb improve fillet dialog logic
- now also the case of only one item in the list is handled properly (single-click will highlight it, double-click will show the final fillet)
2020-02-17 21:53:45 +01:00
wmayer
b06251e853 PartDesign: [skip ci] fix possible segmentation fault in destructors of dressup task panels 2020-02-16 20:58:44 +01:00
wmayer
44b9ed6228 PartDesign: [skip ci] do forward declaration if possible to reduce build timw 2020-02-16 19:26:48 +01:00
donovaly
0fe8157af5 TaskDressUpParameters: GCC compile fix 2020-02-16 05:47:54 +01:00
donovaly
9d28b3d390 [PD] add feature to highlight references in some dialogs
- also fix some logic issues and avoid to break the feature (deleting the last item is now no longer possible)
2020-02-16 05:18:29 +01:00
donovaly
01598a8bb4 fix logic
now also the case that one switches from add mode directly to remove mode is correctly handled
also remove doubled code that is already executed
2020-02-15 04:30:26 +01:00
donovaly
1dfa6d40b4 [PD] enable to de/selecet several entities at once
see https://forum.freecadweb.org/viewtopic.php?f=19&t=43383
2020-02-15 04:07:09 +01:00
luz.paz
dc8bf3dc39 PartDesign: [skip ci] fix header uniformity
This PR fixes header uniformity across all PartDesign WB files
2019-12-22 00:58:38 +01:00
Zheng, Lei
cd2b7e297c PartDesign changes
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
2019-08-17 15:15:47 +02:00
wmayer
dd7c91ddcf fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
wmayer
e8554cc77a do not use doCommand without using format string, add overloaded method of runCommand 2016-09-15 18:53:37 +02:00
wmayer
c2dd2e2b99 fix Coverity issues 2016-08-21 18:46:40 +02:00
Mateusz Skowroński
a8d37dabbe QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1().
This change is Qt4/Qt5 neutral.
2016-04-15 11:55:12 +02:00
Alexander Golubev
27667cf5e6 Fix warnings introduced in new PartDesign
Mostly unused wariables and compare of signed & unsigned
2016-04-12 18:12:21 +02:00
Alexander Golubev
9347f66a9e PartDesign/Gui: Move various utility stuff from Workbench to a separate file
Also do some header cleanup.
2016-04-12 18:12:17 +02:00
Alexander Golubev
e96af480ea PartDesign/TaskDressUpParameters: disable edit of dressup features with broken supports
Also remove unused headers and fix spacing.

A final fixup for issues addressed in:
cb05b01 PartDesign/TaskDressUpParameters: fix a crash when editing a broken object
2016-04-12 18:12:15 +02:00
Alexander Golubev
6134952a46 PartDesign/Gui: make DressUp view providers use the common code. 2016-04-12 18:12:15 +02:00
Alexander Golubev
e16534eeb2 PartDesign/TaskDressUpParameters: fix a crash when editing a broken object 2016-04-12 18:12:15 +02:00
Alexander Golubev
180985cec0 PartDesignGui: Make DressUp and SketchSupport propertie dialogs use common accept() structure 2016-04-12 18:12:15 +02:00
Alexander Golubev
6778c548f4 PartDesign: move common code for TaskDlg{SketcherBased,DressUp}Parameters into new base class
Added a new class: TaskDlgFeatureBased which currently contains common
code for TaskDlgSketcherBasedParameters::reject() as well as the same
methode for TaskDlgDressUpParameters.
It's likely that other Feature task dialogs will inherit this class too.
2016-04-12 18:12:15 +02:00
Alexander Golubev
f9fe1e319f PartDesign/Gui: more old workflow support
* remove an error message if adding a sketchbased feature without a body
* add champfer or fillet old workflow support

Also rework finishFeature() so at least champfer and fillet may be
inserted into any place of any apropriate body(not only the active one) of the body.
2016-04-12 18:12:14 +02:00
Stefan Tröger
afee98c1e9 allow to add faces to fillet and chamfer 2016-04-12 18:12:07 +02:00
blobfish
09e98d96cf Part Design: Fillet: Task: cleanup upon dialog rejection 2016-04-12 18:12:05 +02:00
blobfish
9b9d79d2fe Part Design: adding const char PDBODYKEY and using. No functional change. 2016-04-12 18:12:04 +02:00
jriegel
d7c932d714 Changing active object handling in PartDesign 2016-04-12 18:12:03 +02:00
Jan Rheinländer
80329d3c75 Reference highlighting for fillets and chamfers 2016-04-12 18:12:00 +02:00
jrheinlaender
9dee5333e7 Fixed bugs in various features that reversed the list of selections 2016-04-12 18:11:57 +02:00
jrheinlaender
67f17a24e6 Allow selecting and removing fillet and chamfer references in the dialog (part 2) 2016-04-12 18:11:57 +02:00
jrheinlaender
a6de951e1d Unify code of Dressup features (part 1: Draft) 2016-04-12 18:11:56 +02:00