Markus Lampert
2a97d558e8
pylint warning for PathDeburr
2019-07-01 15:29:51 -07:00
Markus Lampert
8896a84372
More dogbond pylint cleanup
2019-07-01 15:29:51 -07:00
Markus Lampert
a9b2e8e96f
Cleaned up warnings for PathEngraveBase
2019-07-01 15:29:51 -07:00
Markus Lampert
8769618cab
Fixed pylint warnings for PathDressupDogbone
2019-07-01 15:29:51 -07:00
Markus Lampert
c17989fede
Fixed pylint warnings for PathDressupTag
2019-07-01 15:29:51 -07:00
Markus Lampert
ef74365142
Fixed pylint warnings for PathSetupSheet
2019-07-01 15:29:51 -07:00
Markus Lampert
64bd8105a6
Some more pylint warning cleanup
2019-07-01 15:29:51 -07:00
Markus Lampert
6f52808e91
fixed pylint warning for PathOp
2019-07-01 15:29:51 -07:00
Markus Lampert
83581d7047
fixed pylint warning for PathJob
2019-07-01 15:29:51 -07:00
Markus Lampert
f45a11f4c3
Enabled all warnings in addition to errors for path linter
2019-07-01 15:29:51 -07:00
Russell Johnson
1ac8f4cfe9
4th-axis update ( #2311 )
...
Improve property creation
Improve property setup
Implement PathLog.debug() for troubleshooting.
Improve default property values.
Remove unused and incomplete method
Remove unnecessary comments; fix final depth issue
4th-axis improvements
rotation method improvements
remove extra comment blocks
fix incorrect variable references
fix -0.0 re-introduction after initial filter
negative zero re-introduced causes problems with naming method for temp clones
Update faceRotationAnalaysis() method
update opFeatures()
Commented out call to PathOp.FeatureRotation
This feature not yet implemented.
delete call to removed method - self.reportThis()
Remove unnecessary comments
2019-07-01 09:30:58 -05:00
sliptonic
bf9f6021ab
Merge pull request #2303 from Russ4262/path_3d_pocket_upgrade
...
[Path] 3D Pocket: Upgrade to collective face processing!
2019-06-30 18:54:30 -05:00
Russell Johnson
4fc39dfb36
PathDrilling 4th-axis integration
...
Initial integration of 4th-axis functionality to the Drilling op in PathWB
2019-06-30 14:14:38 -05:00
Russell Johnson
e67fc4e706
3D Pocket: Upgrade to collective face processing!
...
New property added: `HandleMultipleFeatures`.
New property and related code allows for improved, and expected, 3D Pocket operations.
Improvement combines faces selected to create one envelope to be processed as the path shape ('collectively' setting).
Old behavior is available with 'Individually' setting.
Enjoy!
2019-06-30 14:06:37 -05:00
sliptonic
a62607505f
Merge branch 'master' into bugfix/pocket-shape-extensions
2019-06-30 09:32:07 -05:00
Russell Johnson
3132dfbf54
ProfileFaces: Fix obj.processPerimeter feature ( #2306 )
...
https://forum.freecadweb.org/viewtopic.php?f=15&t=37368
if obj.processPerimeter: `else` block re-configured to read new property, `HandleMultipleFeatures`
Removed some excess comments
2019-06-30 09:31:30 -05:00
Markus Lampert
68939608ea
Properly deal with deleted objects when cleaning up the extension visualisation.
2019-06-29 19:16:33 -07:00
Markus Lampert
aa15a6cf4a
Cover entire hole if pockeet extension is bigger than hole.
2019-06-29 18:16:56 -07:00
Markus Lampert
4fb0b04a39
Fixed extensions for round holes.
2019-06-29 18:16:56 -07:00
Markus Lampert
05249b2123
Removed redundant log message
2019-06-29 18:16:56 -07:00
Markus Lampert
9c5fa124c3
Fixed extension selection
2019-06-29 18:16:56 -07:00
Markus Lampert
70d8be5b3c
Fixed document restoration logic.
2019-06-29 18:16:56 -07:00
luz.paz
e0377f8e4f
Misc. typo and whitespace fixes
...
Found via `codespell`
2019-06-28 11:39:36 -03:00
sliptonic
00f082c97d
Merge pull request #2282 from sliptonic/lgtmcleanup
...
Lgtmcleanup
2019-06-23 17:29:40 -05:00
wmayer
85270f5cd3
Fix a couple of clang compiler warnings:
...
-Wunused-variable
-Winconsistent-missing-override
-Wdelete-non-virtual-dtor
-Wunused-private-field
-Wformat
2019-06-23 15:19:12 +02:00
sliptonic
b55c210f39
remove unnecessary imports. normalize debug log levels
2019-06-21 13:01:01 -05:00
sliptonic
4a984de243
Path: normalize proxy stratements
...
remove bare exceptions
2019-06-21 13:01:01 -05:00
Russell Johnson
332bfb5052
Fixes bug #4008 : removes phantom path cause
...
Job object was base of transformations, rather than Job base(clone).
2019-06-20 00:02:14 -05:00
Russell Johnson
97f42a6193
Fix functionality of manual override of Final Depth
...
manual Final Depth settings were limited to values greater than the base face for the Op. Manual settings of Final Depth may now proceed below the face (Outside profile ops)
2019-06-20 00:02:14 -05:00
Russell Johnson
2e0861babc
proxy to obj.Proxy partial conversion
2019-06-20 00:02:13 -05:00
sliptonic
fbb138653a
Path: fix proxy error
2019-06-19 10:21:17 -05:00
Yorik van Havre
236f890864
Merged translations from crowdin
2019-06-17 20:06:59 -03:00
Yorik van Havre
d890b4ec17
Updated master ts files
2019-06-17 17:28:12 -03:00
sliptonic
d4a311de19
Path: PEP8 and Proxy changes.
2019-06-17 09:17:38 -05:00
Russell Johnson
4296df8c3e
Merge branch 'master' into pathpocketshape_fix
2019-06-16 16:38:09 -05:00
luz.paz
9453e68e23
Misc. source comment typo and whitespace fixes
...
Found via codespell
2019-06-16 20:47:07 +02:00
Russell Johnson
77d1f8968d
Delete disabled code blocks
...
within guiMessage() method
2019-06-15 12:19:17 -05:00
Russell Johnson
4cff627468
added missing self.stockBB instantiation
...
job boundbox object was missing in opSetDefaultValues()
2019-06-15 12:05:58 -05:00
wmayer
5fb2dfedd1
clean-up CMake file
2019-06-14 00:27:36 +02:00
Russell Johnson
236e1daeb5
Isolate FreeCADGui dependency
...
Thanks @mlampert and @sliptonic for assisting in tracking down the error via unit test analysis.
FreeCADGui usage has to be behind an 'if FreeCAD.GuiUp:` test
2019-06-13 15:42:56 -05:00
Russell Johnson
4b104c4706
Remove reference to removed file: grbl_G81_post.py
...
[Path] Replace old grbl_post.py with new grbl_G81_post.py. (#2255 )
RE: PR #2255
2019-06-13 12:50:22 -05:00
Russell Johnson
c1970aa5e3
Remove unnecessary comment
2019-06-13 12:34:33 -05:00
Russell Johnson
4df89e0e3d
Misc. fixes
...
Clean up code, improve comments, improve user feedback.
Improve temp clone management.
Correct depth issue with self.finDep
Add comment descriptions for new methods
Clean up comments and contribution information
Initiate recognition of type()==SurfaceOfExtrusion
Adopt standard PathGeom.isRoughly() and .Tolerance rather than idependent precision settings
2019-06-13 10:55:32 -05:00
Russell Johnson
a160aab486
Fixes for depths and AttemptInverseAngle
...
Depth correction to obj.FinalDepth.Value in single feature operations
Fix AttemptInverseAngle to be uni-directional
Clean up debug and other user provided feedback
2019-06-13 10:55:31 -05:00
Russell Johnson
bbfecfb7cf
Handle FreeCADGui module with IF: case
2019-06-13 10:55:31 -05:00
Russell Johnson
f89a78f6dd
revert to current FC master version
2019-06-13 10:55:30 -05:00
Russell Johnson
4c69b48dc6
Improve code structure; correct 4th-axis depth issues
2019-06-13 10:55:30 -05:00
Russell Johnson
419df14b2c
Corrected test: Only 4 dogbones created
...
Running test in:
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16886 (Git)
Build type: Release
Branch: master
Hash: ed47e962d2
Python version: 3.6.8
Only yields 4 dogbones
2019-06-13 10:55:29 -05:00
Russell Johnson
338861f2d2
Integration of 4th-axis feature to PathProfileFaces
...
4th-axis integration should not affect current feature set
2019-06-13 10:55:29 -05:00
Russell Johnson
4ec63d537d
Fix for 'reposition of job model' error
...
Re-structured 4th-axis implementation, completely; new structure will be easier to implement in other PathWB tools.
Changed basis for rotational pockets from job model to temporary per-rotation clones.
2019-06-13 10:55:28 -05:00