kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
43,648 Commits 41 Branches 6 Tags
2aa8f133f3eb3f03fefc360bf2ee26a3772a7cfb
Commit Graph

605 Commits

Author SHA1 Message Date
Ryan Kembrey
80c1d7a630 CAM: Update UI strings for consistency 
Closes: #22350
 2025-08-04 20:13:52 +02:00
J-Dunn
966cb36e9e CAM: revert grbl_post regression (#22569) 
* CAM: revert grbl_post regression

I recently noticed a bug in grbl_proc post processor where it was not correctly setting OLD_Z  if current machine_z is below G81 retract plane in R parmeter. 

On digging into my original commit is looks like the two lines which did this have been commented out. 
I can never find the Blame feature when I need so if someone else can find the culprit feel free. 

2bd617a2b3

This PR simply reinstates the missing lines and adds a snippet of NIST as a comment block  to prevent any over-zealous editing in the future. 

This regression means that drilling cycles start with z=clearance height instead of z=safe height leading to much costly air cutting.
This similarly messes up the  the retract plane for G98 leading to excessive machine time wasting and incorrect application of G98 returns. 

Indeed this regression was noticed because some were claiming the Safe height was redundant in drilling ops since it was never used. 

There is much discussion about all this at the moment which is being disrupted by people assuming the current broken paths are what FreeCAD is intended to do. 

Let's fix this ASAP, so we can stop this confusion and get discussions back to reality.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
 2025-08-04 10:57:03 -05:00
sliptonic
bb0965941d Merge pull request #22228 from knipknap/fix-custom-attribute-edit 
CAM: Various bugfixes for CAM tool management
 2025-08-04 10:39:25 -05:00
sliptonic
1d64a3a983 Merge pull request #22392 from knipknap/fix-test-uses-user-data 
CAM: fix: CAM tests use files from user asset dir
 2025-07-28 11:08:50 -05:00
sliptonic
43fe9b3d1a Merge pull request #22578 from z0r0/CAM-bindings 
Core: Generation of python bindings for CAM
 2025-07-28 10:34:34 -05:00
sliptonic
1ba5888330 Merge pull request #22659 from chennes/cam-size_t-fmt-spec 
CAM: Fix the format spec used with size_t
 2025-07-25 14:45:11 -05:00
sliptonic
b5d782e856 Merge pull request #22314 from tarman3/vcarve 
CAM: Vcarve fix
 2025-07-25 12:44:16 -05:00
Kacper Donat
f572d2e4f2 Merge pull request #22660 from chennes/fixMultResultConvertedToLargerType 
Fix mult result converted to larger type
 2025-07-25 10:20:03 +02:00
Chris Hennes
fe624f2c3a CAM: Add missing initializers 2025-07-23 16:51:20 +02:00
Chris Hennes
6c2617874a CAM: Fix multiplication result converted to larger type 2025-07-21 22:03:14 -05:00
Chris Hennes
a0b5cc90cc CAM: Fix the format spec used with size_t 2025-07-21 21:32:07 -05:00
sliptonic
c99cd73cd6 Merge pull request #22398 from dbtayl/fix_22073 
CAM: Adaptive: Fix NULL input shapes when top of stock equals top of model
 2025-07-21 11:35:39 -05:00
Ian 'z0r0' Abreu
efc4defebf fixing imports 2025-07-20 09:04:27 -04:00
Ian 'z0r0' Abreu
536a7452c7 Removal of comments. 2025-07-20 08:51:45 -04:00
Ian 'z0r0' Abreu
6358874a58 merging. 2025-07-18 19:44:47 -04:00
Ian 'z0r0' Abreu
325fa7f5e6 removing List, Dict typing refs. 2025-07-18 19:44:09 -04:00
Ian Abreu
b721257670 Merge branch 'main' into CAM-bindings 2025-07-18 18:28:49 -04:00
Ian 'z0r0' Abreu
e4e8625a4b initial commit 2025-07-18 18:27:08 -04:00
sliptonic
7de4fac9fe Merge pull request #22524 from jffmichi/drilling_remove_redundant 
CAM: remove redundant move after drilling
 2025-07-18 14:15:19 -05:00
sliptonic
3f6a3f10ff Merge pull request #22374 from z0r0/CAM-Inspect-Fix 
CAM: Fixing Length Check in CommandPathInspect class
 2025-07-17 13:40:08 -05:00
jffmichi
3bce6e3fc9 CAM: remove redundant move after drilling 2025-07-16 20:31:42 +02:00
jffmichi
e12b4fd27c CAM: select rows instead of cells in drilling panel 2025-07-15 21:09:16 +02:00
sliptonic
759bad7455 Merge pull request #22330 from z0r0/fanuc-postprocessor-fix 
CAM: Fix for Fanuc Post-Processor
 2025-07-11 11:00:50 -05:00
Ian Abreu
6c5098680f Merge branch 'main' into CAM-Inspect-Fix 2025-07-09 19:40:30 -04:00
Samuel Abels
0ad45ac99a CAM: silence unnecessary log for preferences change when no change was actually made 2025-07-09 10:19:22 +02:00
Dan Taylor
e914eca089 CAM: Adaptive: Fix NULL input shapes when top of stock equals top of model (fix #22073) 2025-07-08 20:09:33 -05:00
Samuel Abels
3332c49271 CAM: fix: CAM tests use files from user asset dir 2025-07-08 20:39:52 +02:00
tarman3
ec839c5d43 CAM: Vcarve fix 2025-07-07 19:56:02 +03:00
sliptonic
e0466b7a14 Merge pull request #21341 from tarman3/arraywarning 
CAM: Changes in warnings of old Array
 2025-07-07 11:06:11 -05:00
Ian Abreu
1724e9b62f fixing typos 2025-07-06 16:30:53 -04:00
Ian Abreu
83dd97608f adding sanity fix 2025-07-06 16:26:50 -04:00
Ian Abreu
a370673467 Merge branch 'main' into CAM-Inspect-Fix 2025-07-06 16:24:42 -04:00
Ian Abreu
7158294d34 Adding simple check 2025-07-06 11:07:15 -04:00
Kacper Donat
3d3d3ad6d2 Merge pull request #22138 from chennes/compilerWarningCleanup20250622 
Compiler warning cleanup
 2025-07-06 16:32:08 +02:00
Kacper Donat
38ec685f2d CAM: Fix origin indicator for Job 
This commit fixes how origin (coordinate system) indicator looks. Before
it showed as disc, and now it shows as point which is more approperiate
given the context.
 2025-07-05 18:46:01 +02:00
Dan Taylor
a7f1b96c45 [CAM] Correctly process Adaptive extensions as faces instead of shells (fix 22177) 2025-07-04 14:51:55 -05:00
Samuel
b16fb74889 Merge branch 'main' into fix-custom-attribute-edit 2025-07-04 20:32:37 +02:00
Ian Abreu
05d9eeded2 correcting to use Tool vs. ToolController 2025-07-04 11:30:46 -04:00
Ian Abreu
bd24577184 initial fix 2025-07-04 11:10:43 -04:00
tarman3
51f489083b CAM: Changes in warnings of old Array 2025-07-01 06:11:56 +03:00
Samuel Abels
173ee65b8b CAM: Fix: rename vbit and threadmill back to v-bit and thread-mill to avoid backward compatibility issues 2025-06-30 22:59:14 +02:00
Samuel Abels
16d90cfbb9 CAM: Fix: shape parameters coming from the attributes section in the fctb file were not normalized 2025-06-30 21:48:21 +02:00
Samuel Abels
be969e1589 remove unused import of PartGui 2025-06-30 21:30:34 +02:00
Samuel Abels
b5e4b400ad CAM: Fix: Tool editor ignored shape attributes if they were not in the Shape group. Now it reads all except Base 2025-06-30 20:27:54 +02:00
Samuel Abels
7f7f5ba2bb CAM: make ToolBitShape more robust against invalidly typed parameters in toolbit files (e.g. Flutes with string value) 2025-06-30 20:27:26 +02:00
Samuel Abels
3829e1db76 CAM: Fix: Remove invalid normalization of shape name 2025-06-30 20:26:51 +02:00
Samuel Abels
2d1746d04f CAM: gracefully handle tool numbers that are strings in the tool library JSON 2025-06-29 21:39:04 +02:00
Samuel Abels
da8eec5744 CAM: Fix: ToolBitShapeCustom properties not editable if they had no type specified in the schema 2025-06-29 21:34:06 +02:00
Samuel Abels
788560d709 CAM: fix toolbit editor shape resolution for high DPI displays 2025-06-29 13:15:47 +02:00
Samuel Abels
3521ae91cc CAM: reduce default size of toolbit editor dialog 2025-06-29 13:02:09 +02:00