Commit Graph

3108 Commits

Author SHA1 Message Date
sundtek
7172e57e5d Update PathAdaptive.py
the internal unit is mm, only lowering the accuracy should be enough.
2021-12-20 01:15:59 +08:00
sliptonic
473bdc07dd Merge pull request #5262 from sliptonic/bug/translation
[PATH]  Bug/translation
2021-12-19 09:33:11 -06:00
sundtek
47fc8dee91 change discretize value to fix issues
Discretize of 0.0001 is okay for inches, but for metric <1microns would be quite small, this fixes some issues when generating paths for curves that look inward.
I found following post in the forum: https://forum.freecadweb.org/viewtopic.php?f=15&t=42755
I have experienced similar issues with other curves in my object.
2021-12-19 19:23:09 +08:00
wmayer
e743c30f3b Add Global.h headers to modules 2021-12-18 14:06:40 +01:00
sliptonic
21765dec9c Modified combobox selection
cleaned up translation method

Profile translation cleanup

Incorporating additional suggestions
2021-12-17 08:35:41 -06:00
Russell Johnson
1eccba10ca Path: Translation Solution POC 2021-12-17 08:35:41 -06:00
sliptonic
3ca86cafeb PathOpGui Black reformat 2021-12-17 08:35:41 -06:00
luz paz
810d41ce52 Path: fix typo in author's name 2021-12-10 02:36:56 +01:00
luz paz
e901e584ac Path: fix file header uniformity 2021-12-10 02:36:56 +01:00
luz paz
b6f9f39ffc Fix various typos and grammatical refinements 2021-12-09 08:57:52 -06:00
Peter Roß
9f9709c7a3 Merge branch 'FreeCAD:master' into RRF-PP-for-Path 2021-12-06 12:33:23 +01:00
sliptonic
73fa6217ce Merge pull request #5217 from sliptonic/feature/rotationgenerator
[PATH] rotation generator and tests
2021-12-02 15:40:06 -06:00
sliptonic
b2800dfbb8 draft generator and tests 2021-12-01 13:15:09 -06:00
sliptonic
f5d230ed29 Merge pull request #5205 from sliptonic/bug/depthsteps
[PATH]  depthparams handles negative steps and finish step correctly. Unit tests
2021-11-26 20:24:25 -06:00
sliptonic
8e6c5a497b make sure depthparams handles negative steps and finish step correctly
revised test
2021-11-26 13:27:44 -06:00
Zheng, Lei
789d32f87b Test: fix test case
Adding dynamic property with an invalid name or existing name is now an
error, because there is no easy way for Python code to find out the name
of a property if it is auto renamed.
2021-11-21 19:03:53 -06:00
sliptonic
7ca80cade0 Merge pull request #5177 from sliptonic/bug/profilebug
[Path] face outerwires aren't always the first wire in the Wires list.
2021-11-18 08:44:09 -06:00
P-C-R
4cf2c8c405 Merge branch 'master' into RRF-PP-for-Path 2021-11-18 07:59:14 +01:00
Yorik van Havre
a26fb4db1a Merged crowdin translations 2021-11-16 17:30:39 +01:00
sliptonic
4c129c7526 face outerwires aren't always the first wire in the Wires list.
Added logic to compare hashCodes()

https://forum.freecadweb.org/viewtopic.php?f=13&t=50567
2021-11-15 18:40:28 -06:00
P-C-R
698fe21c0f Update rrf_post.py 2021-11-15 08:20:06 +01:00
P-C-R
8e27e8010f Bugfix for "Before Tool Change" Commands 2021-11-15 08:15:07 +01:00
luz paz
3da6ced354 Fix header uniformity 2021-11-13 06:20:19 -05:00
sliptonic
73c01a4196 cmake error 2021-11-10 13:33:20 -06:00
sliptonic
4a7cdd5095 fixing comment errors 2021-11-09 09:04:01 -06:00
sliptonic
56875b2137 Drill Generator and testing 2021-11-08 18:57:16 -06:00
P-C-R
cfa658187c Merge branch 'master' into RRF-PP-for-Path 2021-11-05 10:42:26 +01:00
wmayer
09da245af9 App: harmonize API of App::Application
* make getHomePath() static and return a std::string
* make getExecutableName() static and return a std::string
2021-11-04 10:50:09 +01:00
P-C-R
6f087718f6 Upload of a PP for RRF (RepRapFirmware)
Modified Marlin PP for RRF.
2021-11-03 15:33:51 +01:00
wmayer
833868bd13 Path: [skip ci] partially fix issue 0004765: [MSVC][Build][Permissive-][std:c++latest] FreeCAD failed to build on MSVC 2021-11-01 19:32:21 +01:00
wmayer
74639da997 OCCT: port FreeCAD sources to version 7.6
SMESH is not yet ported
Although FreeCAD code compiles with OCCT 7.6 it doesn't work at the moment
2021-10-09 13:49:02 +02:00
Russell Johnson
c35e44d5dd Application of Black formatting 2021-10-06 19:56:42 -05:00
Russell Johnson
d59ae608d6 Fix incorrect arguments list
This commit fixes the error reported in the forum at https://forum.freecadweb.org/viewtopic.php?f=15&t=33121&start=50#p537787.

This error was introduced when another user replaced the `extractFaceOffset()` method from the PathSurfaceSupport.py module with an improved `getOffsetArea()` function in the PathUtils.py module.  The two instances of the improved `getOffsetArea()` calls here in this fix did not get corrected when that improvement was originally made.
2021-10-06 19:56:03 -05:00
sliptonic
c21f7ab023 Black reformat 2021-09-29 16:51:00 -05:00
sliptonic
9fbd227456 Job object doesn't exist in this context.
Derive output name in the output section or default if unknown
2021-09-29 16:51:00 -05:00
sliptonic
b5d6a796e2 Merge pull request #5070 from Russ4262/fix/pocket_shape_finish_pass
[Path] Reinstate fix for intermittent PocketShape finish pass
2021-09-29 13:43:18 -05:00
Yorik van Havre
77925c428e Updated ts files 2021-09-29 14:32:12 +02:00
Russell Johnson
e018707307 Path: Strict application of Black code formatting to module file
This commit ONLY contains application of `Black` code formatting.  No other alterations have been made in this commit.
2021-09-27 20:53:09 -05:00
Russell Johnson
0242ada64e Path: Restore removal shape envelope buffer
This buffer application was removed in PR #4978 with removal of rotational code.

The buffer is required to provided adequate significant digit or rounding  in later processing of envelope in Path.Area().

NOTE:  I suggest separate `removalshape` envelopes  be created without the necessary `buffer` adjustment to allow for usage of the `removalshape` for subsequent REST type operations.
2021-09-27 20:53:09 -05:00
sliptonic
0afe01dc5e Merge pull request #5009 from Russ4262/fix/ramp_dressup
[Path] Fix for inactive ramp dressup base operation
2021-09-27 15:34:43 -05:00
sliptonic
fdfe0291fd Merge pull request #5050 from jimzim111/PathArray_Z
Path: PathArray translate copies along Z axis as it does along X/Y
2021-09-27 15:19:43 -05:00
sliptonic
c062384976 Merge pull request #4975 from Russ4262/cleanup/pathprofile
[Path] LGTM cleanup of PathProfile module
2021-09-27 15:16:20 -05:00
Russell Johnson
c44b7d7b54 Path: Fixes #4645
Fixes bug #4645.
This PR adds a simple `integrityCheck()` method to Job object class.  The method is called on the Gui side before openning the task panel to edit the job.  The same method is also called upon document restoration.
2021-09-24 06:43:16 -05:00
Russell Johnson
2bb8baec06 Path: Delete unnecessary comments 2021-09-24 06:40:53 -05:00
Russell Johnson
dd03e616d0 Path: LGTM cleanup 2021-09-24 06:40:53 -05:00
Russell Johnson
fcd8b8558e Path: Fix Face Region boundary shape usage
This commit removes automatic edge extension for `Face Region` boundary shape.  It applies the `Clear Edges` toggle for `Face Region`.  It applies `Exclude Raised Areas` correctly.  The problem of collision paths for `Clear Edges` with `Exclude Raised Areas` for certain use cases remains and is not fixed with this commit.
2021-09-24 06:39:25 -05:00
Russell Johnson
7ec38a5c3b Path: Remove unused import 2021-09-24 06:39:25 -05:00
Russell Johnson
1fbb7412b7 Path: Add docString and comments for getAllIncludedFaces() method 2021-09-24 06:39:25 -05:00
Russell Johnson
48d10b25b2 Path: LGTM fix
Prompted by LuzPaz in Gitter.im/FreeCAD/Path chatroom
2021-09-24 06:39:25 -05:00
Russell Johnson
61a43a644c Path: Black code formatting only 2021-09-24 06:38:39 -05:00