Commit Graph

21089 Commits

Author SHA1 Message Date
sliptonic
4c129c7526 face outerwires aren't always the first wire in the Wires list.
Added logic to compare hashCodes()

https://forum.freecadweb.org/viewtopic.php?f=13&t=50567
2021-11-15 18:40:28 -06:00
wmayer
cd2955f3d3 PD: simplify Pad/Pocket commands 2021-11-16 00:58:55 +01:00
wmayer
a8cb5ed419 PD: [skip ci] for pockets use opposite direction of reference axis 2021-11-16 00:35:57 +01:00
sliptonic
7e5e0fe2fe Merge pull request #5154 from sliptonic/feature/drill-generator
[PATH] Drilling refactor part 1 - Generator and testing
2021-11-15 09:05:28 -06:00
Uwe
838bdf93bc [PD] fix issue 0004785
- then the profile of a pad/pocket was a face, the direction handling was completely broken
2021-11-15 15:44:28 +01:00
Uwe
61481dc9c5 [PD] uniform pad and pocket handling
- since pockets now can have a certain direction, also handle the reference axis like for pad
- uniforms initial length to 10.0
2021-11-15 15:32:56 +01:00
P-C-R
698fe21c0f Update rrf_post.py 2021-11-15 08:20:06 +01:00
P-C-R
1c55e0be93 Merge branch 'master' into RRF-PP-for-Path 2021-11-15 08:18:18 +01:00
P-C-R
8e27e8010f Bugfix for "Before Tool Change" Commands 2021-11-15 08:15:07 +01:00
Zheng, Lei
14dfae0597 App: add hiddenref() expression built-in function
Any object reference inside this function is treated as hidden to
exclude it from dependency calculation. This function allows some form
of cyclic depdenency.

Merger note: renamed from "HREF" to "HIDDENREF" to avoid confusion with
the standard "hypertext reference" use of HREF.
2021-11-14 20:45:09 -06:00
Roy-043
359955a51e Draft: revise findMidpoint function
The findMidpoint function (used by Draft_Snap_Midpoint) only worked for straight and circular edges. With this revision the midpoint of all edges can be found.
2021-11-14 11:34:06 -06:00
wmayer
0c933ac70a Part: use of factory method of Vector2dPy 2021-11-14 18:19:34 +01:00
Uwe
414f4d706e [PD] uniform Pad/pocket UI
now that pockets have the same functionality as pads, the UIs can be unified:

- the position of the Offset widget in the UI is better in pocket, thus use it for pad too
- add missing tabstops for pad
- add missing tooltip for pocket
- update tabstops for pocket
2021-11-14 03:58:21 +01:00
alexneufeld
39c162f938 Addon Manager: Added VendorParts workbench icon 2021-11-13 19:08:10 -06:00
wmayer
5eb97d0028 Spreadsheet: several improvements
* do not simply return with Py_None from Python handler without incrementing the ref. counter as otherwise the interpreter steals a reference and the program will crash after a while
* avoid using the plain Python C API and instead use the PyCXX API
2021-11-13 21:56:15 +01:00
wmayer
63e1f95a97 Spreadsheet: get access to the sheet view from the view provider via Python 2021-11-13 21:43:58 +01:00
wmayer
1e3b97f619 Spreadsheet: in ViewProviderSheet do not add a second member to store the Python wrapper because the base class already has it
and it invalidates the wrapper in case the it is destroyed
2021-11-13 21:34:43 +01:00
wmayer
00846945d5 SpreadSheet: fix -Wunused-parameter 2021-11-13 20:45:06 +01:00
wmayer
b308645654 SpreadSheet: fix -Winconsistent-missing-override 2021-11-13 20:41:06 +01:00
wmayer
5f7b8214e5 Spreadsheet: implement SheetViewPy that acts as sub-class of MDIViewPy 2021-11-13 20:40:32 +01:00
luz paz
3da6ced354 Fix header uniformity 2021-11-13 06:20:19 -05:00
Chris Hennes
093f15dce5 Spreadsheet: Expose currentIndex to Python 2021-11-12 22:54:24 -06:00
Uwe
4a4db353a5 [PD] fix pad/pocket direction issue
- the info if a custom direction is used, was incorrectly determined by checking a checkbox that only displays the vector value, no matter if it is a custom vector or not
2021-11-13 04:03:04 +01:00
Chris Hennes
37dbcf7f66 Spreadsheet: Add programmatic selection of cells
Implement modifying the current selection programmatically via the
ViewProvider object in both C++ and Python. This enables unit testing of
GUI tasks that require a selection, and improves scriptability of
Spreadsheet.
2021-11-12 17:33:39 -06:00
Uwe
640ecca830 [PD] fix typos 2021-11-13 00:29:33 +01:00
Chris Hennes
179c6b540e Spreadsheet: Minor code cleanup 2021-11-12 13:31:05 -06:00
Jose Luis Cercos-Pita
16bbe12336 Expose the selected cells to Python 2021-11-12 13:19:03 -06:00
P-C-R
5b6be77027 Merge branch 'master' into RRF-PP-for-Path 2021-11-12 19:06:52 +01:00
wmayer
96512c1e01 PD: [skip ci] add PartDesignGlobal.h with export/import macros 2021-11-12 18:25:41 +01:00
Ajinkya Dahale
5aaf6e68b4 [PD] Allow body faces when making loft by pre-selection 2021-11-12 01:33:46 +01:00
Uwe
51cc91da84 Update src/Mod/Sketcher/Gui/TaskSketcherValidation.ui
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2021-11-12 00:45:46 +01:00
luz paz
bad413b0f7 Sketcher: fix typo in Gui/TaskSketcherValidation.ui 2021-11-12 00:45:46 +01:00
Uwe
0b3839f0f6 [PD] TaskDlgPipeParameters - refactor comments
update/refactor comments after today's changes
2021-11-12 00:44:35 +01:00
Uwe
0995c81240 [PD] add feature to set direction for pockets
This PR adds the functionality of pads to pad along either a custom direction or along an edge to pockets.

So with this PR Pad and Pocket are on the same level of functionality.
2021-11-11 15:55:42 -06:00
wmayer
126fadd2d6 PD: make sure to switch off Profile and Section highlighting when closing sweep dialog 2021-11-11 20:33:27 +01:00
wmayer
fb9a3eecff PD: change visibility handling of sweep to support undo/redo 2021-11-11 20:21:47 +01:00
Chris Hennes
c62239d0ba Merge pull request #4626 from pavltom/GUI_TreeView_Item_Ordering
[Gui] Issue #3923 - Add arbitrary Tree View item ordering
2021-11-10 23:35:05 -06:00
Chris Hennes
bef1df4d40 Merge pull request #5163 from donovaly/PD-sweep-section-visibility2
[PD] fix sweep visibility bug
2021-11-10 22:43:49 -06:00
Uwe
969556573b [PD] code improvement for FeaturePad
as noted by @chennes in PR #5164, we should follow the C++ style guidelines:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-if
2021-11-11 02:26:42 +01:00
Uwe
8173f79dc7 [PD] code improvements for TaskPadParameters
as requested by @chennes in PR #5164, the code can be simplified:

- remove a redundant type cast, a redundant qualifier and an inconsistent and unnecessary check
2021-11-11 02:08:57 +01:00
Uwe
cc242aae7d [PD] handle changed property for loft and pipe
- this was missing in PR #5155
2021-11-11 01:24:53 +01:00
Ajinkya Dahale
a4fa45b589 [PD] Check if property is named before strcmp 2021-11-11 01:13:17 +01:00
Uwe
6069d48b6d [PD] fix sweep visibility bug
Currently:

    only sweep path is toggled correctly in its visibility, the profile is never shown
    the sections are always shown

This PR fixes this inconsistency reported here: https://forum.freecadweb.org/viewtopic.php?f=19&t=63544
2021-11-11 00:00:58 +01:00
sliptonic
73c01a4196 cmake error 2021-11-10 13:33:20 -06:00
Ajinkya Dahale
37df050d59 [PD] Clear other taskbox buttons in loft and pipe when one pressed 2021-11-10 17:59:45 +01:00
Bernd Hahnebach
62ad96508a Arch: export IFC, make compatible with ifcopenshell 0.7 2021-11-10 15:59:30 +01:00
Chris Hennes
b660ed815c Merge pull request #5152 from Roy-043/Draft-fix-getTeighaConverter
Draft: fix getTeighaConverter
2021-11-09 23:05:03 -06:00
Uwe
e06034e772 [PD] fix a typo
- also some sorting
2021-11-10 03:26:23 +01:00
luz paz
96bbb4ba21 TechDraw: Renames submenu command + exposes to translation
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/82  
The dropdown `TechDraw > Extensions: centerlines and threading` (submenu) is too long and superfluous. Renamed to: `Extensions: Centerlines/Threading`. Also exposed to translation.
2021-11-10 01:11:39 +01:00
Ajinkya Dahale
314ff0053c [PD] Fixed loft and sweep breaking on section deletion
Item removal in `onDeleteSection()` was also clearing subname details so if one
of the remaining sections was a face this caused a failure.
2021-11-09 23:05:29 +01:00