kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
22,458 Commits 41 Branches 6 Tags
2cf9f395c193f0fc297c4b654ea91b2c408ca2e5
Commit Graph

21450 Commits

Author SHA1 Message Date
Roy-043
2cf9f395c1 Draft: Again revised the 5 scale unit tests. No longer relying on the math module. 
Also avoided the use of a Boolean 'result' variable.
 2020-09-16 13:07:50 +02:00
Roy-043
30fd275089 Draft: Revised the 5 Draft.scale unit tests. No longer using scale_vector_from_center. 
The old Draft.scale unit tests uses the scale_vector_from_center function from Draft.scale. This obviously didn't make sense.
 2020-09-16 13:07:50 +02:00
Roy-043
687461cf15 Draft: added 5 scale unit tests to test_modifications 
The added functions are test_scale_part_feature_arcs, test_scale_part_feature_lines, test_scale_rectangle, test_scale_spline and test_scale_wire.
When comparing vectors and floats a tolerance of 1e-8 is used, but only for the midpoints of the arcs in test_scale_part_feature_arcs is this tolerance required. Scaling a part feature is not possible with the Draft_Scale command, but Draft.scale does support it.
 2020-09-16 13:07:50 +02:00
wmayer
53a500ecf5 PartDesign: make sure to remove selection gate when closing task panel 2020-09-16 12:15:19 +02:00
wmayer
32d69af308 Fem: make sure to remove selection gate when closing task panel 2020-09-16 12:15:01 +02:00
wmayer
be22fb0bc5 Part: do not use local event loop in sweep and thickness panel 2020-09-16 12:14:04 +02:00
donovaly
5abb45f7cf [PD] fix wording for skew prisms 
the UI and the property is not consistent. In the dialog we use the term angle upon user feedback while the property still has the name "skew" in it.
I simply forgot this change in my PR that implemented skew prisms.

This is now corrected by this PR.
 2020-09-15 22:13:26 +02:00
sliptonic
2921a0c64b Merge pull request #3861 from Russ4262/profile_reset_fix 
[Path] Fixes #4433 - `Cut Side` reset with certain Base Geometry changes
 2020-09-15 14:12:01 -05:00
sliptonic
6ab2b2e088 Merge pull request #3862 from Russ4262/pocketshape_fix 
[Path] PocketShape - fix improper path generation
 2020-09-15 14:09:57 -05:00
sliptonic
aa9bde8066 Merge pull request #3813 from xform3/feature/base_geometry_multi_object_select 
[Path] Enable for selection of multiple objects in Base Geometry list
 2020-09-15 13:54:54 -05:00
sliptonic
a723fd7cbe Merge pull request #3849 from Schildkroet/deburr+dressup 
[Path] Fixed DeburrOp not moving to safe height
 2020-09-15 12:48:33 -05:00
sliptonic
9925e5c99f Merge pull request #3870 from vocx-fc/Path_fix_CMakeLists 
Path: add missing postprocessor to CMakeLists
 2020-09-15 12:47:17 -05:00
wmayer
42d643c8f7 PD: whitespace improvements 2020-09-15 14:20:24 +02:00
wmayer
5635f87d0e PD: do not use active document in task dialogs because this is error-prone 
and optimize string creation in TaskSketchBasedParameters::getFaceReference
 2020-09-15 14:13:23 +02:00
wmayer
1c730a7f00 PD: do not use active document in task dialogs because this is error-prone 2020-09-15 13:21:32 +02:00
mwganson
74e4a3e976 [Part Design] allow for preselecting loft sections and pipe spines prior to invoking command 2020-09-15 10:48:09 +02:00
vocx-fc
b0f6920b4e Path: use 4-space indentation, and keep lines short 2020-09-15 00:56:17 -05:00
vocx-fc
645336ffd4 Path: add missing postprocessor to CMakeLists 2020-09-14 22:18:00 -05:00
wmayer
7459f87c88 Part: [skip ci] Coverity: Uninitialized scalar field 2020-09-14 19:30:21 +02:00
wmayer
d13a187a6f App: [skip ci] Coverity: 'Constant' variable guards dead code 2020-09-14 19:06:27 +02:00
wmayer
6199fbb25e Base: [skip ci] Coverity: Uncaught exception 2020-09-14 18:34:25 +02:00
wmayer
3a8a28ce92 Gui: [skip ci] Coverity: Uncaught exception 2020-09-14 17:21:50 +02:00
wmayer
c3d35c65fe dxf: [skip ci] Coverity: Buffer not null terminated 2020-09-14 14:37:20 +02:00
wmayer
d3d8ea841d Gui: [skip ci] Coverity: Uninitialized pointer field 2020-09-14 14:08:21 +02:00
wmayer
3dce94d589 TechDraw: [skip ci] Coverity: Dereference null return value 2020-09-14 14:04:18 +02:00
wmayer
e5a3ba0ce8 TechDraw: [skip ci] Coverity: Uninitialized scalar variable/Uninitialized scalar field 2020-09-14 13:54:55 +02:00
hrobeers
aaf12da9d0 [OpenSCAD] consistent FreeCADGui imports, fixes headless CSG import 2020-09-14 13:28:40 +02:00
wmayer
d205122160 Gui: [skip ci] fixes #0004422: PartDesign value input does not accept trailing slash 2020-09-14 10:37:46 +02:00
wmayer
2c744264d6 Gui: several fixes for expression search box: 
+ rename method setMatchExact() to setExactMatch()
+ move handling of user-defined parameters to class ExpressionParameter
+ Qt::MatchExactly is not supported by QCompleter, use Qt::MatchStartsWith instead
+ add possibility to change match behaviour via context-menu
 2020-09-13 18:35:46 +02:00
Zheng, Lei
d6748a030f Gui: enable search box in stand alone TreeView dockable 2020-09-13 18:35:02 +02:00
Zheng, Lei
4f5a2e923c Gui: allow change ExpressionCompleter filter mode 
Fixes #4428

Filter mode set to Qt::MatchContains for tree view search and link
property editor object search.

Other usage of the completer (e.g. property editor, speadsheet) defaults
to Qt::MatchContains, but can be changed using parameter,

    BaseApp/Preferences/Expression/CompleterMatchExact
 2020-09-13 18:35:02 +02:00
wmayer
82038bb1ff App: [skip ci] add GeoFeaturePy::getPropertyOfGeometry 2020-09-13 13:14:21 +02:00
Syres916
a7ffe6eb83 [Sketcher] Improve Solver Message Visibility... 
...when using dark(er) style sheets.
See discussion https://forum.freecadweb.org/viewtopic.php?f=3&t=50094
 2020-09-13 12:52:28 +02:00
Cheuksan Wang
0aa759b5c5 Move the aliases before other content of cells 
When a user performs insert rows, remove rows, insert columns, or
remove rows, we need to move multiple cells as a batch. The cells are
moved sequentially. For each cell, its dependent alias positions are
looked up and dependencies are added.  However, those cells with
aliases may be moved later in the batch. Thus the earlier dependencies
become wrong. This commit fixes this bug by moving all the aliases
before moving the cells. Unit tests are added to for this bug.

fixes issue #4429
 2020-09-13 11:58:54 +02:00
bitacovir
1a7fd88bc3 Add SVG icon for Part Reverse Shape command 
Part Reverse Shape command does not have icon for the FreeCAD UI (Part WB).

This commit adds SVG file with icon for this command. Also, it makes the necessary changes on Command.cpp and Part.qrc files.

The new SVG icon follows the FreeCAD Artwork Guidelines and were saved as Plain SVG format.

The icon designs keep the style of the existing icons in the Part Workbench:
https://wiki.freecadweb.org/Part_Module

The discussion with the request can be found in the UX/UI Design FreeCAD Forum:
https://forum.freecadweb.org/viewtopic.php?f=34&t=44278&hilit=bitacovir
 2020-09-13 10:01:50 +02:00
wmayer
24fd057cbb MeshPart: [skip ci] import MeshPartGui in order to load icon resources 2020-09-13 09:59:14 +02:00
bitacovir
6aeed648f6 Auto stash before rebase of "upstream/master" 2020-09-12 22:47:45 +02:00
wmayer
f681b86abd fixes #0004426: [skip ci] Patch to add MinLength and MaxLenght to the Netgen options in the Python API (provided by thomasFreeCAD) 2020-09-12 19:37:12 +02:00
wmayer
89a2151a95 App: [skip ci] move execution of extensions to its own method 2020-09-12 18:14:09 +02:00
wmayer
b2f11ae6fd App: [skip ci] improve whitespaces 2020-09-12 17:43:01 +02:00
Zheng, Lei
74abb39883 App: fix GeoFeatureGroupExtension::extensionGetSubObject() 2020-09-12 17:30:56 +02:00
wmayer
4cad62e315 PartDesign: [skip ci] fix L2 parameter in pad feature when using custom direction 2020-09-12 17:26:41 +02:00
Russell Johnson
fd3efcdbd7 [Path] PocketShape - fix improper path generation 
Forum identification and discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=49513.
 2020-09-12 09:35:34 -05:00
donovaly
7cbc9cf5f0 [PD] allow to pad in any direction 
It saves a lot of work if one can directly pad in any direction and OCC allows this.

This PR adds the possibility to define a custom vector for the padding direction.
 2020-09-12 16:33:44 +02:00
donovaly
d4519d5aec [PD and Part] add possibility to create skew prisms 2020-09-12 13:28:00 +02:00
Russell Johnson
47b27edd6d [Path] Fixes #4433 - Cut Side reset with certain Base Geometry changes 
`Cut Side` value was hard-coded to reset when Base Geometry was empty.  This disallowed retention of the current value with changes to selected Base Geometry involving the clearing thereof.
Also restored fixed visibility to `Cut Side` option in Task panel editor per forum mention.
 2020-09-12 00:24:25 -05:00
luz paz
abfb6e8444 fix typo in src/Gui/DlgPropertyLink.ui [skip-ci] 
Found via `codespell v2.0.dev0`  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml 
```
 2020-09-11 16:25:42 +02:00
wmayer
9fd5769f07 TechDraw: [skip ci] fix several gcc/clang warnings 
-Wunused-private-field
-Wmaybe-uninitialized
-Wunused-parameter
 2020-09-11 15:10:58 +02:00
wmayer
877d7e3c49 Gui: [skip ci] workaround for QWindowsStyle to disable spin buttons when it is set read-only 2020-09-11 14:10:45 +02:00
Zheng, Lei
46209e7f77 Gui: fix view object global coordinate space showable checking 2020-09-10 14:30:50 +02:00