Commit Graph

23040 Commits

Author SHA1 Message Date
luz paz
1b8f4747e6 femtest/test_information.md: tweaks
Tweaked the markdown
2020-11-10 23:20:29 +01:00
luz paz
484693c1d8 FEM: remove superfluous 'pass'
Fixes LGTM alert  
Per the documentation:  
```
A 'pass' statement is only necessary when it is the only statement in a block (the list of statements forming part of a compound statement). This is because the purpose of the 'pass' statement is to allow empty blocks where they would otherwise be syntactically invalid. If the block already contains other statements then the 'pass' statement is unnecessary.
```
2020-11-10 23:20:23 +01:00
wmayer
f9420c9877 Part: [skip ci] simplifications in primitives location dialog
- do not use a QSignalMapper if the slot doesn't take care of the emitting widget
- to set the placement only check for the base class GeoFeature, i.e. no need to step through all primitive types
- fix compiler warning of unused variable
2020-11-10 20:20:33 +01:00
donovaly
f0af88ecae [Part] add preview for changes to primitives location
- unset keyboardTracking for the dialog edits
- don't hide the location dialog on creation
2020-11-10 20:03:08 +01:00
wmayer
bdcbf316b9 PartDesign: [skip ci] fix whitespaces 2020-11-10 19:39:44 +01:00
donovaly
ea08a660eb [PD] hole creation
- propose valid values for the cut depth and diameter when creating new holes
- add new definitions for metric fine
- some code simplification and comments
2020-11-10 19:34:53 +01:00
Yorik van Havre
e26a9efae8 Arch: Added Awming window preset 2020-11-10 19:14:06 +01:00
Yorik van Havre
e76c857036 Merged crowdin translations 2020-11-10 14:58:06 +01:00
Yorik van Havre
f76eeddfcb Updated ts files 2020-11-10 14:47:48 +01:00
Yorik van Havre
413d315d37 Draft: Change WP button icon to reflect current state 2020-11-10 14:45:44 +01:00
Yorik van Havre
88f5fc20b1 Draft: Condensed the Draft toolbar style buttons into one with more options 2020-11-10 14:14:18 +01:00
Abdullah Tahiri
485b0b58a0 Sketcher: GeometryFacade inheritance correctness
- Make explicit private inheritance of the interface
- Correct inheritance of ExternalGeometryFacade
- Correct inheritance of ExternalGeometryExtension
- Better document the inheritance choice
2020-11-10 13:35:11 +01:00
Daniel Wood
8713916658 [Path] Add Turning Roughing Selection 2020-11-09 21:14:19 +00:00
Bernd Hahnebach
645535234a Material: fix open material editor with empty material, regression was added with commit 0f87516 2020-11-09 19:29:55 +01:00
wmayer
59c50053a6 MSVC: [skip ci] make working with C++17 compiler 2020-11-09 16:13:34 +01:00
donovaly
08efd286df [Sketch] add missing menu entry for new feature 2020-11-09 16:12:27 +01:00
wmayer
6b9178e0b3 Part: [skip ci] correctly show control points of a B-spline/Bezier curve/surface if a placement is set 2020-11-09 13:14:31 +01:00
marioalexis
3f5caddabf Draft: Enable offset for working plane aligned with current view 2020-11-09 12:42:18 +01:00
marioalexis
a36fb60653 Draft: Improve archDimTracker class 2020-11-09 12:39:19 +01:00
marioalexis
ef2d4f2989 Draft: Fixes in gui_offset 2020-11-09 12:37:56 +01:00
Roy-043
97828f0ba8 Update dxf.cpp
Fixed wrong DXF scale factor for inches. 1/25.4 was wrongly used,
2020-11-09 12:35:14 +01:00
Roy-043
5f63f3ae71 Update dxf.cpp
Fixed wrong Inch scale factor. 1/25.4 was wrongly used.
2020-11-09 12:35:14 +01:00
wmayer
58be246baf Part: [skip ci] fix type of Rotations property of Spiral primitive 2020-11-09 09:31:16 +01:00
Russell Johnson
70473ab422 Path: Fix missing variable declaration for rotational scan
Missing default logical choice within `if...:` block.
Reported in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=44473&start=60#p412303
2020-11-08 22:56:49 -06:00
Russell Johnson
b94cbb617e Path: Fix unsorted arc order for circular cut pattern in some cases 2020-11-08 22:56:49 -06:00
Russell Johnson
220bf0e396 Path: Fix cut direction when CutPatternReversed is true for Circular 2020-11-08 22:56:49 -06:00
Russell Johnson
4c558f1a30 Path: Restructure code to fix closedGap LGTM issue 2020-11-08 22:56:49 -06:00
Russell Johnson
dea85bc999 Path: Some LGTM cleanup 2020-11-08 22:56:49 -06:00
Russell Johnson
604cfaf779 Path: Apply missing CutMode setting when CutPattern = Offset
The `CutMode` toggle had no effect. This fix applies the `CutMode` toggle when the `CutPattern = Offset`.  The indicated `CutMode` may not be accurate depending on the situation, but the toggle will change the cut direction as intended.
2020-11-08 22:56:49 -06:00
donovaly
9b5eb77480 [Sketch] remove now unused variable
also add comment for better understanding
2020-11-08 18:59:28 +01:00
wmayer
c5a4b01d2e Gui: [skip ci] try to avoid to truncate QuantitySpinBox at bottom margin on macOS 2020-11-08 16:07:10 +01:00
Abdullah Tahiri
975c03a206 Sketcher: Some fixes to bspline weight information layer
- fix sign/unsign comparison warning
- show intent in for loop comparison, values inside the loop over size() are not intended and are undesirable
- do not use itw for an index, as it evokes an interator - it -
- BSpline Weight on information layer positioned one line under Knot multiplicity
2020-11-08 15:56:58 +01:00
donovaly
65c96a3b21 [Sketch] add option to display spline weights
When working with weights, it is a huge improvement to see the weights immediately when changing the pole circle radius.
This PR adds an option to display the weights.
2020-11-08 15:56:21 +01:00
wmayer
7251a90f6a Part: [skip ci] implement live preview for primitives 2020-11-08 15:40:59 +01:00
wmayer
70be25752d Part: override extensionSetupContextMenu in ViewProviderSplineExtension 2020-11-08 13:37:17 +01:00
wmayer
31ff1921ce Gui: [skip ci] add method extensionSetupContextMenu to extension view provider 2020-11-08 13:36:31 +01:00
wmayer
4025405ce5 Part: make view provider for helix and spiral inherit from primitive and use spline extension 2020-11-08 12:19:57 +01:00
wmayer
98d7a0400e Part: [skip ci] implement extension ViewProviderSplineExtension 2020-11-08 12:18:44 +01:00
wmayer
694eebf126 smesh: [skip ci] comment out call of std::set_unexpected that has been removed in C++17 2020-11-08 10:47:08 +01:00
wmayer
035803e47d Part: [skip ci] properly handle transactions when editing primitives 2020-11-08 10:43:04 +01:00
wmayer
dabf65cc72 Part: [skip ci] implement live preview for box and cylinder 2020-11-08 10:26:07 +01:00
donovaly
0b9c425678 [part] remove a now misleading comment
I added this comment when I read the dialog state fro the index of the type combobox, now we read the primitive's TypeID so the comment is misleading
2020-11-08 06:43:16 +01:00
Abdullah Tahiri
b8376e1529 Sketcher: Fix select associated constraints when drawhandler active 2020-11-07 20:18:14 +01:00
Chris Hennes
c23e1dd7ba Release handler in commands where not needed
Fixes #0004478: Active constraint tool blocks sidebar tasks from working.

Many commands are interrupted by the existence of a handler. Rather than having these commands silently cancel, purge the handler if a command executes that does not need it.

When right-clicking on an item in the Constraint Task sidebar, any current operation is cancelled and the FreeCAD selection is synced with the selected items in the constraints QListWidget. This allows all of the menu items in the context menu to function properly: if the selection is not synced, anything that relies on the FreeCAD selection (like Delete) will sillently fail.
2020-11-07 20:17:19 +01:00
sgrogan
6cac6d937b set -DBUILD_ENABLE_CXX_STD='C++17' 2020-11-07 19:48:31 +01:00
sgrogan
e9531d2a7e increase osx timeout limit 2020-11-07 19:48:31 +01:00
wmayer
c11a36386b smesh: [skip ci] comment out call of std::set_unexpected that has been removed in C++17 2020-11-07 19:47:11 +01:00
wmayer
f8bd2c81c3 Part: [skip ci] add missing export macro 2020-11-07 10:17:34 +01:00
wmayer
f23187cd0e Part: allow to edit primitives via dialog 2020-11-06 23:12:40 +01:00
Daniel Wood
5807c38416 [Path] Fix Typo - Stock object requires uppercase 'S' 2020-11-06 20:01:56 +01:00