kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
42,744 Commits 41 Branches 6 Tags
2da7c9ff17fe5af25c3d4961e8a1b7d65a168d6e
Commit Graph

3681 Commits

Author SHA1 Message Date
theo-vt
2da7c9ff17 Sketcher: Change the style of the curves in creation to match the construction/defining flag (#22407) 
* Sketcher: Change EditCurvesDrawStyle to match either CurvesDrawStyle or CurvesConstructionDrawStyle in editDraw()

* Match color as well

* Match pattern scale as well

* Use enum instead of boolean flag

* Update src/Mod/Sketcher/Gui/Utils.h

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-07-28 02:33:25 +00:00
Kacper Donat
4823ccb6a1 Merge pull request #22736 from chennes/sketcherCodeQLCleanup 
Sketcher CodeQL cleanup
 2025-07-26 11:21:53 +02:00
Chris Hennes
29da89febd Sketcher: Clean up some old commented out code 2025-07-25 19:12:30 -05:00
Chris Hennes
cdf0097dec Sketcher: Fix increment of parabola constraint tag 
It is an invisible and unstated assumption of the redundant-constraint
removal code that the "tag" of a constraint can be used as the index
into the SketchObject's Constraint list. This is true for all objects
except a parabola, which, when creating its internal alignment focus
constraints, incremented the ConstraintCounter for *each* of the
internal constraints, instead of only once.
 2025-07-25 22:03:10 +02:00
Luz Paz
9efd70ffa4 Fix various source comment typos 
Found via codespell
 2025-07-25 10:25:54 -05:00
Chris Hennes
3679a2adca Sketcher: Extract "processFace" function 
Tool-aided refactor, no functional changes.
 2025-07-25 10:08:29 -05:00
Chris Hennes
403056fa20 Sketcher: Resolve "Declaration hides variable" 
Reduce some code duplication via helper method.
 2025-07-25 09:48:34 -05:00
Chris Hennes
ab91372e28 Sketcher: Resolve "Type confusion" CodeQL critical warning 2025-07-25 09:21:43 -05:00
matthiasdanner
f3e1e6cec0 Sketcher: Display arc angle and length constraints beyond center point (#22651) 
* Allow arc segment length and angle constraints to go past the center point

* fix angle helper lines

* fix linter warning

* fix arc length calculation

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
 2025-07-25 13:57:21 +02:00
Kacper Donat
f572d2e4f2 Merge pull request #22660 from chennes/fixMultResultConvertedToLargerType 
Fix mult result converted to larger type
 2025-07-25 10:20:03 +02:00
Kacper Donat
b7c978314e Merge pull request #22577 from AjinkyaDahale/sk-fix-22352 
Sketcher: Avoid crash when using trim as described in #22352
 2025-07-25 00:16:28 +02:00
Syres916
e828c5da4d [Sketcher] Ensure All Reference Constraints are Read Only in the Property Editor 2025-07-24 08:40:09 -05:00
Chris Hennes
f1c200b204 Sketcher: Fix multiplication result converted to larger type 2025-07-21 23:40:56 -05:00
Benjamin Nauck
ac07a56b75 Sketcher: Add support for more than 3 points 
While this adds a new way, it keeps the old to make it easier to merge.
This will allow other work to be merge before without rebase issues
 2025-07-21 18:02:23 +02:00
Benjamin Nauck
6eff3ed949 Sketcher: Initialize constraint members in class declaration 2025-07-21 18:02:23 +02:00
wmayer
402d533bff Sketcher: fix for issue 12925 2025-07-21 10:55:06 -05:00
PaddleStroke
aa785f78d6 Sketcher: Dimension: Offset the label when moving mouse (#22387) 
* Sketcher: Dimension: Offset the label when moving mouse

* Sketcher: Create dedicated enum for offset boolean

This improves readability because the intent must be stated explicitly.

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-07-20 19:47:21 +02:00
matthiasdanner
f38485ada2 Sketcher: Add second arc helper on diameter constraint (#22579) 
* add second arc helper on diameter constraint

* fix linter warnings

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
 2025-07-20 19:46:49 +02:00
Chris Hennes
538b6e042c Merge pull request #22227 from kadet1090/refactor-tool-hints 
Sketcher: Refactor Tool Hints
 2025-07-20 12:05:15 -05:00
PaddleStroke
4bdaa0180a Sketcher: Fix random gray icon (#22502) 
* Sketcher Fix #10027
 2025-07-20 00:17:58 +02:00
Kacper Donat
4ac445afe7 Sketcher: Declare tr function for DrawSketchHandler 2025-07-19 10:05:09 +02:00
Kacper Donat
ed14e6b24f Sketcher: Use generic tool hints table for DrawSketchHandlerBSpline 2025-07-19 10:05:09 +02:00
Kacper Donat
91de480bc8 Sketcher: Use generic tool hints table for DrawSketchHandlerTranslate 2025-07-19 10:05:09 +02:00
Kacper Donat
6564ad5c6e Sketcher: Use generic tool hints table for DrawSketchHandlerSlot 2025-07-19 10:05:09 +02:00
Kacper Donat
05eb702f87 Sketcher: Use generic tool hints table for DrawSketchHandlerScale 2025-07-19 10:05:08 +02:00
Kacper Donat
276a44c1e3 Sketcher: Use generic tool hints table for DrawSketchHandlerRotate 2025-07-19 10:05:08 +02:00
Kacper Donat
6b22c79be2 Sketcher: Use generic tool hints table for DrawSketchHandlerRectangle 2025-07-19 10:05:08 +02:00
Kacper Donat
49fbffa200 Sketcher: Use generic tool hints table for DrawSketchHandlerPolygon 2025-07-19 10:05:08 +02:00
Kacper Donat
7d7fc0c021 Sketcher: Use generic tool hints table for DrawSketchHandlerLineSet 2025-07-19 10:05:08 +02:00
Kacper Donat
23bd9e86fd Sketcher: Use generic tool hints table for DrawSketchHandlerLine 2025-07-19 10:05:08 +02:00
Kacper Donat
9a9613d88c Sketcher: Use generic tool hints table for DrawSketchHandlerFillet 2025-07-19 10:05:08 +02:00
Kacper Donat
ed617cdf74 Sketcher: Use generic tool hints table for DrawSketchHandlerExtend 2025-07-19 10:05:08 +02:00
Kacper Donat
2ab975cfd5 Sketcher: Use generic tool hints table for DrawSketchHandlerEllipse 2025-07-19 10:05:08 +02:00
Kacper Donat
edf0d488e4 Sketcher: Use generic tool hints table for DrawSketchHandlerCircle 2025-07-19 10:05:08 +02:00
Kacper Donat
5c1d097161 Sketcher: Use generic tool hints table for DrawSketchHandlerBSpline 2025-07-19 10:05:08 +02:00
Kacper Donat
e86a43c183 Sketcher: Use generic tool hints table for DrawSketchHandlerArcSlot 2025-07-19 10:05:08 +02:00
Kacper Donat
f0c6cd7a0f Sketcher: Use generic tool hints table for DrawSketchHandlerArcOfParabola 2025-07-19 10:05:08 +02:00
Kacper Donat
d1a25c98bc Sketcher: Use generic tool hints table for DrawSketchHandlerArcOfHyperbola 2025-07-19 10:05:08 +02:00
Kacper Donat
20876d7b35 Sketcher: Use generic tool hints table for DrawSketchHandlerArcOfEllipse 2025-07-19 10:05:08 +02:00
Kacper Donat
b2453caaea Sketcher: Use generic tool hints table for DrawSketchHandlerArc 2025-07-19 10:05:08 +02:00
Ajinkya Dahale
114d3dcd87 Sketcher: Improve constraint transfer in SketchObject::trim() 
Provide new geos to `deriveConstraintsForPieces` manually, since they are
not (and likely cannot be at time of calling) added to the sketch. This will
make sure that the method has sufficient information to properly transfer/create
new constraints.
 2025-07-19 03:25:38 +05:30
Ajinkya Dahale
018ac7b9dd Sketcher: Skip checks in deriveConstraintsForPieces when risky 
Possibly fixes #22352.

It is possible to call the method when new geos are not yet created or added to
the sketch. In such cases, the values obtained can be "dirty", and is likely a
seg-fault.
 2025-07-19 03:25:38 +05:30
theo-vt
b0dcce6c66 Sketcher: Only autoscale if the datum being edited is the scale defining datum (#22419) 2025-07-18 09:58:30 -05:00
Florian Foinant-Willig
c968effe26 Sketcher: manage legacy negative circle-line distance (#22203) 
* manage legacy negative circle-line distance

* Add test for legacy negative circle-line distance
 2025-07-17 23:00:38 -05:00
matthiasdanner
9cd3b31067 Sketcher: Fix Constraint Filter Handling (#22072) 
* Fix SpecialFilter Handling for selected and associated constraints
Fix show constraints in 3d view if no constraints in list and filter to only show selected is disabled

---------

Co-authored-by: Matthias Danner <28687794+matthiasdanner@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
 2025-07-17 07:51:44 +00:00
PaddleStroke
562d646082 Sketcher: add ConstraintLineByAngle helper. (#22273) 
* Sketcher: add ConstraintLineByAngle helper.

* Update src/Mod/Sketcher/Gui/Utils.cpp

* Update src/Mod/Sketcher/Gui/Utils.cpp

---------

Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-07-14 19:44:32 +00:00
Florian Foinant-Willig
0ecdb8b00e Sketcher: clean planegcs/Geo (#22378) 
* Sketcher: clean planegcs/Geo
 2025-07-14 10:56:25 -05:00
theo-vt
c8bddd2f2b Sketcher: assign the old geometries' GeometryId[s] to new geometries after scaling (#22263) 
* Reassign facade ids after scale operation if deleting geometries

* Fix failing CI
 2025-07-14 17:39:03 +02:00
Fermín Olaiz
1881686e72 Fix crash on out-of-bound vector access (#22397) 2025-07-09 19:07:11 +02:00
FEA-eng
0e8a7b6319 Sketcher: Add tooltip for autoscale feature (#22252) 
* Sketcher: Update SketcherSettings.ui

* Sketcher: Update SketcherSettings.ui
 2025-07-07 18:31:55 +02:00