Commit Graph

2081 Commits

Author SHA1 Message Date
sliptonic
2e1796cbb5 Merge pull request #3331 from Russ4262/Waterline_updates
[Path] Waterline fixes(5), new IgnoreOuterAbove feature, and code simplification
2020-04-17 10:40:15 -05:00
Russell Johnson
9642271335 Path: Optimization for open edges update
Remove required usage of DocObject creation, in lieu of Part geometry usage - the preferred method.
Limit DocObject creation to debugging mode only.
Remove dependency on Draft module.
Drawback is top edge must be selected, and Final Depth set appropriately when using profiling open edges.
2020-04-16 12:53:32 -05:00
Russell Johnson
c3dcf94ffd Path: Move more common methods to PathSurfaceSupport module 2020-04-16 00:35:05 -05:00
Russell Johnson
0bfea7429b Path: Add new support module for 3D Surface and Waterline 2020-04-16 00:28:33 -05:00
Russell Johnson
fa13068220 Path: Comment cleanup; adjust messages; set 2 default values 2020-04-16 00:28:33 -05:00
Russell Johnson
ba88e0eef2 Path: Implement new module PathSurfaceSupport; Add Spiral cut pattern
New module is shared with 3D Surface operation. Module contains PathGeometryGenerator class. More common methods can be moved into the new module.
2020-04-16 00:28:25 -05:00
Russell Johnson
ce42444afa Path: Preparation for making property defaults readable through class 2020-04-16 00:28:18 -05:00
Russell Johnson
2fc634a22a Path: Improve backwards compatibility capabilities 2020-04-16 00:28:11 -05:00
Russell Johnson
ea960770af Path: Improve property visibility in Data tab 2020-04-16 00:28:04 -05:00
Russell Johnson
873b9c0f6f Path: Expose operation's property details to access via class 2020-04-16 00:27:58 -05:00
Russell Johnson
996d4710f5 Path: Fix weakness in face analysis for unique OuterWire cases
synced with PathSurface module
2020-04-16 00:27:49 -05:00
Russell Johnson
18e6fa2127 Path: Add missing tooltips 2020-04-16 00:27:40 -05:00
Russell Johnson
04093c3d76 Path: Waterline fixes(5), new IgnoreOuterAbove, and code simplification
Fix module base for getFacets()
Fix isOnLineSegment() usage.
Fix property visibility in Data tab.
Fix missing raise to SafeHeight after clearing layer.
Fix handling of `import ocl` failure
Move Draft import to dependent function
Raise `import ocl` test in code execution
Disable face selection for Waterline and issue warning as intermediate fix. Application of face-selection from 3D Surface requires some modification for use in Waterline.  This work is to be done.  Some existing carryover methods should be usable in current form.
Compact setup() function
Sync some methods with PathSurface in preparation of extracting common methods to independent support module.
Increase SampleInterval range for OCL Dropcutter algorithm.
Convert OCL Dropcutter waterline to use FreeCAD.Vector() points rather than ocl.Point().
Simplify some code and delete unnecessary comments.
LGTM cleanup.
New feature - IgnoreOuterAbove. Ignore the outer-most waterline above this height.  Designed to eliminate the model profile path created in some use cases.
Adjust tooltip language for `Algorithm`
2020-04-16 00:27:40 -05:00
Russell Johnson
1c268425a4 Path: Improve Tasks editor interaction
Swap setEnabled() method for show() and hide().
Include showing and hiding associated labels.
Path: Hide `optimizeEnabled` input
2020-04-16 00:27:06 -05:00
Eric Trombly
08fc5556d5 fix some typos in recent lazyloader implementation 2020-04-15 12:32:48 -05:00
sliptonic
9427b5d0aa Merge pull request #3330 from etrombly/lazyloader
[Path] Use lazyloader for deferred python imports
2020-04-15 10:22:28 -05:00
Eric Trombly
24e681c63b add lazyloader support
lazy_loader is copied to Ext now, modified external imports to lazy_load

add a few more imports to be lazy loaded, think the install path is correct now

[TD]"<" symbol embedded in html

revert changes to path modules for testing

use lazyloader in PathAreaOp.py

add back in deferred loading

temp change to print error message in tests

temp change to print error message in tests

add _init__.py to lazy_loader

make install in CMakeLists.txt one line
2020-04-13 21:14:34 -05:00
sliptonic
2e4b82169a Merge pull request #3333 from fra589/master
[Path] Add size parameter for syntax highlighting of GCode editor
2020-04-13 08:48:18 -05:00
sliptonic
19151cc547 Merge pull request #3336 from dubstar-04/chamferFixes
[PATH] Deburr Gui Fixes
2020-04-13 08:47:19 -05:00
Zheng, Lei
1becccb152 Path: fix path sort 2020-04-13 14:34:18 +08:00
Daniel Wood
82bee09bb7 Ensure join type is shown 2020-04-12 08:04:32 +01:00
Daniel Wood
54ce85acdf Deburr: signal for update when values are changed 2020-04-12 06:33:34 +01:00
Gauthier
c914b68fe6 Merge remote-tracking branch 'upstream/master' 2020-04-11 17:06:31 +02:00
Gauthier
296be79bc6 Add size parameter for syntax highlighting of GCode editor 2020-04-11 17:05:59 +02:00
Russell Johnson
db18f3322a Path: PEP8 cleanup
line endings fix
2020-04-07 22:17:37 -05:00
Russell Johnson
bf114b606a Path: Fix broken Gui::QuantitySpinBox class
Now, custom expressions are applied to spinbox.
Spinbox now updates, after clicking elsewhere.
Path: Shorten for loop search
2020-04-07 22:17:37 -05:00
luz.paz
4acdf2613d [skip-ci] Various typo fixes
Found via codespell  v1.17.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-07 18:17:03 +02:00
sliptonic
591675cb0a Merge pull request #3316 from realthunder/FixPathSort
Path: handle open edges when sorting path
2020-04-07 09:31:01 -05:00
sliptonic
baa5c92bae Merge branch 'master' into FixPathSort 2020-04-06 14:33:55 -05:00
sliptonic
78b08c6298 Merge branch 'master' into 3d_surface_perf 2020-04-06 14:33:26 -05:00
Patrick F
2359919078 Removed offset check 2020-04-06 21:11:40 +02:00
Eric Trombly
56769f1a27 change isOnLine to isOnLineSegment 2020-04-06 06:34:53 -05:00
Eric Trombly
1ac9c2f4e9 move getFacets from Path to Part 2020-04-06 06:34:53 -05:00
Eric Trombly
6262dc561f added check that facets are valid in getFacets 2020-04-06 06:34:53 -05:00
Eric Trombly
6bb5873e3e add changes to Waterline 2020-04-06 06:34:53 -05:00
Eric Trombly
169d910eca Area.cpp and CMakeLists.txt had extranious line ending 2020-04-06 06:34:53 -05:00
Eric Trombly
c8901cd5af clean up commented old code 2020-04-06 06:34:53 -05:00
Eric Trombly
7cc190fff0 remove debug profiling from surface 2020-04-06 06:34:53 -05:00
Eric Trombly
edf9319f5a visual studio doesn't like indexing facets with [, changed to ( 2020-04-06 06:34:53 -05:00
Eric Trombly
a0e45bffaa remove parallel processing, replace mesh generation with getting facets 2020-04-06 06:34:53 -05:00
Eric Trombly
94935996cb change from openmp to std::thread 2020-04-06 06:34:53 -05:00
Eric Trombly
144d3b62f3 changed some for loops to list comprehensions, added openmp for area to make two loops parallel, changed a fuse to a compound 2020-04-06 06:34:53 -05:00
Eric Trombly
f210d71f18 remove sleep calls, change some for loops to list comp, move isPointOnLine to base vector 2020-04-06 06:34:53 -05:00
Zheng, Lei
9c86629a5f Path: handle open edges when sorting path 2020-04-06 09:58:01 +08:00
sliptonic
23ae15edc2 Merge pull request #3132 from Schildkroet/deburr+dressup
[Path] Deburr+DressupLeadInOut fixes
2020-04-05 18:34:52 -05:00
Patrick F
7d3c7dfef0 Bugfix for circular hole base 2020-04-02 19:38:21 +02:00
luz.paz
1663fbb1cd [skip ci] Fix typos in Path WB
Found via 
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-01 13:28:48 +02:00
Patrick Felixberger
58264bc7da Setup length depending on tool 2020-03-31 17:31:30 +02:00
Patrick Felixberger
b7702d5738 Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into deburr+dressup 2020-03-31 17:18:06 +02:00
sliptonic
4a53aa1100 Merge pull request #3231 from Russ4262/4th_axis_fixes
[Path] 4th-axis rotational alignment improvements;  Code clean-up
2020-03-31 08:17:18 -05:00