Commit Graph

102 Commits

Author SHA1 Message Date
Russell Johnson
4c1951aedc Path: Allow parent job assignment
Modifications focus on allowing the creation of operations to include direct provision of parent job.
Path: Remove `useGui` implementation
2021-08-13 19:02:40 -05:00
Russell Johnson
03cce806f3 Path: Remove first-draft rotational code Path
Remove all first-draft rotational-related code from Path workbench to make way for more stable, long-term integration of a rotational indexing capability.
2021-05-27 10:04:31 -05:00
Daniel Wood
f497d0da04 Use defaults for retract height
Use the StartDepth + SafeHeightOffset to calculate the retract height in relation to the hole start height.
2021-05-06 08:09:43 +01:00
Daniel Wood
1e8e81b986 use correct feedrate for rapid moves 2021-05-05 20:33:26 +01:00
Daniel Wood
5ff5b11e3c Rapid to safe height above the hole 2021-05-04 14:06:30 +01:00
Daniel Wood
ac13b55666 fixes for drilling operation start depth 2021-05-04 13:41:50 +01:00
Russell Johnson
ad6645f492 Path: Fix rotational errors and organize/simplify some rotational code
Fix rotational alignment and drilling depth issues for rotational drilling ops.
Issues identified in forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=52262.
Path:
2020-11-30 20:57:25 -06:00
Russell Johnson
ce65794a10 Path: Clean up comments and simplify one code block 2020-11-30 20:57:25 -06:00
luz paz
60c055e62d Path: Fix header uniformity and remove trailing whitespace
This PR fixes header uniformity across all Path files. It also removes all trailing whitespace.
2020-11-05 19:57:21 +01:00
sliptonic
7811c05275 Merge pull request #3192 from Schildkroet/4th-axis-improve
[Path] 4th axis improve
2020-03-18 23:48:22 -05:00
Patrick Felixberger
61d578bb61 Code clean up 2020-03-16 18:30:30 +01:00
Russell Johnson
8e9d704556 4th-axis fixes and improvements
Fix rotational orientation of pockets.  Need to apply same fix to ProfileFaces.
Fix final depth issue based upon error in rotational orientation fixed here.
Add property, `LimitDepthToFace` to facilitate easier pockets and face profiling on rotational-enabled operations.
Hide rotational support properties when operations do not use rotation.
Remove unnecessary property, `B_AxisErrorOverride`, and delete dead code that used it.
2020-03-14 11:36:21 -05:00
Patrick Felixberger
208c20ec53 Merge branch 'millface-drilling-improvements' of https://github.com/Schildkroet/FreeCAD into millface-drilling-improvements 2020-03-12 00:01:20 +01:00
Patrick Felixberger
a853187977 Changed property names 2020-03-12 00:00:44 +01:00
Patrick Felixberger
639327d62c Clean up 2020-03-11 22:49:28 +01:00
Patrick Felixberger
a08ca59766 Fixed broken final depth calculation for rotational axis in pocket, profile and drill; Added EnableRotation to GUI; Fix some weird gcode generation 2020-03-11 21:16:21 +01:00
Schildkroet
dc9d481879 Fixed wrong property name; Set default value 2020-03-11 07:45:02 +01:00
Patrick Felixberger
9953e96b5b Removed 'Use Tip Length' and added 'Extra Offset' in Drilling OP 2020-03-09 22:34:41 +01:00
Patrick Felixberger
d4bb31d726 Added coolant support to grbl_post
Improved canned cycles

Added/translated comments
2020-03-03 21:27:31 +01:00
Markus Lampert
81bbb0066d Removed dead code for debugging shortcut warnings. 2020-01-03 23:13:55 -08:00
Daniel Wood
55ba721155 Add coolant feature to Ops 2019-08-28 19:40:08 +01:00
IMback
ac16f2f673 Restore R parameter behavior 2019-08-08 19:29:26 +02:00
IMback
4fdec77034 Peck retract height default changed from 10mm to opStartDepth+1
Peck depth default changed to tool dia*0.75
Fields changed to QuanitiySpinBoxes
Insure travel between regions is always performed at safe height
Make Peck and Dwell exclusive in GUI
Restore name of RetractHeight
Use SetupSheet for all numerical properties
2019-08-08 10:38:30 +02:00
Russell Johnson
c6efd007f0 PathDrilling 4th-axis integration
Initial integration of 4th-axis functionality to the Drilling op in PathWB
2019-06-30 14:14:38 -05:00
sliptonic
617c619d2f remove unnecessary imports. normalize debug log levels 2019-06-21 13:01:01 -05:00
sliptonic
c8e945a3ab Path: normalize proxy stratements
remove bare exceptions
2019-06-21 13:01:01 -05:00
Russell Johnson
e1d3160c50 proxy to obj.Proxy partial conversion 2019-06-20 00:02:13 -05:00
luz.paz
ec12ffae0c Path: source comment typo fixes
Found via `codespell`
2019-05-30 19:57:25 +02:00
Markus Lampert
53404b3207 Operation settings support for Drilling. 2018-09-02 00:32:22 -07:00
Markus Lampert
353ec4a646 Added name parameter to operation proxy constructor. 2018-09-02 00:32:22 -07:00
Markus Lampert
9cd8ac46f7 Add job as parameter to opSetDefaultValues 2018-09-02 00:32:22 -07:00
Markus Lampert
9788cf047f Fix for missing base class initialisation during creation. 2017-12-02 11:06:45 -08:00
Markus Lampert
c38eee06e2 Abort OP creation transaction if TC selection is aborted with cancel, #3274 2017-11-28 12:39:02 -02:00
pekkaroi
57c7626aee Path: Allow removing of all base objects in Circular hole tools 2017-11-21 17:19:57 -03:00
Markus Lampert
4f81e26ac6 Fixed drilling depths and circular hole remove logic. 2017-09-28 11:27:47 -07:00
Markus Lampert
684b4f6e7e Added doc strings to operations. 2017-08-22 10:16:58 -03:00
Markus Lampert
84c5e717fd Added location points for drilling to base framework. 2017-08-22 10:16:58 -03:00
Markus Lampert
31c0889166 Fixed drilling tip length issue. 2017-08-22 10:16:58 -03:00
Markus Lampert
b6c31bedab Rebased Helix op on PathOp framework, also it's UI. 2017-08-22 10:16:58 -03:00
Markus Lampert
355075f7c3 Split base hole processing into separate class. 2017-08-22 10:16:58 -03:00
Markus Lampert
dbbee79378 Split DrillingGui into its own file and base it off of PathOpGui. 2017-08-22 10:16:58 -03:00
Markus Lampert
fccee0b24f Refactored PathDrilling operation using PathOp. 2017-08-22 10:16:58 -03:00
Markus Lampert
45b3233ab7 Fixed Apply button misbehaviour for drilling. 2017-08-22 10:16:58 -03:00
Markus Lampert
070ca71727 Removed Names and added support for ArchPanels again. 2017-08-22 10:16:58 -03:00
Markus Lampert
3ff47ef258 Removed Positions and replaced Enabled with Disabled. 2017-08-22 10:16:58 -03:00
Markus Lampert
e7e9722bfc Eliminated Diameter as a property. 2017-08-22 10:16:57 -03:00
Markus Lampert
354538956d Fixed tool tip length compensation and added safeguards against invalid cutting edge angles. 2017-08-13 16:21:22 -07:00
kogolbok
9b905497b6 Path: Drilling. Fix drillbit tip compensation. 2017-08-13 19:49:26 +03:00
pekkaroi
5497030fbe Path: possibility to add custom drill point 2017-08-12 13:46:25 +02:00
pekkaroi
9eac3a29e2 PATH: Clarify comment in PathDrilling 2017-08-12 13:46:25 +02:00