kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
26,352 Commits 41 Branches 6 Tags
308a5e4c6353137b215b2f964181bb99b0a97522
Commit Graph

1680 Commits

Author SHA1 Message Date
wmayer
308a5e4c63 PD: change visibility handling of sweep to support undo/redo 2021-11-11 20:21:47 +01:00
Chris Hennes
8d1735741b Merge pull request #4626 from pavltom/GUI_TreeView_Item_Ordering 
[Gui] Issue #3923 - Add arbitrary Tree View item ordering
 2021-11-10 23:35:05 -06:00
Chris Hennes
e3cdb7f875 Merge pull request #5163 from donovaly/PD-sweep-section-visibility2 
[PD] fix sweep visibility bug
 2021-11-10 22:43:49 -06:00
Uwe
7353ec0096 [PD] code improvement for FeaturePad 
as noted by @chennes in PR #5164, we should follow the C++ style guidelines:
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-if
 2021-11-11 02:26:42 +01:00
Uwe
aa0f0cd3bb [PD] code improvements for TaskPadParameters 
as requested by @chennes in PR #5164, the code can be simplified:

- remove a redundant type cast, a redundant qualifier and an inconsistent and unnecessary check
 2021-11-11 02:08:57 +01:00
Uwe
6db3337cd2 [PD] handle changed property for loft and pipe 
- this was missing in PR #5155
 2021-11-11 01:24:53 +01:00
Ajinkya Dahale
0f7f7136ce [PD] Check if property is named before strcmp 2021-11-11 01:13:17 +01:00
Uwe
7bea9e5bc5 [PD] fix sweep visibility bug 
Currently:

    only sweep path is toggled correctly in its visibility, the profile is never shown
    the sections are always shown

This PR fixes this inconsistency reported here: https://forum.freecadweb.org/viewtopic.php?f=19&t=63544
 2021-11-11 00:00:58 +01:00
Ajinkya Dahale
99bafa24e8 [PD] Clear other taskbox buttons in loft and pipe when one pressed 2021-11-10 17:59:45 +01:00
Uwe
e6837f8ef2 [PD] fix a typo 
- also some sorting
 2021-11-10 03:26:23 +01:00
Ajinkya Dahale
854b547503 [PD] Fixed loft and sweep breaking on section deletion 
Item removal in `onDeleteSection()` was also clearing subname details so if one
of the remaining sections was a face this caused a failure.
 2021-11-09 23:05:29 +01:00
Ajinkya Dahale
9cade40755 [PD] Support adding solid faces for loft and pipe sections 
With these changes, one face per solid can be added as either the first
"profile" or subsequent sections in loft and pipe.

This commit depends on `App::PropertyXLinkSubList` preserving the order in which
sections are added.

A minor change this also adds is that when a solid's face is selected that face
is mentioned in the fields instead of the solid (eg `Box:Face1` instead of
`Box`).
 2021-11-09 23:05:29 +01:00
wmayer
182a0ed882 PD: [skip ci] fix crash in ReferenceSelection::allow 2021-11-09 18:37:54 +01:00
Uwe
fe00d3ab59 [PD] fixes loft visibility on creation and modification 
- the PR fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=3&t=63252

- (also a MSVC code formatting fix)
 2021-11-07 21:57:00 +01:00
Uwe
f1bc66b323 [PD] simplify Loft code 
- also two automatic style fixes made by MSVC
 2021-11-07 19:04:38 +01:00
wmayer
b37354b28b PD: [skip ci] fix ambiguous shortcut overload in TaskDlgPipeParameters 2021-11-07 08:27:33 +01:00
Ajinkya Dahale
a24b94efc8 [PartDesign] Fix typo in method name 2021-11-06 00:03:48 +01:00
wmayer
ce95ed8047 PD: [skip ci] open a transaction when creating a new body with DlgActiveBody 2021-11-04 23:21:14 +01:00
Chris Hennes
dfa8bbc8e0 Merge pull request #5128 from luzpaz/freecad-translation-6 
PD: Expose missing commands to translation in Measure dropdown menu
 2021-11-01 00:22:28 -05:00
wmayer
ad458c423a PD: [skip ci] if no active body exists then by default pre-select the first option to create a new body 2021-10-31 12:33:48 +01:00
0penBrain
ffa6b3ce5e [PartDesign] Remove useless function overriding 
Double-click is already handled by PartDesign::ViewProvider::doubleClicked()
 Overridings in Loft & Pipe brings no specific behavior
 By removing overridings, behavioral consistency is improved both in ...
 ... undo commands & body activation management when PartDesign items ...
 ... are double-clicked
 2021-10-29 17:30:06 +02:00
Tomas Pavlicek
17f328c7a9 [Gui] Issue #3923 - Arbitrary Tree item ordering + tests 2021-10-26 19:09:34 +02:00
luz paz
d917e65c99 PD: Expose missing commands to translation in Measure dropdown menu 
Fixes https://github.com/FreeCAD/FreeCAD-translations/issues/6
 2021-10-26 10:35:21 -04:00
wmayer
c1910e644f PD: [skip ci] when creating a datum object allow user to create a body if needed 2021-10-22 20:23:16 +02:00
wmayer
50be9655e8 PD: open transaction when calling item of context-menu of sketch based features 2021-10-22 20:01:43 +02:00
wmayer
16e797362a PD: [skip ci] code cleanup 2021-10-22 19:06:57 +02:00
wmayer
f4e4ed0c25 PD: simplify code to display add/sub shape 2021-10-09 11:38:25 +02:00
wmayer
f0aa77c96d PD: simplify code to display rejected shape and move it to its own function 2021-10-08 22:32:26 +02:00
wmayer
9aa287ba7b Part: remove ViewProviderPartExt::getNormals 2021-10-08 19:34:48 +02:00
wmayer
27d65eca51 PD: do not enforce a reference axis when no profile is used to pad a face 2021-10-08 18:21:42 +02:00
wmayer
12ef275264 PD: do not set ReferenceAxis when no profile is used to pad a face 2021-10-08 17:45:59 +02:00
bartus
6766932b35 Fix linux build: undefined std:string_view 
Pop 'mesh' library c++ stranderd to c++17
Add required <string_view> header
 2021-10-03 14:36:16 +02:00
Chris Hennes
9ce6b0df94 Merge pull request #5071 from donovaly/PD-pad_along_fixes 
[PD] fixes for padding along edge
 2021-09-29 13:25:13 -05:00
Yorik van Havre
140e03301e Updated ts files 2021-09-29 14:32:12 +02:00
donovaly
7921c3f5fa [PD] fixes for padding along edge 
- handle custom direction like all other directions
- allow to view the direction vector for all directions, but only to edit for custom
- fix enabling of the length alongNormal option
- also fix a translation issue
 2021-09-29 01:11:50 +02:00
wmayer
4a47b98b16 PD: [skip ci] fix minor issues: 
* don't need to clear an empty vector
* remove two code blocks that effectively do nothing (except of producing a warning :) )
 2021-09-28 15:43:25 +02:00
Chris Hennes
7580a8364a Merge pull request #4685 from donovaly/PD-pad-direction-selection 
[PD] add feature to select pad direction via an edge
 2021-09-27 13:11:40 -05:00
Yorik van Havre
6ad3530981 Merged crowdin translations 2021-09-23 17:14:48 +02:00
donovaly
6c3661d3d9 rebase to master 2021-09-20 01:37:47 +02:00
donovaly
b868dbbe7f small fixes as suggested by @chennes 
therefore also in the helix code
 2021-09-20 00:59:17 +02:00
donovaly
7bfede97b7 [PD] add feature to select pad direction via an edge 
This was requested by users in the forum and is indeed very valuable for the usability.
 2021-09-20 00:59:16 +02:00
Chris Hennes
ccaa439d1a PD: LGTM - don't catch BaseException 2021-09-19 14:37:23 -05:00
Chris Hennes
6c532c2fda PD: Silence LGTM warning about empty block 2021-09-19 13:39:49 -05:00
troyp76
b3dbcd9ff8 Improved chamfer behavior when faces are selected 
Improved chamfer behavior when faces are selected and non equal chamfer types are used
 2021-09-18 22:03:28 +10:00
Ajinkya Dahale
28d8d808a8 PartDesign: Add new need active body dialog with option to choose body (#4949) 
* [PD] Add new need active body dialog

Intended for use wherever an active body is needed but none exists. The dialog
contains a list with the bodies present in the document, with an extra option to
make a new body. Custom text can be provided if needed.

This commit also replaces the warnings used by "new sketch" and "primitive"
command with this new dialog.

Addresses issue #4288.
 2021-09-16 12:27:46 -05:00
luz paz
909030859d PD: Fix typo in function getContiniusEdges->getContinuousEdges 
Related to PR #5029
 2021-09-15 10:11:37 -04:00
wmayer
fff27ee78b PD: fix ProfileBased::Restore to not affect sub-classes that need to handle changed property types/names 2021-09-15 15:45:24 +02:00
wmayer
2af9c5038e PD: move handling of changed properties of Transformed to handleChangedPropertyType 2021-09-15 15:20:40 +02:00
wmayer
ba2ad05983 PD: move handling of changed properties of the Chamfer/Fillet to handleChangedPropertyType 2021-09-15 15:14:14 +02:00
wmayer
fa86b0216e Mod: make sure to call the base class' handleChangedPropertyType 2021-09-15 14:07:32 +02:00