kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
24,778 Commits 41 Branches 6 Tags
317177dad6fcd0ce8738c7d550094a11c229deb2
Commit Graph

236 Commits

Author SHA1 Message Date
Yorik van Havre
a25d7cd2ec Merge pull request #4389 from marioalexis84/draft-close_button 
[0.20] [Draft] Call finish method if Close button is pressed in dumb taskdialog
 2021-04-20 11:36:03 +02:00
marioalexis
b42994fbc4 Draft: Fix regression in trimex command 2021-04-11 16:24:02 -03:00
Yorik van Havre
37ef8ee24f Merge pull request #4410 from marioalexis84/draft-snap 
Draft: Fixes #0004278: Working Plane Proxy origin hijack nearby object
 2021-03-30 13:16:14 +02:00
Yorik van Havre
7573e54d16 Merge pull request #4546 from chennes/lgtmDraftUnusedLoopVariables 
[DRAFT] Remove unused loop variable
 2021-03-30 13:04:08 +02:00
Yorik van Havre
d8fc51dcf5 Merge pull request #4625 from marioalexis84/draft-edit 
Draft: Make Edit closed wires consistent with open wires and tracker
 2021-03-30 12:50:06 +02:00
Yorik van Havre
55cb6e58eb Merge branch 'master' into draft-snap 2021-03-26 11:21:08 +01:00
Yorik van Havre
8f02f8c8f3 Merge branch 'master' into draft-close_button 2021-03-26 11:19:09 +01:00
Yorik van Havre
c4a49a5575 Merge pull request #4348 from marioalexis84/draft-coordinate_input 
[0.20] [Draft] Add global mode to enter points - Fixes #0004108
 2021-03-26 11:18:23 +01:00
marioalexis
efbdc2ec9e Draft: Clear tracker attributes when finish method is executed in gui_stretch 2021-03-20 17:12:58 -03:00
marioalexis
96d1516abe Draft: Change selectUi and makeDumbTask argument named 'callback' to 'on_close_call' 
Suggested by user @carlopav
 2021-03-20 17:12:58 -03:00
marioalexis
122a3dad59 Draft: Set reject method for working plane task dialog 2021-03-20 17:12:58 -03:00
marioalexis
a57b323e00 Draft: Call finish method if pressed Close button in dumb taskdialog 2021-03-20 17:12:58 -03:00
marioalexis
4ef6bde9a3 Draft: Make Edit closed wires consistent with open wires and tracker 2021-03-20 01:58:10 -03:00
marioalexis
bc60c93266 Draft: Fix regression in sync_snap_toolbar_button function 2021-03-14 17:14:58 -03:00
Yorik van Havre
d0eb13be15 Merge pull request #4544 from chennes/draftSnapSyncRefactor 
[DRAFT] Refactor sync_snap_toolbar_button
 2021-03-10 16:24:16 +01:00
Chris Hennes
752cb73d24 [Draft] Fix localize_vectors double definition 
LGTM identified an instance where a function was defined twice: in this
case, one version was intended to take a list of items and the second
version just a single item. Because they share the same name and number
of arguments, the second definition overrode the first. This causes no
problems in the current code because the version that takes a list is
never used. However, for consistency with the analogous
"globalize_vectors" and "globalize_vector" functions, the "localize*"
versions are changed to match that pattern. All calls in are
converted to the singular use.
 2021-03-01 09:36:21 -06:00
Chris Hennes
f018b1dedb [DRAFT] Remove unused loop variable 
LGTM is concerned about the unused loop variable in this algorithm.
While there was nothing wrong here, to eliminate the alarm the loop was
removed entirely, since Python allows the use of the multiplication
operator here to achieve the same effect.
 2021-02-28 23:18:53 -06:00
Chris Hennes
d78017f2e0 [Draft] Return once the button is found 2021-02-28 21:48:31 -06:00
Chris Hennes
58a6f05956 [DRAFT] Refactor sync_snap_toolbar_button 
LGTM objected to the re-use of the loop variable a in the algorithm.
Upon closer inspection, the algorithm in this function could be modified
to match the algorithm in sync_snap_statusbar_button (which does the
same thing to the statusbar that this does to the toolbar). This
eliminates the double-use. This change does not affect the functionality
of the routine.
 2021-02-28 21:42:46 -06:00
Chris Hennes
283d09dc1a [DRAFT] Add call to super().__init__ where missing 
Identified by LGTM. The toplevel superclass does initialize one data
member to an empty array, but this didn't appear to cause any problems.
 2021-02-27 18:21:54 +01:00
marioalexis
0efc7a3e4f Draft: Fix snap to proxy WP and BuildingParts - fixes #0004278 2021-02-23 21:40:06 -03:00
Yorik van Havre
686df593ea Draft: Applied patch from nahshon - fixes misc errors from translation fixes 2021-02-15 15:50:45 +01:00
David Osterberg
1d2c51d66f Draft: Fix regressions in Draft array 2021-02-14 01:20:06 +01:00
wmayer
2b881cccad Draft: fix syntax errors 2021-02-13 12:14:12 +01:00
Yorik van Havre
43feb585ad Draft: Fixed broken translations everywhere 2021-02-12 14:44:58 +01:00
Chris Hennes
fe7e45a7de [DRAFT] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
marioalexis
7c8c5892d0 Draft: Correct the placement in scale_with_clone - fixes #0004113 2021-02-06 23:42:22 -03:00
marioalexis
768264b7f8 Draft: Use function-specific icons in the taskbar 2021-02-01 01:26:15 -03:00
Roy-043
74d5c0a88a [Draft] Fix snap to center of faces of solids 
The code would only find a center snap on the face with index=0 of solids.

In V0.19 Part.getShape was introduced (line 399). But not all consequences were not fully implemented.

In the '# we are snapping to an edge' section (line 411) the code could be cleaned up. There is no need to check if the index of the edge is correct for the parent object since we are no longer dealing with a parent object. That portion was effectively dead code.

The '# we are snapping to a face' section (line 429 in the revised code) has been modified accordingly, which fixes the bug.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=23&t=54747
 2021-01-25 15:33:36 +01:00
marioalexis
0f33a09c10 Draft: Prevent Draft_Wire from setting a single-edge wire as closed 2021-01-22 01:16:40 -03:00
Yorik van Havre
d7d20ba484 Draft: Don't snap to ImagePlanes 2021-01-12 15:31:55 +01:00
Yorik van Havre
eb549a99d3 Draft: Added import/export buttons to Annotation styles editor dialog 2021-01-05 16:54:06 +01:00
marioalexis
4d9e29418a Draft: Fix multiple crashes when using modification functions - fixes #0004243 2021-01-02 02:15:43 -03:00
luz paz
ff96cb301e Fix typos [skip ci] 
Found via `codespell v2.1.dev0`
 2020-12-23 14:32:38 -05:00
Yorik van Havre
799a2e1f5d Reverting files wrongly committed with 5a974f824 2020-12-23 15:21:43 +01:00
Yorik van Havre
5a974f824c Updated ts files 2020-12-23 14:51:04 +01:00
Yorik van Havre
8e223cdf5d Draft: Small wording fix 2020-12-15 16:41:35 +01:00
Yorik van Havre
bc4856672f Draft: Small fixes to Draft SetStyle panel 2020-12-15 16:40:16 +01:00
luz paz
2a8c1271d5 Draft: fix header uniformity + trailing whitespace 
[skip ci]
 2020-12-11 13:19:49 +01:00
Yorik van Havre
f13c8974b5 Draft: Colored grid axes 2020-12-03 15:15:15 +01:00
marioalexis
31f30747ac Draft: Change archDimTracker text position depending on distance and scale values 2020-11-23 16:25:21 -03:00
Yorik van Havre
bff31175cb Draft: better checks for no active document 2020-11-16 13:25:12 +01:00
Yorik van Havre
23dd5fa8e2 Draft: Enabled 'apply to selected' button in SetStyle dialog 2020-11-16 12:59:44 +01:00
marioalexis
2b2524451e Draft: Fixes #0004293: Vertical dimensions can't be created in XZ and YZ working plane 2020-11-13 10:58:34 +01:00
Yorik van Havre
413d315d37 Draft: Change WP button icon to reflect current state 2020-11-10 14:45:44 +01:00
Yorik van Havre
88f5fc20b1 Draft: Condensed the Draft toolbar style buttons into one with more options 2020-11-10 14:14:18 +01:00
marioalexis
3f5caddabf Draft: Enable offset for working plane aligned with current view 2020-11-09 12:42:18 +01:00
marioalexis
a36fb60653 Draft: Improve archDimTracker class 2020-11-09 12:39:19 +01:00
marioalexis
ef2d4f2989 Draft: Fixes in gui_offset 2020-11-09 12:37:56 +01:00
Roy-043
aebf568eae Draft: Draft_Dimension_linked_geometry_fix 
Linked geometry was not handled if the selected edge started or ended at vertex zero.
 2020-10-29 19:26:55 +01:00