Commit Graph

1396 Commits

Author SHA1 Message Date
luz.paz
3253de75e9 Fix for a previous commits
Crowdin:  Sketcher/App/SketcherAnalysis remove newlines
Crowdin:  Part/AttachmentEditor/TaskAttachmentEditor.py fix previous commiit
Crowdin:  Gui/NetworkRetriever.cpp correct previous commit
2019-01-30 11:08:03 -02:00
luz.paz
d858a8609d Crowdin: Sketcher/App/SketchObject.cpp uniformity fix 2019-01-30 11:08:03 -02:00
luz.paz
c65fce6128 Crowdin: Sketcher/App/SketchAnalysis.cpp remove superflous whitespace 2019-01-30 11:08:03 -02:00
luz.paz
95f16814f6 Crowdin: Sketcher/Gui/CommandConstraints.cpp grammar fix 2019-01-30 11:08:03 -02:00
luz.paz
90841f72c1 Crowdin: Sketcher/Gui/CommandCreateGeo.cpp typo fix 2019-01-30 11:08:03 -02:00
luz.paz
0df518db8f Crowdin: Sketcher/Gui/SketchRectangularArrayDialog.ui typo fix 2019-01-30 11:08:03 -02:00
luz.paz
16653a4be9 Crowdin: Sketcher/Gui/SketcherSettings.ui whitespace fix 2019-01-30 11:08:03 -02:00
luz.paz
83c2434bd9 Crowdin: Sketcher/Gui/CommandConstraints.cpp 2019-01-30 11:08:03 -02:00
Abdullah Tahiri
7d8e566264 Sketcher: fixes #3762 2019-01-12 17:26:19 +01:00
wmayer
1f30c218e6 remove signal blocker
fixes 0003752: Preferences/Sketcher: Changing Grid size default is not respected upon creation of new Sketches
2019-01-01 18:17:23 +01:00
Yorik van Havre
41fee3bb3d Fixed wording as notifed on crowdin 2018-12-31 16:21:49 -02:00
wmayer
be5796b2d0 add method restoreFinished and reimplement it in SketchObject 2018-12-29 15:27:32 +01:00
Yorik van Havre
2ea84272fd Updated translations from crowdin 2018-12-23 13:54:30 -02:00
Mateusz Skowroński
71a8e2668d Fix GCC 8 warning: catching polymorphic type by value [-Wcatch-value=] 2018-12-23 11:05:02 -02:00
Abdullah Tahiri
e72bd857c7 Sketcher: Tangency between arcofellipse and other curves
========================================================

Surprisingly there was no code to handle arcofellipse tangencies using AngleViaPoint constraint.

fixes #3659
2018-12-20 11:59:26 -02:00
Abdullah Tahiri
2830f107ae Sketcher: Improve element widget name of external geometry
===========================================================

fixes #3719

what?
https://forum.freecadweb.org/viewtopic.php?f=3&t=32693&p=274634#p274634
2018-12-19 10:27:30 -02:00
Abdullah Tahiri
c43adafb12 Sketcher: Respect general autoconstraints setting on sketch creation
====================================================================

fixes #3727

https://www.freecadweb.org/tracker/view.php?id=3727

https://forum.freecadweb.org/viewtopic.php?f=3&t=32761
2018-12-17 18:44:56 +01:00
Abdullah Tahiri
64cd6a9082 remove experimental string from VBO and sketcher continue mode 2018-12-17 18:01:52 +01:00
wmayer
fd050c6f1d minor changes 2018-12-15 21:43:37 +01:00
Abdullah Tahiri
57b7142cd7 Sketcher: Do not recompute on geometry deletion
fixes #3642
2018-12-15 16:38:54 +01:00
Abdullah Tahiri
c88a64e8e7 Make Open vertices detection routine accesible to Python 2018-12-03 12:11:11 +01:00
Abdullah Tahiri
18e680f283 Move Open vertices detection routine to SketchAnalysis 2018-12-03 12:11:11 +01:00
wmayer
4d4f016277 only save setting if grid view is shown or not 2018-12-02 12:15:28 +01:00
Abdullah Tahiri
e654e476f6 Make show grid checkbox work again 2018-12-02 10:10:39 +01:00
luz.paz
4dc201e086 Misc. typo, grammar, and whitespace fixes
[skip ci]
2018-11-27 15:02:58 -03:00
wmayer
36e3d5ef66 Fix scan coverity issues:
CID 184350:  Null pointer dereferences
2018-11-20 15:11:43 +01:00
Abdullah Tahiri
8db80c5c99 Property: dropping isorderrelevant boolean member in favour of bit in the status of the properties 2018-11-19 11:31:09 +01:00
Abdullah Tahiri
8176b7129c SketchObject: Activate relevant propertylist order 2018-11-19 11:31:08 +01:00
wmayer
893f038717 improve whitespaces 2018-11-19 10:03:50 +01:00
Abdullah Tahiri
5705763088 Sketcher: Improving group constraint preselection
=================================================

the position obtained from the SoPath of the picked point when entering
the combined icon object is not the center of the icon, what leads to
wrong preselection or no preselection at all.

This commit uses the translation of the Constraint node, which is the same that
is used to locate the constraint icons on the screen in the first place.
2018-11-18 12:03:13 +01:00
Abdullah Tahiri
6df9b895ff Sketcher: Fillet increase debugging verbose and disable by default 2018-11-18 12:03:05 +01:00
wmayer
56db19824e Replace Base::Exception with appropriate subclass 2018-11-14 19:27:52 +01:00
wmayer
4f02b209fc fixes 0003689: Snap to grid checkbox in edit control widget does not update 2018-11-14 12:40:39 +01:00
Abdullah Tahiri
07cf5b10d7 Sketcher: Trim support multiple intersections for circles
=========================================================

The problem with ellipses:
https://forum.freecadweb.org/viewtopic.php?f=3&t=31594&sid=37481b7a6c1ae2614c9840fc27a7773e&start=60#p267248

The problem with circles:
https://forum.freecadweb.org/viewtopic.php?f=3&t=31594&sid=37481b7a6c1ae2614c9840fc27a7773e&start=60#p267536
2018-11-09 22:30:04 +01:00
Abdullah Tahiri
084c483603 Sketcher: Ellipse trim, handle multiple intersection 2018-11-09 22:30:04 +01:00
Abdullah Tahiri
4245ae6863 Sketcher: Ellipse trimming with internal aligment geometry
==========================================================

Trimming was not considering a case where an ellipse is trimmed with respect to its own internal aligment geometry.

This resulted in Coincident Constraints with PointPos = Sketcher::none, which is invalid.
2018-11-09 22:30:03 +01:00
wmayer
f6a9cfaad3 fix -Wabsolute-value 2018-11-09 12:46:36 +01:00
wmayer
fbb8e86cbf remove trailing spaces 2018-11-05 11:55:14 +01:00
wmayer
c1f19d3854 remove trailing spaces 2018-11-05 10:53:01 +01:00
wmayer
dedf42102e remove leftover of boost.signals headers 2018-11-05 00:03:36 +01:00
Abdullah Tahiri
13f589a0a6 Sketcher: Allow driven constraints when autoredundancy removal and autorecomputes active
==========================================================================================

https://forum.freecadweb.org/viewtopic.php?f=3&t=31998#p266626
2018-11-04 14:46:37 -03:00
Abdullah Tahiri
0a667889a0 Sketcher: Trim bug
==================

Trim tool fails to generate coincidence upon trimming an arc of ellipse at the end of the arc.

https://forum.freecadweb.org/viewtopic.php?f=3&t=31594&start=50#p266765
2018-11-04 14:43:24 -03:00
Abdullah Tahiri
d779e5b4b9 Sketcher: Fillet radius estimation improvement 2018-11-04 14:43:24 -03:00
Abdullah Tahiri
293e5732ad Sketcher: SketchObject Debug disabled by default 2018-11-04 14:43:24 -03:00
Abdullah Tahiri
abc7101118 Sketcher: Add DEBUG macro to SketchObject 2018-11-04 14:43:24 -03:00
Abdullah Tahiri
69d62787eb Sketcher: Intercurve fillet Improvement and delete constraint on point fix
==========================================================================

Intercurve fillet uses endpoint constraints for improved accuracy, but before this
commit was only considering a coincident constraint. Now it also considers an endpoint
tangency or perpendicular.

delConstraintOnPoint with coincidentonly=false, was not checking endpoint perpendiculars and
would therefore fail to delete them.

https://forum.freecadweb.org/viewtopic.php?f=3&t=31594&start=30#p265731
2018-11-04 14:43:24 -03:00
Abdullah Tahiri
fe78c1a037 Sketcher: Expose mass datum commands to python 2018-11-04 14:41:20 -03:00
Abdullah Tahiri
2c41e70c91 Sketcher: Mass operations on dimensionals
=========================================

This commit introduces two functions to operate on all datum constraints exclusively:

- Make all datum constraints driving or not driving, depending on the argument.
- Move all datum constraints at the end of the constraint list.

The practical use an ongoing effort towards improving the block constraint behaviour, that will be defered to 0.19
2018-11-04 14:41:20 -03:00
Abdullah Tahiri
6a1aed66e2 Sketcher: Refactor code relating to dimensional constraint checks 2018-11-04 14:41:20 -03:00
Abdullah Tahiri
8e2e5d7b6a Sketcher: Made constraints aware of whether they are dimensionals or not
========================================================================

Centralise the knowledge on whether a constraint is dimensional or not within the constraint
2018-11-04 14:41:20 -03:00