Commit Graph

1611 Commits

Author SHA1 Message Date
Russell Johnson
33008fbb17 Handle FreeCADGui module with IF: case 2019-06-13 10:55:31 -05:00
Russell Johnson
f703881ce0 revert to current FC master version 2019-06-13 10:55:30 -05:00
Russell Johnson
a7202f151f Improve code structure; correct 4th-axis depth issues 2019-06-13 10:55:30 -05:00
Russell Johnson
376486d621 Corrected test: Only 4 dogbones created
Running test in:
OS: Windows 10 (10.0)
Word size of OS: 64-bit
Word size of FreeCAD: 64-bit
Version: 0.19.16886 (Git)
Build type: Release
Branch: master
Hash: dc4fffb9735cc4eb4045f003f208f2affa4d8c5b
Python version: 3.6.8

Only yields 4 dogbones
2019-06-13 10:55:29 -05:00
Russell Johnson
1f3b3ad4e4 Integration of 4th-axis feature to PathProfileFaces
4th-axis integration should not affect current feature set
2019-06-13 10:55:29 -05:00
Russell Johnson
5bbb59501a Fix for 'reposition of job model' error
Re-structured 4th-axis implementation, completely; new structure will be easier to implement in other PathWB tools.
Changed basis for rotational pockets from job model to temporary per-rotation clones.
2019-06-13 10:55:28 -05:00
Russell Johnson
8aa27693c9 Improve 4th-axis integration
Improvements to 4th-axis readiness for other PathAreaOp based tools in PathWB.
Add guiMessage() method for rendering GUI messages to user.
2019-06-13 10:55:27 -05:00
Gauthier Brière
9bd10a3e0d [Path] Replace old grbl_post.py with new grbl_G81_post.py. (#2255)
* Replace the old grbl_post.py by grbl_G81_post.py

* Cleaned grbl_G81_post.py replacing old grbl_post.py
2019-06-13 09:14:17 -05:00
Zheng, Lei
6148d0275e Path: improve AreaPy exception handling 2019-06-11 13:24:00 +08:00
Zheng, Lei
56f42a0a2f Path: fix Area tolerance problem 2019-06-11 13:23:33 +08:00
sliptonic
7d7fdbebdf Merge pull request #2251 from realthunder/PathFix
Path: handle PathAreaOp object migration
2019-06-10 16:44:11 -05:00
sliptonic
8ceb2aedd9 Merge pull request #2245 from sliptonic/lgtm
Path: lgtm Cleanup
2019-06-10 16:43:38 -05:00
Markus Lampert
13c76d412b More TC ui import cleanup 2019-06-10 23:21:52 +02:00
brad
33b6e25582 Path: remove unnecessary imports 2019-06-10 10:50:06 -05:00
brad
5a4c49da28 Path: post processor cleanup 2019-06-10 10:50:06 -05:00
brad
361bb6e3c8 Path: remove obsolete code 2019-06-10 10:50:06 -05:00
brad
8e372108b5 Path: lgtm Cleanup 2019-06-10 10:50:06 -05:00
Zheng, Lei
d280fc575b Path: handle PathAreaOp object migration 2019-06-10 09:29:01 +08:00
brad
019ba23d0c PATH: Inspect editor now preserves last size and position 2019-06-08 08:53:24 -05:00
Markus Lampert
adceb31db3 Dressup gui import cleanup 2019-06-02 11:30:18 -07:00
Markus Lampert
b69b7a1f67 More FreeCADGui removal from Path model classes. 2019-06-02 11:03:14 -07:00
Markus Lampert
edcb39d192 Removed obsolete gui import 2019-06-02 11:03:14 -07:00
Markus Lampert
fa6fca71ad Remove unqualified gui import 2019-06-02 11:03:14 -07:00
markus
308409802a Split ToolController into model and gui. 2019-06-02 11:03:14 -07:00
markus
30f0a861e2 Moved FreeCADGui dependency from PathUtils into PathUtilsGui 2019-06-02 11:03:14 -07:00
markus
b27b6d0c1b Removed FreeCADGui dependency if Gui is not up 2019-06-02 11:03:14 -07:00
luz.paz
ec12ffae0c Path: source comment typo fixes
Found via `codespell`
2019-05-30 19:57:25 +02:00
Russell Johnson
edce531880 Increase tool count limit to 99999 2019-05-27 14:39:13 -05:00
wmayer
3fa43e8b9c fix some compiler warnings 2019-05-26 14:35:09 +02:00
lo
069746975c cmake: manually add dynamic_lookup flag to area-target 2019-05-24 14:37:33 +02:00
lo
1922c84ca0 cmake: add option to disable linking of python extension modules to python-libraries 2019-05-24 14:37:33 +02:00
wmayer
c5cf94e575 fix Path build failure 2019-05-16 12:46:02 +02:00
Abdullah Tahiri
7f551dab53 PCH: Path GUI PCH Enable 2019-05-16 12:46:02 +02:00
luz.paz
659d17129a FIx some user and non-user facing typos
Found via ` codespell -q 3 -I ../fc-word-whitelist.txt -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig* -L pard,wallthicknessOn`  
codespell version 1.15.0.dev0
2019-05-12 16:59:26 +02:00
Russell Johnson
5b9dccc690 Enable cutter and FC to OCL cutter translation
Enable self.cutter attribute
Without, 3D Surface op is non-functional
2019-05-10 22:40:32 -05:00
Yorik van Havre
636fb7b116 Updated master translation files (minor changes) 2019-05-10 23:14:36 -03:00
Yorik van Havre
2d47993780 Merged latest translations from crowdin 2019-05-10 19:19:37 -03:00
Yorik van Havre
9a1bb779c9 Updated master translation files 2019-05-10 19:15:33 -03:00
easyw
1d87008048 added try,except for OpenCamLib test 2019-05-10 13:16:16 +02:00
easyw
54f8048682 added try,except for OpenCamLib test 2019-05-10 13:15:11 +02:00
Russell Johnson
3d2a8504c8 Path: Integrate 4th-axis feature to PathPocketShape and 3D Surface ops (#2114)
* PathSurface: Add StepDown support

Add StepDown support for PathSurface operation.
A low-level optimization algorithm is included.

* Update PageOpSurfaceEdit.ui

* PathSurface: Activate CompletionMode input

Update code to use CompletionMode selection from user.

* PathSurfaceGui: Add Completion Mode selection box

Add Completion Mode selection box for user input.

* PathSurface: Use depth_params() for step control

Implemented PathUtils.depth_params() for control of step downs to maintain consistency throughout PathWB.
Suggested by Sliptonic.

* PathSurface: Improve stability - Rev3

Organized code better, improved path optimization algorithm

* PathSurface: Add XY rotational surfacing

Add options to perform 3D surfacing by rotating object around X or Y axis.

* PathSurface: update setup function

Add properties to setup function

* PathSurface: Remove extraneous code

removed commented lines that consume processing time

* PathSurface: Correct nxt.z point assignment

Corrected error in nxt.z value assignment. Was assigning value to pnt.z instead of nxt.z

* PathSurface: Update 4th axis operation

Provided both parallel and perpendicular to axis  scans when performing rotational operation.

* PathSurface: Corrected Y-axis rotation to gcode

Inverted Y-axis scan values in gcode to produce correct result

* PathSurface: Adjust gcode feed rates

Adjust feed rates for axial rotations

* PathSurface: Implement waterline alternative

Used OCL dropcutter scan as data base for python algorithm to extract a waterline.  Waterline also incorporates step down feature.

* PathSurface: Update to 3m-Usable

stability improvements
fixed step on multi-pass 4th axis scans
initiate code to accommodate cut modes: zigzag, line
initiate code to accommodate offset cutter on 4th axis scans to simulate a tilted cutter for ball end mills

* PathSurface: Update 3m-Usable_r1

change instantiated static class attributes from value None, to 0.0

* PathSurface: Revert to 3i-Usable_r1

Further testing needed for 3m-Usable release

* PathSurface: Update to Rev. 3s Usable

fixed step over in rotational scans
start/stop indexes
tilt cutter adaptation for ball end mill
cut pattern: zigzag, line partially implemented
ignore waste option initiated for planar scans
cut mode partially implemented: conventional & climb

* PathSurface: Update to Rev. 3t Usable

Corrected rotational errors
corrected cutter tilt rotation
added "ignore waste" feature for planar surface operation

* Implement 4th-axis feature

Implement 4th-axis feature:
add gcode commands for rotation
re-compute operation heights, to consider rotation radii

* Deleted reference to undeclared variable

* Added missing class attributes/variables

* Added missing class variables/attributes

* Relocate class variables to higher class

* Remove references to undeclared variables

relocated class variables here
delete references to undeclared variables

* Correct rotation direction for normal-to-Y faces

* Remove X oriented 180 degree rotation adjustment

Probable error in FreeCAD gcode renderer, producing incorrect B axis rotation

* Update 4th-axis integration

Address FC error with B axis rotation rendering: user input to override error for visual alignment with model.
Correct pocket depths with Final Depth input enforced.
Add Reverse Direction flag input for reversing direction of pocket: necessary in some use cases.
NOTE: 4th-axis throws errors with Extension Corners feature.  EC feature needs 4th-axis rotation integration when calculating extensions for a particular part feature/face.
General testing needed.

* PathSurface: Add StepDown support

Add StepDown support for PathSurface operation.
A low-level optimization algorithm is included.

* Update PageOpSurfaceEdit.ui

* PathSurface: Activate CompletionMode input

Update code to use CompletionMode selection from user.

* PathSurfaceGui: Add Completion Mode selection box

Add Completion Mode selection box for user input.

* PathSurface: Use depth_params() for step control

Implemented PathUtils.depth_params() for control of step downs to maintain consistency throughout PathWB.
Suggested by Sliptonic.

* PathSurface: Improve stability - Rev3

Organized code better, improved path optimization algorithm

* PathSurface: Add XY rotational surfacing

Add options to perform 3D surfacing by rotating object around X or Y axis.

* PathSurface: update setup function

Add properties to setup function

* PathSurface: Remove extraneous code

removed commented lines that consume processing time

* PathSurface: Correct nxt.z point assignment

Corrected error in nxt.z value assignment. Was assigning value to pnt.z instead of nxt.z

* PathSurface: Update 4th axis operation

Provided both parallel and perpendicular to axis  scans when performing rotational operation.

* PathSurface: Corrected Y-axis rotation to gcode

Inverted Y-axis scan values in gcode to produce correct result

* PathSurface: Adjust gcode feed rates

Adjust feed rates for axial rotations

* PathSurface: Implement waterline alternative

Used OCL dropcutter scan as data base for python algorithm to extract a waterline.  Waterline also incorporates step down feature.

* PathSurface: Update to 3m-Usable

stability improvements
fixed step on multi-pass 4th axis scans
initiate code to accommodate cut modes: zigzag, line
initiate code to accommodate offset cutter on 4th axis scans to simulate a tilted cutter for ball end mills

* PathSurface: Update 3m-Usable_r1

change instantiated static class attributes from value None, to 0.0

* PathSurface: Revert to 3i-Usable_r1

Further testing needed for 3m-Usable release

* PathSurface: Update to Rev. 3s Usable

fixed step over in rotational scans
start/stop indexes
tilt cutter adaptation for ball end mill
cut pattern: zigzag, line partially implemented
ignore waste option initiated for planar scans
cut mode partially implemented: conventional & climb

* PathSurface: Update to Rev. 3t Usable

Corrected rotational errors
corrected cutter tilt rotation
added "ignore waste" feature for planar surface operation

* Implement 4th-axis feature

Implement 4th-axis feature:
add gcode commands for rotation
re-compute operation heights, to consider rotation radii

* Deleted reference to undeclared variable

* Added missing class attributes/variables

* Added missing class variables/attributes

* Relocate class variables to higher class

* Remove references to undeclared variables

relocated class variables here
delete references to undeclared variables

* Remove X oriented 180 degree rotation adjustment

Probable error in FreeCAD gcode renderer, producing incorrect B axis rotation

* Correct rotation direction for normal-to-Y faces

* Update 4th-axis integration

Address FC error with B axis rotation rendering: user input to override error for visual alignment with model.
Correct pocket depths with Final Depth input enforced.
Add Reverse Direction flag input for reversing direction of pocket: necessary in some use cases.
NOTE: 4th-axis throws errors with Extension Corners feature.  EC feature needs 4th-axis rotation integration when calculating extensions for a particular part feature/face.
General testing needed.

* Apply XYZ Model translations to paths; Add rotation axis selection property

* Spelling correction

ln 110

* Geometry list box: shrink height

560 to 400 height

* Update 4th-axis integration

Clean up code
Add comments for visionary elements
Apply axis selection to opHeights rotational calculations

* Update 4th-axis integration

Prepare sorting of vertical faces per axis_angle grouping, just as horizontal faces are sorted, for analysis as connected shapes

* Reset to FreeCAD master current

* Reset to current FreeCAD master version

* Update PathPocketBase.py

* Reset to current FreeCAD master

* Corrected __created__ date

* Convert all print() to PathLog.debug()

* Convert print() to PathLog.debug(); Clean up code

Use PathLog.debug over print() for troubleshooting
Clean up large commented sections of code.

* Convert print() to PathLog.debug(); combine duplicate methods

* Update last modified stamp

* Update last mofified timestamp

Also, removed commented-out code

* Typo corrected: "selt." to "self."

Discovered in https://api.travis-ci.org/v3/job/526456071/log.txt
on 30 April 2019 while searching for errors related to failure of PR #2114

* Restore initialization of self.depthparams

PR is failing Travis CI build test. Previous deletion of this code appears to be the reason.
See report at: https://api.travis-ci.org/v3/job/526492709/log.txt

* Convert tuple sizes from other PathWB ops

* B-axis rotation: render correction

* Revert "rebase to FC master 2019-05-02"

* Correct depthparams opOnDocumentRestored() issue

* Relocate "UseRotation" property from PathAreaOp.py

* Improve meshFromShape() calculation per @sliptonic

faster mesh creation
helps smooth jagged lines in path results

* Part: Make 3rd party libraries into PCH

* PartDesign: 3rdParty to PCH

* Sketcher: PCH

* PartDesign: PCH GUI

* Sketcher: GUI PCH

* Travis windows build (#2110)

Travis windows build

* Travis: enable clcache debug

* disable travis clcache debug

* respect user settings for dialog used in merge-document command

* msbuild verbose and logo

* Travis force wait 60 minutes

* Travis: Use & between vars sourcing and msbuild

* Travis: Move building to external batch script (#2131)

* Travis: Move building to external batch script

* Travis: double quotes to escape route

* Travis: use cmd.exe to call batch file

* Crowdin: fix grammatical error + whitespace 

https://crowdin.com/translate/freecad/569/en-fi#6498705

* Crowdin: experiment to fix crowdin 'ghost' strings

The following translation strings still perpetuate after updating crowdin translations. This commit experiments with removing their source counterparts in the FC .ts files. I'm not sure why they are not rendered obsolete by the normal operations. 
  
* https://crowdin.com/translate/freecad/6766/en-en#6499472  
* https://crowdin.com/translate/freecad/6766/en-en#6573450

* fix for edit tracker draw styles

* deleted commented code

* Travis: filter out

* AddonManager: allow to add custom repositories

* Revert "rebase to FC master 2019-05-02"

* Draft: Fixed Draft text justification

* Arch: Fixed bug in arch windows creation

* Arch: Fixed export of windows colors to IFC

* Draft: Fixed 0.18.1 bug in DXF importer

* Arch: Fixed wrong exported objects in IFC export

* Arch: Fixed export of sites to IFC

* Start: Fixed bad default icon in start page

* Correct depthparams opOnDocumentRestored() issue

* Relocate "UseRotation" property from PathAreaOp.py

* Improve meshFromShape() calculation per @sliptonic

faster mesh creation
helps smooth jagged lines in path results

* Relocate "UseRotation" property in PathAreaOp.py

* Syntax correction

Travis CI python 3.7 build test fails regularly due to syntax error at this point

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* path pep8 cleanup

* Multi-face geometry selection repaired

Previous version broke ability to select process multiple faces selected by user in geometry tab in operation task window.
Also performed some syntax cleaning per PEP8 linter

* Update script version info
2019-05-06 21:29:08 -05:00
sliptonic
052a072018 Merge branch 'master' into master 2019-05-05 17:05:50 -05:00
brad
a340264311 Path: refactor PathEngrave.py 2019-05-04 17:27:45 -05:00
wmayer
320162a323 revert e7230366 to fix build failure 2019-05-04 12:36:00 +02:00
Abdullah Tahiri
635ce5cd81 Path: Add libarea to PCH 2019-05-03 23:15:09 +02:00
Abdullah Tahiri
45f44a2d9f Path: PathSimulator PCH 2019-05-03 23:15:09 +02:00
Abdullah Tahiri
36f512abce PCH: Path GUI 2019-05-03 23:15:09 +02:00
Abdullah Tahiri
c03424c70e PCH: Path App 2019-05-03 23:15:09 +02:00
luz.paz
b7b433e461 Misc. typo and whitespace fixes
Found via `codespell`
2019-04-30 10:15:59 -03:00
Patrick Felixberger
438f3d30ca Header changes 2019-04-23 20:17:29 +02:00