Commit Graph

19559 Commits

Author SHA1 Message Date
Yorik van Havre
3352ebf9a0 Merge pull request #4811 from carlopav/DraftEdit_Improvements
Draft: Edit improvements to context menu and code organization
2021-06-04 13:15:18 +02:00
0penBrain
e02902cfa2 [Sketcher] Fix 'Reference' checkbox not working for radius/diameter ; fixes #4627
As a consequence :
Remove message box when several arcs/circles are selected ...
... and enforce creation of equality constraints in this case
Former existing option of adding a dimensional constraint ...
... to each circle encouraged improper constraining
2021-06-04 06:12:51 +02:00
Yorik van Havre
d0d637b2c6 merged crowdin translations 2021-06-03 15:43:34 +02:00
Yorik van Havre
4361893f24 updated ts files 2021-06-03 15:37:33 +02:00
carlopav
267291567f Draft: Edit, cleanup of new GuiTools.addPoint methods
In new splitted addPoint methods, getObjectsInfo and the consequent checks have been removed and moved to main DraftEdit module in a new get_specific_object_info method.
This method returns the info for the selected object at a given position and the 3d Vector of the point clicked on the object.
2021-06-01 23:21:12 +02:00
carlopav
5841b737e1 Draft: Edit, moved resetTrackers for context menu actions to main module
The wrapper allows to call resetTrackers in the main module after the callback to the GuiTools is executed.

This is the last commit, many thanks to @matthijskooijman for having menthored me :)

I think it's helpful to have @matthijskooijman explanation on this use of the wrapper:

This defines a new wrapper function, that calls the original callback and then calls resetTrackers. Note that this creates a new function for every loop iteration, so each of these wrapper functions captures potentially different callback, self and obj values so things work as expected. Note I did something weird with the callback value there: Since functions like these capture a variable, not its value at the time of function definition, and loop variables like label and callback are a single variable shared between all loop iterations, capturing callback directly ends up with all wrappers calling the last callback (i.e. they all capture the same variable and by the time the wrappers are called, that variable will contain the last of the callbacks). This is commonly solved by using a default value in the function definition, since such a default value uses the value of the (in this case) callback variable, not capturing the variable.
2021-06-01 23:20:41 +02:00
carlopav
0ea4c5d2fe Draft: Edit, Added reverse wire option to context menu
Now Draft Edit can reverse the order of the points of a Draft_Wire
2021-06-01 22:53:24 +02:00
carlopav
28ced10d50 Draft: Edit, rewriting context menu system
get_edit_point_context_menu(self, edit_command, obj, node_idx)
get_edit_obj_context_menu(self, edit_command, obj, position)
that are called depending if the user is over an editpoint or over another part of the object.
2021-06-01 22:53:01 +02:00
carlopav
cc87ab4913 Draft: Edit, Split out addPoint in multiple methods in the GuiTools
Now Draft_Wire, Draft_BSpline, Draft_Bezcurve have their own methods to add points.
2021-06-01 21:57:38 +02:00
carlopav
bd02136f9d Draft: Edit, change startEditing method to accept (obj, node_idx)
This enable to start editing also without an user click event, by just calling the method and specifying the object and the edit point index.
It is used for alternative edit mode (alt_edit_mode) by arc context menu
2021-06-01 21:47:37 +02:00
carlopav
b108f66780 Draft: Edit, Remove all the empty pass functions
Remove unused functions. Since GuiTools objects inherit from the GuiTools class, they do not need those placeholders.
2021-06-01 21:47:37 +02:00
sliptonic
fd4870992b Path cleanup PathGuiInit 2021-06-01 13:15:59 -05:00
sliptonic
d23393923a Revert "[Path] Handle unavailability of Camotics library/module" 2021-06-01 12:55:48 -05:00
Yorik van Havre
f7cdb4cc04 Merge pull request #4822 from marioalexis84/draft-fillet
Draft: Add shortcut to fillet command
2021-06-01 17:01:53 +02:00
Yorik van Havre
9332e52d94 Draft: Added ExclusionPoints property to shape2dview object 2021-06-01 11:30:04 +02:00
donovaly
7436bbfa30 [Sketch] fix too long tooltips
- they were too long for smaller screens
- the other UI file changes were automatically make by Qt Designer
2021-06-01 08:12:52 +02:00
marioalexis
d363f10edf Draft: Add shortcut to fillet command 2021-05-31 16:18:36 -03:00
sliptonic
f316cb337d Revert "[PATH] CAMotics simulation. First Draft" 2021-05-31 12:49:25 -05:00
Yorik van Havre
43a2e2e640 Merge pull request #4820 from Roy-043/Draft_Fix_make_text
Draft: make_text fixed 3 small issues
2021-05-31 19:44:13 +02:00
Yorik van Havre
ff6845e2f3 OpenSCAD: Fixed typo 2021-05-31 14:54:48 +02:00
Yorik van Havre
5ddf75d358 Arch: Added arrow and bar bubble modes to Arch Axis object 2021-05-31 14:14:46 +02:00
Yorik van Havre
6b3c3a60f6 Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-05-31 10:54:49 +02:00
Roy-043
cd31a4f026 Draft: make_text fixed 3 small issues
Fixed 3 small issues in make_text that came up while working on make_label (pull request #4801).
2021-05-30 19:53:02 +02:00
sliptonic
d80d6fa844 fix cancel bug 2021-05-30 10:49:16 -05:00
Russell Johnson
71b5050707 Path: Handle unavailability of Camotics library/module 2021-05-29 13:52:00 -05:00
Russell Johnson
0a710faecc Path: Alphabetize import list and remove comments therein 2021-05-29 13:50:06 -05:00
sliptonic
f1d7a4277d removed PathUtils import from all post-processors to avoid the deleted proxy error
I removed or commented out code using this import.  In all cases,
the import was used to get descriptive information from the Job
2021-05-28 13:04:16 -05:00
sliptonic
bb50a37024 Merge pull request #4672 from sliptonic/feature/camotics2
[PATH]  CAMotics simulation.  First Draft
2021-05-28 13:03:13 -05:00
sliptonic
a9f6fad531 Merge pull request #4812 from jimzim111/patharray_multibase
Path: PathArray based on multiple bases, and choice of direction
2021-05-28 10:38:55 -05:00
sliptonic
9e795191bc add missing reference in cmakelists 2021-05-28 10:29:06 -05:00
sliptonic
ad5445d40f Initial Commit 2021-05-28 10:25:46 -05:00
Yorik van Havre
f94f4257cf Merge branch 'master' of github.com:FreeCAD/FreeCAD 2021-05-28 14:11:51 +02:00
Yorik van Havre
cc1140489e Merge pull request #4801 from Roy-043/draft_make_label_text_input
Draft: Fixed make_label to accept list of strings for custom_text
2021-05-28 13:46:10 +02:00
Yorik van Havre
750f8ae643 Merge pull request #4814 from Syres916/patch-18
[Material] Change Graphite File encoding to UTF-8
2021-05-28 13:40:26 +02:00
Russell Johnson
16015f66e3 Path: Remove first-draft rotational code Path
Remove all first-draft rotational-related code from Path workbench to make way for more stable, long-term integration of a rotational indexing capability.
2021-05-27 10:04:31 -05:00
Yorik van Havre
b1d9a5607f Merged crowdin translations 2021-05-27 14:51:33 +02:00
Yorik van Havre
c6771853ae Updated translation files 2021-05-27 14:44:40 +02:00
Roy-043
c0105690f4 Merge branch 'master' into draft_make_label_text_input 2021-05-26 16:23:22 +02:00
jim
e728c9226c Merge branch 'patharray_multibase' of https://github.com/jimzim111/FreeCAD into patharray_multibase 2021-05-25 18:37:05 -07:00
jim
815679a487 fix whitespace 2021-05-25 18:36:51 -07:00
jimzim111
a2960cd4e6 Merge branch 'master' into patharray_multibase 2021-05-25 18:34:49 -07:00
jim
b0ab46878b Clean up logic that tests whether there any base Paths to process 2021-05-25 18:34:19 -07:00
jim
9234c33db1 Hide ToolController property. TC can be chosen by the first operation in the PathArray Base property. 2021-05-25 18:24:50 -07:00
jim
4e2137b358 Wrap strings in QT_TRANSLATE_NOOP 2021-05-25 18:11:15 -07:00
Syres916
13cb80ef5e [Material] Change File encoding to UTF-8
See discussion https://forum.freecadweb.org/viewtopic.php?f=3&t=58892
2021-05-25 15:02:22 +01:00
Yorik van Havre
da53836d06 Merge pull request #4806 from meapeteze/TD_Spreadsheet_merged_cells_optimal
Fix TechDraw View Spreadsheet with merged cells, 2
2021-05-25 15:07:54 +02:00
Yorik van Havre
e6af8032e2 Merge pull request #4804 from luzpaz/Crowdin-Draft
Crowdin: fix Draft mirror code typo
2021-05-25 15:07:28 +02:00
Yorik van Havre
601d6ca466 Merge pull request #4808 from matthijskooijman/movewithhost-link-exception
Draft: Do not move children of App::Link objects
2021-05-25 15:06:55 +02:00
Yorik van Havre
0a4ea36073 Merge pull request #4805 from luzpaz/StartWB-tooltip
StartWB: Add missing tooltip for 'Show tips' preference dialog
2021-05-25 15:06:31 +02:00
Yorik van Havre
5d57496f25 Merge pull request #4809 from matthijskooijman/draft-arch-simplifications
Draft & Arch: Python code simplifications
2021-05-25 15:05:46 +02:00