Commit Graph

17757 Commits

Author SHA1 Message Date
Roy-043
611bcdd4c4 Arch: 4 additional tests for ArchRoof (bug fix)
ArchRoof bug fix:
* Removed unnecessary use of FreeCAD.Vector. Renamed some functions and variables for clarity (in this description the new names are used). Reformatted the code. Moved imports to the top of the file. Updated the tooltips. Tweaked the title text "Parameters ...".
* Fixed the length of list properties bug.
* Flip direction did not work properly. The adopted solution is to reverse the edges the roof is based on.
* Added support for consecutive parallel edges.
* Added support for zero angle roof segments.
* The code now handles zero length runs without throwing an error.
* To handle triangular roofs with a zero length eave, "eave" (egde) has been turned into "eavePtLst" (list of points).
* The ridges of opposite parallel roof segments (if they do not use a relative profile) are recalculated if the sum of their runs is larger than the distance between their edges. The old version of the command would do this only if segments connected to gables and only properly if the corners between the edges of the segments and the gable were 90 degrees.
* Revised backGable and nextGable. They now call helperGable.
* Revised the 6 other back/next functions. They now call helperSloped. This also fixes several cases where cookie-cutter outlines (profilCurr["points"]) were wrong. In nextHigher, backHigher, nextLower and backLower a point was wrongly projected on the X-axis. In nextHigher the point on the higher ridge was wrongly included.
* Improved the cookie-cutter outlines for roof segments with lower overhangs and higher ridges in corners.
* Data from a relative profile is no longer used if it in turn references a relative profile.
* Changed the default idrel to -1 and changed calcMissingData to not process this value. This avoids confusion for users who are unaware of the relative profile feature.
* Introduced find_inters as a workaround for DraftGeomUtils.findIntersection. The latter finds intersections for parallel lines that share a point. Find_inters uses a modified version of getLineIntersections from DraftGeomUtils.findIntersection.
* Calling DraftVecUtils.removeDoubles later in the program flow as it does not compares the first and the last vector.
* Avoided the QTreeWidget scrolling to the top on every change, by not clearing it but updating existing items instead.
* Added self.tree.setRootIsDecorated(False). This gets rid of the 1st column's extra left margin. Removed item.setTextAlignment(0,QtCore.Qt.AlignLeft) as this did not work.
2020-10-12 11:43:04 +02:00
Roy-043
aff5da530e Arch: ArchRoof bug fix
* Removed unnecessary use of FreeCAD.Vector. Renamed some functions and variables for clarity (in this description the new names are used). Reformatted the code. Moved imports to the top of the file. Updated the tooltips. Tweaked the title text "Parameters ...".
* Fixed the length of list properties bug.
* Flip direction did not work properly. The adopted solution is to reverse the edges the roof is based on.
* Added support for consecutive parallel edges.
* Added support for zero angle roof segments.
* The code now handles zero length runs without throwing an error.
* To handle triangular roofs with a zero length eave, "eave" (egde) has been turned into "eavePtLst" (list of points).
* The ridges of opposite parallel roof segments (if they do not use a relative profile) are recalculated if the sum of their runs is larger than the distance between their edges. The old version of the command would do this only if segments connected to gables and only properly if the corners between the edges of the segments and the gable were 90 degrees.
* Revised backGable and nextGable. They now call helperGable.
* Revised the 6 other back/next functions. They now call helperSloped. This also fixes several cases where cookie-cutter outlines (profilCurr["points"]) were wrong. In nextHigher, backHigher, nextLower and backLower a point was wrongly projected on the X-axis. In nextHigher the point on the higher ridge was wrongly included.
* Improved the cookie-cutter outlines for roof segments with lower overhangs and higher ridges in corners.
* Data from a relative profile is no longer used if it in turn references a relative profile.
* Changed the default idrel to -1 and changed calcMissingData to not process this value. This avoids confusion for users who are unaware of the relative profile feature.
* Introduced find_inters as a workaround for DraftGeomUtils.findIntersection. The latter finds intersections for parallel lines that share a point. Find_inters uses a modified version of getLineIntersections from DraftGeomUtils.findIntersection.
* Calling DraftVecUtils.removeDoubles later in the program flow as it does not compares the first and the last vector.
* Avoided the QTreeWidget scrolling to the top on every change, by not clearing it but updating existing items instead.
* Added self.tree.setRootIsDecorated(False). This gets rid of the 1st column's extra left margin. Removed item.setTextAlignment(0,QtCore.Qt.AlignLeft) as this did not work.
2020-10-12 11:43:04 +02:00
Daniel Wood
61dc5dea04 Add a task panel page for controlling turning diameters 2020-10-11 07:57:59 +01:00
Daniel Wood
66afbc36a8 Add turning selection gate 2020-10-11 07:57:59 +01:00
Markus Lampert
101a0e00ec Using python type conversion to return voronoi element color 2020-10-10 18:10:06 -07:00
wmayer
12155f4aab Part: [skip ci] harmonizing the way to add sub-modules to Part module 2020-10-10 11:44:51 +02:00
sliptonic
ed61873b2c make deburr ignore non-vertical faces
fixes #4327
2020-10-09 12:50:06 -05:00
sliptonic
b5f37f06aa make deburr check for tool attributes fixes #4327 2020-10-09 12:50:06 -05:00
wmayer
d76124b61e Part: [skip ci] fix crash when trying to convert null shape to nurbs 2020-10-09 18:54:57 +02:00
wmayer
11afaaea68 Part: [skip ci] port class TaskCheckGeometryResults to OCCT 7.5 2020-10-09 08:39:42 +02:00
wmayer
13963592f4 Part: [skip ci] fix crash when trying to scale null shape 2020-10-09 08:31:48 +02:00
wmayer
de64e6500b Part: port class BOPProgressIndicator to OCCT 7.5 2020-10-09 02:42:13 +02:00
luz paz
b0d7850406 Fix various typos [skip-ci]
Found via `codespell v2.0.dev0`  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-10-08 18:21:15 +02:00
wmayer
f91eb34355 Part: link TKStepAttr, TKStepBase and TKStep209 2020-10-08 17:24:13 +02:00
wmayer
fd9cdb9de9 Part/Import: [skip ci] disable use of Message_ProgressIndicator for OCC >= 7.5 due to major API changes 2020-10-08 14:48:35 +02:00
wmayer
16d9118919 Path: [skip ci] fix build failure on Windows if PCH is disabled 2020-10-08 10:00:31 +02:00
sliptonic
6f941c34d1 lgtm cleanup
fix contradictory tooltip
2020-10-07 16:53:52 -05:00
sliptonic
ae847efd74 Merge pull request #3934 from J-Dunn/master
PATH: G0 retraction and return speeds for grbl_post G83 expand
2020-10-07 15:15:47 -05:00
sliptonic
1816a71d27 Merge pull request #3937 from sliptonic/feature/setupreport
Path Feature:  Setup Report
2020-10-07 12:21:12 -05:00
sliptonic
55c1506904 Panel for AxisMap dressup
Zdepth correction dressup open panel on create
2020-10-07 12:17:36 -05:00
sliptonic
1e2fb1099a add task panel for dragknife 2020-10-07 12:17:36 -05:00
sliptonic
d06d5687c1 Merge pull request #3936 from sliptonic/bug/finshsteplabel
Path:  change final step down label for clarity fixes #4439
2020-10-06 18:02:05 -05:00
sliptonic
c42149b0d4 making it a bit more forgiving of old jobs/tools 2020-10-06 13:47:13 -05:00
sliptonic
cfa38c26a4 Ignore old-style tool controllers 2020-10-06 13:47:13 -05:00
sliptonic
a8a76deb87 Allow adding a material to the stock object.
Select the stock object and use the Arch Material button to add and assign
the material to the stock.

The only thing affected is the path-sanity report
2020-10-06 13:47:13 -05:00
sliptonic
dfc4e53f67 Working html report with asciidoctor 2020-10-06 13:47:13 -05:00
Bernd Hahnebach
566d32177a Arch: import IFC, support multiple styles in styled items in IFC4 2020-10-06 19:27:54 +02:00
Bernd Hahnebach
3b6e0a9342 Arch: import ifc, small fix in colors 2020-10-06 19:10:52 +02:00
Bernd Hahnebach
4c057c95bf Arch: import ifc, colors in IFC4 print warning not implemented 2020-10-06 19:08:48 +02:00
Bernd Hahnebach
6d7ed787b2 Arch: import ifc, fix typo in material colors 2020-10-06 17:20:32 +02:00
Bernd Hahnebach
8292664f49 Arch: import ifc, fix import break if colors dictionary contains None values 2020-10-06 17:16:42 +02:00
sliptonic
83c24d6105 change final step down label for clarity
issue #4439
2020-10-06 10:07:58 -05:00
sliptonic
dfb02201b7 Merge pull request #3915 from Russ4262/fix_Profile
Path: Profile - Fix rotation error and remove FinalDepth limit
2020-10-06 09:04:02 -05:00
sliptonic
33550fc11d Merge pull request #3933 from sliptonic/bug/vcarvedepth
Path:  improve vcarve to add coolant mode and set z depth from base object
2020-10-06 09:01:51 -05:00
wmayer
f8a45e6b3c PartDesign: [skip ci] remove automatic adjustment of view frustum when creating a body
In v0.17 this was needed to fix bug 2503 and was done with commit 798a57e2b7.
Now a more sensible view frustum is already set on document creation.

The automatic adjustment is even annoying now if the document is not empty and nothing is selected because
the view frustum can become too big and thus the objects appear quite small.
2020-10-06 15:32:35 +02:00
vocx-fc
f4ff61c354 Complete: do not build the Complete workbench because it is empty
If it is "built", it can be hidden by commenting out the last line
which adds it to the system:
`# Gui.addWorkbench(CompleteWorkbench())`
2020-10-06 12:34:33 +02:00
Syres916
4fbb37623a [Image] Very minor improvement to Report View..
..output
2020-10-06 12:01:32 +02:00
Bernd Hahnebach
d45e143f17 Arch: ifc import, typo in var name 2020-10-06 10:53:56 +02:00
wmayer
6badcaced6 Part: [skip ci] work around OCCT bug
For certain OCCT versions in the file ShapeUpgrade_UnifyDomain a method of the class Precision is used but Precision.hxx is not included which can lead to a build failure.
2020-10-06 08:48:53 +02:00
Matsievskiy S.V
706a014ce9 AddonManager: Fix python imports
Move misplaced imports from addonmanager_macro to addonmanager_workers
2020-10-06 08:21:04 +02:00
J-Dunn
0cc3c5cacb PATH: fast retraction and return speeds for grbl_post G83 expansion #3725
Ensure fast retraction and then plunge to just short off previous drilled depth at G0.  Fixes painfully slow air drilling which makes peck drilling impracticable.
https://forum.freecadweb.org/viewtopic.php?f=15&t=25604&p=435639#p435639
2020-10-06 01:23:18 +01:00
sliptonic
611806b26d add coolant mode
fix Z depth
2020-10-05 18:00:47 -05:00
sliptonic
027de684cb Merge pull request #3901 from J-Dunn/master
[Path] fix 3Dsurface with countersink tools
2020-10-05 14:23:48 -05:00
sliptonic
284f1c26ec Merge pull request #3930 from mlampert/bugfix/voronoi-32-bit-build-failure
PATH: Dealing with 32bit compile error of Voronoi interface.
2020-10-05 14:21:01 -05:00
Yorik van Havre
0f7979f4ae Merge branch 'master' of github.com:FreeCAD/FreeCAD into master 2020-10-05 17:28:42 +02:00
Yorik van Havre
fd21a83778 AddonManager: Fixed missing import 2020-10-05 17:03:16 +02:00
wmayer
9c20ce05ed Part: [skip ci] expose ShapeUpgrade_UnifySameDomain to Python 2020-10-05 16:57:16 +02:00
Markus Lampert
99cbb413e0 Dealing with 32bit compile error of Voronoi interface. 2020-10-04 22:44:45 -07:00
wmayer
ab4ab444b6 Path: [skip ci] fix memory leak in CommandPy::getParameters()
For some background information see: https://forum.freecadweb.org/viewtopic.php?f=15&t=50583
2020-10-04 19:43:54 +02:00
Russell Johnson
5eb5434c6a Path: Fix rotational error for certain situations
Error discovered during recent troubleshooting of Pocket_Shape with rotation.
Initial application of new operation yields path, but subsequent changes and applications failed due to `if ...` statement removed here for the fix.
2020-10-03 13:56:46 -05:00