Commit Graph

21595 Commits

Author SHA1 Message Date
Uwe
34ea32928b [PD] Pad and Pocket: remove unused includes 2022-02-19 17:57:11 +01:00
Uwe
99d469f68e [PD] Helix: remove unused includes 2022-02-19 17:18:45 +01:00
Ajinkya Dahale
61a7654094 [Sketcher] Allow multiplicity change of B-Spline end knots
The first and last knots (which are often also poles) of a B-Spline are not
represented in sketcher as knots, but as end points of the curve. This creates a
problem when we want to change the multiplicities of those knots. As a
workaround, these points are treated differently.

NOTE: While it is technically possible to have end knots in a non-periodic
spline with degree <= degree of the curve, `Geom_BSplineCurve::RemoveKnot()`
fails for the first and last knots, so we are stuck with this. So, this commit
effectively only makes knot multiplicity change possible for periodic splines.
For non-periodic splines this commit just changes the confusing "no knot is
selected" message to an unhelpful "multiplicity modification failed".
2022-02-19 16:10:43 +01:00
Ajinkya Dahale
0a02853bb7 [Sketcher] Fix some strings in CommandConstraints.cpp 2022-02-19 16:10:43 +01:00
Uwe
acb3586a5b [PD] FeatureHelix: simplify code
- also rename some variables for better readability
- remove unused includes
2022-02-19 00:48:11 +01:00
Chris Hennes
964ff6428b Addon Manager: Improve macro metadata extraction 2022-02-18 17:10:52 -06:00
sliptonic
87a93d5dff Merge pull request #6373 from Russ4262/fix/3d_surface_property_enumerations
Path: Correct restoration of 3D Surface property enumerations
2022-02-18 10:57:11 -06:00
sliptonic
3869e1eda0 Merge pull request #6391 from Russ4262/revert/extensions_waterline
Path: Remove waterline, outline, and avoid extensions
2022-02-18 10:54:33 -06:00
Ajinkya Dahale
cc8ec6dbd3 [Sketcher] Use knot insertion pointer when using that tool
Icon courtesy @bitacovir, adapted from https://forum.freecadweb.org/viewtopic.php?f=34&t=66262&p=572480#p572471.
2022-02-18 16:05:54 +01:00
Ajinkya Dahale
054f99d5bc [Sketcher] Use point-and-click for knot insertion
Here, point and click means we can move the cursor around and select a point on
the curve, instead of having to enter a value in a dialog (just like we do for
geometry creation and constraints). Continuous mode is also supported, but these
only apply to one B-Spline which should selected before pressing the tool button.

A `DrawSketchHandlerBSplineInsertKnot` is created to handle all the graphical aspects.

Finer control may be desirable but that awaits tool settings task box or similar
changes where keyboard input can be used.

Made some changes as per comments by @abdullahtahiriyo. Also change `activated`
to follow recent NVI changes.
2022-02-18 16:05:54 +01:00
Chris Hennes
743c18bae0 Addon Manager: Fix bug in error messaging 2022-02-18 08:47:39 -06:00
Chris Hennes
6396c33959 Addon Manager: Black reformat 2022-02-18 08:38:57 -06:00
Chris Hennes
d1edc70001 Addon Manager: Add error checking for proxy setup
Also make a minor tweak to the enabled status of the check all for updates button.
2022-02-18 08:37:20 -06:00
Russell Johnson
480eff20d3 Path: Remove waterline, outline, and avoid extensions 2022-02-17 23:39:44 -06:00
Russell Johnson
a708c52201 Path: Convert enable extensions button to checkbox 2022-02-17 23:10:15 -06:00
Uwe
7c11debe1a [TD] ViewProviders: remove more unused includes
- also sort the includes
2022-02-18 05:11:52 +01:00
Uwe
9b14bf80d1 [TD] ViewProviders: remove unused includes
- also sort the includes
2022-02-18 04:43:32 +01:00
Uwe
1345c4ae8e [PD] ViewProviderBody: add missing include 2022-02-18 04:25:20 +01:00
Uwe
bb49dd9622 [Part] ViewProvider2DObject: remove unused includes
- also sort them
2022-02-18 04:03:10 +01:00
Uwe
24ebf4b4bb [PD] ViewProviderDatum: sorting 2022-02-18 04:02:18 +01:00
Uwe
eff6c4c66b [PD] ViewProviderBody: remove unused includes
- also sot the includes
2022-02-18 04:01:02 +01:00
Uwe
cf290cc319 [PD] ViewProviderDatum: add missing includes 2022-02-18 03:54:02 +01:00
Uwe
41e3c1b6bb [Sketch] ViewProviderDatum/Primitive: remove unused includes
- also sort the includes
2022-02-18 03:38:49 +01:00
Uwe
fe44ae7ae5 [Sketch] ViewProviderSketch: add missing include 2022-02-18 03:27:53 +01:00
Uwe
4e974190bf [Sketch] ViewProviderSketch: remove unused includes
- also sort the includes
2022-02-18 03:15:27 +01:00
Chris Hennes
ad3449e81b Addon Manager: Force recache on custom repo change 2022-02-17 19:17:09 -06:00
Chris Hennes
e000430696 Addon Manager: Improve manual update display 2022-02-17 19:00:57 -06:00
Chris Hennes
2298e8cb41 Addon Manager: Correct displayed modification time 2022-02-17 18:31:36 -06:00
Chris Hennes
6ef54d046b Addon Manager: Add -ff-only option to pull 2022-02-17 18:26:47 -06:00
Chris Hennes
212e19eaad Addon Manager: Fix missing update button connection 2022-02-17 18:26:24 -06:00
Chris Hennes
2760b13701 Addon Manager: Fix custom repos ending in .git 2022-02-17 18:03:14 -06:00
Chris Hennes
14db94ee2d Addon Manager: Correct macro display
If the "download macros" preference is off, the macro will not yet have
a URL to load the data from. Make sure to load the macro before
attempting to display it. Also resolves the issue with macros being
unable to be installed under similar circumstances.
2022-02-17 17:28:52 -06:00
wmayer
f7392d47b9 Sketcher: fix warnings:
* fix -Winconsistent-missing-override
* fix -Woverloaded-virtual that is also a bug because the DrawSketchHandlerArcOfParabola didn't set the suitable mouse cursor
2022-02-17 21:14:37 +01:00
Abdullah Tahiri
f7741d4399 DrawSketchHandler: activation and deactivation via NVI pattern
==============================================================

With the introduction of overridable default behaviour for commands, it makes sense to keep control of the execution path of the activation and deactivation.

Non-virtual interface pattern enforces execution control of the virtual functions, while allowing the behaviour to be overriden in a case by case basis.
2022-02-17 19:37:48 +01:00
sliptonic
16a2c559aa Merge pull request #5343 from Russ4262/fix/open_edge_zero_start
[Path] Fix open edge zero value start point
2022-02-17 12:36:38 -06:00
wmayer
2fdef5ca22 PD: make sure that Attachment editor shows up the context-menu of datum objects 2022-02-17 19:28:01 +01:00
wmayer
bb2872d5de Sketch: make sure that Attachment editor shows up in the context-menu 2022-02-17 19:27:11 +01:00
wmayer
2a3d3da30d Part: in ViewProviderAttachExtension check if feature has the AttachExtension 2022-02-17 19:26:11 +01:00
Chris Hennes
629798a235 TD: Fix MSVC compilation failure
Also shifts to snprintf to eliminate overrun risk.
2022-02-17 11:33:52 -06:00
sliptonic
21e77bc4cd Merge pull request #6387 from SamuelMayer/kinetic_nc_pp
Path: Added KineticNC Postprocessor 2nd try
2022-02-17 10:01:32 -06:00
0penBrain
3eb233dc37 [Sketcher] Fix typo 2022-02-17 16:17:04 +01:00
0penBrain
6bb1fb6732 [Sketcher] Disable constraint selectability on Shift press 2022-02-17 16:17:04 +01:00
0penBrain
a12f5f2691 [Sketcher] Disable constraints selection when geometry/constraint handler is active 2022-02-17 16:17:04 +01:00
edi271
3b16914a9c Update CommandExtensionDims.cpp 2022-02-17 10:05:56 -05:00
edi271
7efa2d69d5 Update CommandExtensionDims.cpp 2022-02-17 10:05:56 -05:00
edi271
226908bb66 Update TaskCustomizeFormat.ui 2022-02-17 10:05:56 -05:00
edi271
2a30032c7d New extension tool: cutomize format 2022-02-17 10:05:56 -05:00
edi271
281e18a353 Icons and Ui-files 2022-02-17 10:05:56 -05:00
edi271
4744ec5103 Force tree update 2022-02-17 10:05:56 -05:00
Yorik van Havre
a242ae0f52 Merge pull request #6355 from Roy-043/Draft-Housekeeping-call-'make'-functions-with-new-name-(3)
Draft: Housekeeping: call 'make' functions with new name (3)
2022-02-17 11:40:59 +01:00