Uwe
38cc6f29e0
[PD] Pad /Pocket: remove unused code
2022-01-08 03:24:09 +01:00
Uwe
5aadc54d18
[PD] Pad/Pocket: fix reverse behavior
...
- bring back intended behavior as in FC 0.19:
- if 2 lengths, then midplane is invisible
- if reversed checked, then no symmetric and if symmetric then no reverse
- unify the code for Pad and Pocket (reversed is always visible)
- fix a typo in a bool name
2022-01-08 01:15:23 +01:00
Uwe
9a8e055cc6
[PD] Hole: fix angle constraints
...
- all 3 angles cannot be >= 180°
- also add missing minimum in UI for taper angle
2022-01-07 20:38:05 +01:00
Uwe
7c158a3751
[PD] rename a UI file
...
Pad and Pocket share the same UI file therefore change the name to make this clear that changes in that file must be handled for Pad and Pocket
2022-01-07 20:36:29 +01:00
Uwe
ccc45659b0
[PD] correct copyright
...
these files were added by Werner in 2020
2022-01-06 21:56:53 +01:00
Uwe
a6b01fa1f0
[PD] Hole: some coding style fixes
...
all done by MSVC
2022-01-06 16:18:25 +01:00
Uwe
8df64b7426
[PD] add missing hole constraint
...
- add missing constraint for hole diameter
- add missing sets of angle constraints in the task dialog
2022-01-06 15:39:13 +01:00
mwganson
977b602469
[PartDesign] Chamfer and Fillet, select all edges for the user when no subobjects have been selected prior to executing command
2022-01-05 01:40:10 +01:00
Jonas Bähr
d70faa1f5e
PD: helix cleanup: remove unused strings from task panel ui
...
Since the tool tips are now set from the property descriptions we don't
need them any more in the .ui file. Removing them prevents garbage in
the translation source files.
2022-01-03 11:40:29 +01:00
Jonas Bähr
88063627d2
PD: Use the helix property docs as tooltip in the task panel
...
By reusing the property docs as tooltip we avoid maintaining the same
information in two places. The propery descriptions have been made
translatable, too, to ensure a fully translatable UI.
The ground work for this was layed by the work on Issue 0002524, long
time ago: https://tracker.freecadweb.org/view.php?id=0002524
2022-01-03 11:40:29 +01:00
wmayer
175ceb2d12
PD: [skip ci] remove obsolete TaskPocketParameters.ui
2022-01-01 11:50:43 +01:00
wmayer
c855a3072e
PD: fix bug in TaskDressUpParameters::KeyEvent and simplify code
2021-12-31 17:03:16 +01:00
wmayer
e1b03bc0eb
[skip ci] fix some typos
2021-12-31 14:03:51 +01:00
mwganson
a930d4ebac
[PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode
2021-12-31 14:01:43 +01:00
Yorik van Havre
6cb3782c03
Merged crowdin translations
2021-12-29 12:20:12 +01:00
Zheng, Lei
d286a54fc1
PartDesign: show error on SubShapeBinder CopyOnChange failure
...
The failure is not obivous as it would have been occurred in a
hidden temporary document.
2021-12-21 21:41:02 -07:00
Zheng, Lei
2bd4404afb
PartDesign: expose SubShapeBinderPython
2021-12-21 21:41:02 -07:00
Zheng, Lei
39c04e4877
PartDesign: support CopyOnChange in SubShapeBinder
2021-12-21 21:41:02 -07:00
Uwe
c5f87d8ea8
[PD] hole dialog improvements
...
- no keyboard tracking
- don't disable labels since we don't do this for the other dialog labels
- avoid a doubled word in subsequent labels
- further UI file changes are by Qt's Designer
2021-12-22 02:46:07 +01:00
Uwe
9770449be7
[PD] fix several hole thread issues
...
- actually use specified thread depth, fixes issue reported here: https://github.com/FreeCAD/FreeCAD/pull/4274#issuecomment-997787744
- fixes 2 UI enabling issues
- the thread depth cannot be longer than the hole depth
- the hole cannot be deeper than the through-all depth
2021-12-22 01:09:06 +01:00
wmayer
6d4d433080
PD: [skip ci] improve readability of argument list
2021-12-19 22:02:08 +01:00
Uwe
3d03f0a468
[PD] style improvements for Helix
...
all done automatically by MSVC
2021-12-19 17:52:33 +01:00
Jonas Bähr
bb3d02298d
PD: Fix assignment of Angle/Growth properties
...
Depending on the input mode, either `Growth` or `Angle` is used to create
a conical or flat spiral. The respective other can easily be calculated
to give consistent view. This is already done for the other properties,
e.g. `Height` is calculated from `Pitch` and `Turns`.
With this patch, the same is done for `Angle` and `Growth`.
2021-12-19 16:21:51 +01:00
luz paz
a5bfba2665
PD: Adjust header uniformity
2021-12-16 23:55:48 +01:00
wmayer
8a2ea97276
PD: support of wires in ReferenceHighlighter
2021-12-15 16:25:06 +01:00
wmayer
5bef110491
PD: do not throw an exception in TaskSketchBasedParameters::make2DLabel as otherwise editing a broken loft/pipe won't be possible
2021-12-15 15:36:36 +01:00
wmayer
94d8a2034a
PD: hide the sections of a loft only if it can be recomputed successfully
2021-12-15 15:13:33 +01:00
wmayer
a87c8dca31
PD: hide the profile of a sketch based feature only if it can be recomputed successfully
2021-12-15 15:13:03 +01:00
wmayer
2d9c403cc0
PD: in ViewProviderLoft::highlightSection follow the same logic as in Loft::execute for selected profiles/sections
2021-12-14 00:30:59 +01:00
wmayer
df76209f58
PD: use class ReferenceHighlighter inside ViewProviderDressUp
2021-12-13 16:56:48 +01:00
wmayer
418ef59625
PD: use class ReferenceHighlighter inside ViewProviderPipe
2021-12-13 15:58:55 +01:00
wmayer
098927fb54
PD: properly reset line colors when un-highlighting loft profile/sections
2021-12-13 15:46:04 +01:00
wmayer
6289ff40d5
PD: highlight current profile and sections of a loft when selecting a new profile/section
2021-12-13 15:01:08 +01:00
wmayer
2b65ef8fcf
PD: make Loft working again when two sketches are pre-selected
2021-12-13 10:32:40 +01:00
luz paz
b6f9f39ffc
Fix various typos and grammatical refinements
2021-12-09 08:57:52 -06:00
wmayer
208237d2e6
PD: 0004582: Mulit-transformation dialog cannot be cancelled
2021-12-09 06:13:25 +01:00
wmayer
ca5c799ce2
Gui: rename methods of SelectionObserver to clarify intention in client code
2021-12-07 14:17:07 +01:00
wmayer
ce88fa2052
PD: enable selection only on request and disable it after selecting an object
2021-12-07 13:06:48 +01:00
wmayer
a27b3067ba
PD: eliminate the boolean argument from TaskSketchBasedParameters::onSelectReference
2021-12-07 11:04:22 +01:00
Uwe
1e4c7a2de9
[PD] improve selection mode exit for Helix
...
exit the selection mode if selection was got - like we do it for all other PD features
2021-12-07 04:18:33 +01:00
wmayer
8df497b08e
Gui: move methods startDefaultEditMode() and addDefaultAction() to ViewProviderDocumentObject
2021-12-06 19:24:26 +01:00
wmayer
e71051f4f0
PD: 0004742: Editing features by context menu may not be undoable
2021-12-06 14:11:10 +01:00
Uwe
3cef5da1ad
[PD] fix division by zero in Helix
...
- when a helix is defined in the growth mode it can have a pitch of zero
This commit fixes the resulting division by zero by directly setting the known turns
2021-12-06 02:40:34 +01:00
Uwe
1af3755a17
[PD] add missing tooltips for Helix dialog
2021-12-05 19:21:27 +01:00
wmayer
6e52161dce
PD: refactor ReferenceSelection
2021-12-03 21:38:28 +01:00
wmayer
543024e078
PD: comment out dead code
2021-12-03 20:18:46 +01:00
0penBrain
7aef0b3de7
[Gui] UserEditMode : fix operating on PartDesignObject
2021-12-03 16:53:30 +01:00
wmayer
fab96e2151
PD: avoid include generated .ui file in header file
2021-12-03 15:59:15 +01:00
wmayer
c64d86274c
PD: minor cleanup in view provider headers
2021-12-03 15:58:23 +01:00
wmayer
3ee1d91b88
PD: cleanup the mess with boolean arguments and replace them with a bitmask
2021-12-03 14:46:19 +01:00