Chris Hennes
7b33ba361b
[OpenSCAD] Minor fixes from LGTM analysis
2021-03-09 15:58:07 +01:00
David Osterberg
80af82a4fe
PartDesign: Hole performance: Compound holes and cut once
...
- Remove unused code
- BooleanOperation trick
For some reason doing the cut in a boolean operation is
20% faster than doing it directly. Unclear why.
2021-03-08 15:30:24 +01:00
guskog
94b1fbb58b
Gui: Sketcher Color Preferences UI rearrangement.
2021-03-08 15:11:42 +01:00
Gustav Skog
0e9b8ef4d4
Reworked Prefereces Sketcher Colors User interface, adding groupings.
2021-03-08 15:06:51 +01:00
UR-0
95b7c5074d
[FEM] improve error message if gmsh.exe not found
2021-03-08 14:26:08 +01:00
UR-0
a48c7e27a9
satisfy Travis
2021-03-07 11:24:20 +01:00
UR-0
eceea653ae
[FEM] make ccx_dat_file object (from ccx_Result) ReadOnly
2021-03-07 11:24:20 +01:00
Benjamin Nauck
f6c9cc90ee
[Base] Remove includes to StdStlTools.h as that's not needed anymore
...
std::make_unique was introduced in c++14, so no need to use the back
ported version
2021-03-06 21:20:32 +01:00
Chris Hennes
7bbff520a0
Modify Python checks when cMake >= 3.12
2021-03-06 21:11:34 +01:00
UR-0
0274b039a2
fixes not handled exception in "task_mesh_gmsh.py"
...
error = sys.exc_info()[0].strip()
<class 'AttributeError'>: type object 'RuntimeError' has no attribute 'strip'
Furthermore reporting "value" instead of "type" gives more useful error messages
2021-03-06 21:00:23 +01:00
Benjamin Nauck
41de6c3d99
[Spreadsheet] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
505ba29c6b
[Sketcher] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
babe8c2487
[Sandbox] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
fabcbf76d4
[Robot] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
e7024f5db3
[Points] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
991dbd75c5
[Path] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
f555754810
[MeshPart] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
7ec00e22f0
[Fem] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
5caa4b9a55
[Assembly] Use std::shared_ptr instead of boost::shared_ptr
...
There's no need to use boost version when stl has support for shared_ptr
2021-03-06 19:32:03 +01:00
Benjamin Nauck
afb1d0fbc9
[Path] Switch from boost::tuple to std::tuple
...
It's better to use the standard lib when possible
2021-03-06 19:31:06 +01:00
Russell Johnson
c087c18fbe
Path: Remove 'verify final depth' warning
2021-03-06 11:44:06 -06:00
Chris Hennes
b2ebaa01a2
[OpenSCAD] Add unit tests for importing primitives
2021-03-06 13:31:09 +01:00
wmayer
f6863bdb77
Fem: [skip ci] set backend of matplotlib to Qt5Agg
2021-03-05 21:25:27 +01:00
wmayer
f85478155b
Revert "[PartDesign] Add Material property to Body"
...
This reverts commit 4fcf8f199c .
There is no need to make this a static property because it can be added at runtime via Python or the GUI
2021-03-04 18:50:57 +01:00
Yorik van Havre
7b87cc8a74
Merge pull request #4549 from chennes/lgtmFixDraftLocalizeVectors
...
[Draft] Fix localize_vectors double definition
2021-03-04 12:27:05 +01:00
howetuft
4fcf8f199c
[PartDesign] Add Material property to Body
2021-03-04 12:19:50 +01:00
wmayer
55896f316e
PD: [skip ci] in the helix dialog use step size of 5 degree for the angle
2021-03-04 11:09:54 +01:00
donovaly
965250246a
[PD] use same helix angle step as for other features
...
All other PD features use a step size of 1.0 for angles.
(Personally also for me a step of 5 is not convenient)
2021-03-04 11:08:41 +01:00
donovaly
249c2c7970
[PD] set App constraints for their Gui counterparts
...
based on Werner's work yesterday, this PR takes care of the missing PD features to use the constraints already defined in App
2021-03-04 11:03:24 +01:00
00001000bit
39d82a8d5d
Update icon for Sketcher Constraint Block
...
The existing icon for the sketcher constraint for "constraint block" is easily confused with the icon for the diameter constraint. A small modification to add a 2nd cross bar will visually distinguish it.
2021-03-04 10:23:10 +01:00
wmayer
ac23438eb6
PD: [skip ci] in the helix task dialog use the value range defined in the helix feature
2021-03-03 17:40:11 +01:00
donovaly
f982112e24
[PD] set constraints for helix properties
...
at the moment it is possible by a click to set e.g. -1 turn which would cause an error
2021-03-03 17:25:40 +01:00
David Osterberg
318972ce70
PartDesign: Allow customization of Helix preview modes
2021-03-03 17:15:08 +01:00
M G Berberich
d1439107df
[PD] fixes problem with the path for user-defined hole-cut-types
...
https://forum.freecadweb.org/viewtopic.php?f=19&t=51403&start=20#p482574
2021-03-03 16:02:17 +01:00
donovaly
3704ad68d8
[PD] make constraints static class member
...
the MSVC IDE warned me about different floatAngle definitions in PD
2021-03-03 15:58:22 +01:00
donovaly
42bf2c8285
[PD] attempt to use more reasonable angle limit for drafts
...
using e.g. 89.999 as angle works. It might not be useful in real life, but the 89.99 seem arbitrary.
2021-03-03 15:56:21 +01:00
wmayer
0f3e98588f
PD: AddressSanitizer: heap-use-after-free
...
Fix crash inside TaskDlgSketchBasedParameters::reject()
2021-03-03 15:53:12 +01:00
wmayer
036c6b0d25
PD: improve task panel for revolution/groove:
...
* set range Angle property to spin box
* connect signals after initializing widgets to avoid superfluous recomputes
2021-03-03 15:42:48 +01:00
wmayer
bc1b9ea1bb
PD: [skip ci] set value range to angle spin box
2021-03-03 15:22:53 +01:00
wmayer
3694da3102
PD: [skip ci] fix angle checks for groove and revolution
2021-03-03 14:56:16 +01:00
wmayer
3e7429d163
PD: [skip ci] set angle constraints for groove
2021-03-03 14:55:19 +01:00
donovaly
c0de42335b
[PD] disallow angles <=0 for holes and revolution
...
neither the taper, drill or countersink angle can be zero or negative for a valid hole, thus set a constraint
2021-03-03 14:33:01 +01:00
wmayer
eccc5bfe1a
PD: [skip ci] fix angle check in PolarPattern::getTransformations()
2021-03-03 10:39:41 +01:00
wmayer
832174641c
PD: improve task panel for polar patterns:
...
* set range of Occurrences property to spin box
* connect signals after initializing widgets to avoid superfluous recomputes and possible inconsistencies
2021-03-03 10:32:46 +01:00
wmayer
2d54d838cf
PD: improve task panel for linear patterns:
...
* set range of Occurrences property to spin box
* connect signals after initializing widgets to avoid superfluous recomputes and possible inconsistencies
2021-03-03 10:32:02 +01:00
donovaly
7f1b47d118
[PD] disallow invalid polar and linear pattern settings
...
as discussed in 356db441a6 we should disallow invalid property settings
2021-03-03 07:45:08 +01:00
luz paz
cb81426e63
Crowdin: remove trailing whitespace [skip ci]
2021-03-02 17:29:21 +01:00
wmayer
89b094683f
Gui: support to customize the font size of bounding boxes
2021-03-02 16:29:57 +01:00
David Osterberg
43bc30da84
Beautify xml step 1: These changes do not affect the uic output
2021-03-02 16:29:11 +01:00
Chris Hennes
62ebad19d6
[Arch] LGTM issues in Dice3DS
...
LGTM identified a few minor issues in the Dice3DS code -- none of them
appear to be real errors, so the changes here should not affect the
behavior of the code.
2021-03-01 10:35:39 -06:00