Commit Graph

35 Commits

Author SHA1 Message Date
berniev
da9ebc572f Mod: redundant void 2 2022-08-08 10:27:50 +02:00
Uwe
697e88aed6 [PD] remove more superfluous nullptr checks 2022-07-18 01:33:28 +02:00
wmayer
3608ee7f51 PD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
9ef2470799 PD: Fix several coverity issues:
* CID 350558: Uninitialized pointer field
* CID 350554: Uninitialized pointer field
* CID 350589: Uninitialized pointer field
* CID 350608: Uninitialized pointer field
* CID 350544: Uncaught exception
* CID 350568: Uncaught exception
* CID 350603: Uncaught exception
* CID 350562: Unchecked dynamic_cast
* CID 350591: Unchecked dynamic_cast
* CID 350583: Unchecked dynamic_cast
* CID 350598: Unchecked dynamic_cast
2022-03-13 16:32:19 +01:00
Uwe
7c8031d356 [PD] Hole, Pipe and Revolution: remove unused includes 2022-02-19 18:47:26 +01:00
wmayer
af868ed079 PD: move ReferenceHighlighter to Part module 2022-01-18 18:24:02 +01:00
wmayer
418ef59625 PD: use class ReferenceHighlighter inside ViewProviderPipe 2021-12-13 15:58:55 +01:00
wmayer
e71051f4f0 PD: 0004742: Editing features by context menu may not be undoable 2021-12-06 14:11:10 +01:00
0penBrain
0bd0ec5ed2 [PartDesign] Remove useless function overriding
Double-click is already handled by PartDesign::ViewProvider::doubleClicked()
 Overridings in Loft & Pipe brings no specific behavior
 By removing overridings, behavioral consistency is improved both in ...
 ... undo commands & body activation management when PartDesign items ...
 ... are double-clicked
2021-10-29 17:30:06 +02:00
David Osterberg
17af884e50 PartDesign: Fix broken outdated icon filenames
This fixes some cases that were missed in commit 2834075d6a
2021-02-12 17:46:27 +01:00
Abdullah Tahiri
87c9f83bd6 Gui: Colorful/Greyable overlay status in icons
===============================================

Before this implementation, specific status via former mergeOverlayIcon() was greyed out
with the visibility.

With this commit, the developer has two options:

a) override mergeGreyableOverlayIcons, in which case the overlay will
be greyed out when the item is greyed out as per former mergeOverlayIcon()

b) override mergeColorfulOverlayIcons, in which case the overlay will
be superimposed after the icon is greyed out as it is the case for stardard
error and recompute flags.
2021-01-06 13:54:00 +01:00
wmayer
901ee4e5e1 PD: [skip ci] fix msvc warning 2020-09-21 13:28:56 +02:00
wmayer
b9e5bce0f0 PD: improve reference highlighting of a pipe
This change allows to highlight the spline, auxiliary spine, profile and sections of a pipe.
This gives the user a much better feedback of what external shapes are already used to build the pipe
2020-09-17 16:19:38 +02:00
Zheng, Lei
11a93a0578 PartDesign changes
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
2019-08-17 15:15:47 +02:00
Abdullah Tahiri
2ac5707072 PartDesign: Refactor set/remove tip in the new Gui::ViewProvider mechanism 2019-06-23 01:03:35 +02:00
Abdullah Tahiri
e82c154d1d PartDesign: PCH GUI 2019-05-02 07:12:51 +02:00
Abdullah Tahiri
7acdd87bf2 fixes #3724 2018-12-14 19:26:30 +01:00
wmayer
3653d7ed11 fixes 0003148: PartDesign does not allow colouring of single faces for non-primitives 2018-09-24 19:30:36 +02:00
wmayer
14985a8b0b fix typos 2017-09-25 22:36:31 +02:00
Kurt Kremitzki
0d3f5b114c PDN: Fix Pipe claimChildren to only grab sketches 2017-08-12 14:48:14 +02:00
Kurt Kremitzki
7f34faa8b8 PDN: Make Loft and Pipe claim children correctly 2017-07-26 23:16:12 +02:00
Ajinkya Dahale
7a9fecbbf0 Minor bug in PartDesignGui::ViewProviderPipe
Assert excludes any "Edge1"
2017-02-01 09:08:05 +05:30
Stefan Tröger
c5ca99658b PartDesign: Fix pipe preview display
When a base feature was available the preview mode did not show the pipe and also set the visibility of the pipe to false
2016-05-18 23:53:49 +02:00
Mateusz Skowroński
b5519922d8 QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1().
This change is Qt4/Qt5 neutral.
2016-04-15 11:55:12 +02:00
Stefan Tröger
d7e52f11a7 PartDesign: Fix context menus 2016-04-12 18:12:23 +02:00
Stefan Tröger
64de3b64e1 PartDesign: prevent claiming features 2016-04-12 18:12:23 +02:00
Stefan Tröger
f712f5e4ac PartDesign: Modeling features work with faces
-Rename Sketchbased to ProfileBased to show new behavior
-Adopt ProfileBased to make the relevant helper functions work with faces too
-Adopt features for unified use of helper functions
-Adopt commands to allow face selection
2016-04-12 18:12:22 +02:00
Alexander Golubev
0cfc0cd424 Fix warnings introduced in new PartDesign
Mostly unused wariables and compare of signed & unsigned
2016-04-12 18:12:21 +02:00
Alexander Golubev
c782a11aab PartDesign/Gui: Move various utility stuff from Workbench to a separate file
Also do some header cleanup.
2016-04-12 18:12:17 +02:00
Stefan Tröger
ab2cc10ac7 add missing return value 2016-04-12 18:12:09 +02:00
Stefan Tröger
84cd1588d0 Update pipe icon and add it to the taskwatcher 2016-04-12 18:12:09 +02:00
Stefan Tröger
68ee7f4f27 add two scaling modes 2016-04-12 18:12:09 +02:00
Stefan Tröger
d796ca2bf9 better pipe view handling 2016-04-12 18:12:09 +02:00
Stefan Tröger
342ba89afd generalize preview mode 2016-04-12 18:12:09 +02:00
Stefan Tröger
e7803eca61 add basic part design pipe infrastructure 2016-04-12 18:12:09 +02:00