Commit Graph

14 Commits

Author SHA1 Message Date
wmayer
e30a42b647 Core: Fix compiler warning 2024-10-28 19:06:31 +01:00
Pieter Hijma
4bb45cb70d Gui: Make VarSet dialog modal
Also tracks its own transactions to prevent interfering with other
transactions.
2024-10-28 17:33:14 +01:00
Pieter Hijma
b1709292a0 Gui: Fix tooltip/documentation in VarSet dialog 2024-10-24 23:01:12 -05:00
Pieter Hijma
e71a4ebeb7 Core: Fix VarSet add property dialog Esc segfault (#17215)
* Core: Fix VarSet add property dialog Esc segfault

* Core: Improve the way disconnect is handled

* Core: Add a check for a non-existing property
2024-10-17 20:14:50 -05:00
Pieter Hijma
68817a104e Gui: Fix showing multiple dialogs VarSet add prop 2024-10-11 08:55:15 -05:00
Kris Wilk
d1c04fd193 Prevent using reserved names for properties or aliases (Fix #16846) (#16902)
* Prevent naming properties with reserved words (Fix #16846)

* Prevent using reserved constant names for properties or aliases

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* App: Add unit test for isTokenAConstant

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-10-03 10:03:10 -05:00
wmayer
dad175cee9 MSVC: Fix several compiler warnings 2024-09-12 11:58:36 +02:00
Pieter Hijma
065d43f71b Core: Fix adding VarSet props with existing prefix 2024-08-12 11:44:24 -04:00
Chris Hennes
58eae9df6b Merge pull request #15172 from Ondsel-Development/varset-property-types
Gui: Handle various property types better in VarSet dialog
2024-07-15 11:24:46 -05:00
Pieter Hijma
3a76828b1e Gui: Add font data to VarSet dialog 2024-07-15 11:13:11 +02:00
Pieter Hijma
855d3e5325 Gui: Handle property types better in VarSet dialog
This makes a distinction between types that cannot be instantiated and
types without an editor (editing values can be done in the property
view).  It adapts to DlgAddProperty.* using the same mechanism to filter
properties.
2024-07-15 09:38:29 +02:00
Pieter Hijma
fc6120b8dd Gui: Prevent invalid editors in VarSet dialog
In the VarSet dialog, we can create an editor after the name and type
has been determined.  However, if the name is changed after an editor
has been created, the editor is invalid because the underlying property
has been removed.  In that case, the function onNameDetermined() should
clean up the invalid editor and this happens in most cases.
Unfortunately, it cannot handle the case in which a click happens on the
invalid editor itself.  This click should result in onNameDetermined() but
since the editor is already invalid, onNameDetermined() is triggered too
late.

The current commit solves this by listening for every change in the name
of the property and handle the editors accordingly.
2024-07-13 22:51:46 -05:00
Pieter Hijma
673b81cf6a Core: Adapt to new-style editor connect()
Use the new-style connect() in createEditor that has been introduced by
\#14004
2024-05-21 11:04:19 +02:00
Pieter Hijma
b5b4b0cba9 Core: Add a dialog to add properties to a VarSet 2024-05-21 09:59:49 +02:00