Commit Graph

272 Commits

Author SHA1 Message Date
Markus Lampert
3c4bccbf6c Fixed parabola calculation if vornonoi edge starts close to its location. 2020-10-25 16:33:13 -07:00
Markus Lampert
0d747d7abd Fixed voronoi parabola creation with correct orientation. 2020-10-25 16:33:13 -07:00
Markus Lampert
35da5c890c Replaced toGeom with toPoint for VoronoiVertex and toShape for VoronoiEdge - results in arbitrary orientation of parabola for multiple z 2020-10-25 16:33:13 -07:00
Markus Lampert
d3615f7e54 Added equal/not equal comparison to voronoi python objects with unit tests. 2020-10-25 16:33:13 -07:00
Priit Laes
961e4d75b1 build: boost: Clean up branches requiring boost-1.55 2020-10-13 12:56:28 +02:00
Markus Lampert
574bdd2d09 Using python type conversion to return voronoi element color 2020-10-10 18:10:06 -07:00
luz paz
df93939be3 Fix various typos [skip-ci]
Found via `codespell v2.0.dev0`  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-10-08 18:21:15 +02:00
wmayer
0c1f17d516 Path: [skip ci] fix build failure on Windows if PCH is disabled 2020-10-08 10:00:31 +02:00
Markus Lampert
7ea1bb0cb7 Dealing with 32bit compile error of Voronoi interface. 2020-10-04 22:44:45 -07:00
wmayer
0cc65089c4 Path: [skip ci] fix memory leak in CommandPy::getParameters()
For some background information see: https://forum.freecadweb.org/viewtopic.php?f=15&t=50583
2020-10-04 19:43:54 +02:00
Markus Lampert
a71632b914 More integer type cleanup for the voronoi python interface 2020-09-29 19:50:33 -05:00
Markus Lampert
68fecf9a90 Unified voronoi indices for python to be of type long 2020-09-29 14:58:42 -05:00
Markus Lampert
c3306582bf Added voronoi colorExterior case where one external vertex coincides with a point of an input segment. 2020-09-28 14:58:08 -05:00
Markus Lampert
81a7341632 Added vertex cache to voronoi colorExterior callback processing - cuts execution time in half. 2020-09-28 14:58:08 -05:00
Markus Lampert
67ded9cbfa Added retrieval of points and segments for voronoi diagram 2020-09-28 14:58:08 -05:00
Markus Lampert
3a50f84ba4 Added Index as attribute of all voronoi objects for easier debugging 2020-09-28 14:58:08 -05:00
Markus Lampert
e3adbc0bf9 Simplified and further optimised colinear colorisation 2020-09-28 14:58:08 -05:00
Markus Lampert
65b2cc1f48 Added color -1 to mean resetting all color. 2020-09-28 14:58:08 -05:00
Markus Lampert
32cc97b1a7 Some algorithm optimisations 2020-09-28 14:58:08 -05:00
Markus Lampert
08e73632ec Added callback to colorExterior to also color 'interior' 2020-09-28 14:58:08 -05:00
Markus Lampert
7e6975a154 Added colorColinear and resetColor algorithms 2020-09-28 14:58:08 -05:00
Markus Lampert
10ce91f873 Added optional scaling factor to Voronoi construction. 2020-09-28 14:58:08 -05:00
Markus Lampert
0045a04d4b Added scaling to micro meters 2020-09-28 14:58:08 -05:00
Markus Lampert
afdf41f716 Added support for distances of edge end points. 2020-09-28 14:58:08 -05:00
Markus Lampert
8d68122ec1 Added api calls for coloring all twins and coloring exterior edges and vertices. 2020-09-28 14:58:08 -05:00
Markus Lampert
42b074c0dd Added toGeom for curved edges. 2020-09-28 14:58:08 -05:00
Markus Lampert
8f16b94669 Added geometries for vertices and linear edges. 2020-09-28 14:58:08 -05:00
Markus Lampert
bbd2c049a9 Added support for voronoi cells 2020-09-28 14:58:08 -05:00
Markus Lampert
13742cca41 Added support for voronoi edges. 2020-09-28 14:58:08 -05:00
Markus Lampert
04cf9c2e46 Added python bindings for voronoi diagram construction and accessing the resulting vertices. 2020-09-28 14:58:08 -05:00
sliptonic
169a66b225 Merge pull request #3706 from etrombly/emptyPath
[PATH] don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same.
2020-08-04 10:20:13 -05:00
wmayer
13fc0554a0 LGTM: [skip ci] fix: Missing header guard 2020-07-27 11:16:41 +02:00
wmayer
45e0673645 LGTM: [skip ci] fix: Declaration hides parameter
A local variable hides a parameter. This may be confusing. Consider renaming one of them.
2020-07-27 10:57:34 +02:00
wmayer
c162037476 LGTM: [skip ci] fix: Large object passed by value 2020-07-24 18:32:31 +02:00
wmayer
4807fd3b33 PVS: V730 Not all members of a class are initialized inside the constructor 2020-07-18 10:59:27 +02:00
Eric Trombly
cf9fec5ffd don't generate gcode if op isn't valid. Don't plunge to start height if safe and clearance height are the same. 2020-07-15 19:35:18 -05:00
luz.paz
ef37cc3930 Fix typos [skip-ci]
Found via codespell v1.18.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-06-29 20:52:23 +02:00
sliptonic
25445b0cb5 Merge pull request #3584 from gwicke/area_tweaks
Path: Area fixes and robustness tweaks
2020-06-19 12:30:32 -05:00
wmayer
730154a684 boost 1.73.0: The practice of declaring the Bind placeholders (_1, _2, ...) in the global namespace is deprecated 2020-06-12 17:51:33 +02:00
Gabriel Wicke
2fb60a40b2 Path: Area fixes and robustness tweaks
- Bug fix: Fix crasher in discretize() when the edge to discretize is
  not a 3d curve, and a nullptr is returned when trying to access the
  underlying curve. This change essentially removes an older work-around
  for QuasiUniformDeflection, which is no longer needed since we are
  using UniformDeflection. This change is tested with the original test
  case from https://forum.freecadweb.org/viewtopic.php?f=15&t=42628, as
  well as my own crasher test case.
- WireJoiner robustness: Support passing in a tolerance into
  WireJoiner::findCloseWires(), and initialize this to
  AreaParameter.Tolerance. In testing, this significantly improves the
  ability to join projected areas in complex 3d surface path models.
- Area::project() robustness: Pass the work plane down into the
  projection area instance, so that it does not need to be derived from
  shapes. This avoids crashing out on "shapes are not coplanar" from
  getPlane, when lenient processing was requested via the Coplanar
  parameter.
2020-06-07 20:09:55 -07:00
Gabriel Wicke
86cd9f2124 Path: Opt into automatic git newline normalization
Avoid spurious diffs from inadvertent newline changes by letting git
normalize newlines in the path module as well, just as a list of other
modules including Draft already do.

This effectively standardizes all checked-in code to Unix newlines, but
checkouts might use CRLF if that is the user preference.
2020-05-31 08:33:29 -07:00
Eric Trombly
3c046fab71 change intra-operation travels back to clearance height, then rapid to safe height 2020-04-27 20:31:36 -05:00
Eric Trombly
be01153ea7 remove retraction to clearance height for intra-operation travels 2020-04-24 22:32:27 -05:00
Eric Trombly
745945d2cb fix detect of 0,0 start point 2020-04-24 20:05:39 -05:00
Eric Trombly
c10eed7eb0 pass endVectorin PathAreaOp and clean up gcode generation 2020-04-24 20:05:39 -05:00
Daniel Wood
7153c3d836 ensure the getCycleTime function returns a value 2020-04-23 16:43:00 +01:00
Daniel Wood
87ce2ec4d4 Add getCycleTime method to Path::ToolPath 2020-04-22 19:08:09 +01:00
Zheng, Lei
1becccb152 Path: fix path sort 2020-04-13 14:34:18 +08:00
luz.paz
4acdf2613d [skip-ci] Various typo fixes
Found via codespell  v1.17.0.dev0  
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-07 18:17:03 +02:00
Zheng, Lei
9c86629a5f Path: handle open edges when sorting path 2020-04-06 09:58:01 +08:00