Commit Graph

27 Commits

Author SHA1 Message Date
Chris Hennes
b89ad30bc0 Merge pull request #19917 from tritao/refactor-document-recompute
Core: Refactor code around document and feature recompute
2025-03-16 23:59:12 -05:00
Joao Matos
8710bbd825 Part/PartDesign/TechDraw: Simplify calls to DocumentObject::recomputeFeature. 2025-03-03 21:22:22 +00:00
Kacper Donat
a72a63232a Base: Move App::Color to Base
Every basic data type is stored in Base module, color is standing out as
one that does not. Moving it to Base opens possibilities to integrate it
better with the rest of FreeCAD.
2025-02-17 21:10:26 +01:00
wandererfan
2737e830b1 [TD]fix fail on object deleted during dialog (#9626) 2023-05-24 10:15:45 -04:00
wmayer
4b3fb1c079 TD: replace slots with member function pointers 2023-02-03 00:21:38 +01:00
wmayer
25a63f8750 TD: move to new style connect() 2023-02-01 01:33:34 +01:00
Uwe
cbd0140dcd [TD] Task*, part 2/2: remove unused includes
- also some sorting
- also take care of PreCompiled.h
2022-12-07 19:49:05 +01:00
wandererfan
acf17905ed [TD]CI clang warnings 2022-09-05 17:48:38 -04:00
Uwe
2e5e4dced8 [TD] Gui: remove some superfluous nullptr checks 2022-07-19 02:49:46 +02:00
wmayer
fd8719c85c TD: [skip ci] activate PCH of TechDraw (Gui) and use forward declarations
For MSVC this reduces compile time by ~20%
2022-03-25 13:54:47 +01:00
wmayer
a99be14233 TD: modernize C++11
* use nullptr
2022-03-23 19:26:14 +01:00
wmayer
66417b3ce1 TD: [skip ci] use setAutoCloseOnTransactionChange for balloon and dimension task dialog 2021-02-12 17:43:31 +01:00
wmayer
d4e8a5a384 TechDraw: [skip ci] avoid to trigger a slot in constructor of TaskBalloon 2021-02-12 16:55:39 +01:00
wmayer
bb0d75b6cc TechDraw: [skip] fixes for balloon feature:
* reimplement ViewProviderBalloon::setupContextMenu() to show item to start editing it
+ fix TaskBalloon::accept() and TaskBalloon::reject()
2021-02-12 15:36:21 +01:00
donovaly
b5f57ed2f0 [TD] make pointers to the UI std::unique_ptr
as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all TD dialogs that don't already use a unique_ptr.
2021-01-19 19:24:27 +01:00
donovaly
0c7c330fe1 [TD] show balloon dialog on double-clicking
when adding GD&T statements as described in https://wiki.freecadweb.org/TechDraw_Geometric_dimensioning_and_tolerancing
You will quickly get a lot of balloons and it is then very tiring to be forced to first select a balloon with a single-click in the drawing, then go to the model tree and there double-click to get the dialog.

This PR also removes unused includes from the dialog code.
2021-01-11 03:02:35 +01:00
donovaly
a9da6194a5 [TD] update balloon dialog
2 weeks ago the properties EndTypeScale and LineVisible were added but not to the dialog.

This PR adds them t the balloon dialog-

It also took the opportunity to cleanup the code:
- add missing tooltips
- uniform tooltips in App and Gui
- uniform the UI element names
2021-01-02 11:49:20 +01:00
wandererfan
6632921e38 [TD]change misleading prop name - Shape 2020-06-15 13:57:55 -04:00
donovaly
d9e65c7780 [TD] use Gui::QuantitySpinBox in dialogs
as recently discussed

- also add lost alignment properties
2020-03-28 08:51:12 -04:00
donovaly
58b926e308 forbid negative width and size
- also uniform line endings
2020-03-22 09:33:38 -04:00
donovaly
b0fc725077 [TD] make balloon dialog show changes
see https://forum.freecadweb.org/viewtopic.php?f=35&t=44362
2020-03-22 09:33:38 -04:00
donovaly
7e60dcd734 - add missing update on changed color
- some minor code rearrangements and wording changes
2020-03-20 11:34:03 -04:00
donovaly
14fbda341c [TD] Balloon fixes
- remove the unused property OriginIsSet
- refurbish TaskDialog and add new settings:
  - use SpinBox for Shape Scale
  - add Font Size
  - add Text Color
  - add Line Width
  - add Kink Length
- correct and add tooltips
2020-03-20 11:34:03 -04:00
donovaly
d8fda751d0 [TD] use uniform naming for balloon outline
- in the prefs we call the outline "shape" and this describes it better than "symbol" (it is the shape of the bubble). The line end, however, has a symbol so "Shape" makes clear that is is something different.
2020-03-19 09:26:50 -04:00
wandererfan
dcef41782e [TD]harmonize Arrow enums 2020-03-11 09:33:54 -04:00
Franck Jullien
accf578dd9 [TD] Fix TaskPanel comboBox values 2019-06-29 06:31:54 -04:00
Franck Jullien
36d341f3df [TD] Add TaskPanel for Balloons
TaskPanel can be open by double clicking either Balloon label on drawing
page or Balloon object in tree view.
2019-05-22 12:50:47 -04:00