kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
34,875 Commits 41 Branches 6 Tags
3eda026ecb10d7b8015b2c9da21bc60773ee49f0
Commit Graph

331 Commits

Author SHA1 Message Date
Abdullah Tahiri
3eda026ecb Sketcher Gui: Fix dead code clang-tidy 2023-11-05 07:11:57 +01:00
Abdullah Tahiri
533250bc34 Sketcher Gui: clang-tidy diagnostic errors 2023-11-05 07:11:57 +01:00
Paddle
0f049a6cb0 Sketcher: commandConstraint : remove leftover bothexternal variable. 2023-10-22 13:51:21 +02:00
wmayer
e9586c4206 Sketch: fix several compiler and lint warnings 
* Remove private unused field 'sketchView'
* Mark constructor with single argument as explicit
* Mark virtual methods of base class as override
* Fix clang code model parsing error
* Avoid too short identifiers
* Avoid redundant ternary operators
* Avoid passing Base::Unit by value but by const reference
 2023-10-20 12:29:59 +02:00
Paddle
019bd50bbc Fix typo making Sketcher_Dimension fails for angles. 2023-10-10 13:48:07 +02:00
Paddle
2ea27064d5 Create makeAngleBetweenTwoLines and Create Create calculateAngle to remove duplicates 2023-10-07 07:43:39 +02:00
wmayer
b2d255e5fc Sketch: fix a few minor issues: 
* fix compiler warning about unused variable
* fix const correctness
* fix access type of setExpression()
* removed duplicated method
 2023-09-19 22:01:19 +02:00
Paddle
f080b39829 Sketcher_Dimension : adds arc-angle mode for arcs. 2023-09-19 08:25:45 +02:00
Paddle
b97a2ef6dc Adds a small convenience function to get arc of circle angle. 2023-09-18 21:33:24 +02:00
howie-j
49bca90219 fixes #10651 2023-09-18 10:56:13 -05:00
Florian Foinant-Willig
e8becf3f15 Sketcher: refactor CommandConstraint.cpp (#10692) 
* Sketcher: refactor CommandConstraint.cpp with TypeId helpers

* Sketcher: cosmetic empty lines

* fix pointer misusage
 2023-09-18 10:37:03 -05:00
Paddle
cde6afe847 Sketcher_Dimension : enable user to deselect geos by clicking on them again. 2023-09-14 20:57:39 -05:00
wmayer
bc8a5e4704 Sketcher: fix several inconsistencies in Sketcher_CompDimensionTools 
* The menu text and tooltip of the Sketcher_ConstrainRadius command shouldn't be different if part of the group command or not.
  The explicit mentioning to change the weight of a B-Spline is pointless and confusing.
* The order of Sketcher_ConstrainRadius and Sketcher_ConstrainDiameter has flippend when used in Sketcher_CompDimensionTools
* The command Sketcher_ConstrainRadiam is completely missing
* The command Sketcher_ConstrainSnellsLaw was wrongly re-added
* CmdSketcherCompConstrainRadDia uses a wrong context
 2023-09-14 20:56:14 -05:00
wmayer
d9d7bf87ae MSVC: fix several compiler warnings 2023-09-12 22:57:26 +02:00
howie-j
332b64f8b6 Fixes #10596 2023-09-07 21:14:56 +02:00
Paddle
c1bd68d8a5 Sketcher_Dimension Replace SubNames by std::move(SubNames) 2023-09-02 11:35:31 +02:00
Paddle
351bd2d5f4 Sketcher_Dimension fix crash. 2023-09-01 18:50:46 +02:00
wmayer
ee6e9e4923 Sketcher: fix several warnings: 
* fix -Wunused-parameter
* fix -Wsign-compare
 2023-09-01 17:34:29 +02:00
Paddle
465e98a502 Sketcher_Dimension: Disable arc-circle and arc-line distances as they are not implemented yet. 2023-09-01 08:00:21 -05:00
Paddle
126558ccf8 Sketcher_Dimension: Implement Point-to-Circle distance. 2023-09-01 08:00:21 -05:00
Paddle
392d29c20b Sketcher_Dimension Fix the transaction auto-closing issue 2023-09-01 07:58:45 -05:00
Paddle
be7b9b33e7 Sketcher_Dimension : Implement selection->tool workflow 2023-09-01 07:58:45 -05:00
Paddle
3fad071760 Sketcher_Dimension : Turn the command into a group-command to have at hand individual commands. 2023-09-01 07:57:44 -05:00
luzpaz
40d2a90e3a Fix typos 2023-08-31 22:29:17 -05:00
Florian Foinant-Willig
9681ad595b Sketcher: Point to Circle Distance Constraints (#9559) 2023-08-28 10:58:09 -05:00
Paddle
e21b6cf860 Implement GeomSelectionSizes to further refactor Dimension::makeAppropriateConstraint 2023-08-27 18:48:33 +02:00
Paddle
d5bdebfe10 Dimension: Fix 2 circles concentric and length mode. 2023-08-27 18:48:00 +02:00
Paddle
a683f3aca4 Fix crash when user click 'Close' button while Dimension is active. 
TaskDlgEditSketch didn't purge the handler first as is doing CmdSketcherLeaveSketch.
 2023-08-27 09:26:44 +02:00
Paddle
f1f31fd3df Refactor makeAppropriateConstraint 2023-08-27 08:25:20 +02:00
Paddle
1fcfdedb05 Replace multiple occurence of selVec.size() by s_vec to clean the makeAppropriateConstraint function 2023-08-27 07:26:53 +02:00
Paddle
3598dd4820 Small simplification by removing useless tests in makeAppropriateConstraint 2023-08-26 22:13:11 +02:00
Paddle
b95713599a refactor Sketcher Dimension releaseButton 2023-08-26 19:47:23 +02:00
Paddle
bc3d06fafc Remove superfluous virtual add missing override. 2023-08-26 19:13:52 +02:00
Paddle
eee2f14128 Change the name to 'Dimension' instead of 'Constrain Contextual' 2023-08-26 08:35:27 +02:00
Paddle
b10b9bf22d Sketcher: Constrain Contextual implementation. 2023-08-26 07:41:09 +02:00
Abdullah Tahiri
78ae9c1d7d SketcherGui: apply clang-format 2023-05-25 17:08:03 +02:00
Roy-043
3aca29a8b4 Sketcher: fix typo in Refraction constraint menu text 2023-05-25 14:12:06 +02:00
Abdullah Tahiri
2bc3295cf3 Sketcher: Obey non-intrusive preferences for modal pop-ups 
==========================================================

This commit turns the remaining blocking pop-ups in which the user can only click "ok"
into non-intrusive notifications, depending on the user preferences in settings.
 2023-05-24 18:35:41 +02:00
Abdullah Tahiri
bcedfae708 Sketcher: Command constraints error handling adaptation 
=======================================================

- Better handling for exceptions originating in Python addConstraint.
- Refactor to reuse code for handling of exceptions
 2023-05-23 14:24:45 +02:00
Abdullah Tahiri
17f65d8746 Sketcher: Make Command Constraints show the severity of warning for typical user mistakes 2023-05-23 14:24:45 +02:00
Chris Hennes
cb10e49b27 Sketcher: Tweak wording as suggested by translators 2023-05-02 20:29:36 +02:00
Florian Foinant-Willig
d3322ead12 Sketcher : Circle to Line Distance Constraint 2023-05-02 15:41:51 +02:00
0penBrain
4cc2a1af62 Gui: prevent crashes on MacOS using boost::format 2023-03-31 15:22:03 +02:00
wmayer
651029e774 Sketch: fix trailing whitespaces of recorded sketcher commands 2023-03-26 18:41:56 +02:00
flachyjoe
e2a13763e9 Sketcher: Add circle to circle distance constraint 2023-03-19 14:05:35 +01:00
Abdullah Tahiri
7920f51c76 Sketcher: Constraint - notification and internal geometry command clean up 
==========================================================================

- Migration of all constraints to the new non-intrusive notification framework.

- Removal of internal geometry command

- Command to create manually internal geometries is removed (deprecated).
 2023-03-13 16:21:01 +01:00
Ajinkya Dahale
7ba24d5572 [Sketcher] Substitute knot tangent related constraints 2023-01-23 20:43:51 +01:00
Ajinkya Dahale
d5793dc0e4 [Sketcher] Enable point-on-B-spline in Sketcher and GUI 
Also squashes:

[Sketcher] Allow point on external B-spline
 2023-01-21 21:41:27 +01:00
Ajinkya Dahale
6d59b2d28e [Sketcher] Add line tangent at knot through endpoint 2023-01-17 16:02:23 +01:00
Ajinkya Dahale
bb8a3c8885 [Sketcher] Disallow tangent at knot with non-line in GUI 2022-12-24 18:22:16 -06:00