Commit Graph

55 Commits

Author SHA1 Message Date
Chris Hennes
950507a498 Revert "Resolve #11825 - no automatic quantity conversion: App::anyToQuantity"
This reverts commit c1ef15fbdf5db5aaf2ec86cb44bff237d1966238.
2024-02-12 15:29:15 -06:00
bgbsww
57d8a9e61a Switch to using enum 2024-02-04 09:27:16 +01:00
bgbsww
a5cf4bdd33 Tweak resetElementMap to default to empty defined element map (#12098)
* Tweak resetElementMap tp default to empty defined element map

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2024-01-24 21:24:08 -06:00
Chris Hennes
297dff5e9b Merge pull request #12007 from chennes/toponamingElementNameComparator
App/Toponaming: Add Comparator for mapped elements
2024-01-19 09:20:59 -06:00
Chris Hennes
36451d1add Tests/Toponaming: Add tests for ElementNameComparator
This verifies the existing functionality, but does not alter it. Two tests are disabled because they represent cases that the current code does not handle correctly. They are edge cases that are not expected in real code.
2024-01-16 19:25:38 -06:00
Ladislav Michl
5fe2b33bb0 Tests: Avoid use of fmtlib when not needed 2024-01-15 17:38:56 +01:00
Andrei Pozolotin
71a61cf423 Resolve #11825 - no automatic quantity conversion: App::anyToQuantity 2024-01-11 11:32:18 -06:00
Stefan Brüns
ffad094051 [App] Fix segfault due to missing Py_Initialize in StringIDRefTest
The PyObject desctructor requires an initialized interpreter, otherwise
PyGILState_Ensure crashes.

Fixes #11878
2024-01-10 22:34:04 -06:00
Chris Hennes
75547d04df App/Toponaming: Add basic tests for CGD serialization 2023-11-08 17:11:32 -06:00
wmayer
931fcdabbf tests: add initApplication() to avoid code duplications 2023-10-21 16:31:26 -05:00
wmayer
6ef99e413b Tests: suppress warning about intened self-assignment 2023-10-11 15:12:42 +02:00
wmayer
15622bb519 App: the function findLicense() uses the '==' operator to compare two C strings.
This is wrong and leads to failures under Windows.
2023-10-10 13:31:10 +02:00
Chris Hennes
de82b54b63 Merge pull request #10667 from chennes/toponamingHasherToDocument
App/Toponaming: Add StringHasher to Document
2023-09-20 13:31:02 -05:00
Pesc0
4767b116ec fix qbytearray length out of bound 2023-09-19 12:38:27 -05:00
wmayer
bd067fa203 Tests: fix a memory leak in StringIDRefTest::getPyObject 2023-09-18 14:58:38 +02:00
Chris Hennes
2f811201d6 App/Toponaming: Add a few tests for Document 2023-09-17 13:13:37 -05:00
Chris Hennes
9b55b3a70b App/Toponaming: Add StringHasher to Document 2023-09-17 13:13:37 -05:00
pre-commit-ci[bot]
e92ed45df9 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-12 13:02:35 -04:00
Chris Hennes
246a387625 Tests: Reformat to current clang-format standard 2023-09-03 09:51:42 -05:00
wmayer
9dd4779252 Test: add more unit tests 2023-08-26 13:17:53 +02:00
Chris Hennes
6a9efd6731 App/Toponaming: Add tests for findTagInElementName
Also apply clang-tidy to that function, and fix an error with the postfix return.
2023-07-15 22:47:08 -05:00
Chris Hennes
66f6350fd3 App/Toponaming: Basic tests and linter issues 2023-07-14 23:03:18 -05:00
Pesc0
c65f049d20 [Toponaming] create ElementMap class (#9175)
* Copypaste ElementMap
* Add MappedNameRef
* Fix missing include
* Copypaste `findTagInElementName`
* fix error introduced _somewhere_
* refactor toponaming constants
* Move `findTagInElementName` in `MappedName`
* reintroduce workaround to compile ElementMap
* Added missing functions copied from complexgeodata
* fix last compile errors, reorder and format files
* remove recursive refs to ComplexGeoData
* Add more comments
* fixed comments and added tests
* added FIXME, make functions private, misc fixes
* Move static functions from complexGeoData to PostfixStringReferences. Rename to ElementNamingUtils
* Fix broken includes due to previous change
* Revert constants from string to const char*
* added childmap tests and made hasher public
* Make functions private
* Added remaining tests
* removed bool return from `erase` functions
* fix missing appexport

Co-authored-by: John Dupuy <jdupuy98@gmail.com>
2023-06-15 09:05:24 -05:00
Chris Hennes
41a924ccec App/Toponaming: Adjust StringHasher tests 2023-05-11 16:41:52 -05:00
Chris Hennes
5c119307b8 App/Toponaming: StringHasher tests, commenting, and cleanup 2023-05-11 14:34:36 -05:00
Chris Hennes
8c208d5441 App/Toponaming: Stubs of tests for StringHasher 2023-05-11 14:34:36 -05:00
Chris Hennes
987f502afe App/Toponaming: Fix Reader tests for Linux 2023-05-11 14:34:35 -05:00
Chris Hennes
e3dfd3536d App/Toponaming: Unit tests for StringIDRef 2023-05-11 14:34:35 -05:00
Chris Hennes
ed7d79b0f5 App/Toponaming: Minor refactoring and tests for StringID 2023-05-11 14:34:35 -05:00
Chris Hennes
ec575c612a App/Toponaming: Add missing include to Writer 2023-05-11 14:34:35 -05:00
berniev
38f4f3a2fc simplifying a function
Dramatic simplification of legacy code by separating code and data and applying some later C++.
Function removed from Application.cpp as it was in a anonymous namespace and could not easily be subjected to unit testing.
Added ProgramOptionsUtilities.h
2023-04-07 12:37:05 +02:00
Chris Hennes
9e9e0f7593 Formatting: Apply pre-commit to tests/src 2023-04-06 08:07:53 +02:00
luzpaz
07a5342b60 Toponaming: fix whitespace in App/MappedName.cpp 2023-04-01 15:21:01 +00:00
Chris Hennes
b1039c71ac App/Toponaming: Add test for EDGE2<EDGE12 2023-03-25 11:22:12 -05:00
Chris Hennes
d871779299 App/Toponaming: Add tests to MappedElement 2023-03-24 10:05:09 -05:00
Ajinkya Dahale
776e940006 [Core] Create ElementMap and tests
Test is a dummy for now. `ElementMap.h` only contains const values.
2023-03-22 21:53:23 +05:30
Pesc0
6354c37041 Added all tests and minor fixes 2023-03-19 02:55:24 +01:00
Chris Hennes
a920d5109f App/Toponaming: Add IndexedName tests for MappedName class 2023-03-19 01:57:54 +01:00
Pesc0
6b3d99fbbd Improved some tests 2023-03-19 01:32:29 +01:00
Pesc0
f1f1590639 Remove use of = operator in object construction 2023-03-19 00:41:13 +01:00
Pesc0
9af5a71e92 Fixed tests 2023-03-18 19:44:18 +01:00
Pesc0
d589d5205d Use AAA pattern in test suite 2023-03-17 01:43:34 +01:00
Pesc0
2ec169f2a9 MappedName unit tests almost complete 2023-03-17 01:43:34 +01:00
Pesc0
c39f603744 Added initial tests to MappedName 2023-03-17 01:43:34 +01:00
Pesc0
9200160502 Added MappedName class 2023-03-17 01:42:53 +01:00
Chris Hennes
45c0b634fa App: Clean up IndexedName and add tests
Fixes the matching algorithm when provided a vector of existing names:
The original algorithm was equivalent to a 'startswith' algorithm, when it should
have been testing for exact and complete string equality. This also does some
refactoring to rename and clarify variables and functions, simplifies some
functions by using standard library calls when possible, and addresses various
linter complaints. It also applies our current clang-format to the files.

Co-authored-by: Ajinkya Dahale <AjinkyaDahale@users.noreply.github.com>
2023-03-14 13:08:23 -05:00
wmayer
0e4f7a1e46 Test: fix license unit test 2023-03-11 03:19:59 +01:00
luzpaz
01e8bbc2bf Fix various typos and whitespace 2023-03-10 14:40:46 +01:00
berniev
6c9d7ebc7a an example of using constexpr array for data
simplifies code and removes the need for a class.
2023-03-07 23:22:44 +01:00
wmayer
910f1e2481 Test: add unit tests for expressions with operator 2023-02-26 09:00:27 +01:00