Commit Graph

1676 Commits

Author SHA1 Message Date
wmayer
3fd2f64639 Fix several regressions:
+ improve PropertyMaterialList::readString
+ fix transparency handling in ViewProviderPartExt
+ do not register the private member '_diffuseColor' as property because it would be exposed to the
  public where it can be modified
+ fix ViewProviderPartExt::finishRestoring() to correctly restore old project files
+ fix ViewProviderPartExt::setHighlightedFaces() to correctly show face colours if VBO is enabled
+ fix ViewProviderBoolean::updateData()
  fix ViewProviderMultiFuse::updateData()
  fix ViewProviderMultiCommon::updateData()
  fix ViewProviderCompound::updateData()
  fix ViewProviderFillet::updateData()
  fix ViewProviderChamfer::updateData()
  that all set invalid transparency values
+ Filter ShapeAppearance in ViewProviderBody::unifyVisualProperty
  because body features usually have different number of faces than the body itself
+ manually fix some bad looking auto-formatted code
+ clean up code and remove duplicated code
2024-06-11 11:58:32 +02:00
wmayer
d88253c2a1 Fix several compiler warnings
* variable 'xAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'yAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* variable 'zAngle' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
* unused variable 'base' [-Werror,-Wunused-variable]
* unused variable 'extrude' [-Werror,-Wunused-variable]
2024-06-11 11:42:12 +02:00
Kacper Donat
86e07e9181 Gui: Fix use of no longer existing DiffuseColor property 2024-06-10 19:40:48 -05:00
Kacper Donat
988d31bed8 GUI: Add UI for Up To Shape feature
Add UI for Up To Shape feature and overall refactor of Pad / Pocket.
2024-06-10 18:05:21 +02:00
Kacper Donat
83cf2a17cd Gui: Refactor DressUp VP to use setHighlighted*
This refactors DressUp VP a bit so it does no longer store original copy
of original faces colors to properly support selection, but uses
highlight methods provided by the base class. It simplfies code a bit
and ensures coherent behavior.
2024-06-10 18:05:21 +02:00
wmayer
707b0e6264 Fix compiler warnings 2024-06-04 20:23:19 +02:00
Chris Hennes
7abadaf7f3 Merge pull request #14485 from bgbsww/bgbsww-toponamingFixDressUpShadowSubs
Toponaming fix dress up shadow subs
2024-06-03 21:01:22 -05:00
bgbsww
617e63bc23 Toponaming: reformat code 2024-06-03 19:29:01 -04:00
Chris Hennes
6404de9c21 Update translations 2024-06-03 11:04:42 -05:00
Chris Hennes
5f601eb6c7 Merge pull request #12589 from NomAnor/pd-trans-body
Add a new mode to PD patterns that will transform the base feature's shape instead of the tool shapes
2024-06-03 10:46:33 -05:00
Chris Hennes
f331c91b89 Merge pull request #13317 from Ondsel-Development/add-prop-varset
Core: Add properties to variable sets
2024-06-03 10:34:57 -05:00
Zheng, Lei
a926cd41b3 Toponaming: update TaskDressUp addAllEdges 2024-06-03 11:22:55 -04:00
bgbsww
a495280693 Toponaming: fix bug with points in sketches 2024-06-01 22:57:31 -05:00
David Carter
5feb963f9d Material: Appearance Updates 2
Improves the use of the ShapeAppearance property for the Part workbench.

    removes DiffuseColor property
        adds Python compatibility using custom attributes
        transitions DiffuseColor to ShapeAppearance on open
    Improved UI elements for setting object appearance, and appearance per face
    Lays the foundation for future texture support
2024-06-01 19:57:16 -05:00
wmayer
560cab6f31 clang/gcc: Add build option FREECAD_WARN_ERROR to force to make warnings into errors 2024-05-29 13:37:07 +02:00
André Althaus
cd3bda3845 Fix signal for Qt < 5.15 2024-05-28 13:48:48 +02:00
André Althaus
b42d56bb3b Replace combobox with radio buttons 2024-05-28 09:34:08 +02:00
Max Wilfinger
03cab3d1fc Revert UI command change in Sketcher and PartDesign 2024-05-27 11:51:02 -05:00
Chris Hennes
764dc4cc31 Merge pull request #13968 from marcuspollio/UI-TaskPanels-cleanup-1
UI : Task panels cleanup - Sketcher and Part Design headers
2024-05-27 10:56:07 -05:00
David Carter
a0fdc86948 Material: Appearance and Material inspectors
Dialogs to view the Appearance and Material properties of an object

These inspectors are intended to be used when debugging Appearance and
Material issues in a model.

The Appearance inspector displays the appearance properties of an
object. This will be more useful once PR 13792 is merged which migrates
parts to use ShapeAppearance instead of DiffuseColor. This shows each
of the appearance properties per face for the object.

The Material inspector shows the material, models, and properties
assigned to a model. It displays useful debugging information such as
the UUID and file paths associated with eacch of the items. This is
useful when finding and resolving model conflicts.

The material inspector now gives the option of copying the information
to the clipboard.
2024-05-27 10:50:35 -05:00
Chris Hennes
73ae4102e6 Update translations
Arch->BIM is a WIP
2024-05-25 19:11:51 -05:00
André Althaus
099e33a77f Remove feature selection dialog for transformed features
The dialog is no longer necessary because without a selection the
transformed features default to "Transform body".
2024-05-23 12:40:41 +02:00
André Althaus
40a1487cb5 Set TransformMode to "Transform body" if no features are selected on creation of transform features 2024-05-23 12:23:32 +02:00
André Althaus
98d46c41be Add a combo box to the transform featues UI for the TransformMode 2024-05-23 12:22:26 +02:00
wmayer
1d78063df8 Fix accessibility of some group commands
Several group commands are active but require an active document to work. This PR overrides the method isActive() to
disable the commands if no active document exists.

The affected commands are:
* Std_ViewGroup
* Std_LinkActions
* PartDesign_CompDatums
* PartDesign_CompSketches
2024-05-23 10:14:46 +02:00
Pieter Hijma
b6026c98c9 Core: Add VarSets to Groups
If a Group is selected, add the VarSet to the group.
2024-05-21 09:59:49 +02:00
marcuspollio
f2c6d9ed62 Resolve conflicts 2024-05-21 10:51:07 +12:00
marcuspollio
ed88002018 Merge remote-tracking branch 'upstream/main' into UI-TaskPanels-cleanup-1 2024-05-21 10:36:10 +12:00
Chris Hennes
40c5d137d2 Merge pull request #14074 from NomAnor/pd-icons
Change PartDesign Pad and Revolution tree icons
2024-05-20 11:45:16 -05:00
Max Wilfinger
ba9240a3f2 Update Part Design toolbars.
Command group for datum. Removed ShapeBinder. Added CheckGeometry.
2024-05-20 10:39:32 -05:00
André Althaus
eaa5b5c294 Use Body toolbar icon for the tree 2024-05-19 12:17:16 +02:00
André Althaus
641e866319 Remove unused icons 2024-05-19 12:16:56 +02:00
André Althaus
de6fe29d30 Replace the yellow Part primitive toolbar icons with the blue tree icons 2024-05-19 12:12:48 +02:00
André Althaus
d8c139fef0 Make "Sketch" in Pad icon red
In other icons the support geometry is red and this mirrors the other icons
2024-05-19 12:12:48 +02:00
André Althaus
fd74429dfa Change PartDesign Pad and Revolution tree icons
Use the same icons as the toolbar buttons.
2024-05-17 09:09:46 +02:00
marcuspollio
1b2a3c3c29 Address feedback 2024-05-15 14:27:18 +12:00
marcuspollio
a5a26aee9e Merge remote-tracking branch 'upstream/main' into UI-TaskPanels-cleanup-1 2024-05-15 13:45:43 +12:00
Chris Hennes
9fead3682d Update translations 2024-05-12 17:06:56 -05:00
marcuspollio
12a09af5cd PartDesign UI: Update Task panels titles and icons
update Workbench.cpp, TaskFeaturePick.cpp
2024-05-12 15:08:14 +12:00
Chris Hennes
a5d8aaa21c Update translations
Also removes Web from translation scripts.
2024-05-06 18:17:53 +02:00
hlorus
74d055e11a [Part/PD] Remove measure tools 2024-04-29 09:27:22 -04:00
Chris Hennes
ead426c6eb Update translations
Note: Web and Start omitted
2024-04-24 13:58:21 -05:00
Chris Hennes
e7069e6797 Update translations. 2024-04-17 16:50:38 -05:00
wmayer
5d451b1486 PD: fix shape appearance of datum features, shape binder and sub-shape binder 2024-04-09 22:15:51 +02:00
wmayer
dfc74591cc Material: add workbench manipulator
Implement a workbench manipulator to inject Std_Material and Std_Appearance to (context) menu.
2024-04-05 10:08:06 +02:00
David Carter
ba20441935 Material: Material appearance
Uses new material system for appearance

Each feature object now has a property called ShapeMaterial that
describes its physical properties. If it has a shape, it has a
material.

The ShapeColor attribute is replaced by a ShapeAppearance attribute.
This is a material list that describes all appearance properties, not
just diffuse color. As a list in can be used for all elements of a
shape, such as edges and faces.

A new widget is provided to allow the user to select materials in a
consistent fashion. It can also launch the material editor with its
more advanced capabilities.
2024-04-04 07:39:58 -05:00
wmayer
96b054aa84 PD: Fixes 12673: Transforming of sub-shape binder fails
The problem is caused by conflicting values of the anonymous enum of ViewProviderSubShapeBinder. The solution is to set a higher value than the highest value of EditMode
2024-04-02 08:18:46 +02:00
wmayer
b711c586c8 PD: replace static_cast with dynamic_cast
The use of static_cast here could cause undefined behaviour because at this point it's not guaranteed that findBodyOf()
really returns a PartDesign::Body
2024-04-02 08:17:45 +02:00
Max Wilfinger
9f0a2ea3f7 adjust Part Design icons incl. WB icon 2024-04-01 11:15:33 -05:00
André
48f0e5043a Allow adding subfeatures to MultiTransform if there is no active Body (#12538)
* Allow adding subfeatures to MultiTransform if there is no active Body

Previously the active Body would be checked and used to add new
subfeatures.
This would either do nothing, when no Body was active,
causing confusion for users becaues than can edit other features without
an active Body.
Or it would add the subfeature to the wrong Body if another Body than the
one of the MultiTransform was active.

Now the Body of the MultiTransform is checked and used.

# Conflicts:
#	src/Mod/PartDesign/Gui/TaskMultiTransformParameters.cpp

* Change getTopTransformedObject() to protected

This needs to be called from the MultiTransform.

* Fix typo
2024-04-01 10:40:17 -05:00