Commit Graph

18 Commits

Author SHA1 Message Date
donovaly
3fdce54be7 [PD] fix dressup feature display when broken
As discussed in https://forum.freecadweb.org/viewtopic.php?p=479647#p479377
the user can end up without either seeing nothing or an inexisting dressup feature.

This PR fixes this.
2021-02-19 14:51:52 +01:00
wmayer
cbee07d53a PartDesign: fix issues of PR #3108
* in the undo/redo list use an object's label and not the internal name
* check by the transaction ID instead of name to open a transaction to make the workbenches independent of implementation details of the core system
* when rejecting a task do not call undo() because this is not the same as aborting a pending transaction
* this also fixes the warning: <App> Document.cpp(1182): Cannot commit transaction while transacting
2020-03-14 14:51:45 +01:00
Zheng, Lei
e9bbae0a89 PartDesign: fix task dressup/transformed creation cancel 2020-03-14 14:51:45 +01:00
wmayer
c654ce3629 PartDesign/Fem: [skip ci] when handling Del key make sure that deleteAction is instantiated 2020-02-19 11:31:40 +01:00
donovaly
1a718a6371 improve code as suggested by Werner
see https://forum.freecadweb.org/viewtopic.php?p=369921#p369921
2020-02-18 23:16:48 +01:00
donovaly
0283cb09fb improve fillet dialog logic
- now also the case of only one item in the list is handled properly (single-click will highlight it, double-click will show the final fillet)
2020-02-17 21:53:45 +01:00
wmayer
44b9ed6228 PartDesign: [skip ci] do forward declaration if possible to reduce build timw 2020-02-16 19:26:48 +01:00
donovaly
0fe8157af5 TaskDressUpParameters: GCC compile fix 2020-02-16 05:47:54 +01:00
donovaly
9d28b3d390 [PD] add feature to highlight references in some dialogs
- also fix some logic issues and avoid to break the feature (deleting the last item is now no longer possible)
2020-02-16 05:18:29 +01:00
donovaly
0310a99f4e [PD] add shortcut to context menus
- people should be informed that there is a shortcut available (that was recently added)
- make the shortcut also translatable since "Del" means nothing in e.g. German
- minor code style fix in TaskDressUpParameters.h
2020-02-14 09:59:46 +01:00
luz.paz
dc8bf3dc39 PartDesign: [skip ci] fix header uniformity
This PR fixes header uniformity across all PartDesign WB files
2019-12-22 00:58:38 +01:00
Zheng, Lei
cd2b7e297c PartDesign changes
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
2019-08-17 15:15:47 +02:00
wmayer
dd7c91ddcf fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
Alexander Golubev
e16534eeb2 PartDesign/TaskDressUpParameters: fix a crash when editing a broken object 2016-04-12 18:12:15 +02:00
Alexander Golubev
6778c548f4 PartDesign: move common code for TaskDlg{SketcherBased,DressUp}Parameters into new base class
Added a new class: TaskDlgFeatureBased which currently contains common
code for TaskDlgSketcherBasedParameters::reject() as well as the same
methode for TaskDlgDressUpParameters.
It's likely that other Feature task dialogs will inherit this class too.
2016-04-12 18:12:15 +02:00
Stefan Tröger
afee98c1e9 allow to add faces to fillet and chamfer 2016-04-12 18:12:07 +02:00
jrheinlaender
6639fc978f Allow selecting and removing fillet and chamfer references in the dialog 2016-04-12 18:11:56 +02:00
jrheinlaender
a6de951e1d Unify code of Dressup features (part 1: Draft) 2016-04-12 18:11:56 +02:00