Commit Graph

26910 Commits

Author SHA1 Message Date
Ajinkya Dahale
8113f12337 [PD] Set revolution taskview items based on method 2023-11-14 00:20:20 +05:30
Ajinkya Dahale
c7101d7ced [PD] Support two-angle/up-to-face groove
Elements copied from revolution and pocket feature.
2023-11-14 00:20:20 +05:30
Ajinkya Dahale
796727fcd3 [PD] Use enum class for revolution method 2023-11-14 00:20:20 +05:30
Ajinkya Dahale
7a6927ca78 [PD] Update revolution properties based on method 2023-11-14 00:20:20 +05:30
Ajinkya Dahale
43a8104926 [PD] Refactor FeatureRevolution further
New methods created to reduce size of `execute`.

Use BRepPrimAPI instead of BRepFeat whenever possible since otherwise there are
some limitations.
2023-11-14 00:20:19 +05:30
Ajinkya Dahale
149738af7f [PartDesign] Refactor mode support in revolution
Encodes support for "two angles".
Clarifies that up-to-first and up-to-last is not supported.
2023-11-14 00:20:19 +05:30
Ajinkya Dahale
5a51a490a8 [PartDesign] Some more dummy functionality for revolution
[PD] Some more setup

[PD] Some refactor in `TaskRevolutionParameters`
2023-11-14 00:20:19 +05:30
Ajinkya Dahale
82b5e16cd1 [PartDesign] Add some dummy options for revolution
These options correspond to "up to face" and "2 angles". They are expected to do
nothing right now. However there is also some experimental code for "up to face"
in this commit, whose behavior is not confirmed.
2023-11-14 00:20:19 +05:30
wandererfan
9b377c83d4 [TD]fix regression on Links with scale 2023-11-13 12:21:10 -05:00
sliptonic
f01c8b7fc2 Merge pull request #11368 from LarryWoestman/staging
Path:  Rearranged and renumbered some of the tests
2023-11-13 11:19:56 -06:00
Abdullah Tahiri
f63a06afa8 SketcherGui: ArcSlot lints 2023-11-13 18:19:10 +01:00
Abdullah Tahiri
1a880d3e12 SketcherGui: Fix lints 2023-11-13 18:18:50 +01:00
Roy-043
f77c5fdcd7 Draft: remove the tolerance preference
The tolerance function now derives its value from the precision preference.

Additonally:
Removed the epsilon() function. It did not make sense and was not used.
2023-11-13 18:07:37 +01:00
sliptonic
b0694a3930 Merge pull request #11337 from yorikvanhavre/start-timeformat
Start: Fixed default time format
2023-11-13 10:59:49 -06:00
sliptonic
462a354664 Merge pull request #11223 from wwmayer/Part_format_xml
Part: format XML files
2023-11-13 10:52:03 -06:00
sliptonic
2f92f43867 Merge pull request #11136 from FlachyJoe/fix_11135
PD: Pad to the base shape
2023-11-13 10:46:54 -06:00
Paddle
6b89039661 ArcSlot DSH : implement the Arc slot tool with tool parameters support. 2023-11-13 15:05:36 +01:00
Paddle
83db40179b Circle DSH : Implement tool parameters. 2023-11-13 14:00:18 +01:00
Paddle
28744a9bbc Ellipse DSH : add cursor texts and remove showInternal checkbox. 2023-11-13 14:00:18 +01:00
Paddle
ccbe4c1c49 Ellipse DSH : Implement tool parameters. 2023-11-13 14:00:18 +01:00
Paddle
314449cef9 Arc DSH : implement tool parameters. 2023-11-13 14:00:18 +01:00
Paddle
c2bb84de8e DSH : modify drawDoubleAtCursor so that it can draw an angle. 2023-11-13 14:00:18 +01:00
Paddle
dfd4d6a6d9 Adds areColinear function to Utils. 2023-11-13 14:00:18 +01:00
Paddle
d8d1692bcb Adds CircleEllipseConstructionMethod. 2023-11-13 14:00:18 +01:00
wmayer
ceeacb5f7d RE: Allow to create planes from several selected meshes, remove ... from menu text 2023-11-13 10:38:41 +01:00
LarryWoestman
f3a9dc8d8d Path: Rearranged and renumbered some of the tests 2023-11-12 16:45:06 -08:00
Roy-043
220bf83222 Draft: remove unused dimorientation and saveonexit prefs 2023-11-12 20:54:25 +01:00
Roy-043
88cd41416e Draft: Draft_SelectPlane did not trigger the grid 2023-11-12 20:16:34 +01:00
Florian Foinant-Willig
230d355e1d PartDesign_Pad: add an up to shape mode 2023-11-12 20:06:57 +01:00
Abdullah Tahiri
cd601fb488 Sketcher: DSH Default - improve return value of ShapeGeometry functions
=======================================================================

Previous version return an reference to the smart pointer to generic Part::Geometry.

This version returns a type specific naked pointer, while ShapeGeometry keeps ownership
and memory management, so if an arc is created a Part::ArcOfCircle is returned.
2023-11-12 17:53:36 +01:00
Abdullah Tahiri
99889ac487 Sketcher: Box Selection - refactor
==================================

Full refactor of this function without change of functionality (hopefully).
2023-11-11 21:19:12 +01:00
Abdullah Tahiri
6eb55822a0 Sketcher: Box selection - Hyperbola/Parabola endpoint fix 2023-11-11 21:19:12 +01:00
Abdullah Tahiri
2d499873b0 Sketcher: DSH - improving geo creation helpers for ShapeGeometry
================================================================

In some DSHs instead of the convenience function, the code is being duplicated because
of the need to access the geometry after pushing it to the std::vector.

This commit leverages emplace_back return reference to improve code reuse.
2023-11-11 21:18:20 +01:00
pre-commit-ci[bot]
dce4dc3518 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-11-11 18:21:31 +01:00
bgbsww
640de8ceb2 Fix 10545 by using position of array members 2023-11-11 18:21:31 +01:00
wandererfan
22a73f7d2f [TD]fix 3x extension circle methods #11310 2023-11-11 07:48:03 -05:00
wandererfan
6ccf57b3a2 [TD]add 2 utility methods
- toAppSpace converts qt point to app view coords
- angleWithX(Base::Vector3d) returns [0,2pi]
2023-11-11 07:48:03 -05:00
Abdullah Tahiri
c4085b0a8f Sketcher: Adapt DSHs to new dynamic cursor 2023-11-11 11:15:54 +01:00
Abdullah Tahiri
1d0c72a685 Sketcher: DSHController - extend framework to make cursors OVP visibility dependent 2023-11-11 11:15:54 +01:00
Abdullah Tahiri
c863f2f341 Sketcher: DSH - new cursor drawing functions 2023-11-11 11:15:54 +01:00
pavltom
9de796d4e6 [TechDraw] Issue #6527 - Implement face transparency 2023-11-10 10:48:06 -05:00
wandererfan
3d9c37c3e3 [TD]fix Print Center Marks #11309 2023-11-10 09:30:19 -05:00
wandererfan
458b7ca5ac [TD]Fix margins on PDF output #11308 2023-11-10 09:30:19 -05:00
Yorik van Havre
370455399b Start: Fixed default time format - fixes #10793 2023-11-10 14:10:43 +01:00
Roy-043
89c967008d Draft: Improve grid behavior
This PR improves the behavior of the Draft grid:
* Options in the preferences: "Always show the grid" and "Show the grid during commands".
* The parameters are used for new views. In existing views the grid can be toggled either during a command or when no command is active.
* When switching to a different workbench all grids are hidden unless GridHideInOtherWorkbenches is set to `False`. This can be a Fine-tuning parameter IMO.

Notes:
* The defaultCameraHeight parameter becomes obsolete. It was only used in very specific circumstances.
* The code of PR #8818 becomes obsolete. It makes more sense to use `App.activeDraftCommand` instead of adding a `tool` argument to some functions. Will do some related cleanup later.
* Improved alignment for the related preference ui. The checkbox interaction has been fixed as well.
2023-11-10 14:02:38 +01:00
Roy-043
b3a06b746b Arch: make Arch_CutPlane nesting and link aware
Forum topic:
https://forum.freecad.org/viewtopic.php?t=82340
2023-11-10 11:04:27 +01:00
Roy-043
1205925ec8 MEASUREMENT should also be checked if INSUNITS is zero 2023-11-10 10:21:54 +01:00
Roy-043
6458f4dd53 Avoid Python match function 2023-11-10 10:21:54 +01:00
Roy-043
86788e3777 Draft: fix import scale for Legacy DXF importer
Fixes #10253.
2023-11-10 10:21:54 +01:00
czinehuba
12a34be4a6 Update iso10642.json (#11302)
* Update iso10642.json

Update ISO10642 with M2 and M2.5 sizes

* Update iso10642.json

Updated dimensions
2023-11-09 12:26:56 -06:00