kindred/create
1
1
Fork 0
Code Issues 43 Pull Requests Actions 2 Packages Projects 9 Releases 2 Wiki Activity
27,578 Commits 40 Branches 6 Tags
414ac4cb7d06ccedeb05373aa8b316a0f42c29f4
Commit Graph

1852 Commits

Author SHA1 Message Date
Uwe
414ac4cb7d [PD] ViewProvider: remove unused includes 2022-02-17 04:43:16 +01:00
Uwe
aa02ab5c66 [Part] add context menu icon for color face 
- the other context menu entries have icons and we use this icon already in the View menu

- also sort the includes
 2022-02-17 03:20:31 +01:00
wmayer
95f583a677 Part: fix typos in make* functions 2022-02-16 12:48:02 +01:00
Uwe
7786e24fcd [PD] change default FaceMaker to Bullseye 
Part does already use this FaceMaker since it can also handle islands.

The PR therefore
- uniforms the behavior of PD and Part
- fixes #6366
- enables to use nested sketches for the various PD features like Revolve
 2022-02-16 11:20:02 +01:00
wmayer
58a70cbbe5 Part: define Part_SectionCut as permanent menu item 2022-02-14 16:48:09 +01:00
Yorik van Havre
19b89b1085 Merged crowdin translations 2022-02-14 12:31:57 +01:00
Uwe
68a5c7e438 [PD, Part] bring section cutting feature back to the View menu 
As discussed here:
https://github.com/FreeCAD/FreeCAD/pull/6213#issuecomment-1033696604
the feature makes not much sense when only available from within the Part menu.

For now, bring it at least back to the View menu for Part and PD
 2022-02-14 01:34:55 +01:00
Uwe
9b1245ab5f [PD] use Part's face coloring 
like for the measurement features of Part, the color per faces can be used for PD too
 2022-02-14 01:01:40 +01:00
wmayer
15ff4c8f94 PD: for better cohesion do not call generateTaperedPrism inside generatePrism 2022-02-14 00:46:48 +01:00
wmayer
32ae033b43 PD: restore old method name and fix doxygen documentation 2022-02-13 22:30:17 +01:00
Uwe
dc332a5ca0 [PD] moves Extrude code to FeatureExtrude 
* [PD] moves Extrude code to FeatureExtrude

- since the Extrude code is only used by Pocket/pad, it should better in FeatureExtrude
 2022-02-12 19:37:53 +01:00
wmayer
09a05a9cd0 Part: Circle variable name change to create consistency 
Change variable names of the Circle from Angle0 to Angle1 to create consistency with all other named angle variables
 2022-02-11 18:28:58 +01:00
0penBrain
aed8864cd9 Modernize signal/slot connection for real :) 2022-02-08 17:51:36 +01:00
wmayer
5c9bffb73d PD: fix 'stack-use-after-scope' crash 2022-02-08 17:16:59 +01:00
Uwe
d9f8516c4a [PD] Extrude: modernize SignalSlot connection 
as suggested recently by @chennes
 2022-02-04 22:20:31 -06:00
Uwe
eb0c313506 [PD] Extrude: handle angle edit visibility 
- adds missing code to handle the edits for the taper angle
 2022-02-05 02:11:14 +01:00
Mark Ganson TheMarkster
aa76cbc875 [PartDesign Fillet/Chamfer] add UseAllEdges boolean property (#5340) 
- [PartDesign Fillet/Chamfer] add UseAllEdges boolean property
- add UseAllEdges checkbox to fillet and chamfer dialogs
- put UseAllEdges property into Chamfer and Fillet groups, create Fillet group for fillets and put Radius into it, too.
 2022-02-05 01:50:51 +01:00
Uwe
cfdf334b7f [PD] add option to create tapered Pad / Pocket 
This PR adds the same functionality as provided by Part Extrude.
The used code parts are sorted out to a new helper function that is used by Part and PartDesign.
 2022-02-02 01:04:06 +01:00
Yorik van Havre
b0b1c0afbb Merged crowdin translations 2022-02-01 12:59:42 +01:00
wmayer
ad7ab573eb PD: PrefQuantitySpinBox now requires an explicit entry name for the parameter group 2022-01-31 16:47:08 +01:00
Yorik van Havre
b3e2c87530 Merged crowdin translations 2022-01-26 14:15:14 +01:00
Uwe
09d7b44495 [PD] uniform default Pad/Pocket lengths 
- the initialization of the length was different than the default set in Command.cpp
- it is annoying that the default 2nd length was 10 and 20 times the default for the 1st length
  -> uniform and take the same than the 1st length
 2022-01-23 13:42:07 +01:00
wmayer
59c470dedf PD: fix bad formatting 2022-01-23 11:07:59 +01:00
Uwe
ad24b32fef Revert "[PD] uniform default Pad/Pocket lengths" 
This reverts commit 501b45bac8.

Sorry, this should have gone to a PR
 2022-01-23 05:06:38 +01:00
Uwe
501b45bac8 [PD] uniform default Pad/Pocket lengths 
- the goal of the recent Pad/Pocket code refactoring was to handle Pad and Pocket the same
  default Pad were 10 long, Pocket only 5 -> uniform this to 10
- the initialization of the length were different than the default set in Command.cpp
- it was annoying that the default 2nd length was 10 and 20 times the default for the 1st length -> uniform and take the same than the 1st length
 2022-01-23 04:58:58 +01:00
Uwe
62ed6b509e [PD] FeatureSketchBased: only style fixes 
to reduce diffs of coming and pending PRs

all fixes were automatically made by MSVC
 2022-01-23 04:50:52 +01:00
Uwe
3c7ed89306 [PD] correct copyright year 
both files were created in 2021
 2022-01-23 04:45:12 +01:00
0penBrain
e3c0a43797 [PartDesign] Allow single (viewport) click for mapping feature selection 
Parameter 'singleClickFeatureSelect' can be used to enable/disable
 2022-01-22 16:14:30 +01:00
0penBrain
5bbd24e48d Display Midplane checkbox with Pocket/ThroughAll 
Was enabled but not visible.
Hopefully last time I fix it. :)
 2022-01-22 10:34:14 +01:00
wmayer
af868ed079 PD: move ReferenceHighlighter to Part module 2022-01-18 18:24:02 +01:00
wmayer
f9b37729fe PD: add PD test modules to __init__.py 2022-01-18 18:02:10 +01:00
Jonas Bähr
96e7c6b3b5 PD: Add tests for InvoluteGear 
There are some basic tests to cover the gear profile and its parameters
and some integration tests for the interaction with PD Pad and Pocket.

I followed the same pattern as the other PartDesign tests, e.g. not using
PEP8 style method names. Eventually some helper methods could be
extracted and moved to the common base framework in Mod/Test, but that's
another step.
 2022-01-18 17:43:52 +01:00
Ajinkya Dahale
d5ae0777d0 [PD] Correct include guard name 
Correction in `PartDesignGui::ReferenceHighllighter`
 2022-01-18 03:01:20 +01:00
wmayer
6461f9f6d2 PD: [skip ci] make uniform the license text of test modules 2022-01-17 16:38:10 +01:00
wmayer
2d1c083d9a PD: fix crash in thickness dialog when clicking 'Add Face' button 2022-01-16 18:59:26 +01:00
wmayer
f147986fa9 App: Bugfix for NULL-Pointer dereference of Property->getName() 2022-01-16 14:30:51 +01:00
Chris Hennes
089b18f868 Part Design: Missing = 2022-01-14 09:38:45 -06:00
Uwe
66864bbe7b [PD] Pad/Pocket: sort out duplicated code 
the checkboxes are almost identical and it avoids work to have them in one location
 2022-01-14 13:17:25 +01:00
wmayer
a1a8de633c PD: fix small inconsistence, use forwared declaration 2022-01-14 12:22:16 +01:00
Ajinkya Dahale
b2e6f91c1d [PD] Use buttonToggled signal in PD pipe 
Combines other button toggle methods/signals/slots involved.
 2022-01-13 22:31:05 -05:00
Ajinkya Dahale
1296e2c417 [PD] Use Gui::ButtonGroup in TaskDlgPipeParameters 2022-01-13 22:31:05 -05:00
luz paz
19e984f8c9 Fix various typos 
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childrens,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,inout,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oce,oder,ontop,orgin,orginx,orginy,ot,pard,parm,parms,pres,programm,que,rady,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
 2022-01-12 14:50:39 -06:00
Uwe
626425526b [PD] sort out more Pad/Pocket code 
as suggested in #5349
 2022-01-10 14:33:02 +01:00
Yorik van Havre
e33ef084ff Merged crowdin translations 2022-01-10 11:23:59 +01:00
luz paz
b0fcf45513 Fix various superfluous whitespace in *.dox files 2022-01-09 21:01:42 -06:00
David Österberg
2ba95b3423 PartDesign: Improve orientation behaviour for conical helices (#5363) 
* PartDesign: Improve orientation behavior for conical helices

As identified in the forum
https://forum.freecadweb.org/viewtopic.php?f=3&t=65136

The Freenet orientation mode does not give expected results for helices with cone angle.
By using an auxiliary helix that is axially offset it is guaranteed that the orientation frame
is always consistent with a cylindrical coordinate system.

Results will be the same as before when cone angle is 0.
 2022-01-09 22:13:15 +01:00
Uwe
f84d32d1b6 [PD] sort includes 
- to keep the overview
- removed double entries
- will make diff of pending PRs smaller
 2022-01-09 21:36:07 +01:00
wmayer
f1a265479d PD: declare signedLengthConstraint in FeatureExtrude as static class member 2022-01-09 10:53:04 +01:00
David Osterberg
968a9d83ae PartDesign: Silence noisy FeatureTransformed 
Remove several report view messages that are not necessary for everyday use.
By request from the forum (https://forum.freecadweb.org/viewtopic.php?f=3&t=64900&start=20#p558962)
 2022-01-08 15:30:39 +01:00
Uwe
38cc6f29e0 [PD] Pad /Pocket: remove unused code 2022-01-08 03:24:09 +01:00