kindred/create
1
1
Fork 0
Code Issues 30 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
26,377 Commits 41 Branches 6 Tags
414f4d706e89c00ce987ed349692c4243ee6f03a
Commit Graph

41 Commits

Author SHA1 Message Date
donovaly
f481c47123 [PD] fix multi-transform View 
- fixes bug 4581
  See the first issue reported here:
  https://forum.freecadweb.org/viewtopic.php?f=3&t=56093#p482553

- also fix issue that one could set 1 occurrence for polar patterns despite 2 are required at least

- also fix potential dereferencing null pointer (reported by MSVC)
 2021-03-01 13:11:15 +01:00
Chris Hennes
41a40c1c31 [PD] Catch Python exceptions in dtors (Coverity) 
In some PartDesign task dialogs, the destructors call functions that may
throw exceptions. If that occurs and the exception is uncaught, this
will ususally end up terminating the program. This commit adds try-catch
blocks around each instance of that (identified by Coverity) and handles
the Python exception in the normal reporting workflow.
 2021-02-08 21:30:22 +01:00
donovaly
2ac84872ec [PD] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for PartDesign

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all PartDesign dialogs that don't already use a unique_ptr.
 2021-02-05 18:01:57 +01:00
luz paz
faa8688ee5 PartDesign: Issue #0004473: Expose openCommand() to translation 
Continuing the work to expose the undo/redo functionality to translation. This commit does so for the PartDesign Wb.  
Ticket: https://tracker.freecadweb.org/view.php?id=4473
 2020-12-01 14:53:35 +01:00
mwganson
432ac985e7 [PartDesign Multitransform] prevent crash when pressing delete key without feature selected to remove in multitransform dialog 2020-10-12 16:36:11 +02:00
wmayer
a9af418698 PartDesign: [skip ci] move indexesMoved() to base class TaskTransformedParameters to avoid code duplication 2020-07-31 13:16:44 +02:00
donovaly
d5787f9bda [PD] allow to change feature order in patterns 
As discussed here: https://forum.freecadweb.org/viewtopic.php?f=27&t=48998#p420352
The pattern dialogs need a feature to change the order of the features to be patterned
 2020-07-31 11:47:31 +02:00
donovaly
5aa15e7d71 [PD] spread the fix from commit fa963d36d1 to 3 other affected dialogs 2020-02-15 17:00:26 +01:00
wmayer
88a60f91e9 PartDesign: use QKeySequence::Delete instead of a QString 2020-02-14 10:11:09 +01:00
donovaly
5ca8b490f0 [PD] add shortcut to context menus 
- people should be informed that there is a shortcut available (that was recently added)
- make the shortcut also translatable since "Del" means nothing in e.g. German
- minor code style fix in TaskDressUpParameters.h
 2020-02-14 09:59:46 +01:00
luz.paz
d38f18af23 PartDesign: [skip ci] fix header uniformity 
This PR fixes header uniformity across all PartDesign WB files
 2019-12-22 00:58:38 +01:00
Zheng, Lei
11a93a0578 PartDesign changes 
* Mostly for supporting in-place editing

* Add new SubShapeBinder that support cross coordinate system,
  external, and sub-object binding
 2019-08-17 15:15:47 +02:00
wmayer
10c745175f support Del shortcut in several PD task dialogs 2019-02-27 13:36:45 +01:00
sL1pKn07
018b41032a [For v018] Fix build with Qt5 beta 
Seems need add some headers for build with incoming Qt 5.11 (Tested with 5.11.0beta2)
 2018-04-10 12:59:41 +02:00
wmayer
5a1a88568a harmonize creation of linear pattern inside a multi transform to direction creation of linear pattern 2017-09-29 23:57:31 +02:00
wmayer
3769d38e89 fix dangling pointer when cancelling multi-transform task panel 2017-09-29 19:18:34 +02:00
Itai Nahshon
2e2c041885 PartDesign: Multi Transform Linear Pattern fix. 2017-09-16 01:25:14 +03:00
wmayer
09737f2db3 rename method from remObject to removeObject to be more readable 2017-09-13 18:57:38 +02:00
Stefan Tröger
034219771f PartDesign: Prevent problems with link scopes during feature creation 2017-09-09 16:55:55 +02:00
wmayer
9c49a0bab1 issue #0001649: Changing names on Pads does not change them everywere 2016-10-21 15:45:50 +02:00
wmayer
6fef24f676 replace const char* with QString in removeItemFromListWidget 2016-10-21 13:48:45 +02:00
wmayer
664cf65d26 fix -Wextra in PartDesign 2016-09-22 18:34:56 +02:00
wmayer
63ad26491f fix Coverity issues 2016-08-22 15:02:18 +02:00
Alexander Golubev
9cba6c48ea PartDesign/TaskMultiTransformParameters: fix a segfault 
The segfault was caused by premature delete of object
TaskMultiTransformParameter::subFeature refered to.
Steps to reproduce:
1. Create a multitransform
2. Add a sub transfurmation to it
3. Press cancel
 2016-04-12 18:12:16 +02:00
Alexander Golubev
113c10a2b7 PartDesign: make transform parameter dialogs use common base code with other dialogs 
subj;
Make PasrtDesign::Transformed provide common for all features
classes interface getBaseObject() instead of specific getSupportObject ();
Refactor some TransformedParameters methods.
 2016-04-12 18:12:16 +02:00
Jan Rheinländer
deb9e85d03 Fixed crash after rejecting a MultiTransform dialog 2016-04-12 18:12:00 +02:00
jrheinlaender
5376e3a3e5 Fixed bugs in various features that reversed the list of selections 2016-04-12 18:11:57 +02:00
jrheinlaender
fcea39b0d8 Enable multiple originals for the transformed features 2016-04-12 18:11:56 +02:00
jrheinlaender
f9b0e5908a Allow transforming a Pattern feature into a MultiTransform feature 2016-04-12 18:11:54 +02:00
jrheinlaender
7330d4357e Made the rest of the PartDesign features aware of the Body 2016-04-12 18:11:49 +02:00
Mateusz Skowroński
cd2db00f22 QString::fromAscii() is obsolete in Qt5. Replace it with fromLatin1(). 
This change is Qt4/Qt5 neutral.
 2016-01-05 16:07:25 +01:00
Eivind Kvedalen
ddfbe349cf PartDesign: Added support for expressions. 2015-09-21 14:51:09 +02:00
logari81
525cddaaf3 PartDesign: Refactor pattern features and gui 
- remove StdDirection,StdAxis and StdMirrorPlane properties
- support sketch H_Axis, V_Axis, N_axis as valid references in patterns
- polish reference selection gui (unified for standard axes and custom references)
 2013-01-09 23:18:38 +01:00
logari81
e7f3b07115 PartDesign: exit selection mode when closing a MultiTrasnform subtask and small space improvements 2012-09-15 10:12:33 +02:00
jrheinlaender
08043f46c2 PartDesign: make MultiTransform honour the "Update view" checkbox when adding transformations 2012-09-14 00:16:43 +02:00
jrheinlaender
e5d1643878 PartDesign: fix bug when adding transformation to MultiTransform 2012-09-13 16:22:48 +02:00
logari81
f0917eff39 PartDesign: fix bug in checkbox "Update View" of pattern features and do some code refactoring 2012-09-13 15:46:46 +02:00
logari81
8b35efdb83 PartDesign: restrict patterns to only one original and improve selection of references 2012-09-11 16:54:45 +02:00
logari81
afc794894f PartDesign: fix small issue with embedded TaskPanels in MultiTransform 2012-09-10 11:37:48 +02:00
logari81
16047f452f PartDesign: select references for Pattern features from original object 2012-09-09 09:19:18 +02:00
jrheinlaender
b30a49ece3 PartDesign: implement Transform and Pattern features 2012-09-07 11:55:26 +02:00