Wanderer Fan
4da3c21dcf
[TD]Allow override of dimension line angles
2022-01-27 09:42:49 -05:00
Aapo
253817e3e9
[TD] Add new non-standard format specifier '%w' that truncates trailing zeros.
2022-01-21 11:24:44 -05:00
Wanderer Fan
e91cc8e329
[TD] avoid memory leaks by using shared_ptr
...
TD geometry objects are sometimes double deleted. This
change uses shared_ptr instead of raw pointers to manage
deletions.
2022-01-07 13:34:20 -05:00
wmayer
c11d5df80a
TD: replace usage of raw pointers of Vertex and Face with shared pointers.
...
This fixes issue 4741: Broken File After Using Landmark Dimension in TechDraw
2021-12-10 14:25:24 +01:00
Chris Hennes
cbdc2ac48e
[TD] Remove deprecated Qt < 5.9 code
2021-04-02 12:02:54 +02:00
Benjamin Nauck
d358e13cd6
TechDraw: [skip ci] convert source files from iso-8859 to utf-8
...
All other source files are either plain ascii or utf-8, this converts
the last few to utf-8.
2021-03-25 18:02:12 +01:00
Aapo
51194d67d5
[TD] Hotfix for Dimension label Arbitrary value regression in DrawViewDimension.cpp
2021-02-25 10:28:42 +01:00
Aapo
4ea0784341
[TD] Dimensions: donovaly's minor fixes for TheoreticalExact dimensions.
2021-01-31 15:17:46 +01:00
Aapo
e802179cf4
[TD] Improve arbitrary tolerance and unit handling for Equal Tolerances.
2021-01-31 15:17:46 +01:00
Aapo
660710c26e
[TD] Add under- and overtolerances for Dimension Task layout, fixes for Dimension tolerance refresh and behavior.
2021-01-31 15:17:46 +01:00
Aapo
a2f060e36e
[TD] Fix degree sign processing for equilateral angular plusminus dimensions.
2021-01-31 15:17:46 +01:00
Aapo
d26b6542ca
[TD] Fix regression in Dimensions: Setting arbitrary under tolerance was somehow lost.
2021-01-31 15:17:46 +01:00
Aapo
1c02a2ae9f
[TD] Fix Dimension unit printing problem for US building units and other multivalueschema.
2021-01-18 21:52:35 +02:00
donovaly
fc91b251ee
[TD] add dialog to modify some dimension settings
...
also fix issue that tolerance could be set despite theoretically exact is true under some circumstances
also some wording improvements
also a minor fix to use 0.0 instead of DBL_MIN
2021-01-15 05:21:49 +01:00
donovaly
2b0a13f71d
[TD] don't allow tolerances for exact values
...
as discussed here: https://forum.freecadweb.org/viewtopic.php?f=35&t=54218
when a value is theoretically exact it must not have a tolerance
This PR
* fixes this
* also fixes the bug that OverTolerance must not be negative if the tolerances are equal
2021-01-13 04:05:31 +01:00
donovaly
e8d76d49bf
[TD] some fixes
...
- the setting "Standard and Style" only affects new dimensions, thus it must be italic
- fix bug that the Property 'LockPosition' appears for dimensions -> this is an option for views and thus must be hidden for dimensions
- since tolerances are in the vast majority fractions of a millimeter/inch, set its stepsize to 0.1
(I hope I did it right in handleChangedPropertyType.)
- fix inconsistent newlines in TaskBalloon.h
- improve wording for a heading
2021-01-10 00:29:34 +01:00
donovaly
714a716575
[TD] handle equal tolerances correctly
...
the common rule is that if a dimension has equal over- and undertolerance, they are output on the same line as the dimension concatenated using the ± character.
This PR does this.
Note that this is not just cosmetics, it is even standardized in the GD&T norms.
also:
* use one format specifier for tolerances since the norms don't allow a different format for the over- and the undertolerance
* some code optimizations like a self-explaining function name, remove unnecessary/outdated comments
2021-01-08 15:14:37 +01:00
Aapo
079b8ff5c3
[TD] DrawViewDimension Tolerances, print zero tolerances without plus sign and decimals.
2020-12-30 18:49:59 +01:00
donovaly
30fcddae40
[TD] fix bug with angular and small values
...
* angular as reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53473&start=10#p461507
* small values: since we convert to e.g. mm, we must then not output e.g. 'µm'
* also a code optimization, fix a typo, removal of a meanwhile misleading comment
2020-12-30 16:20:27 +01:00
donovaly
7dea668381
[TD] fix unit conversion for dimensions
...
as reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=53473
my commit cbcf45a4b9
2020-12-21 01:27:41 +01:00
Aapo
97e3947948
[TD] Make Dimension Tolerances respect the Prefs formatSpec when creating a Dimension.
2020-12-17 17:30:29 +01:00
donovaly
38734f4f86
[TD] treat dimensions the same way, no matter if with unit or not
...
fixes the issue reported here: https://forum.freecadweb.org/viewtopic.php?f=35&t=52545&start=40#p454483
2020-12-05 03:58:39 +01:00
Mark O'Donovan
bc3f90663e
Remove unused variable in DrawViewDimension.cpp
2020-12-04 17:13:56 +01:00
donovaly
8fe7ca0c21
tolerances can be negative, thus the decimal precision check must be adapted
2020-12-03 15:50:06 +01:00
donovaly
0baabcaa45
[TD] fix unit mismatch bug
...
- also make global decimal option italic since it only affects new dimensions
- also fix a typo in UnitsApi.h
2020-12-03 15:50:06 +01:00
wmayer
578e4aca14
[TD] add an enum to avoid to work with plain numbers
2020-12-02 16:42:21 +01:00
wmayer
e95b3167dd
[TD] use PropertyQuantity for OverTolerance and UnderTolerance and add backward compatibility
2020-12-02 16:42:10 +01:00
aapo-aapo
e71b7ac879
@aapo-aapo @chennes [TD] Suggested minor improvements for DrawViewDimension.cpp and QGIViewDimension.cpp in Pull request review.
...
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org >
2020-12-02 16:38:21 +01:00
Aapo
3f623576d5
[TD] Add tolerance format specifiers and arbitrary tolerances.
2020-12-02 16:38:21 +01:00
Aapo
768a2b1f11
[TD] Make tolerance labels use the same formatValue() conversion as dimension labels. Support MultiValueSchemas for tolerances, too.
2020-12-02 16:38:21 +01:00
Aapo
c695b4009b
[TD] Refactor DrawViewDimension getFormatedValue() into two functions.
2020-12-02 16:38:21 +01:00
Aapo
31d6c7528d
Refactor code in DrawViewDimension::getRefType() shorter and simpler. No functional change except subelement sizes > 3 are supported, even though they are not supposed to happen.
2020-11-19 13:40:42 +01:00
Aapo
bda3e700fa
[TD]fix V2E DistanceX,Y to always use the closest point of edge to the vertex.
2020-11-18 14:54:44 +01:00
wandererfan
ad1b48b73d
[TD]fix V2E DistanceX,Y
2020-08-30 18:59:11 -04:00
wmayer
dccb2a3c3c
PVS: V523 The 'then' statement is equivalent to the 'else' statement
2020-07-18 10:59:27 +02:00
wandererfan
c19fae2cbb
[TD]Treat Imperial1/USCustomary as single value schema
2020-06-15 13:57:55 -04:00
wandererfan
9fb162f5ba
[TD]missing prefix/suffix for compound schema
2020-06-15 13:57:55 -04:00
wandererfan
e80c576241
[TD]Centralize preference getters
2020-04-24 11:13:49 -04:00
wandererfan
ee626abef4
[TD]synchronize defaults in code and prefs
2020-03-16 08:57:08 -04:00
Tobias Ellinghaus
4ce9fbc57c
TD: Fix decimal separator of dimensions
...
When the system separator isn't '.' we want to make sure to use it.
2020-03-14 08:04:49 -04:00
wandererfan
b7146a5ea3
[TD]fix crash on RenderMode = NONE
2020-03-11 18:17:46 -04:00
wandererfan
e0eda0de58
[TD]expose dimension arrow position to Python
2020-03-02 08:37:19 -05:00
wandererfan
96e8f752be
[TD]Landmark Dims initial impl
2020-02-25 17:21:00 -05:00
wandererfan
dcc2790834
[TD]fix potential nullptr while restoring
2019-12-30 18:20:48 -05:00
wandererfan
6a31795600
[TD]improve presentation of tolerance text
2019-12-18 07:01:46 -05:00
wandererfan
186d52ffd4
[TD]fix dim text for multi value schemas
2019-12-05 07:10:08 -05:00
wandererfan
a7ad04ba4a
[TD]const-ness for dump function parameter
2019-11-10 15:58:45 -05:00
wandererfan
c773e20bf3
[TD]Always show degree symbol
2019-11-07 16:59:10 -05:00
wandererfan
5cab111a65
[TD]Implement unique tags for Cosmetic Vertex
2019-11-02 14:59:32 -04:00
wandererfan
5bb659e7e2
[TD]Transition to on demand page updates ph1
2019-10-23 14:19:52 -04:00
