kindred/create
1
1
Fork 0
Code Issues 51 Pull Requests 1 Actions Packages Projects 9 Releases 2 Wiki Activity
42,353 Commits 40 Branches 6 Tags
43bcb7205d3a5213538599bf7bbe40ac4eb8cbe9
Commit Graph

2757 Commits

Author SHA1 Message Date
Kacper Donat
8fe791bd6f Merge pull request #22169 from 3x380V/fix_19002 
PD: Fix regression about single-solid check
 2025-06-25 21:40:05 +02:00
wmayer
23d93e45ff PD: Correctly handle single solid rule for loft with and without base 2025-06-25 00:14:15 +02:00
wmayer
4ac7f57ac4 PD: Use isSingleSolidRuleSatisfied() for pipe feature 
This fixes issue 18977

Fixes: 935bdf9a0f ("PartDesign: Refactor single-solid rule enforcement")
 2025-06-25 00:13:54 +02:00
wmayer
eb52dd4a9a PD: Fix regression about single-solid check 
For several PD features the single-solid check fails. The regression
is caused by PR 13960 and reported as issue 19002. The reason for the
failure is that the first solid of the output shape is retrieved and
then checked for a single solid. This test will always pass, of course.

The single-solid is fixed for these features:
* Pad
* Pocket (never worked there)
* Fillet
* Chamfer
* Groove (never worked there)
* Revolution (never worked there)
* Loft

Fixes: 935bdf9a0f ("PartDesign: Refactor single-solid rule enforcement")
 2025-06-25 00:09:33 +02:00
Bas Ruigrok
699c06dd0c PartDesign: Remove use of adjustCameraPosition() 2025-06-23 19:28:56 +02:00
David Tanana
e17a83fa1f PartDesign: Added 1 3/16 16 threaded drill hole diameter (#22000) 
* Adding UNf 1 3/16  16 to this list
* Updating type and test params
 2025-06-17 08:59:00 -05:00
wmayer
456659d763 Test: Do not write test files into CWD 
When running the tests make sure to write the test files into the temp directory.

This fixes issue 19112
 2025-06-10 17:11:25 +02:00
wmayer
017f2c8842 Helper function to get preferred delete key depending on platform 2025-06-09 18:10:52 +02:00
Chris Hennes
272c3034b4 Merge pull request #21659 from 3x380V/gui_fixes 
Gui: random fixes
 2025-06-03 19:23:21 -05:00
Alfredo Monclus
69f3dae845 PD: hole change the task panel threaded and model thread checkboxes into a combo/dropdown (#21664) 
* PD: hole change threaded and modeled to combo in taskpanel

* Gui: Property editor apply review suggestions
 2025-06-03 21:14:52 +02:00
Kacper Donat
c6130552ca Merge pull request #21427 from tritao/async-occt-progress 
Part: Introduce `OCCTProgressIndicator` and port operations to support it.
 2025-06-02 18:04:38 +02:00
Alfredo Monclus
551c15b48f feat(PD): ISO tyre valve threads 2025-06-02 10:50:10 -05:00
Yorik van Havre
94144ecd99 Translations: Merged crowdin translations 2025-06-02 11:48:26 +02:00
Yorik van Havre
bba4a7b990 Translations: updated ts files 2025-06-02 11:07:28 +02:00
James Stanley
eadd0bc191 PartDesign: Add OCCT progress support to FeatureTransformed. 
Include `<Base/ProgressIndicator.h>` and bail out when
`Base::ProgressIndicator::getInstance().UserBreak()` returns true during
transformation loops and composite operations in
`FeatureTransformed.cpp`.
 2025-05-30 18:25:32 +01:00
wmayer
5d11b2938f Gui: Replace calls of FCMD_SET_EDIT with Gui::cmdSetEdit 2025-05-30 18:04:33 +02:00
theo-vt
13e7952ccc PartDesign: Fix hole centered on point edge case (#21257) 
* Light refactor of getTopoShape function

* Fix hole edge case

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Update src/Mod/Part/App/PartFeature.cpp

Co-authored-by: Kacper Donat <kadet1090@gmail.com>

* Refactor simplifyCompound()

* Use Base::Flags<GetShapeOption>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Shorten enum name and move it from class scope to namespace scope

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-05-29 22:37:54 +02:00
Alfredo Monclus
3aabb826aa PD: hole safeguard countersink depth calculation against possible math issues 2025-05-24 02:05:06 -06:00
Alfredo Monclus
07e7918baf PD: hole calculate counterbore and countersink if no standards are available 2025-05-23 20:51:35 -06:00
Alfredo Monclus
9bbddbc1f6 PD: hole fix head custom values checkbox not appearing 2025-05-23 20:51:28 -06:00
Alfredo Monclus
ff17eb611a PD: hole: calculate depth of countersink and adjust other parameters accordingly when changed 2025-05-23 17:36:26 -06:00
Alfredo Monclus
236c287f16 PD: hole: fix standarized head cuts not working in metric regular sizes 2025-05-23 14:15:44 -06:00
Alfredo Monclus
dc58468088 PD: move the base profiles types to the top 2025-05-15 23:31:55 +02:00
Chris Hennes
f5806841b6 Merge pull request #19907 from benj5378/getAttribute 
Base: make getAttribute template
 2025-05-12 10:39:55 -05:00
Benjamin Bræstrup Sayoc
492b8312b3 Base: make getAttribute template 2025-05-09 15:54:57 +02:00
theo-vt
e56979e76e PartDesign: Fix no longer possible to make a hole from one selected circle in a sketch (#21030) 
* Search for profile shape subelements without simplifying compounds for hole center detection

* Simpler solution
 2025-05-08 16:47:26 +00:00
Beep6581
601c0f9b09 PartDesign: Merge pull request #21015 from Beep6581/fix-thread-pitch 
Fixes hole thread pitch
 2025-05-07 21:53:09 +02:00
bofdahof
998f4e4d45 Console: rename PascalCase named methods to camelCase 2025-05-06 17:50:21 +02:00
Ladislav Michl
c293d74566 Base: rename Exception's PascalCase methods to camelCase 2025-05-05 23:50:01 +02:00
Kacper Donat
b5119d996b PartDesign: Use freecad_cast whenever possible 2025-04-26 14:23:25 +02:00
Florian Foinant-Willig
d6dd100266 PartDesign: Prevent user to remove core properties 2025-04-22 23:52:17 +02:00
theo-vt
774ec2cc93 PartDesign: Center holes on sketch points as well as circles and arcs (#20583) 
Co-authored-by: Kacper Donat <kadet1090@gmail.com>
 2025-04-21 23:30:57 +02:00
Alfredo Monclus
70007a28c1 refactor: add disambiguation to clearance hole names and use names from the standard (#19869) 
* PD: refactor: threadFit use standard naming and add disambiguation

* PD: fix: do not use variables for tr
 2025-04-21 09:54:23 -05:00
Florian Foinant-Willig
57b9a41335 PartDesign: Fix #20205 where Placement changes at Suppression 2025-04-16 20:39:58 +02:00
PaddleStroke
82ae162d5f PartDesign: TaskFeaturePick : Fix LCS temporary visibility 2025-04-15 21:19:34 +02:00
Benjamin Nauck
f932c7e4e0 Use Base::toRadians() instead of manually converting 2025-04-15 07:16:36 +02:00
Kacper Donat
a86c300688 Gui: Disable Show Placement for Body Features 2025-04-13 17:54:01 +02:00
Kacper Donat
b300c80b90 Base: Use explicit pointer syntax for freecad_cast (#20694) 
* Base: Use explicit pointer syntax for freecad_cast

This aligns our custom cast with other casts

* All: Use explicit pointer syntax for freecad_cast
 2025-04-11 14:11:33 +00:00
PaddleStroke
5195cb49de PartDesign : New sketch: Fix regression 2025-04-08 14:03:30 +02:00
Syres916
fa3c6e1068 [PartDesign] Fix spelling of auxiliary and curvilinear… 
…but also handle the properties name change from old files
 2025-04-07 11:30:51 -05:00
PaddleStroke
5639728e8a PartDesign: Fix use of App::Planes to create sketches (#20453) 2025-04-07 17:34:13 +02:00
Kacper Donat
35a9673a75 Base: Rename Base::freecad_dynamic_cast into freecad_cast 
This is to make it shorter and easier to use. QT does the same thing
with their qobject_cast.
 2025-04-07 10:32:28 -05:00
Benjamin Nauck
65a0fb0ed4 PartDesign: Add #include <limits> where used 2025-03-31 23:52:18 +02:00
Benjamin Nauck
98876d070d PartDesign: Use std::numeric_limits and std::numbers instead of defines 2025-03-29 13:32:38 +01:00
Joao Matos
ee4c9a6e8b PartDesign: Remove XML binding files. 2025-03-25 06:11:22 +01:00
karliss
f0fe00e16a PartDesign: Update counterbore min size in reaction to diameter changes (#20217) 
Can't rely purely on `TaskHoleParameters::threadDiameterChanged` to update it since the signal is intentionally blocked while syncing state to GUI.

Closes #19744
 2025-03-24 21:18:40 +00:00
Chris Hennes
723d16fcff PD: Eliminate unused variable in FeatureHole 2025-03-23 18:25:40 +01:00
PaddleStroke
8353c44958 PartDesign : Subshapebinder tooltip (#20023) 
* PartDesign : Subshapebinder tooltip

* Update src/Mod/PartDesign/Gui/Command.cpp

Co-authored-by: Furgo <148809153+furgo16@users.noreply.github.com>

---------

Co-authored-by: Furgo <148809153+furgo16@users.noreply.github.com>
 2025-03-22 11:21:31 -05:00
Chris Hennes
8f2e330a53 PD: Check threadType before using to index 
Coverity issue 545314
 2025-03-22 07:15:15 +01:00
tritao
16968aa3ee PartDesign: Convert XML bindings to Python API bindings model. 2025-03-21 23:14:24 +01:00