kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
42,472 Commits 41 Branches 6 Tags
43cb525948ae695aeb959bf2ab025dfea6d69e1c
Commit Graph

3427 Commits

Author SHA1 Message Date
flachyjoe
5389eeccb3 Improve Part.Shape methods documentation 
Formats UserDocu to follow the template:
 Description
 method(args) -> return
 --
 More infos
 2021-03-28 15:36:36 +02:00
luz paz
1a40cdfd43 fix source comment typos [skip ci] 
Found via  codespell v2.1.dev0
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu
```
 2021-03-28 10:57:24 +02:00
donovaly
f71dd32ae9 [Part] change icon to math the other Part icon scheme 
The other Part icons have red lines indicating wires, only the new make faces ion does not. The PR changes this to use the same for all icons.
 2021-03-25 18:11:49 +01:00
donovaly
d65cc5c63f [Part] uniform feature sorting 
at the moment the sorting is confusing, the sorting in the menu differs from the toolbars and some features even belong in the menu to another category than in the toolbars and one feature has not yet a toolbar entry

This PR implements a uniform sorting for the menu and toolbar and adds the missing toolbar icon
 2021-03-25 18:04:35 +01:00
bitacovir
3b4e96d4a7 [UI] Replace Bitmap icon of Part_PointsFromMesh command 2021-03-25 17:42:26 +01:00
Abdullah Tahiri
5ea99f4786 Part: Geometry - Add function to trim a B-Spline 
================================================

Supports both non-periodic and periodic case
 2021-03-21 06:56:23 +01:00
Abdullah Tahiri
e8d5d69314 Part: Part2DObject::seekTrimPoints rename parameters 
====================================================

This function takes parameters named GeoId, which evoke the Sketcher GeoId and which
indeed are used by the sketcher. However, these indices are just indices of the provided
geometry list. Therefore:
1. The are never negative (no matter if a corresponding Sketcher GeoId is external or not).
2. They do not have reserved indices for axes.
3. Most importantly, not found GeoId1 and GeoId2 are coded as -1, which for the Sketcher has
a well defined meaning (axis), whereas the Sketcher uses Constraint::GeoUndef as undefined or
not present/ not found index, which currently is -2000.

For these reasons, it was judged appropriate to rename the parameters and documentation to
emphasise that this function is unrelated and dettached from any Sketcher knowledge, and that
indices are just normal indices of a vector.
 2021-03-21 06:56:23 +01:00
wmayer
b86deada1c Part: [skip ci] implement makeShellFromWires 2021-03-16 16:01:43 +01:00
tomate44
f5de466ae5 Part: fixes and check input values for spiral and helix primitives 2021-03-10 14:24:01 +01:00
tomate44
8334a59c4b Part primitives: add SegmentLength property to helix and spiral 2021-03-10 14:23:16 +01:00
tomate44
1ad246bdad Part primitives: use makeSpiralHelix in spiral and helix primitives 2021-03-10 14:22:04 +01:00
tomate44
8a7a5b583f TopoShape: add a common function to build spirals and helixes 2021-03-10 14:18:12 +01:00
Benjamin Nauck
8a2cfc268e [Base] Remove includes to StdStlTools.h as that's not needed anymore 
std::make_unique was introduced in c++14, so no need to use the back
ported version
 2021-03-06 21:20:32 +01:00
Benjamin Nauck
0032f4e298 [Path] Switch from boost::tuple to std::tuple 
It's better to use the standard lib when possible
 2021-03-06 19:31:06 +01:00
wmayer
9add6e2c9a Revert "[PartDesign] Add Material property to Body" 
This reverts commit 92db97a26dbdd5c2210df39dd08a716faf6102f6.

There is no need to make this a static property because it can be added at runtime via Python or the GUI
 2021-03-04 18:50:57 +01:00
howetuft
6061b8fa8b [PartDesign] Add Material property to Body 2021-03-04 12:19:50 +01:00
wmayer
dfba396b4f Gui: support to customize the font size of bounding boxes 2021-03-02 16:29:57 +01:00
David Osterberg
c1b3fba031 Beautify xml step 1: These changes do not affect the uic output 2021-03-02 16:29:11 +01:00
Chris Hennes
1667c4d9f6 [Part] Fix signature of TempoVis dummy function 
If the import of TempoVis fails, TaskAttachmentEditor creates s dummy
function to replace the real TempoVis function. That function's
signature did not match the real TempoVis. Caught by LGTM.
 2021-02-27 18:21:05 +01:00
Yorik van Havre
fa85db61f9 Merged crowdin translations 2021-02-25 13:27:48 +01:00
Yorik van Havre
5c12afb5b5 Merged crowdin translations 2021-02-24 18:07:59 +01:00
wmayer
253bbb54ba Part: [skip ci] Fix coverity warning 
Coverity warnings fixed:

CID 316522 (#2 of 2): Uninitialized scalar variable (UNINIT)
5. uninit_use_in_call: Using uninitialized value newSelection. Field newSelection.shapeType is uninitialized when calling push_back
 2021-02-21 16:06:59 +01:00
wmayer
cc4824680b Part: [skip ci] add missing expression bindings to tube dialog 2021-02-21 15:20:12 +01:00
luz paz
147542aef0 Part: Part.CompoundTools.Explode.explodeCompound access a property of... 
...a sometimes null object with an error

Python code, file `src/Mod/Part/CompoundTools/Explode.py`
The `explodeCompound` function can be called in a context without assigning the `ViewObject` property, for example from a command line script.

The error that is fixed by this patch. 
```
Traceback (most recent call last):
  ...
  File "/opt/freecad/Mod/Part/CompoundTools/Explode.py", line 23, in explodeCompound
    cf.ViewObject.DontUnhideOnDelete = True
AttributeError: 'NoneType' object has no attribute 'DontUnhideOnDelete']
```

Patch submitted by marioamb.  
Fix #004421  
https://tracker.freecadweb.org/view.php?id=4421
 2021-02-21 11:40:20 +01:00
donovaly
8a4334abcd [Part] fix regression in location dialog layout 
For some reason the horizontal alignment got broken. This PR replaces the different grids with each on grid per groupbox
 2021-02-21 11:36:13 +01:00
wmayer
48fdbbab4c PD: [skip ci] fixes #0004573: missing bindings to expressions in primitives location dialog 2021-02-20 20:04:37 +01:00
donovaly
e3dff59c2e [Part] add missing bindings 
For FC 0.19 we added bindings to the PD primitives but we forgot the Part primitives
 2021-02-20 20:02:09 +01:00
Abdullah Tahiri
6d0c845208 Part: Geometry - BSpline - fix weight assignment 
================================================

If during assignment of weights (during the for loop iteratively setting the poles) all weights
become (temporarily) equal even though weights does not have equal values
OCCT will convert all the weights (the already assigned and those not yet assigned)
to 1.0 (nonrational b-splines have 1.0 weights). This may lead to the assignment of wrong
of weight values.

The work-around is to temporarily set the last weight to be assigned to a value different from
the current value and the to-be-assigned value for the weight at position last-to-be-assign but one.

Fixes:
https://forum.freecadweb.org/viewtopic.php?p=478701#p478702
 2021-02-18 17:28:38 +01:00
David Osterberg
29cd1049bb Part: Allow helix primitive with negative Angle 2021-02-14 11:53:34 +01:00
Yorik van Havre
0de8cceb53 Updated ts files 2021-02-12 14:47:37 +01:00
wmayer
d50dbf184d Part: [skip ci] code-refactoring in DlgPrimitives class 2021-02-12 12:41:45 +01:00
Chris Hennes
6b16e12d7c [OTHER] Catch only Exception, not BaseException 2021-02-11 11:52:45 +01:00
Chris Hennes
3bb03af723 [Part] Coverity: dtors can't throw 2021-02-09 23:58:09 +01:00
Yorik van Havre
97379e035a merged crowdin translations 2021-02-09 16:12:18 +01:00
Chris Hennes
5f80300de6 LGTM: Remove superfluous conditional 2021-02-08 16:39:40 +01:00
Zheng, Lei
0dd091e8c4 Part: allow TaskAttachmentEditor to install attacher extension on demand 2021-02-07 15:39:12 +01:00
wmayer
9572ceab3e Part: [skip ci] fix -Wreorder 2021-02-05 17:26:47 +01:00
donovaly
09fd3dbffa [Part] make pointers to the UI std::unique_ptr 
Same as PR #4293, just for Part

as noted in https://github.com/FreeCAD/FreeCAD/pull/4271#discussion_r554673632
the pointer to the UI should be a unique pointer.

This PR does this for all Part dialogs that don't already use a unique_ptr.
 2021-02-05 17:16:20 +01:00
David Osterberg
cb2da22e86 PartDesign: New features AdditiveHelix and SubtractiveHelix 
These features, based on the code for the Pipe class, allow the user
to simply create a helical sweep within PartDesign workbench.

Sample application is threads, springs, coils, augers, etc.

Also, remove needless requirement for positive cone angle on helixes.

Thanks to @bitacovir for helping with the icons
Thanks to @chennes for review
Thanks to @vosk for review
Thanks to @wwmayer for review

Enforce that links stay within scope for ProfileBased features
This also ensures that the Body itself is not used for creating features within
the body, causing a "Graph not a DAG" error.
 2021-02-04 13:01:12 +01:00
wmayer
d65937d338 Part: [skip ci] rename methods in TopoShape that override non-virtual functions of base class 2021-02-03 16:10:38 +01:00
wmayer
d3e4da9f51 Part: offer all supported STEP schemes by OCC in a combo box 2021-02-02 21:51:11 +01:00
wmayer
d77d3e81cb Part: [skip ci] fix path of attachment icon 2021-01-30 17:22:54 +01:00
Stefan Tröger
ec5ac30756 Remove ExtensionProxy and rely on default Python proxy for extensions. fixes #0004534 2021-01-30 16:00:48 +01:00
Zheng, Lei
99fe37928c Part: fix ViewProviderExt::updateVisual() on incomplete mesh 2021-01-28 17:38:49 +01:00
vosk
1300c630f4 [Part] - Fix memory leaks 2021-01-28 15:45:00 +01:00
bitacovir
67f6353046 Add SVG icons for two Part commands 2021-01-19 19:26:10 +01:00
marioalexis
b263c2aa87 Part: Crash when calling SubShapes of empty shape from Python 2021-01-18 19:47:35 +01:00
Abdullah Tahiri
024283e704 Part: Geometry trigger notifyAttach on extension addition 2021-01-09 20:08:05 +01:00
Abdullah Tahiri
b69b3c71c0 Part/Sketcher: Refactor Geometry Extensions copy/save/restore AND attachment notification 
=========================================================================================

- Long overdue refactor to avoid repetition during save/restore and copy.
- New interface to notify an extension when it is attached. It also enables the extension to gain
a pointer to the geometry container. This is intended to extend the functionality already existing
in Part::Geometry.
 2021-01-09 20:08:05 +01:00
Yorik van Havre
e6aaaf51b6 Merge pull request #4252 from donovaly/Part-angular-measure 
[Part] fix angular measurement
 2021-01-08 11:42:21 +01:00