Commit Graph

17 Commits

Author SHA1 Message Date
pre-commit-ci[bot]
9fe130cd73 All: Reformat according to new standard 2025-11-11 13:49:01 +01:00
wmayer
244020c3b7 PD: Improve groove feature
The only difference between groove and revolution is that for the former
the revolved face is removed from the base shape instead of added.

Thus, the code of the Revolution and Groove classes should be almost
identical. This allows it in a further step to refactor the code and
make a common base class.

This fixes issue 18842.
2025-09-26 23:46:25 +02:00
Ajinkya Dahale
c7101d7ced [PD] Support two-angle/up-to-face groove
Elements copied from revolution and pocket feature.
2023-11-14 00:20:20 +05:30
wmayer
c87e1cc1c2 clang: fix warnings [-Winconsistent-missing-override] 2022-08-09 17:36:25 +02:00
berniev
71dc5ead2f Mod: Use override etc 2 2022-08-09 12:52:26 +02:00
berniev
f4ffd15864 Mod: redundant void 2 2022-08-08 10:27:50 +02:00
wmayer
86751fd944 PD: [skip ci] set angle constraints for groove 2021-03-03 14:55:19 +01:00
luz.paz
dc8bf3dc39 PartDesign: [skip ci] fix header uniformity
This PR fixes header uniformity across all PartDesign WB files
2019-12-22 00:58:38 +01:00
Stefan Tröger
ae9dac71d7 PartDesign: Modeling features work with faces
-Rename Sketchbased to ProfileBased to show new behavior
-Adopt ProfileBased to make the relevant helper functions work with faces too
-Adopt features for unified use of helper functions
-Adopt commands to allow face selection
2016-04-12 18:12:22 +02:00
Stefan Tröger
b0817ff086 allow non-sketch based additive and subtractive features 2016-04-12 18:12:06 +02:00
logari81
68411f28d3 PartDesign: Intelligent defaults for the Reversed flag of Revolution/Groove features 2013-02-14 16:06:23 +01:00
jrheinlaender
ab5f7ab334 PartDesign: Add method suggesting Groove Reversed property so that material is always removed from the support 2013-02-14 00:32:02 +01:00
jrheinlaender
99424229a8 PartDesign: move common properties to FeatureSketchBased and add some source documentation 2012-10-23 13:21:04 +02:00
logari81
978402ed0f PartDesign, FeatureGroove: fix copyright headers 2012-10-23 13:21:04 +02:00
jrheinlaender
1befcbb2b4 PartDesign: tidy up PartDesign feature dependencies 2012-09-09 10:05:43 +02:00
logari81
1d73e27a28 Add missing dllexport keyword to PartDesign classes 2012-09-06 14:21:55 +02:00
jrheinlaender
33f6bfe79b Groove feature (code is 99% identical to Revolution feature) 2012-06-08 17:32:53 +02:00