kindred/create
1
1
Fork 0
Code Issues 37 Pull Requests Actions Packages Projects 9 Releases 2 Wiki Activity
7,240 Commits 41 Branches 6 Tags
4590305921fd8d3a2c4d294c222e1df0240d64f5
Commit Graph

473 Commits

Author SHA1 Message Date
Alexander Golubev
4590305921 PartDesign/Gui: enhance the TaskFeaturePick with new cotegory of sketches: notInBody 
Also add option tp show already used sketches and fix some spacing.
 2016-04-12 18:12:14 +02:00
Alexander Golubev
ffc6cc2f23 Share code for finding a body containing a feature 2016-04-12 18:12:14 +02:00
DeepSOIC
16e4ce20f0 PartDesign workflow without part/body 
PartDesign: make datum features work outside of body/part
PartDesign old workflow: remove a few messageboxes about no part
PartDesign: old workflow: multitransform without body

Still has visibility issues, but generally works.
 2016-04-12 18:12:14 +02:00
DeepSOIC
125dda4d70 PartDesign: Make groove work via Revolution ui 
Purpose: remove duplicate code.
Remaining: wrong title and icon in task dialog.
 2016-04-12 18:12:14 +02:00
DeepSOIC
9776d30b87 PartDesign: rework axis and plane comboboxes and make it work without part. 
Rework combobox filling and link hadling for revolution and transformed features, in order to get rid of hard-coded item indexes and make the lists more dynamic.
 2016-04-12 18:12:14 +02:00
DeepSOIC
2625233dff PartDesign: disable migration 
Temporary. Later, a way to manually invoke it should be made.
 2016-04-12 18:12:14 +02:00
Alexander Golubev
f509e1b0f1 remove unneeded sketcher tools from part design 
Previously similar patch was commited by Stefan Tröger <stefantroeger@gmx.net> but lost during rebase.
 2016-04-12 18:12:14 +02:00
Stefan Tröger
a8bd2f6f7f prevent part design features from accidently cross referencing 2016-04-12 18:12:14 +02:00
Stefan Tröger
318c65eafd fix independent copy and cross reference 2016-04-12 18:12:14 +02:00
Stefan Tröger
a35c231d2a first take on enhanced feature pick task 2016-04-12 18:12:14 +02:00
Stefan Tröger
986623f462 fix loft tool naming 2016-04-12 18:12:13 +02:00
Stefan Tröger
45861b4f92 remove linear and S-shape scaling from pipe 
They worked and are nice feature, but the handling with properties must be worked out better. To avoid any incompatibility due to property changes the functionality is removed now.
 2016-04-12 18:12:13 +02:00
Stefan Tröger
d980952d31 fix body and part tool texts 2016-04-12 18:12:13 +02:00
Stefan Tröger
ecfe545b3b add part tool to task dialog for no selection 2016-04-12 18:12:13 +02:00
Stefan Tröger
0606e767cd fix pipe task dialog icon 2016-04-12 18:12:13 +02:00
Stefan Tröger
12c5e1f92f remove hole feature 
A hole feature is something needed, however, the current implementation does not use the attacher code which would made it intuitive and compatibel to other workbench tools. A reimplementation is needed.
 2016-04-12 18:12:13 +02:00
DeepSOIC
72c70bcc50 Datum UI: fixes 
* fix messagebox not popping when clicking OK but status is error
* accept preselection
* unify code for all datum commands
* edit selected datum if type matches, instead of creating new one
 2016-04-12 18:12:13 +02:00
DeepSOIC
03e354f7ac PartDesign: fix porting procedure... 
...that caused an assert in attacher that back/front subshape strings
were used for attachment to App::Plane.
 2016-04-12 18:12:13 +02:00
DeepSOIC
4e57b1a2ec Datum UI: fixes 
* fix highlighting of reference buttons when active
* fix selection of whole objects
* fix some other logic
 2016-04-12 18:12:13 +02:00
Stefan Tröger
7deb6393cc no temporaries at by reference parameter 2016-04-12 18:12:12 +02:00
Stefan Tröger
4e295c03ed fix crash in boolean op if no base feature exists 2016-04-12 18:12:12 +02:00
DeepSOIC
a3d9907e8c PartDesign: adapt Datum UI to work using Attacher 
* adapt
* introduce mode selection
* kill selection gate to allow selecting whole objects (selection gate
should be reintroduced to disallow references between parts, no
restrictions is a temporary state)
* prevent auto-switchover to next ref after an explicit push of a button
* fix highlighting of buttons when selecting corresponding reference
* allow creation of a feature, even if no mode fits references. With a
warning.
 2016-04-12 18:12:12 +02:00
DeepSOIC
a5d38c9a99 PartDesign: patch old partdesign porting for changes in Datums 2016-04-12 18:12:12 +02:00
DeepSOIC
9e440b955c PartDesign: transfer Datums to become AttachableObjects 
Crude and quick, needs cleanup.
 2016-04-12 18:12:12 +02:00
DeepSOIC
4800957858 Attacher: change Part2DObject's MapMode default to mmDeactivated, and set mode to mmFlatFace only when reading files of old format. 
PartDesign, Sketcher: set mapping mode when setting support

Mapping mode mmFlatFace is no longer default, so an explicit assignment
is required.
 2016-04-12 18:12:12 +02:00
DeepSOIC
34784b2d29 PartDesign: Fix revolution 
It failed to close task if starting a body.
 2016-04-12 18:12:12 +02:00
DeepSOIC
4cc9b32e32 PartDesign: accomodating to sketch's multisupport 
* FeatureSketchBased getSupportFace check for mapping mode
* Fixes failure to place sketches on DatumPlanes
 2016-04-12 18:12:12 +02:00
DeepSOIC
eccff10d90 PartDesign: fix refuse to pad 
When something was depending on a sketch (another sketch, for example),
padding (revolving, pocketing, etc) it was impossible. This is fixed.

Also, padding or revolving a single sketch twice was allowed (with a
warning msg displayed).
 2016-04-12 18:12:11 +02:00
Alexander Golubev
bf58a7be2a PartDesign: make MoveFeatureInTree command use new insert functions 2016-04-12 18:12:11 +02:00
Alexander Golubev
9c113357c5 PartDesign: add migrating sketch support to MoveFeature command 2016-04-12 18:12:11 +02:00
Alexander Golubev
03d3f45277 PartDesign/Workbench: make a message more translation-frendly 2016-04-12 18:12:11 +02:00
Alexander Golubev
ad461fc472 PartDesign: fix spacing in several files 2016-04-12 18:12:11 +02:00
Alexander Golubev
7e1a76eb37 PartDesign/Workbench: move fix of sketch support into separate function 
Outside PartDesign sketches can have no support plane for them. But
PartDesign doesn't allow that.
Move the code for migration of "free" sketches of planes
into a separate fuction so it may be reused.
 2016-04-12 18:12:11 +02:00
DeepSOIC
ec2bbc4c34 Loft: fix build with MSVC2013 2016-04-12 18:12:11 +02:00
DeepSOIC
03be8e1bba PartDesign: tidy up sketch support and base feature confusion 
Not complete, transformPlacement and positionBySketch are pending...
 2016-04-12 18:12:11 +02:00
Alexander Golubev
b9f4e10fa5 PartDesign: fix a couple of crashes 
The first crash was reported here:
http://forum.freecadweb.org/viewtopic.php?f=20&t=11205&start=50#p91052

The second one accures then moving a feature from a body without solid
features.
 2016-04-12 18:12:11 +02:00
Stefan Tröger
7f80e711f6 better active part and document tip handling 2016-04-12 18:12:10 +02:00
Stefan Tröger
d435e15a97 make part design loft functional 2016-04-12 18:12:10 +02:00
Stefan Tröger
987880fffa add loft viewprovider 2016-04-12 18:12:10 +02:00
Alexander Golubev
f4a5bf6acd PartDesign: remove Body::isFeature() because it's the same as BodyBase::hasFeature() 2016-04-12 18:12:10 +02:00
DeepSOIC
36fe5994b9 Revolution: fix crash when selecting stuff during task 2016-04-12 18:12:10 +02:00
Danny Lepage
8aecb00a8d Fix Debug Assert in CmdPartDesignDuplicateSelection::activated 
Under Windows, "Edit/Duplicate selected object" raised a
Debug Assertion Failed "Expression: sequence not ordered".
 2016-04-12 18:12:10 +02:00
Danny Lepage
63bdbe5561 Fix Boolean operation tooltip text. 
As reported by triplus
 2016-04-12 18:12:10 +02:00
DeepSOIC
7653d2d48f Fix build on Windows 2016-04-12 18:12:10 +02:00
Stefan Tröger
ab2cc10ac7 add missing return value 2016-04-12 18:12:09 +02:00
Stefan Tröger
84cd1588d0 Update pipe icon and add it to the taskwatcher 2016-04-12 18:12:09 +02:00
Stefan Tröger
20d551bc88 fix part and body search for invalid objects 2016-04-12 18:12:09 +02:00
Stefan Tröger
620b2bb5d7 simple bugfixes 2016-04-12 18:12:09 +02:00
Stefan Tröger
68ee7f4f27 add two scaling modes 2016-04-12 18:12:09 +02:00
Stefan Tröger
df386cc3c1 make multisection work 2016-04-12 18:12:09 +02:00