Commit Graph

1874 Commits

Author SHA1 Message Date
vocx-fc
4a68fb09c0 Draft: gui_selectplane cleanup
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Added many docstrings to clarify the methods, and spaces
after commas in order to comply with Python PEP8 style.
Also break many lines so that they are shorter than 80 characters.
2020-04-07 18:12:06 +02:00
vocx-fc
fbd929af2b Draft: gui_polararray cleanup
Small spacing fixes like imports in separate lines
for more clarity, the module docstrings,
and the position of the license.

Remove unnecessary check for the graphical interface
as this command should be imported when the interface
is already up and running.

Use proper `ToDo` class instead of importing `DraftGui`.
2020-04-07 18:12:06 +02:00
vocx-fc
9aa74f4f32 Draft: gui_orthoarray cleanup
Small spacing fixes like imports in separate lines
for more clarity, the module docstring,
and the position of the license.

Remove unnecessary check for the graphical interface
as this command should be imported when the interface
is already up and running.

Use proper `ToDo` class instead of importing `DraftGui`.
2020-04-07 18:12:06 +02:00
vocx-fc
f329fbeb40 Draft: gui_edit, many small spacing and docstring edits 2020-04-07 18:12:06 +02:00
vocx-fc
bc84eda70f Draft: gui_edit cleanup
Small spacing fixes like imports in separate lines
for more clarity, the module docstring,
the position of the license, and trailing spaces.

Remove unnecessary check for the graphical interface
as this command should be imported when the interface
is already up and running.

Properly import `gui_trackers` module and use tracker
classes prefixed accordingly.
2020-04-07 18:12:06 +02:00
vocx-fc
d5e80819b1 Draft: gui_circulararray cleanup
Small spacing fixes like imports in separate lines
for more clarity, the module docstring,
and the position of the license.

Remove unnecessary check for the graphical interface
as this command should be imported when the interface
is already up and running.

Use proper `ToDo` class instead of importing `DraftGui`.
2020-04-07 18:12:06 +02:00
vocx-fc
33d82d44dc Draft: clean up gui_arrays and gui_base
Small spacing fixes like imports in separate lines
for more clarity, the module docstring,
and the position of the license.

Remove unused imports. And use proper `ToDo` class
instead of importing `DraftGui`.
2020-04-07 18:12:06 +02:00
vocx-fc
173f509349 Draft: DraftGeomUtils clean up docstrings and spaces 2020-04-07 18:12:06 +02:00
vocx-fc
95b8b6ebc4 Draft: DraftGeomUtils clean up imports, and Python 2 compatibility
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Also fix copying of a list in order to keep compatibility
with Python 2.
2020-04-07 18:12:06 +02:00
vocx-fc
106cd631e0 Draft: WorkingPlane.py clean up imports and docstrings
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.

Cleaned up the class docstring, so it is in only one place
below the class definition. Also small fixes
in the docstrings of the class methods.

The class is now in upper case `Plane` to conform with Python
guidelines. An alias in lowercase `plane` is still provided
for compatibility purposes; this will be deprecated
in the future.
2020-04-07 18:12:06 +02:00
vocx-fc
5125c584bd Draft: DraftVecUtils.py clean up imports and messages
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the new `messages` module to provide the functions
to print text to the console.
Also use `Matrix` prefixed by the `FreeCAD` module.
2020-04-07 18:12:06 +02:00
vocx-fc
b9968d2aa3 Draft: gui_trackers.py clean up imports and spaces
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the `ToDo` class with this new name
following Python guidelines.
2020-04-07 18:12:06 +02:00
vocx-fc
09cc7e0264 Draft: gui_snapper.py clean up imports and spaces
Small spacing fixes like imports in separate lines
for more clarity.
Also use the `OrderedDict` prefixed with the `collections` module.
2020-04-07 18:12:06 +02:00
vocx-fc
79233ee4d0 Draft: todo.py clean up header, imports and messages
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the new `messages` module to provide
the functions to print text to the console.

Use two `DEBUG` variables to print information about
the `ToDo` class in order to see the scheduled commands
when the graphical commands are executed.
2020-04-07 18:12:06 +02:00
vocx-fc
0714ab786f Draft: gui_utils.py clean up imports
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the new `messages` module to provide the functions
to print text to the console.
2020-04-07 18:12:06 +02:00
vocx-fc
eafba705a4 Draft: utils.py clean up header and imports
Small spacing fixes like imports in separate lines
for more clarity, and the position of the license.
Also use the new `messages` module to provide the functions
to print text to the console.
2020-04-07 18:12:06 +02:00
vocx-fc
1fcd4ac556 Draft: Draft.py improve imports of utility functions 2020-04-07 18:12:06 +02:00
vocx-fc
2ef52b3909 Draft: Draft.py clean up header and imports 2020-04-07 18:12:06 +02:00
vocx-fc
7f99cead72 Draft: DraftTools.py clean up header and imports
Small spacing fixes like imports in separate lines for
more clarity, and the position of the license.
Also use the class name `ToDo` in `CamelCase`,
as it is indicated in Python guidelines for classes.
2020-04-07 18:12:06 +02:00
vocx-fc
855dc4c989 Draft: docstrings for the submodules 2020-04-07 18:12:06 +02:00
vocx-fc
9d9102bc7e Draft: Draft_Text split lines by newline characters 2020-04-06 13:01:32 +02:00
vocx-fc
3f726f662f Draft: update unit test for gui_edit 2020-04-06 12:51:55 +02:00
vocx-fc
7d102a5370 Draft: move Draft_Edit to another module 2020-04-06 12:51:55 +02:00
vocx-fc
2cd9a542b5 Draft: task_scale, small style improvements 2020-04-02 16:53:49 +02:00
vocx-fc
2a340bcfd3 Draft: move ScaleTaskPanel to a module
We remove it from `DraftGui.py` to reduce the size of this file.
Then we import it and tie it to its command defined
in `DraftTools.py`.
2020-04-02 16:53:49 +02:00
vocx-fc
b82c9c4db1 Draft: task_shapestring, small style improvements 2020-04-01 13:22:04 +02:00
vocx-fc
46216d6032 Draft: move ShapeStringTaskPanel to a module
We remove it from `DraftGui.py` to reduce the size of this file.
Then we import it and tie it to its command defined
in `DraftTools.py`.
2020-04-01 13:22:04 +02:00
carlopav
d9dd618230 [Draft] Fix to mirror tool
the normal is not computed with the view, but with the working plane if active.
ref. https://forum.freecadweb.org/viewtopic.php?f=23&t=44301&p=380632#p380370
2020-03-31 12:03:02 +02:00
vocx-fc
7ec5d58d0b Draft: update unit test for gui_selectplane 2020-03-31 12:00:38 +02:00
vocx-fc
0b7c0800c1 Draft: improve the Python style gui_selectplane
Also import `todo` and `translate` from the utils module
instead of from `DraftGui`.
Otherwise we have to import the entire `DraftGui` module
which creates dependency problems when we want to use
some functions without the graphical interface.
2020-03-31 12:00:38 +02:00
vocx-fc
72e2bca165 Draft: move and rename DraftSelectPlane 2020-03-31 12:00:38 +02:00
carlopav
49ef7f9fb7 [Draft] Reordering Modifiers toolbar 2020-03-24 11:17:48 +01:00
luz.paz
65f6347953 [skip ci] Fix typos
Found via 
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-03-24 11:14:24 +01:00
vocx-fc
02dabc9022 Draft: use functions from the utils module, not DraftGui
These functions were moved from DraftGui to individual
modules precisely to make them easy to import.
Otherwise we have to import the entire DraftGui module
which creates dependency problems when we want to use
some functions without the graphical interface.
2020-03-23 12:14:58 +01:00
vocx-fc
d38390db1e Draft: update unit test for new gui_trackers module 2020-03-23 12:14:33 +01:00
vocx-fc
478510d20e Draft: Snapper class with new gui_trackers module
Also change the imports in `DraftFillet.py`
and `DraftEdit.py` so the trackers are found.
2020-03-23 12:14:33 +01:00
vocx-fc
419431559a Draft: move DraftTrackers to another module.
Properly import the tracker classes. Avoid star imports,
and use the classes prefixed with the name of the module.
The BIM Workbench also has to be updated to use the new
module.
```
import draftguitools.gui_trackers as DraftTrackers
```
2020-03-23 12:14:33 +01:00
vocx-fc
6a92cb968d Draft: update unit test for gui_snapper 2020-03-20 08:11:04 -03:00
vocx-fc
580270ce4a Draft: move DraftSnap to another module
And do not load the `Snapper` in `DraftGui`.
The Snapper should be initialized by the module
that imports `DraftGui`, most probably `DraftTools`
or even by the `InitGui` of the workbench.
2020-03-20 08:11:04 -03:00
vocx-fc
6b87a416fd Draft: properly import the Snapper class
Avoid star imports, and prepend the module name,
`DraftSnap.Snapper()`.
2020-03-20 08:11:04 -03:00
vocx-fc
3ac2e079bc Draft: move snap commands to an individual module
This way we remove lines from `DraftTools.py`
and we can more easily identify where the snapping
commands are defined.
2020-03-20 08:11:04 -03:00
UR-0
03b652930c DRAFT: import DXF version R12 minimalistic file with legacy importer 2020-03-19 12:21:39 -03:00
vocx-fc
f73de9912c Draft, Arch: coding conventions for the workbench 2020-03-19 12:20:03 -03:00
vocx-fc
e836811e3c Draft: improve the README files with links 2020-03-19 12:11:16 -03:00
vocx-fc
33092ce82c Draft: recompute before using radial dimension in the unit test
This solves a small bug in the radial dimension
unit test introduced in 7917b82c09, where a circle shape
is used before it is recomputed.

```
drafttests/test_creation.DraftCreation.test_dimension_radial
```
2020-03-19 12:10:56 -03:00
triplus
946fd7352b Draft - enable toggle grid command in edit mode
Some people would like to have more control over draft grid visibility  while in Sketcher edit mode.  Hence this PR enables the usage of Draft ToggleGrid  command in Sketcher edit mode.

Forum discussion:
https://forum.freecadweb.org/viewtopic.php?f=34&t=43265&start=20#p374747
2020-03-12 09:26:48 -03:00
vocx-fc
81d7267e72 Draft: add new viewprovider icon for radius dimension
If it is a linear dimension show the older icon;
if it is a radius or diameter dimension show a new icon.

These three modes use the same Proxy class
and the same viewprovider class. Depending on the linked geometry
one icon or the other will be shown.
2020-03-12 09:12:11 -03:00
vocx-fc
dce7f63c02 Draft: add new viewprovider icons for specific objects
When there are many Draft objects in the tree view
the icon can be used to tell different objects apart quickly.
One icon is used for objects that are "straight lines",
whose Proxy is of type `Line`, `Wire` or `Polyline`; another icon
for "regular geometrical" shapes of type `Rectangle` or `Polygon`;
and another icon for "curved" objects of type `Circle`,
`Ellipse`, `BSpline`, `BezCurve`, or `Fillet`.

Other objects use the older default icon.
2020-03-12 09:12:11 -03:00
carlopav
8f2cd4526e [Draft] Remove AddPoint and DelPoint commands from UI
[Draft] Edit: Remove Bezcurve interface from Edit Ui


[Draft] Edit: cleanup


small improvement to tooltip
2020-03-12 09:11:34 -03:00
carlopav
6d2c8b5df3 [Draft] Uniform length and xyz inputfield behaviour
Single returnPressed to accept point if cursor is parallel to xyz axis for bot setfocus on x and on length inputfields.
[Draft] Edit_updated tooltip


[Draft] DraftGui Further cleanup and bugfix
2020-03-12 09:11:34 -03:00