Commit Graph

1784 Commits

Author SHA1 Message Date
mwganson
b8b015d0f1 [PartDesign::Scripts::Spring.py] update old example script 2022-01-03 11:45:05 +01:00
Jonas Bähr
d70faa1f5e PD: helix cleanup: remove unused strings from task panel ui
Since the tool tips are now set from the property descriptions we don't
need them any more in the .ui file. Removing them prevents garbage in
the translation source files.
2022-01-03 11:40:29 +01:00
Jonas Bähr
88063627d2 PD: Use the helix property docs as tooltip in the task panel
By reusing the property docs as tooltip we avoid maintaining the same
information in two places. The propery descriptions have been made
translatable, too, to ensure a fully translatable UI.
The ground work for this was layed by the work on Issue 0002524, long
time ago: https://tracker.freecadweb.org/view.php?id=0002524
2022-01-03 11:40:29 +01:00
wmayer
175ceb2d12 PD: [skip ci] remove obsolete TaskPocketParameters.ui 2022-01-01 11:50:43 +01:00
wmayer
c855a3072e PD: fix bug in TaskDressUpParameters::KeyEvent and simplify code 2021-12-31 17:03:16 +01:00
wmayer
e1b03bc0eb [skip ci] fix some typos 2021-12-31 14:03:51 +01:00
mwganson
a930d4ebac [PartDesign] for chamfer and fillet, add SelectAllEdges option in the context menu while in add or remove mode 2021-12-31 14:01:43 +01:00
Yorik van Havre
6cb3782c03 Merged crowdin translations 2021-12-29 12:20:12 +01:00
Uwe
0a27540479 [PD] refine helix intersection calculation 2021-12-24 01:40:25 +01:00
Uwe
3cff3202ef [PD] fix Helix creation bug
Helices with zero height and zero growth are valid as long as there are no more than 1.0 turns.
2021-12-24 01:10:21 +01:00
Zheng, Lei
d286a54fc1 PartDesign: show error on SubShapeBinder CopyOnChange failure
The failure is not obivous as it would have been occurred in a
hidden temporary document.
2021-12-21 21:41:02 -07:00
Zheng, Lei
2bd4404afb PartDesign: expose SubShapeBinderPython 2021-12-21 21:41:02 -07:00
Zheng, Lei
39c04e4877 PartDesign: support CopyOnChange in SubShapeBinder 2021-12-21 21:41:02 -07:00
Uwe
fa50122c33 [PD] fix a hole thread issue
- The thread must not be deeper than the hole.
  (One could see that if one used a thread depth dimension and set
  it to the same value than the hole depth, the thread was too deep.)
2021-12-22 02:54:49 +01:00
Uwe
c5f87d8ea8 [PD] hole dialog improvements
- no keyboard tracking
- don't disable labels since we don't do this for the other dialog labels
- avoid a doubled word in subsequent labels
- further UI file changes are by Qt's Designer
2021-12-22 02:46:07 +01:00
Uwe
9770449be7 [PD] fix several hole thread issues
- actually use specified thread depth, fixes issue reported here: https://github.com/FreeCAD/FreeCAD/pull/4274#issuecomment-997787744
- fixes 2 UI enabling issues
- the thread depth cannot be longer than the hole depth
- the hole cannot be deeper than the through-all depth
2021-12-22 01:09:06 +01:00
wmayer
6d4d433080 PD: [skip ci] improve readability of argument list 2021-12-19 22:02:08 +01:00
Uwe
7156b33ec4 [PD] fix compilation issue with Helix
I introduced it with commit 7dad9a90
2021-12-19 21:58:19 +01:00
Uwe
3d03f0a468 [PD] style improvements for Helix
all done automatically by MSVC
2021-12-19 17:52:33 +01:00
Uwe
7dad9a908f [PD] small code improvements for Helix 2021-12-19 17:34:14 +01:00
jbaehr
f4fe2efe19 PD: Fix helix property visibility/writability (#5254)
[PD]: Fix helix property visibility/writeability

* Hide irrelevant and internal helix properties
- The `HasBeenEdited` property is only used internally to check whether to
  fill certain other parameters with initial values. So there is no need
  show it in the property grid at all.
- The `Outside` property is only used in the subtractive helix and thus
  hidden for the additive helix.

* Make derived helix properties read-only
Depending on the input mode, some properties are primary input, others
are derived. Prior to this change, also the derived properties have been
writable but their values are ignored and overwritten on the next
recompute. Now, when changing the input mode, only the primary input
props are writable.

* Reorder some helix properties
This change puts the reference axis and input mode at the top to become
more prominent. Only "Base" and "Axis" are higher in the list for
consistency with the other axis-based features.
2021-12-19 16:50:51 +01:00
Jonas Bähr
bb3d02298d PD: Fix assignment of Angle/Growth properties
Depending on the input mode, either `Growth` or `Angle` is used to create
a conical or flat spiral. The respective other can easily be calculated
to give consistent view. This is already done for the other properties,
e.g. `Height` is calculated from `Pitch` and `Turns`.
With this patch, the same is done for `Angle` and `Growth`.
2021-12-19 16:21:51 +01:00
luz paz
a5bfba2665 PD: Adjust header uniformity 2021-12-16 23:55:48 +01:00
wmayer
8a2ea97276 PD: support of wires in ReferenceHighlighter 2021-12-15 16:25:06 +01:00
wmayer
b428fb2afa PD: handle Base::Exception in Loft::execute 2021-12-15 16:24:42 +01:00
wmayer
5bef110491 PD: do not throw an exception in TaskSketchBasedParameters::make2DLabel as otherwise editing a broken loft/pipe won't be possible 2021-12-15 15:36:36 +01:00
wmayer
94d8a2034a PD: hide the sections of a loft only if it can be recomputed successfully 2021-12-15 15:13:33 +01:00
wmayer
a87c8dca31 PD: hide the profile of a sketch based feature only if it can be recomputed successfully 2021-12-15 15:13:03 +01:00
wmayer
2d9c403cc0 PD: in ViewProviderLoft::highlightSection follow the same logic as in Loft::execute for selected profiles/sections 2021-12-14 00:30:59 +01:00
wmayer
df76209f58 PD: use class ReferenceHighlighter inside ViewProviderDressUp 2021-12-13 16:56:48 +01:00
wmayer
418ef59625 PD: use class ReferenceHighlighter inside ViewProviderPipe 2021-12-13 15:58:55 +01:00
wmayer
098927fb54 PD: properly reset line colors when un-highlighting loft profile/sections 2021-12-13 15:46:04 +01:00
wmayer
6289ff40d5 PD: highlight current profile and sections of a loft when selecting a new profile/section 2021-12-13 15:01:08 +01:00
wmayer
2b65ef8fcf PD: make Loft working again when two sketches are pre-selected 2021-12-13 10:32:40 +01:00
Jonas Bähr
7dcd59d9fb PD: Enhance the helix property docs
Most strings are based on descriptions from the wiki [1]. Some have been
extended where I saw need. Note that I'm not a native speaker, though.

[1]: https://wiki.freecadweb.org/PartDesign_AdditiveHelix
2021-12-11 23:33:28 +01:00
luz paz
b6f9f39ffc Fix various typos and grammatical refinements 2021-12-09 08:57:52 -06:00
wmayer
5ddefe56fb PD: 0004699: ShapeBinder still touched after recompute 2021-12-09 12:33:09 +01:00
wmayer
208237d2e6 PD: 0004582: Mulit-transformation dialog cannot be cancelled 2021-12-09 06:13:25 +01:00
wmayer
ca5c799ce2 Gui: rename methods of SelectionObserver to clarify intention in client code 2021-12-07 14:17:07 +01:00
wmayer
ce88fa2052 PD: enable selection only on request and disable it after selecting an object 2021-12-07 13:06:48 +01:00
wmayer
a27b3067ba PD: eliminate the boolean argument from TaskSketchBasedParameters::onSelectReference 2021-12-07 11:04:22 +01:00
wmayer
6167e9f77a PD: 0004759: Bad error message when creating pad with 0 length 2021-12-07 10:09:11 +01:00
Uwe
1e4c7a2de9 [PD] improve selection mode exit for Helix
exit the selection mode if selection was got - like we do it for all other PD features
2021-12-07 04:18:33 +01:00
Uwe
6efd5f1bf6 [PD] fix calculation of possible Helix intersections
the current routine fails for the growth mode.

This PR fixes this by handling this case separately from the other modes.
2021-12-07 03:19:35 +01:00
wmayer
8df497b08e Gui: move methods startDefaultEditMode() and addDefaultAction() to ViewProviderDocumentObject 2021-12-06 19:24:26 +01:00
wmayer
e71051f4f0 PD: 0004742: Editing features by context menu may not be undoable 2021-12-06 14:11:10 +01:00
Uwe
3cef5da1ad [PD] fix division by zero in Helix
- when a helix is defined in the growth mode it can have a pitch of zero

This commit fixes the resulting division by zero by directly setting the known turns
2021-12-06 02:40:34 +01:00
Uwe
3f76c7869a [PD] Helix: improve variable naming
use unique variable names
2021-12-05 21:59:06 +01:00
Uwe
d2dc6ca7dd [PD] rewrite a Helix function
rewrite the function to check if helix might intersect itself to make it better readable/understandable
2021-12-05 21:28:52 +01:00
Uwe
1af3755a17 [PD] add missing tooltips for Helix dialog 2021-12-05 19:21:27 +01:00