Commit Graph

3537 Commits

Author SHA1 Message Date
Roy-043
1db692e38b Draft: Draft_Trimex: Fix wrong angle units in taskpanel
The redraw function was changed to return a list [dist, ang] if the real argument is not True. With this list the action function 'knows' which units to display. This also made it possible to move the "self.ui." related stuff that was in the redraw function to the the action function.
I have also changed to tooltip texts by removing the article "The". This more in keeping with other tooltips.
2021-07-02 11:32:51 +02:00
Yorik van Havre
ed9dca288c Merged crowdin translations 2021-07-01 13:56:25 +02:00
Yorik van Havre
6360345ce5 Updated ts files 2021-07-01 13:50:17 +02:00
Yorik van Havre
5b32b806f6 Arch: Added Depth property to SectionPlanes 2021-07-01 13:46:24 +02:00
Yorik van Havre
b64fddb2e0 Draft: Added Text Spacing and Line Spacing settings to Draft Set Style dialog 2021-07-01 12:59:49 +02:00
Yorik van Havre
e2ea3e7df8 Draft: Fixed text rotation + dim text height in DXF export 2021-07-01 11:20:24 +02:00
Yorik van Havre
c1643887fa Merge pull request #4867 from marioalexis84/draft-label
Draft: Fix rotations and Circle marker in ViewProviderLabel - fixes #0003987
2021-06-30 10:53:07 +02:00
Yorik van Havre
bb23a191db Merge pull request #4865 from Roy-043/Draft-fix-offsets.py
Draft: Fix offsets.py problem with direction if precision=6
2021-06-30 10:51:39 +02:00
Yorik van Havre
dd53430d19 Merge pull request #4492 from marioalexis84/draft-wp_restore
Draft: Fixes #0004562: Active working plane changes when I close Draft Edit panel
2021-06-30 10:50:25 +02:00
Yorik van Havre
257cdd8f42 Draft: Implemented edit mode for Draft texts 2021-06-28 15:47:42 +02:00
Roy-043
d72f90d972 Draft: Fix misplaced Draft_Edit nodes for BezCurve 2nd version
The poles in the resetTrackersBezier function are in the CS of the geometric parent of the curve. Before using `p = obj.getGlobalPlacement().multVec(p)` the nodes have to be translated to the CS of the curve. Otherwise the effects of the curve's Placement would be added twice. See discussion: https://github.com/FreeCAD/FreeCAD/pull/4889



 the global coordinate system. They should therefore not be translated from the LCS to the GCS.
2021-06-26 09:42:56 +02:00
Yorik van Havre
c8b5d8d762 Merged crowdin translations 2021-06-24 17:22:19 +02:00
Syres916
5ca31d6de2 [Draft] Airfoil Import - User feedback not shown..
... as an error therefore Report Console doesn't attract their attention to why there's nothing in the folder on import of faulty dat file.

See discussion: https://forum.freecadweb.org/viewtopic.php?f=3&t=59628
2021-06-23 15:11:36 +01:00
Roy-043
9eb9a58934 Draft: Fix Draft_PointArray and Draft_TwistedArray Count problems
Draft_PointArray and Draft_TwistedArray have Count problems:
1. Draft_PointArray: Count is always zero.
2. Draft_PathTwistedArray: Number of items is Count+1.
3. Draft_PathTwistedLinkArray: Count is increased whenever object is recomputed.

Also the first item in a twisted array should be unrotated.
2021-06-23 11:11:15 +02:00
Roy-043
32953590df Draft: Fix Draft_PointArray and Draft_TwistedArray Count problems
Draft_PointArray and Draft_TwistedArray have Count problems:
1. Draft_PointArray: Count is always zero.
2. Draft_PathTwistedArray: Number of items is Count+1.
3. Draft_PathTwistedLinkArray: Count is increased whenever object is recomputed.

Also the first item in a twisted array should be unrotated.
2021-06-23 11:06:47 +02:00
Yorik van Havre
835e326652 Draft: Fixed working plane set on non-coin view 2021-06-22 16:12:59 +02:00
Yorik van Havre
08c3a6b3e7 Draft: Create Draft texts when using the C++ DXF importer 2021-06-22 13:00:58 +02:00
Yorik van Havre
54139caff9 Draft: Fixed construction group name 2021-06-22 12:38:22 +02:00
Roy-043
3a8d9a2738 Draft: Small cleanup of Utilities menu and utility toolbar
Removed from the Utilities menu because they already occur in the Modification menu:
Draft_FlipDimension
Draft_Edit
Draft_Slope

Removed from the Utilities menu because calling the command from there instead of from the Draft Tray does not make sense:
Draft_AutoGroup

Removed from the "Draft utility tools" toolbar because the command is very rarely used:
Draft_Heal
2021-06-22 11:54:48 +02:00
Roy-043
bc083a06c2 Draft: Fix wrong color format in gui_setstyle.py 2021-06-21 22:46:00 +02:00
Roy-043
3401a63d68 Fix 3 issues with the Draft Tray layer list
Fix 3 issues with the Draft Tray layer list:
The layer list should display even if there are no layers so that the "Add new Layer" option can be selected.
"Project" and "BuildingPart" objects should be added to the list (depending on "AutogroupAddGroups" of course).
The "LayerContainer" object should not be added to the list. Although it is in fact a group, it is just too confusing.
2021-06-21 21:11:52 +02:00
Roy-043
9fad078ba2 Fix 3 issues with the Draft Tray layer list
Fix 3 issues with the Draft Tray layer list:
The layer list should display even if there are no layers so that the "Add new Layer" option can be selected.
"Project" and "BuildingPart" objects should be added to the list (depending on "AutogroupAddGroups" of course).
The "LayerContainer" object should not be added to the list. Although it is in fact a group, it is just too confusing.

Added is_group function. This function can also be used in gui_groups.py.
2021-06-21 21:07:41 +02:00
Yorik van Havre
69b084f492 Merged crowdin translations 2021-06-17 16:04:02 +02:00
Yorik van Havre
7c5f8d8737 Updated ts files 2021-06-17 15:49:33 +02:00
marioalexis
3383f43008 Draft: Fix rotations and Circle marker in ViewProviderLabel - fixes #0003987 2021-06-16 04:42:07 -03:00
Roy-043
df5c24bc63 Draft: Fix offsets.py problem with direction if precision=6
The direction of the offset could be faulty if Draft precision=6. Since we are only interested in the side the pointer is on, working with a high precision does not make sense.
2021-06-15 17:37:21 +02:00
Yorik van Havre
bfbb7dbb92 Merge pull request #4854 from luzpaz/typos
Fix source comment typos
2021-06-15 16:00:20 +02:00
Yorik van Havre
b7dcb2856e Merge pull request #4856 from marioalexis84/draft-make_wire
Draft: Use ordered vertexes to create Draft Wire from Part.Wire
2021-06-15 15:59:52 +02:00
marioalexis
2dcbc694af Draft: Check special characters using focused input field 2021-06-14 01:37:44 -03:00
marioalexis
544ba0f56a Draft: Use ordered vertexes to create Draft Wire from Part.Wire 2021-06-12 18:09:45 -03:00
luz paz
0db5d84a7e Fix source comment typos
Found via `codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,apoints,ba,beginn,behaviour,bloaded,bottome,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,ontop,orgin,orginx,orginy,ot,pard,parms,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml,./build/doc/SourceDocu`
2021-06-10 17:33:40 -04:00
Yorik van Havre
4a9963a03f Merged crowdin translations 2021-06-10 12:24:24 +02:00
Yorik van Havre
5739d6eb7c Updated ts files 2021-06-10 11:48:18 +02:00
Yorik van Havre
c50bbd263d Merge pull request #4833 from carlopav/draft-fix-autogroup
Draft: fix Autogroup to fix Draft_OrthoArray crash when using active Std_Part.
2021-06-09 12:44:42 +02:00
Yorik van Havre
524023cab9 Merge pull request #4840 from marioalexis84/draft-wp
Draft: Improve alignToSelection method on WorkingPlane
2021-06-09 12:43:58 +02:00
Roy-043
cb07846ca8 Draft: Fix wrong tree icon for Draft_PointArray 2021-06-08 14:29:03 +02:00
marioalexis
a6ef3e656b Draft: Check null shape in geometry.py functions 2021-06-06 21:30:20 -03:00
marioalexis
1c918e9d9e Draft: Improve alignToSelection method on WorkingPlane 2021-06-06 21:30:20 -03:00
carlopav
d115db2cbb Draft: Autogroup, insert guard to prevent cyclic references
ref. Forum discussion: Draft_OrthoArray: Crash when using active Std_Part. https://forum.freecadweb.org/viewtopic.php?f=23&t=59155&p=508132#p508132

Autogroup try to add new created Draft Objects into the active Part, but if the Part is used as a Base for the new object this could create a cyclic reference. 
This behaviour is prevented by adding a check for " obj in active_part.InListRecursive"
2021-06-06 11:21:21 +02:00
carlopav
f050f77343 Draft: Autogroup, rename variables to more readable names 2021-06-05 17:07:32 +02:00
Yorik van Havre
fb8b21ec43 Updated ts files 2021-06-04 18:30:30 +02:00
Yorik van Havre
7b58a46ab7 Merge pull request #4827 from Roy-043/Draft_Fix_gui_stretch
Draft: Fix gui_stretch
2021-06-04 13:18:05 +02:00
Yorik van Havre
f9c0455385 Merge pull request #4816 from luzpaz/typos
Fix misc. typos
2021-06-04 13:16:21 +02:00
Yorik van Havre
3352ebf9a0 Merge pull request #4811 from carlopav/DraftEdit_Improvements
Draft: Edit improvements to context menu and code organization
2021-06-04 13:15:18 +02:00
luz paz
097bb0769c Arch: fix typo in translate() 2021-06-03 14:36:21 -04:00
Yorik van Havre
d0d637b2c6 merged crowdin translations 2021-06-03 15:43:34 +02:00
Yorik van Havre
4361893f24 updated ts files 2021-06-03 15:37:33 +02:00
Roy-043
6cbd0cb9b4 Draft: Fix gui_stretch
If a wire is created to replace a rectangle, the MakeFace property of the wire should match that of the rectangle.
2021-06-02 14:28:56 +02:00
carlopav
267291567f Draft: Edit, cleanup of new GuiTools.addPoint methods
In new splitted addPoint methods, getObjectsInfo and the consequent checks have been removed and moved to main DraftEdit module in a new get_specific_object_info method.
This method returns the info for the selected object at a given position and the 3d Vector of the point clicked on the object.
2021-06-01 23:21:12 +02:00
carlopav
5841b737e1 Draft: Edit, moved resetTrackers for context menu actions to main module
The wrapper allows to call resetTrackers in the main module after the callback to the GuiTools is executed.

This is the last commit, many thanks to @matthijskooijman for having menthored me :)

I think it's helpful to have @matthijskooijman explanation on this use of the wrapper:

This defines a new wrapper function, that calls the original callback and then calls resetTrackers. Note that this creates a new function for every loop iteration, so each of these wrapper functions captures potentially different callback, self and obj values so things work as expected. Note I did something weird with the callback value there: Since functions like these capture a variable, not its value at the time of function definition, and loop variables like label and callback are a single variable shared between all loop iterations, capturing callback directly ends up with all wrappers calling the last callback (i.e. they all capture the same variable and by the time the wrappers are called, that variable will contain the last of the callbacks). This is commonly solved by using a default value in the function definition, since such a default value uses the value of the (in this case) callback variable, not capturing the variable.
2021-06-01 23:20:41 +02:00