Commit Graph

1458 Commits

Author SHA1 Message Date
Russell Johnson
4cd4b2e879 Path: Comment cleanup; adjust messages; set 2 default values 2020-04-16 00:28:33 -05:00
Russell Johnson
cb796ca2c9 Path: Implement new module PathSurfaceSupport; Add Spiral cut pattern
New module is shared with 3D Surface operation. Module contains PathGeometryGenerator class. More common methods can be moved into the new module.
2020-04-16 00:28:25 -05:00
Russell Johnson
aaf1eee7c5 Path: Preparation for making property defaults readable through class 2020-04-16 00:28:18 -05:00
Russell Johnson
eb354c3a1d Path: Improve backwards compatibility capabilities 2020-04-16 00:28:11 -05:00
Russell Johnson
ed85341cd9 Path: Improve property visibility in Data tab 2020-04-16 00:28:04 -05:00
Russell Johnson
a0cecce62e Path: Expose operation's property details to access via class 2020-04-16 00:27:58 -05:00
Russell Johnson
9e9d5ce962 Path: Fix weakness in face analysis for unique OuterWire cases
synced with PathSurface module
2020-04-16 00:27:49 -05:00
Russell Johnson
aa1261dc7d Path: Waterline fixes(5), new IgnoreOuterAbove, and code simplification
Fix module base for getFacets()
Fix isOnLineSegment() usage.
Fix property visibility in Data tab.
Fix missing raise to SafeHeight after clearing layer.
Fix handling of `import ocl` failure
Move Draft import to dependent function
Raise `import ocl` test in code execution
Disable face selection for Waterline and issue warning as intermediate fix. Application of face-selection from 3D Surface requires some modification for use in Waterline.  This work is to be done.  Some existing carryover methods should be usable in current form.
Compact setup() function
Sync some methods with PathSurface in preparation of extracting common methods to independent support module.
Increase SampleInterval range for OCL Dropcutter algorithm.
Convert OCL Dropcutter waterline to use FreeCAD.Vector() points rather than ocl.Point().
Simplify some code and delete unnecessary comments.
LGTM cleanup.
New feature - IgnoreOuterAbove. Ignore the outer-most waterline above this height.  Designed to eliminate the model profile path created in some use cases.
Adjust tooltip language for `Algorithm`
2020-04-16 00:27:40 -05:00
Russell Johnson
c0a5a8c97e Path: Improve Tasks editor interaction
Swap setEnabled() method for show() and hide().
Include showing and hiding associated labels.
Path: Hide `optimizeEnabled` input
2020-04-16 00:27:06 -05:00
Eric Trombly
070099daa4 fix some typos in recent lazyloader implementation 2020-04-15 12:32:48 -05:00
sliptonic
1ff9c0899b Merge pull request #3330 from etrombly/lazyloader
[Path] Use lazyloader for deferred python imports
2020-04-15 10:22:28 -05:00
Eric Trombly
7fe094ac02 add lazyloader support
lazy_loader is copied to Ext now, modified external imports to lazy_load

add a few more imports to be lazy loaded, think the install path is correct now

[TD]"<" symbol embedded in html

revert changes to path modules for testing

use lazyloader in PathAreaOp.py

add back in deferred loading

temp change to print error message in tests

temp change to print error message in tests

add _init__.py to lazy_loader

make install in CMakeLists.txt one line
2020-04-13 21:14:34 -05:00
sliptonic
1f1043bf3c Merge pull request #3333 from fra589/master
[Path] Add size parameter for syntax highlighting of GCode editor
2020-04-13 08:48:18 -05:00
Daniel Wood
15318f4957 Deburr: signal for update when values are changed 2020-04-12 06:33:34 +01:00
Gauthier
ae05df5034 Merge remote-tracking branch 'upstream/master' 2020-04-11 17:06:31 +02:00
Gauthier
bc9569515a Add size parameter for syntax highlighting of GCode editor 2020-04-11 17:05:59 +02:00
Russell Johnson
ad784bc7d5 Path: PEP8 cleanup
line endings fix
2020-04-07 22:17:37 -05:00
Russell Johnson
20d85edd62 Path: Fix broken Gui::QuantitySpinBox class
Now, custom expressions are applied to spinbox.
Spinbox now updates, after clicking elsewhere.
Path: Shorten for loop search
2020-04-07 22:17:37 -05:00
sliptonic
c200734dc6 Merge branch 'master' into 3d_surface_perf 2020-04-06 14:33:26 -05:00
Patrick F
65aee430af Removed offset check 2020-04-06 21:11:40 +02:00
Eric Trombly
5ecbc89f30 change isOnLine to isOnLineSegment 2020-04-06 06:34:53 -05:00
Eric Trombly
b631c5600a move getFacets from Path to Part 2020-04-06 06:34:53 -05:00
Eric Trombly
2b8cd1be42 add changes to Waterline 2020-04-06 06:34:53 -05:00
Eric Trombly
0cbf56886a clean up commented old code 2020-04-06 06:34:53 -05:00
Eric Trombly
54022ea630 remove debug profiling from surface 2020-04-06 06:34:53 -05:00
Eric Trombly
fbc266c158 remove parallel processing, replace mesh generation with getting facets 2020-04-06 06:34:53 -05:00
Eric Trombly
651c383925 changed some for loops to list comprehensions, added openmp for area to make two loops parallel, changed a fuse to a compound 2020-04-06 06:34:53 -05:00
Eric Trombly
5f648aa2c1 remove sleep calls, change some for loops to list comp, move isPointOnLine to base vector 2020-04-06 06:34:53 -05:00
sliptonic
bb45a2b01f Merge pull request #3132 from Schildkroet/deburr+dressup
[Path] Deburr+DressupLeadInOut fixes
2020-04-05 18:34:52 -05:00
Patrick F
b8a32610c8 Bugfix for circular hole base 2020-04-02 19:38:21 +02:00
luz.paz
cafed2a137 [skip ci] Fix typos in Path WB
Found via 
```
codespell -q 3 -L aci,ake,aline,alle,alledges,alocation,als,ang,anid,ba,beginn,behaviour,bloaded,byteorder,calculater,cancelled,cancelling,cas,cascade,centimetre,childs,colour,colours,commen,connexion,currenty,dof,doubleclick,dum,eiter,elemente,ende,feld,finde,findf,freez,hist,iff,indicies,initialisation,initialise,initialised,initialises,initialisiert,ist,kilometre,lod,mantatory,methode,metres,millimetre,modell,nd,noe,normale,normaly,nto,numer,oder,orgin,orginx,orginy,ot,pard,pres,programm,que,recurrance,rougly,seperator,serie,sinc,strack,substraction,te,thist,thru,tread,uint,unter,vertexes,wallthickness,whitespaces -S ./.git,*.po,*.ts,./ChangeLog.txt,./src/3rdParty,./src/Mod/Assembly/App/opendcm,./src/CXX,./src/zipios++,./src/Base/swig*,./src/Mod/Robot/App/kdl_cp,./src/Mod/Import/App/SCL,./src/WindowsInstaller,./src/Doc/FreeCAD.uml
```
2020-04-01 13:28:48 +02:00
Patrick Felixberger
66fbec6005 Setup length depending on tool 2020-03-31 17:31:30 +02:00
Patrick Felixberger
d66ff3364e Merge branch 'master' of https://github.com/FreeCAD/FreeCAD into deburr+dressup 2020-03-31 17:18:06 +02:00
sliptonic
e76c505a17 Merge pull request #3231 from Russ4262/4th_axis_fixes
[Path] 4th-axis rotational alignment improvements;  Code clean-up
2020-03-31 08:17:18 -05:00
Russell Johnson
ebb383cc6c Path: Synchronize tooltips. Apply DepthOffset. Hide properties.
Sync tooltip text between 3D Surface and Waterline.
Also, apply `DepthOffset` to Experimental Waterline algorithm.
Hide some properties in Data tab.
2020-03-30 23:24:47 -05:00
Russell Johnson
6644d08191 Path: Implement experimental Waterline algorithm
Insert experimental Waterline algorithm that is non-OCL based.  It slices by step-down value, not stepover.
2020-03-30 22:34:57 -05:00
Russell Johnson
7d4b2f2a50 Path: Fix bug that fails Multi-pass usage 2020-03-30 22:34:57 -05:00
Russell Johnson
5d03294980 Path: Fix "increase by factor of 10" issue
Forum discussion at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=44486.
2020-03-30 22:34:57 -05:00
Russell Johnson
a907585f0d Path: Four bug fixes per forum discussion
Fix grammar mistake.
Fix Gcode comment formatting.
Fix application of `Optimize Step Over Transitions` by adjusting the offset tolerance for creating the offset cut area for the operation.
Fix math error in circular based cut patterns for small diameter cutters.
Identification of bugs begins in the forum at https://forum.freecadweb.org/viewtopic.php?style=3&f=15&t=41997&start=210.
Path: Lower SampleInterval minimum to 0.0001mm
2020-03-30 22:34:57 -05:00
Russell Johnson
11db9553d4 Path: Add Cut Pattern selection to task panel 2020-03-30 22:34:57 -05:00
Russell Johnson
3720b57d63 Path: Add initPage() call to update GUI upon loading
Added initPage() function call updates task panel values and visibilities when user edits an existing operation.
2020-03-30 22:34:57 -05:00
Russell Johnson
3363639681 Path: Update GUI inputs for independent Waterline operation 2020-03-30 22:34:57 -05:00
Russell Johnson
d495ee202d Path: Add ScanType and LayerMode inputs
Added combo boxes with labels
Path: Remove 'Algorithm' property usage.


Path: Connect `ScanType` and `LayerMode' selections from task panel


Path: Update GUI inputs for independent 3D Surface operation
2020-03-30 22:34:57 -05:00
Russell Johnson
4109f0c7df Path: Restructure initOperation() for backward compatibility
Added initOpProperties() to handle independent creation of properties for backward compatibility and to allow for future storage of enumeration property lists within the operation.
Path: Change from PathSurface code to `Waterline`


Path: Updates and fixes


Path: Simplify code

Remove `Algorithm` and `AreaParams` property usage.
Remove other unused properties.
Simplify setupEditorProperties().
Path: Remove unused methods


Path: Update property initialization and handling

Make properties backward compatible with previous versions of the operation.
Remove references to unused properties due to 3D Surface and Waterline separation.
Path: Insert placeholder for `Experimental` algorithm


Path: Fix missing property and fix syntax

Missing `Algrorithm
2020-03-30 22:34:57 -05:00
Russell Johnson
df253cdcdc Path: Add Waterline task panel
Path: Update `Waterline` task panel and GUI code
2020-03-30 22:34:57 -05:00
Russell Johnson
a2c72feba8 Path: Add commented references for missing imported modules
PathSurfaceGui and PathWaterlineGui are imported in the initGui.py module due to OCL dependency.
2020-03-30 22:34:57 -05:00
Russell Johnson
dacb6e62f2 Path: Add Waterline selection gate
Using the same gate as PathSurface
2020-03-30 22:34:57 -05:00
Russell Johnson
312f09e81e Path: Add Waterline modules to PathScripts 2020-03-30 22:34:57 -05:00
sliptonic
f44d7451f5 Merge pull request #3290 from fra589/master
[Path] fix tool change and Feature missing output
2020-03-30 22:18:07 -05:00
sliptonic
c65d0f9858 Merge pull request #3266 from Russ4262/Fix_ProfileEdges_Open-Edges
[Path] Fix failed open edge path for zero GeometryTolerance case
2020-03-30 22:17:03 -05:00