Commit Graph

57 Commits

Author SHA1 Message Date
bgbsww
4d12e338ec Merge branch 'main' into bgbsww-toponaming-makeElementFace 2024-01-23 08:14:07 -05:00
Chris Hennes
096c11e47f Merge pull request #12023 from bgbsww/bgbsww-patch-30
Initial code of mapSubElement Test
2024-01-22 16:02:00 -06:00
bgbsww
266d9c880a Merge branch 'main' into bgbsww-toponaming-makeElementFace 2024-01-22 12:50:13 -05:00
bgbsww
7f2d2050bd Single char constants 2024-01-22 11:29:41 -05:00
bgbsww
26dbd32c15 lint / review cleanups 2024-01-22 11:01:19 -05:00
bgbsww
d405fdadc4 Add tests, reformat to modern C++, clean 2024-01-21 15:34:46 -05:00
bgbsww
3266c38c96 Improve tests 2024-01-19 20:59:19 -05:00
bgbsww
ab3bb9fb71 Improve tests 2024-01-19 10:49:47 -05:00
bgbsww
874d421fa8 Split test cases 2024-01-18 13:15:21 -05:00
bgbsww
fae1cd569f Lint and other cleanups 2024-01-18 11:46:15 -05:00
bgbsww
60ae251b61 Initial code of mapSubElement Test 2024-01-17 09:13:39 -05:00
bgbsww
0cb513f084 Move MapperMaker and MapperHistory out to future PR 2024-01-17 08:55:16 -05:00
bgbsww
51ee04ca34 Tests for transferred TopoShapeMapper objects 2024-01-16 20:11:59 -05:00
Chris Hennes
f0a734fed0 Part/Toponaming: Refactor makeElementCompound
Refactor to address linter issues, breaking up large methods, renaming variables, etc.
2024-01-15 18:17:32 +01:00
Chris Hennes
8124c81a33 Tests/Toponaming: Add tests for makeElementCompound 2024-01-15 18:17:32 +01:00
Chris Hennes
979090169f App/Toponaming: Add addition TNP methods 2024-01-15 18:17:32 +01:00
bgbsww
f2c9d1e409 Adding additional TNP tests (#11829)
* Initial tests for Chamfer, Fillet, Compound

* Lint cleanup, new tests

* Outline of Extrusion and Revolution

* Use python to define a 2d object to extrude and test

* Refactor; start filling in revolution tests

* Example of parameterized tests in Extrusion, cleanups

* Use gtest framework for parameterised tests

* Rearrange for clarity

* WIP with TEST_P use for posterity

* Switch from parameters to individual tests

* Guess at test failures on other platforms

* Cleanups and Revolution Tests

* Remove temp code

* Switch Revolutions to boundbox test; add Compound subshape count test

* Calculate test volume correctly; lint fixes

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-01-06 18:25:44 -06:00
David Carter
d9017bcca3 Material: Material editor enhancements (#11764)
Continues the work of the material subsystem improvements.

Add support for embedded SVG files. These are not the same
as image files so need to be handled differently.

Add the ability to filter materials in the editor when called from
code. This allows programs to select objects supporting specific
models, complete models, older models, etc.

Updated tests, and refactored code.

New models and materials supporting patterns such as used by the
TechDraw workbench.

fixes #11686 - checks for the presense of a model property before
assinging a value. This can happen when a required model definition is
not available.

---------

Co-authored-by: Chris Hennes <chennes@pioneerlibrarysystem.org>
2024-01-06 18:11:53 -06:00
bgbsww
056d7cecd7 Merge branch 'main' into bgbsww-patch-24 2023-12-30 23:25:51 -05:00
Chris Hennes
a2c1d9ff8e Part/Toponaming: clang-tidy cleanup of cache calls 2023-12-27 21:16:59 -06:00
Chris Hennes
e5b95c7522 Part/Toponaming: Clang-tidy cleanup of TopoShapeCache
Part/Toponaming: Move implementions to cpp file
Part/Toponaming: Automated code cleanup
Part/Toponaming: Address boolean blindess with HistoryTraceType
Part/Toponaming: More linter cleanup
Part/Toponaming: Add located and moved methods
Part/Toponaming: Moved and Located
Part/Toponaming: Add missing methods
Part/Toponaming: Add test framework for TopoShapeCache
Part/Toponaming: Add documentation provided by realthunder
Part/Toponaming: Extend tests for TopoShapeCache
Part/Toponaming: Rename getInfo to getAncestry
Part/Toponaming: Fix bug with newer OCCT
Part/Toponaming: Add final tests and tweak naming
Part/Toponaming: Address reviewer comments
2023-12-27 21:16:15 -06:00
pre-commit-ci[bot]
9192a30a93 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-12-25 22:45:02 +00:00
bgbsww
00a9b3261e More delinting 2023-12-25 17:44:06 -05:00
bgbsww
35b853deb5 Remote experimental PrintTo that doesn't work. 2023-12-24 17:34:19 -05:00
bgbsww
66f5f243d8 Missed cleanup 2023-12-23 08:20:34 -05:00
bgbsww
df04428c6b Remove mistaken file 2023-12-23 08:06:16 -05:00
pre-commit-ci[bot]
c0b0f18638 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-12-23 12:29:47 +00:00
bgbsww
c6794a8714 Attempt to mollify lint 2023-12-23 07:28:51 -05:00
pre-commit-ci[bot]
551ba26828 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-12-23 11:55:42 +00:00
bgbsww
b8ac7f833e Be clearer about minimal distance magic numbers 2023-12-23 06:54:43 -05:00
pre-commit-ci[bot]
abf7fb0791 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-12-23 10:55:30 +00:00
bgbsww
619d2c970f Cleanups per pesc0 review notes; general code tightening 2023-12-23 05:53:54 -05:00
pre-commit-ci[bot]
5d48014999 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-12-22 21:17:17 +00:00
bgbsww
d75b158dcf Use inheritance and namespaces to keep tests DRY 2023-12-22 16:16:20 -05:00
bgbsww
7b3946d7b8 First pass cleanup of test code 2023-12-21 14:34:37 -05:00
pre-commit-ci[bot]
05bb3d1bcb [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-12-21 17:06:33 +00:00
bgbsww
93917a186d Preliminary cpp tests for Part boolean operations 2023-12-21 11:45:34 -05:00
David Carter
3dd6a67804 Material: Material editor enhancements
Continues the work of the material subsystem improvements.

This merge covers the continued development of the material editor. The
primary improvements are the addition of new data types, a new
appearance preview UI, and changes in the array data types.

New data types were added to support more advanced workflows, such as
the Render Workbench.The Image datatype allows the material to embed
the image in the card instead of pointing to an image in an external
file. Multi-buyte strings span multiple lines as the name implies.
It preserves formatting accross those lines. Also several list types
are now supported, with the primary difference being the editors.
List is a list of strings, FileList is a list of file path names, and
ImageList is a list of embedded images.

For the appearance preview, the UI now uses the same Coin library as
is used in the documents, meaning the preview will look exactly the
same as the material will be shown in the documents.

The array data types are now more complete. The default value wasn't
being used as originially envisioned and was tehrefore removed. For
3D arrays, the Python API was implemented.

There were a lot of code clean ups. This involved removing logging
statements used for debugging during development, reduction of lint
warnings, and code refactoring.

The editor can automatically convert from previous format files to the
current format. This has been extended to material files generated by
the Render WB. Old format files are displayed in the editor with a
warning icon. Selecting one will require saving the file in the new
format before it can be used.
2023-12-06 08:48:34 -06:00
wmayer
19dfea4783 MSYS: fix broken Qt6 build using MinGW & clang 2023-11-28 19:11:58 +01:00
wmayer
451c094f39 MSVC: fix warnings about conversion between float and double 2023-11-21 23:10:03 +01:00
David Carter
332bf7ed08 Material: Continued Material enahncements
Continues the work of the material subsystem improvements.

Several important items are included in this merge. In terms of new
capabilities, this merge adds List and MultiLineString as valid
property types, complete with editing dialogs. This will help with
backwards compatibility for external workbenches, such as Render.

Stability has been a big focus. New unit tests help to verify features
work as expected. Bugs have been fixed and crashes avoided.

Material cards have had a renaming to their tree structure. For
example, 'StandardMeterials' is redundant, so this was renamed to
'Standard'. The cards themselves are more compliant fully passing the
yamllint tests.

More soon.
2023-11-20 12:19:29 -06:00
David Carter
d1e96a5195 Material: Material editor enhancements
Continues the work of the material subsystem improvements.

This merge covers the continued development of the material editor. The
primary improvements are in the handling of 2D and 3D array properties.
These properties are now fully editable, and can be saved and restored.

The cards now separate the author and license. These were previously
saved as a single item. Future support will be provided for standard
open source licenses.

Saving operations validate the cards to ensure UUIDs of materials are
considered. Warnings are given when a save could potentially impact the
models, such as saving over a material instead of creating a new
instance.

The editor is still not complete. There are a number of functional
elements, such as drag/drop operations, folder creation, and deletion
operations that need to be added to the main tree. State needs to be
saved and restored to improve the user experience. The appearance
preview also needs significant work. This will be handled in a future
PR.
2023-10-24 12:36:36 -04:00
wmayer
931fcdabbf tests: add initApplication() to avoid code duplications 2023-10-21 16:31:26 -05:00
wmayer
b01a41237a Mat: fix several compiler warnings:
* -Winconsistent-missing-override
* -Wtautological-undefined-compare
2023-09-27 21:38:56 -05:00
Chris Hennes
1dd2baa172 Merge pull request #10690 from davesrocketshop/material_merge
Material: Material handling enhancements
2023-09-27 16:15:06 -05:00
howie-j
12f80320fc [Sketcher] Fix angle constraint expression regression (#10743)
* fix 10742

* moved expression string modifier to helper function

* Tests: Add example tests for SketchObject

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* made expr modifier func static, pass by value and added unit tests

---------

Co-authored-by: Chris Hennes <chennes@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2023-09-25 10:44:31 -05:00
David Carter
37c7169ee4 Material: Material handling enhancements
Rework of the material handling system.

This first part concntrates on a rework of the material cards.
Rather than use a fixed list of possible properties, properties can
be defined separately in their own files and mixed to provide a
complete list of possible properties. Properties can be inherited.

The cards then provide values for the properties. These can also
be inherited allowing for small changes in cards as required.

The new property definitions are more extensive than previously.
2 and 3 dimensional arrays of properties can be defined. Values
are obtained by calling an API instead of reading from a dictionary.

For compatibility, a Python dictionary of values can be obtained
similar to how it was done previously, but this is considered a
deprecated API and won't support the newer advanced features.

The editor is completely reworked. It will be able to edit older format
material cards, but can only save them in the new format.

For testing during the development phase, a system preference can
specifiy wether the old or new material editors are to be used. This
option will be removed before release.
2023-09-25 11:04:15 -04:00
David Carter
902af79514 Material: Material handling enhancements
Rework of the material handling system.

This first part concntrates on a rework of the material cards.
Rather than use a fixed list of possible properties, properties can
be defined separately in their own files and mixed to provide a
complete list of possible properties. Properties can be inherited.

The cards then provide values for the properties. These can also
be inherited allowing for small changes in cards as required.

The new property definitions are more extensive than previously.
2 and 3 dimensional arrays of properties can be defined. Values
are obtained by calling an API instead of reading from a dictionary.

For compatibility, a Python dictionary of values can be obtained
similar to how it was done previously, but this is considered a
deprecated API and won't support the newer advanced features.

The editor is completely reworked. It will be able to edit older format
material cards, but can only save them in the new format.

For testing during the development phase, a system preference can
specifiy wether the old or new material editors are to be used. This
option will be removed before release.
2023-09-25 11:04:01 -04:00
pre-commit-ci[bot]
e92ed45df9 [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
2023-09-12 13:02:35 -04:00
Chris Hennes
246a387625 Tests: Reformat to current clang-format standard 2023-09-03 09:51:42 -05:00