Commit Graph

1142 Commits

Author SHA1 Message Date
wmayer
4d28a062fc CMP0050: make PartDesign module aware of cmake policy 2018-08-20 17:19:04 +02:00
looooo
1b3e23d768 Py3: PartDesign: relative imports 2018-08-19 10:59:11 +02:00
luz.paz
fab9cad50f Misc. typos
Found via `codespell`
Trivial typos

Found via `codespell`
2018-08-18 21:48:42 +02:00
Markus Lampert
e13c09235f Changed all catch types to references for polymorphic exceptions. 2018-08-08 15:45:30 +02:00
wmayer
5380a03266 add option to resize datum planes manually 2018-07-30 22:31:24 +02:00
Eivind Kvedalen
5670ef0e2a Fix for issue #3541: Normalize xDir vector for Hole feature to correct hole diameter. 2018-07-29 01:03:17 +02:00
luz.paz
323d5db720 PartDesign: fixes for Qt 5.11
Similiar to changes made in 7e63a33b8b
CC @efferre79
2018-07-28 15:32:43 +02:00
wandererfan
a712d49685 Revise multiple solids message 2018-07-13 10:23:42 -03:00
wandererfan
29352e07b3 Fix PD Pocket Through All Unit Test
- test for Pocket Through All case
  generated a multi-solid solution.
  Now returns single solid.
2018-07-13 10:23:42 -03:00
wandererfan
0d3008e4eb Fix #3401 warning on multiple solid
- PartDesign only uses the first result shape
  of an operation and discards the rest without
  warning.

- this also fixes #1707
2018-07-13 10:23:42 -03:00
JimStar
6a5ad383ab Extended global marker size to be used for other modes 2018-07-11 21:22:28 -03:00
ageeye
be6fb16f29 PartDesign::Clone maintain the colors of the original 2018-06-12 10:30:07 -03:00
wmayer
311fe7be59 fixes #0002725: Random color for features in PartDesignNext 2018-06-10 18:37:53 +02:00
wmayer
af2ebf86ff fixes #0003256: additive elements do not use color of Body 2018-06-10 10:12:32 +02:00
wmayer
920a4e62b2 add missing newlines 2018-06-09 11:47:12 +02:00
looooo
b28238bb73 python syntax checker: remove some strange leading characters 2018-05-23 19:13:54 +02:00
luz.paz
43244aa762 More misc. typos 2018-05-19 12:17:52 -04:00
luz.paz
68c4b22315 Source typos fixes 2018-05-11 10:02:56 -03:00
wmayer
9d3a2a27b4 fix several warnings:
-Winconsistent-missing-override
-Wsign-compare
-Wmaybe-uninitialized
-Wmissing-braces
2018-04-29 13:28:36 +02:00
wmayer
4275b604f3 fix warning -Winconsistent-missing-override 2018-04-29 11:50:04 +02:00
luz.paz
9167064fc1 Misc. typos
Found via `codespell`
2018-04-25 09:41:33 -03:00
DeepSOIC
350d2320bc PartDesign: fix #2758 Datum Point persistence, again 2018-04-14 15:48:56 +02:00
looooo
cdcb3bec4a PySide2: qApp -> QApplication 2018-04-14 10:40:31 +02:00
luz.paz
6fe582d7a8 [For v0.18]PartDesign: translation fixes
ref: https://crowdin.com/translate/freecad/564/en-sv#6502053
[skip ci]
2018-04-11 10:49:56 -03:00
sL1pKn07
6674467254 [For v018] Fix build with Qt5 beta
Seems need add some headers for build with incoming Qt 5.11 (Tested with 5.11.0beta2)
2018-04-10 12:59:41 +02:00
DeepSOIC
ba069d9125 PartDesign: fix #0002758 Datum point moves to (0,0,0) when reopening the file
OCC has a peculiarity, that when saving single vertexes, it burns in placement into vertex coordinates. In loaded shape, Placement is zero. This caused datum point placement reset to zero, and its shape had nonzero  coordinates.

This fix keeps placement property from resetting, and reconstructs a new vertex upon load.
2018-04-04 17:43:15 +02:00
wmayer
f04d4430aa improve exception handling in ViewProviderBody::dropObject 2018-04-04 17:14:21 +02:00
wmayer
24eb8eec9b chamfer size must be greater than zero 2018-04-04 16:25:11 +02:00
wmayer
130885c010 fixes #0003416: Crash on draft operation for a face 2018-04-04 16:09:15 +02:00
Yorik van Havre
46fd41d70a Merged translations from crowdin 2018-03-26 18:52:02 -03:00
luz.paz
46d32d78a3 Misc. typos: Please merge right before 0.17 release
I'm still finding typos in the source code. I propose that you keep this PR open prior ro relaese and then merge  so that if I find other typos in the meantime they will be part this release.
2018-03-18 15:15:16 +01:00
wmayer
bbbbf6c691 don't allow to set empty list of bodies for boolean operations
don't update the body feature if boolean body list is empty
2018-03-15 12:05:13 +01:00
wmayer
03ce0f276e fixes #0003376: PartDesign Boolean produces exception with wrong selection of active Body 2018-03-15 11:13:45 +01:00
wmayer
0e4a3d2dba fix possible crash in pipe/scaling task panels 2018-03-10 16:53:14 +01:00
wmayer
4fd7ccc98e fix German translation 2018-03-03 23:37:15 +01:00
Yorik van Havre
143b89c8f3 Applied latest translations from crowdin 2018-02-21 14:25:31 -03:00
luz.paz
dcc65070c1 Misc source comment typos
Found via `codespell -q 3 --skip="*.po,*.ts,./.git,./src/3rdParty,./src/CXX,./src/zipios++,./src/Mod/Assembly/App/opendcm" -I ~/Projects/fc-word-whitelist.txt`  
Whitelist consists of:
```
aline
alledges
als
ang
behaviour
bloaded
calculater
cancelled
cancelling
cas
centimetre
childs
colour
colours
doubleclick
dum
eiter
elemente
freez
iff
indicies
initialisation
initialise
initialised
initialises
kilometre
lod
mantatory
methode
metres
millimetre
modell
nd
normaly
nto
oder
ot
pres
que
recurrance
rougly
seperator
serie
strack
substraction
te
thru
vertexes
whitespaces
```
2018-02-16 09:35:19 -05:00
wmayer
2de84d64e8 fix warning: lambda capture 'this' is not used [-Wunused-lambda-capture] 2018-02-10 12:42:41 +01:00
wmayer
e40b2c7470 disable tip handling in PD view providers when start or finish editing 2018-02-10 00:46:30 +01:00
wmayer
3f9dda9263 proper handling of setting and reverting preview mode in PD view provider 2018-02-10 00:42:10 +01:00
wmayer
8101f35f22 avoid superfluous transaction on PD primitive creation 2018-02-09 23:10:40 +01:00
wmayer
c5ae798026 in ViewProviderBody::updateData make sure a view provider exists 2018-02-09 22:14:44 +01:00
Abdullah Tahiri
5681acf937 Part Design: Avoid feature modification during initialization
=============================================================

The values for the primitives are set after the connections to the slots "onchange" are connected.

This causes a river of onChanges at feature level which set the properties and modify the feature (to the same values).

Moving the connections at the end of the function just solves this issue.
2018-02-09 16:01:19 +01:00
luz.paz
12c04d6c4e Crowdin: fix case for 'partdesign'
ref: https://crowdin.com/translate/freecad/564/en-fr#6500374
also through in a random typo fix
2018-02-07 09:45:34 +01:00
luz.paz
1d5799e5b3 Misc. typos
Inspired by @normandc per https://gitter.im/FreeCAD/FreeCAD?at=5a729c6ece68c3bc742df205
2018-02-07 09:40:03 +01:00
wmayer
f139966868 make green for tip a bit darker 2018-02-01 19:30:25 +01:00
Abdullah Tahiri
3ea4debaf3 PartDesign: Highlight body tip
==============================

It generates a small green icon on the treeview for those features being the tip of the body.
2018-02-01 19:15:48 +01:00
wmayer
9d838dd8d2 fixes #0003302: PDN cloned object have duplicated 'Unnamed' ghost on every file reopen 2018-01-30 19:26:06 +01:00
wmayer
28c2baefbf fixes #0002559: Body becomes visible upon changing DisplayModeBody 2018-01-30 15:58:32 +01:00
Abdullah Tahiri
2ad1653a3f PartDesign: OnDelete basefeature fixing and visualization
=========================================================

fixes #3084
fixes #3061 (at least what it is understood in the analysis as being a bug, the visualization left).

Basically when deleting a feature, if it is the base feature (feature with which it will merge or cutout), the dependent objects'
base feature is made to be the base feature of the object being deleted. This code pre-existed at body level, but was not being called (see below).

Additionally, if the visible object is not the one being deleted, we leave that one visible. If the visible object is the one
being deleted, we make the previous object visible.

Deletion from the tree of a feature is handled by Document.removeObject, which has no clue about what a body is. Therefore, Bodies, although an
'activable' container, know nothing about what happens at Document level with the features they contain.

The Deletion command StdCmdDelete::activated, however does notify the viewprovider corresponding to the feature (not body) of the imminent deletion
(before actually doing it). Consequently, the only way of notifying a body of the imminent deletion of one of its features so as to do the clean up
required (moving basefeature references, tip management) is from the viewprovider of the feature being deleted.
2018-01-22 22:03:18 +01:00