Commit Graph

55 Commits

Author SHA1 Message Date
Russell Johnson
4e152e074a Enable cutter and FC to OCL cutter translation
Enable self.cutter attribute
Without, 3D Surface op is non-functional
2019-05-10 22:40:32 -05:00
Russell Johnson
aaae829704 Path: Integrate 4th-axis feature to PathPocketShape and 3D Surface ops (#2114)
* PathSurface: Add StepDown support

Add StepDown support for PathSurface operation.
A low-level optimization algorithm is included.

* Update PageOpSurfaceEdit.ui

* PathSurface: Activate CompletionMode input

Update code to use CompletionMode selection from user.

* PathSurfaceGui: Add Completion Mode selection box

Add Completion Mode selection box for user input.

* PathSurface: Use depth_params() for step control

Implemented PathUtils.depth_params() for control of step downs to maintain consistency throughout PathWB.
Suggested by Sliptonic.

* PathSurface: Improve stability - Rev3

Organized code better, improved path optimization algorithm

* PathSurface: Add XY rotational surfacing

Add options to perform 3D surfacing by rotating object around X or Y axis.

* PathSurface: update setup function

Add properties to setup function

* PathSurface: Remove extraneous code

removed commented lines that consume processing time

* PathSurface: Correct nxt.z point assignment

Corrected error in nxt.z value assignment. Was assigning value to pnt.z instead of nxt.z

* PathSurface: Update 4th axis operation

Provided both parallel and perpendicular to axis  scans when performing rotational operation.

* PathSurface: Corrected Y-axis rotation to gcode

Inverted Y-axis scan values in gcode to produce correct result

* PathSurface: Adjust gcode feed rates

Adjust feed rates for axial rotations

* PathSurface: Implement waterline alternative

Used OCL dropcutter scan as data base for python algorithm to extract a waterline.  Waterline also incorporates step down feature.

* PathSurface: Update to 3m-Usable

stability improvements
fixed step on multi-pass 4th axis scans
initiate code to accommodate cut modes: zigzag, line
initiate code to accommodate offset cutter on 4th axis scans to simulate a tilted cutter for ball end mills

* PathSurface: Update 3m-Usable_r1

change instantiated static class attributes from value None, to 0.0

* PathSurface: Revert to 3i-Usable_r1

Further testing needed for 3m-Usable release

* PathSurface: Update to Rev. 3s Usable

fixed step over in rotational scans
start/stop indexes
tilt cutter adaptation for ball end mill
cut pattern: zigzag, line partially implemented
ignore waste option initiated for planar scans
cut mode partially implemented: conventional & climb

* PathSurface: Update to Rev. 3t Usable

Corrected rotational errors
corrected cutter tilt rotation
added "ignore waste" feature for planar surface operation

* Implement 4th-axis feature

Implement 4th-axis feature:
add gcode commands for rotation
re-compute operation heights, to consider rotation radii

* Deleted reference to undeclared variable

* Added missing class attributes/variables

* Added missing class variables/attributes

* Relocate class variables to higher class

* Remove references to undeclared variables

relocated class variables here
delete references to undeclared variables

* Correct rotation direction for normal-to-Y faces

* Remove X oriented 180 degree rotation adjustment

Probable error in FreeCAD gcode renderer, producing incorrect B axis rotation

* Update 4th-axis integration

Address FC error with B axis rotation rendering: user input to override error for visual alignment with model.
Correct pocket depths with Final Depth input enforced.
Add Reverse Direction flag input for reversing direction of pocket: necessary in some use cases.
NOTE: 4th-axis throws errors with Extension Corners feature.  EC feature needs 4th-axis rotation integration when calculating extensions for a particular part feature/face.
General testing needed.

* PathSurface: Add StepDown support

Add StepDown support for PathSurface operation.
A low-level optimization algorithm is included.

* Update PageOpSurfaceEdit.ui

* PathSurface: Activate CompletionMode input

Update code to use CompletionMode selection from user.

* PathSurfaceGui: Add Completion Mode selection box

Add Completion Mode selection box for user input.

* PathSurface: Use depth_params() for step control

Implemented PathUtils.depth_params() for control of step downs to maintain consistency throughout PathWB.
Suggested by Sliptonic.

* PathSurface: Improve stability - Rev3

Organized code better, improved path optimization algorithm

* PathSurface: Add XY rotational surfacing

Add options to perform 3D surfacing by rotating object around X or Y axis.

* PathSurface: update setup function

Add properties to setup function

* PathSurface: Remove extraneous code

removed commented lines that consume processing time

* PathSurface: Correct nxt.z point assignment

Corrected error in nxt.z value assignment. Was assigning value to pnt.z instead of nxt.z

* PathSurface: Update 4th axis operation

Provided both parallel and perpendicular to axis  scans when performing rotational operation.

* PathSurface: Corrected Y-axis rotation to gcode

Inverted Y-axis scan values in gcode to produce correct result

* PathSurface: Adjust gcode feed rates

Adjust feed rates for axial rotations

* PathSurface: Implement waterline alternative

Used OCL dropcutter scan as data base for python algorithm to extract a waterline.  Waterline also incorporates step down feature.

* PathSurface: Update to 3m-Usable

stability improvements
fixed step on multi-pass 4th axis scans
initiate code to accommodate cut modes: zigzag, line
initiate code to accommodate offset cutter on 4th axis scans to simulate a tilted cutter for ball end mills

* PathSurface: Update 3m-Usable_r1

change instantiated static class attributes from value None, to 0.0

* PathSurface: Revert to 3i-Usable_r1

Further testing needed for 3m-Usable release

* PathSurface: Update to Rev. 3s Usable

fixed step over in rotational scans
start/stop indexes
tilt cutter adaptation for ball end mill
cut pattern: zigzag, line partially implemented
ignore waste option initiated for planar scans
cut mode partially implemented: conventional & climb

* PathSurface: Update to Rev. 3t Usable

Corrected rotational errors
corrected cutter tilt rotation
added "ignore waste" feature for planar surface operation

* Implement 4th-axis feature

Implement 4th-axis feature:
add gcode commands for rotation
re-compute operation heights, to consider rotation radii

* Deleted reference to undeclared variable

* Added missing class attributes/variables

* Added missing class variables/attributes

* Relocate class variables to higher class

* Remove references to undeclared variables

relocated class variables here
delete references to undeclared variables

* Remove X oriented 180 degree rotation adjustment

Probable error in FreeCAD gcode renderer, producing incorrect B axis rotation

* Correct rotation direction for normal-to-Y faces

* Update 4th-axis integration

Address FC error with B axis rotation rendering: user input to override error for visual alignment with model.
Correct pocket depths with Final Depth input enforced.
Add Reverse Direction flag input for reversing direction of pocket: necessary in some use cases.
NOTE: 4th-axis throws errors with Extension Corners feature.  EC feature needs 4th-axis rotation integration when calculating extensions for a particular part feature/face.
General testing needed.

* Apply XYZ Model translations to paths; Add rotation axis selection property

* Spelling correction

ln 110

* Geometry list box: shrink height

560 to 400 height

* Update 4th-axis integration

Clean up code
Add comments for visionary elements
Apply axis selection to opHeights rotational calculations

* Update 4th-axis integration

Prepare sorting of vertical faces per axis_angle grouping, just as horizontal faces are sorted, for analysis as connected shapes

* Reset to FreeCAD master current

* Reset to current FreeCAD master version

* Update PathPocketBase.py

* Reset to current FreeCAD master

* Corrected __created__ date

* Convert all print() to PathLog.debug()

* Convert print() to PathLog.debug(); Clean up code

Use PathLog.debug over print() for troubleshooting
Clean up large commented sections of code.

* Convert print() to PathLog.debug(); combine duplicate methods

* Update last modified stamp

* Update last mofified timestamp

Also, removed commented-out code

* Typo corrected: "selt." to "self."

Discovered in https://api.travis-ci.org/v3/job/526456071/log.txt
on 30 April 2019 while searching for errors related to failure of PR #2114

* Restore initialization of self.depthparams

PR is failing Travis CI build test. Previous deletion of this code appears to be the reason.
See report at: https://api.travis-ci.org/v3/job/526492709/log.txt

* Convert tuple sizes from other PathWB ops

* B-axis rotation: render correction

* Revert "rebase to FC master 2019-05-02"

* Correct depthparams opOnDocumentRestored() issue

* Relocate "UseRotation" property from PathAreaOp.py

* Improve meshFromShape() calculation per @sliptonic

faster mesh creation
helps smooth jagged lines in path results

* Part: Make 3rd party libraries into PCH

* PartDesign: 3rdParty to PCH

* Sketcher: PCH

* PartDesign: PCH GUI

* Sketcher: GUI PCH

* Travis windows build (#2110)

Travis windows build

* Travis: enable clcache debug

* disable travis clcache debug

* respect user settings for dialog used in merge-document command

* msbuild verbose and logo

* Travis force wait 60 minutes

* Travis: Use & between vars sourcing and msbuild

* Travis: Move building to external batch script (#2131)

* Travis: Move building to external batch script

* Travis: double quotes to escape route

* Travis: use cmd.exe to call batch file

* Crowdin: fix grammatical error + whitespace 

https://crowdin.com/translate/freecad/569/en-fi#6498705

* Crowdin: experiment to fix crowdin 'ghost' strings

The following translation strings still perpetuate after updating crowdin translations. This commit experiments with removing their source counterparts in the FC .ts files. I'm not sure why they are not rendered obsolete by the normal operations. 
  
* https://crowdin.com/translate/freecad/6766/en-en#6499472  
* https://crowdin.com/translate/freecad/6766/en-en#6573450

* fix for edit tracker draw styles

* deleted commented code

* Travis: filter out

* AddonManager: allow to add custom repositories

* Revert "rebase to FC master 2019-05-02"

* Draft: Fixed Draft text justification

* Arch: Fixed bug in arch windows creation

* Arch: Fixed export of windows colors to IFC

* Draft: Fixed 0.18.1 bug in DXF importer

* Arch: Fixed wrong exported objects in IFC export

* Arch: Fixed export of sites to IFC

* Start: Fixed bad default icon in start page

* Correct depthparams opOnDocumentRestored() issue

* Relocate "UseRotation" property from PathAreaOp.py

* Improve meshFromShape() calculation per @sliptonic

faster mesh creation
helps smooth jagged lines in path results

* Relocate "UseRotation" property in PathAreaOp.py

* Syntax correction

Travis CI python 3.7 build test fails regularly due to syntax error at this point

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* Correct rebase issue: PR #2114

* path pep8 cleanup

* Multi-face geometry selection repaired

Previous version broke ability to select process multiple faces selected by user in geometry tab in operation task window.
Also performed some syntax cleaning per PEP8 linter

* Update script version info
2019-05-06 21:29:08 -05:00
cclauss
a7c0f4bc5b Drop depencence on six module 2019-01-07 15:51:34 +01:00
cclauss
51ab27f54a Fix file, long, raw_input, and xrange for Python 3 2019-01-07 15:42:37 +01:00
luz.paz
4dc201e086 Misc. typo, grammar, and whitespace fixes
[skip ci]
2018-11-27 15:02:58 -03:00
pekkaroi
2f2f5af4c2 Path: PathSurface task panel update 2018-11-04 14:49:21 -03:00
pekkaroi
5118118740 generalized optimization algorithm 2018-11-04 14:49:21 -03:00
pekkaroi
c40060bc20 Path: Optimize output of OCL dropcutter algo. 2018-11-04 14:49:21 -03:00
luz.paz
b214f606c4 Misc. typo and whitespace fixes
ref: https://forum.freecadweb.org/viewtopic.php?f=3&t=30988#p256964
along with other misc. fixes
2018-09-19 17:26:03 +02:00
Markus Lampert
3687224ce0 Added support for multi base model to Surface op. 2018-09-11 07:24:36 +02:00
Markus Lampert
c4340a7577 Fixed surface settings. 2018-09-02 00:32:22 -07:00
Markus Lampert
9d7d9e8177 Partial operation settings support for Surface op. 2018-09-02 00:32:22 -07:00
Markus Lampert
ebe76319b8 Added name parameter to operation proxy constructor. 2018-09-02 00:32:22 -07:00
Markus Lampert
070d17e4e4 Add job as parameter to opSetDefaultValues 2018-09-02 00:32:22 -07:00
markus
7c048482bf Hiding all/most properties that are supposed to be hidden on document restore again. 2018-09-01 21:01:04 +02:00
sliptonic
024ce84da3 Using PropertyVectorDistance
per yorik: https://forum.freecadweb.org/viewtopic.php?f=3&t=29787#p244785
2018-07-19 12:06:09 -03:00
sliptonic
3d09e6543a Fix for coverity CID 168953
Make test for ocl not conditional.
2018-07-15 16:28:16 -03:00
pekkaroi
d7d4489da1 Change StepOver to PropertyPercent 2018-07-07 14:11:08 -03:00
pekkaroi
097f73afcb Path: Surface op improvements for drop cutter algo 2018-07-07 14:11:08 -03:00
Markus Lampert
fb0fc49a30 Removed PathPreferences class and moved functionality into the module interface. 2018-06-19 21:53:41 -07:00
luz.paz
13db1e5349 Crowdin: Path string fixes 2018-04-25 11:03:10 +02:00
Markus Lampert
eaa7b6f591 Fixed all ops to use Op...Depth in order to not mess with the expressions. 2017-10-22 11:24:58 -07:00
sliptonic
8637831132 Path: refactor Surface 2017-09-19 11:12:31 +02:00
Markus Lampert
1664e65135 Restored icons for profile ops; cleaned up accel keys. 2017-08-22 10:16:58 -03:00
sliptonic
266fb0b70f Path: Adding Apply buttons
Give user more control of when long
running updates are executed in task
panels
2017-06-28 21:46:44 +02:00
sliptonic
a5a88e5b59 Path: remove obsolete code from cmake
also refactored depthparams and fixes to depths
on various operations
2017-06-28 21:46:44 +02:00
sliptonic
17b16a7286 Path: adding cancel buttons to operations 2017-06-28 21:46:44 +02:00
Markus Lampert
4c3cee03c5 Replaced default context argument with explicit call for pylupdate to pick up the strings and contexts. 2017-06-03 15:37:41 -07:00
Markus Lampert
3368c8682e Moved almost all translate implementations away from QtGui. 2017-06-03 15:37:41 -07:00
sliptonic
098ca483d3 Path: add cursor waiting decorator to long running functions.
Remove obsolete ToolDescription code from label change.
2017-05-31 23:38:59 +02:00
looooo
ef22d5202d py3: define xrange for python3
this is done in files where the xrange is used.
replace this with range once python2 is not supported anymore.
issue 0000995
2017-05-18 15:56:09 +02:00
Ian Rees
a079b415ae Path: Use Deflection param for PathSurface meshes
The MaxLength option is quite slow and doesn't give as well-defined of
control over meshing accuracy as the deflection parameter.
2017-04-02 20:33:54 +12:00
Ian Rees
c913481ec1 Path: Add Property to Job for geometry tolerance 2017-04-02 19:58:50 +12:00
sliptonic
493d346bdc Path: adapt other operations
# Conflicts:
#	src/Mod/Path/Gui/Resources/panels/DrillingEdit.ui
#	src/Mod/Path/PathScripts/PathDrilling.py
2017-03-21 10:27:51 -03:00
Kurt Kremitzki
e47edae9c3 Update Path to py3-compatible printing 2017-01-30 10:21:22 +01:00
Sebastian Stetter
21b116649e PATH: fix for 2805
changed TaskPanels to use unit conversions via FreeCAD.Units
commented out references to segLen since it si used nowhere
2017-01-09 13:24:23 +01:00
sliptonic
8d0af8fcbf PathSurface now uses base object from job.
This means Surface won't work on Meshes directly.
They should be converted so FreeCAD solids first.
Surface still needs lots of work.
2016-10-15 15:25:54 -03:00
sliptonic
05ff7e40d5 menu cleanup 2016-10-15 15:25:54 -03:00
sliptonic
2f04ea9586 Drilling handles multiple locations
Jog rates started
Automatically create default tool in new job.
2016-10-15 15:25:54 -03:00
sliptonic
5398c58d6b Tool Library replaces ToolTable Job replaces Project 2016-10-15 15:25:54 -03:00
Yorik van Havre
a50bd5dc88 Made Path objects properties translatable - fixes #2524 2016-10-07 22:21:02 -03:00
sliptonic
bf46ea4804 Additional fixes for post processing.
comment diameter instead of radius for compensated profile/surface ops
opensbp improved pre processor is more explicit with XY values
cmake copies opensbp postprocessor.
Removed unnecessary file.
2016-07-03 22:41:38 -03:00
sliptonic
d1b927767a Fix for bug #2528
Improved handling of comments
2016-07-03 22:41:38 -03:00
sliptonic
fd57f47e3d Fix feedrate bug #2597
minor edits to linuxcnc post processor
2016-07-03 22:41:38 -03:00
sliptonic
dff173cd1f Fixes for various gcode errors
Some operations were still outputting even if disabled.
Nested comments caused trouble in linuxcnc
Machine was producing an initial move that was potentially dangerous
2016-06-11 10:51:27 -05:00
sliptonic
4568a4e583 Fixes for PathSurface.
Correctly remember settings.
2016-05-31 21:15:39 -03:00
sliptonic
2cc36497b8 remove translation from property descriptions. 2016-05-23 13:04:58 -03:00
brad
91978ba1a4 Operations and ToolControllers have labels set automatically.
This will hopefully make things a little clearer
A couple more Sanity checks.
Don't error if no TC in project.
2016-05-23 13:04:58 -03:00
sliptonic
7436a5e397 Cleanup. Make surface, drilling, and engrave work with preselect 2016-05-23 13:04:58 -03:00
sliptonic
a0f332feb0 OCC pocket handles large curves better now. Needs testing
initial commit
2016-05-23 13:04:58 -03:00